58004 2011-04-06 18:35:50 -0700 Memory Leak in CoreIPC::decodeResourceError 2011-04-07 09:08:11 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 381034 0 msaboff 2011-04-06 18:35:50 -0700 The local NSError object created in decodeResourceError() has a retain count of 2 when the function exits. One is needed for the ResourceError reference argument, the other should be released directly or via an autorelease. 381039 1 88555 msaboff 2011-04-06 18:41:01 -0700 Created attachment 88555 Patch to wrap NSError allocation with autorelease 381040 2 88555 mjs 2011-04-06 18:46:54 -0700 Comment on attachment 88555 Patch to wrap NSError allocation with autorelease r=me (But why autorelease instead of release? Explicit release is usually better.) 381098 3 88555 darin 2011-04-06 20:37:00 -0700 Comment on attachment 88555 Patch to wrap NSError allocation with autorelease View in context: https://bugs.webkit.org/attachment.cgi?id=88555&action=review > Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:188 > + NSError *nsError = [[[NSError alloc] initWithDomain:nsString(domain) code:code userInfo:userInfo] autorelease]; A plain old release is much faster than autorelease, so it would be better to do it that way. 381392 4 msaboff 2011-04-07 09:08:11 -0700 Committed r83177: <http://trac.webkit.org/changeset/83177> 88555 2011-04-06 18:41:01 -0700 2011-04-06 20:37:00 -0700 Patch to wrap NSError allocation with autorelease 58004.patch text/plain 1489 msaboff SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMTI5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMDYgIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0MjogTWVtb3J5IGxlYWsgaW4gZGVjb2RlUmVzb3Vy Y2VFcnJvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTgwMDQKKworICAgICAgICBXcmFwcGVkIHRoZSBjcmVhdGlvbiBvZiBOU0Vycm9yIGluIFsuLiBh dXRvcmVsZWFzZV0gdG8KKyAgICAgICAgcmVsZWFzZSBsb2NhbGx5IGNyZWF0ZWQgb2JqZWN0Lgor CisgICAgICAgICogU2hhcmVkL21hYy9XZWJDb3JlQXJndW1lbnRDb2RlcnNNYWMubW06CisgICAg ICAgIChDb3JlSVBDOjpkZWNvZGVSZXNvdXJjZUVycm9yKToKKwogMjAxMS0wNC0wNiAgU2lkZGhh cnRoIE1hdGh1ciAgPHNpZGRoYXJ0aC5tYXRodXJAbm9raWEuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEJlbmphbWluIFBvdWxhaW4uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFj L1dlYkNvcmVBcmd1bWVudENvZGVyc01hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvbWFjL1dlYkNvcmVBcmd1bWVudENvZGVyc01hYy5tbQkocmV2aXNpb24gODMxMjgp CisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1dlYkNvcmVBcmd1bWVudENvZGVyc01hYy5t bQkod29ya2luZyBjb3B5KQpAQCAtMTg1LDcgKzE4NSw3IEBAIGJvb2wgZGVjb2RlUmVzb3VyY2VF cnJvcihBcmd1bWVudERlY29kZXIKICAgICBpZiAoY2VydGlmaWNhdGUuY2VydGlmaWNhdGVDaGFp bigpKQogICAgICAgICBbdXNlckluZm8gc2V0T2JqZWN0OihOU0FycmF5ICopY2VydGlmaWNhdGUu Y2VydGlmaWNhdGVDaGFpbigpIGZvcktleTpAIk5TRXJyb3JQZWVyQ2VydGlmaWNhdGVDaGFpbktl eSJdOwogCi0gICAgTlNFcnJvciAqbnNFcnJvciA9IFtbTlNFcnJvciBhbGxvY10gaW5pdFdpdGhE b21haW46bnNTdHJpbmcoZG9tYWluKSBjb2RlOmNvZGUgdXNlckluZm86dXNlckluZm9dOworICAg IE5TRXJyb3IgKm5zRXJyb3IgPSBbW1tOU0Vycm9yIGFsbG9jXSBpbml0V2l0aERvbWFpbjpuc1N0 cmluZyhkb21haW4pIGNvZGU6Y29kZSB1c2VySW5mbzp1c2VySW5mb10gYXV0b3JlbGVhc2VdOwog CiAgICAgcmVzb3VyY2VFcnJvciA9IFJlc291cmNlRXJyb3IobnNFcnJvcik7CiAgICAgcmV0dXJu IHRydWU7Cg==