57999 2011-04-06 16:58:55 -0700 clearIfComposited call is really slow 2011-04-07 20:09:40 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jbauman jbauman cmarrin commit-queue kbr oldest_to_newest 380974 0 jbauman 2011-04-06 16:58:55 -0700 clearIfComposited call is really slow 380977 1 88544 jbauman 2011-04-06 17:04:03 -0700 Created attachment 88544 Patch 381052 2 88544 kbr 2011-04-06 19:02:13 -0700 Comment on attachment 88544 Patch Looks good. 381110 3 88544 commit-queue 2011-04-06 20:57:32 -0700 Comment on attachment 88544 Patch Rejecting attachment 88544 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 2 Last 500 characters of output: LayoutTestControllerQt.cpp M Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp M Tools/ChangeLog r83137 = 7f2c250c078454d645915dace97b96aef2626877 (refs/remotes/trunk) M Tools/DumpRenderTree/mac/DumpRenderTree.mm M Tools/DumpRenderTree/LayoutTestController.cpp M Tools/DumpRenderTree/LayoutTestController.h M Tools/ChangeLog r83138 = 8fef0c2b86f5af6c92684d29e9b2e11bf6f5822f (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8348429 381617 4 kbr 2011-04-07 13:18:13 -0700 You need to take out the "No new tests. OOPS!" line from your ChangeLog. Could you upload a new patch? 381638 5 88684 jbauman 2011-04-07 13:35:28 -0700 Created attachment 88684 Fix patch 381657 6 88684 kbr 2011-04-07 13:42:43 -0700 Comment on attachment 88684 Fix patch Looks good. 381953 7 88684 commit-queue 2011-04-07 20:09:35 -0700 Comment on attachment 88684 Fix patch Clearing flags on attachment: 88684 Committed r83242: <http://trac.webkit.org/changeset/83242> 381954 8 commit-queue 2011-04-07 20:09:40 -0700 All reviewed patches have been landed. Closing bug. 88544 2011-04-06 17:04:03 -0700 2011-04-07 13:35:25 -0700 Patch bug-57999-20110406170402.patch text/plain 1720 jbauman U3VidmVyc2lvbiBSZXZpc2lvbjogODMwNzUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2NGYzMDQ0YjYyNTQwOGNk MjY3NmVhNjVmMTA3OTg3NGJlZDc4ZGI2Li41Y2E0MjIzMzllMGVmYmUyYmFjMjkwMTEyMWE0MzUy ZTgwM2MxMTNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDYgIEpvaG4g QmF1bWFuICA8amJhdW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgY2xlYXJJZkNvbXBvc2l0ZWQgY2FsbCBpcyByZWFsbHkg c2xvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc5 OTkKKworICAgICAgICBNb3ZlIGdldENvbnRleHRBdHRyaWJ1dGVzIGNhbGwgYWZ0ZXIgdGhlIGlm LCBzbyBpdCBpc24ndCBjYWxsZWQgbmVhcmx5IGFzIG9mdGVuLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250 ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6Y2xlYXJJ ZkNvbXBvc2l0ZWQpOgorCiAyMDExLTA0LTA2ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKaW5kZXggYWE0 MGE2NDlmOThiOWJiOTg1NzE0ZmY2ZTQ3OTVjNWE1NDkwYmRkYi4uNTA4ZmM0MTMxODJlMGIzZmZl YmM4Zjc4YmM2MDMyYTAzMDRlZTc0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9j YW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCkBAIC01MDIsMTIgKzUwMiwxMiBAQCBi b29sIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6Y2xlYXJJZkNvbXBvc2l0ZWQoR0MzRGJpdGZpZWxk IG1hc2spCiAgICAgaWYgKGlzQ29udGV4dExvc3QoKSkgCiAgICAgICAgIHJldHVybiBmYWxzZTsK IAotICAgIFJlZlB0cjxXZWJHTENvbnRleHRBdHRyaWJ1dGVzPiBjb250ZXh0QXR0cmlidXRlcyA9 IGdldENvbnRleHRBdHRyaWJ1dGVzKCk7Ci0KICAgICBpZiAoIW1fY29udGV4dC0+bGF5ZXJDb21w b3NpdGVkKCkgfHwgbV9sYXllckNsZWFyZWQKICAgICAgICAgfHwgbV9hdHRyaWJ1dGVzLnByZXNl cnZlRHJhd2luZ0J1ZmZlciB8fCBtX2ZyYW1lYnVmZmVyQmluZGluZykKICAgICAgICAgcmV0dXJu IGZhbHNlOwogCisgICAgUmVmUHRyPFdlYkdMQ29udGV4dEF0dHJpYnV0ZXM+IGNvbnRleHRBdHRy aWJ1dGVzID0gZ2V0Q29udGV4dEF0dHJpYnV0ZXMoKTsKKwogICAgIC8vIERldGVybWluZSBpZiBp dCdzIHBvc3NpYmxlIHRvIGNvbWJpbmUgdGhlIGNsZWFyIHRoZSB1c2VyIGFza2VkIGZvciBhbmQg dGhpcyBjbGVhci4KICAgICBib29sIGNvbWJpbmVkQ2xlYXIgPSBtYXNrICYmICFtX3NjaXNzb3JF bmFibGVkOwogCg== 88684 2011-04-07 13:35:28 -0700 2011-04-07 20:09:35 -0700 Fix patch bug-57999-20110407133527.patch text/plain 1712 jbauman U3VidmVyc2lvbiBSZXZpc2lvbjogODMwNzUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2NGYzMDQ0YjYyNTQwOGNk MjY3NmVhNjVmMTA3OTg3NGJlZDc4ZGI2Li5hMjQ2NGZkNmMwNjczZmYxMTZjYWE3OTg5OTI0NTZm NDgwYzA2OGI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDYgIEpvaG4g QmF1bWFuICA8amJhdW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgY2xlYXJJZkNvbXBvc2l0ZWQgY2FsbCBpcyByZWFsbHkg c2xvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc5 OTkKKworICAgICAgICBNb3ZlIGdldENvbnRleHRBdHRyaWJ1dGVzIGNhbGwgYWZ0ZXIgdGhlIGlm LCBzbyBpdCBpc24ndCBjYWxsZWQgbmVhcmx5IGFzIG9mdGVuLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4KKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmNsZWFySWZDb21wb3Np dGVkKToKKwogMjAxMS0wNC0wNiAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCmluZGV4IGFhNDBhNjQ5Zjk4 YjliYjk4NTcxNGZmNmU0Nzk1YzVhNTQ5MGJkZGIuLjUwOGZjNDEzMTgyZTBiM2ZmZWJjOGY3OGJj NjAzMmEwMzA0ZWU3NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dl YkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMv V2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcApAQCAtNTAyLDEyICs1MDIsMTIgQEAgYm9vbCBXZWJH TFJlbmRlcmluZ0NvbnRleHQ6OmNsZWFySWZDb21wb3NpdGVkKEdDM0RiaXRmaWVsZCBtYXNrKQog ICAgIGlmIChpc0NvbnRleHRMb3N0KCkpIAogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBS ZWZQdHI8V2ViR0xDb250ZXh0QXR0cmlidXRlcz4gY29udGV4dEF0dHJpYnV0ZXMgPSBnZXRDb250 ZXh0QXR0cmlidXRlcygpOwotCiAgICAgaWYgKCFtX2NvbnRleHQtPmxheWVyQ29tcG9zaXRlZCgp IHx8IG1fbGF5ZXJDbGVhcmVkCiAgICAgICAgIHx8IG1fYXR0cmlidXRlcy5wcmVzZXJ2ZURyYXdp bmdCdWZmZXIgfHwgbV9mcmFtZWJ1ZmZlckJpbmRpbmcpCiAgICAgICAgIHJldHVybiBmYWxzZTsK IAorICAgIFJlZlB0cjxXZWJHTENvbnRleHRBdHRyaWJ1dGVzPiBjb250ZXh0QXR0cmlidXRlcyA9 IGdldENvbnRleHRBdHRyaWJ1dGVzKCk7CisKICAgICAvLyBEZXRlcm1pbmUgaWYgaXQncyBwb3Nz aWJsZSB0byBjb21iaW5lIHRoZSBjbGVhciB0aGUgdXNlciBhc2tlZCBmb3IgYW5kIHRoaXMgY2xl YXIuCiAgICAgYm9vbCBjb21iaW5lZENsZWFyID0gbWFzayAmJiAhbV9zY2lzc29yRW5hYmxlZDsK IAo=