57997 2011-04-06 16:18:10 -0700 Document leaks when navigating away from a scrolled page 2011-04-06 19:04:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 slewis webkit-unassigned abarth eric slewis webkit.review.bot oldest_to_newest 380947 0 88541 slewis 2011-04-06 16:18:10 -0700 Created attachment 88541 testcase <rdar://problem/9187856> REGRESSION(r75555): ~5-7 MB increase in memory between iBench runs When navigating away from a page in a scrolled state the scrollbars are reset which fires a scroll event. WIth the new EventQueue for scroll events the event is never dispatched before the page detaches and keeps the Document alive. Solution is to cancel the scroll event when detaching the page. To repro: Load attached testcase Scroll navigate to about:blank close the window. 380969 1 88542 slewis 2011-04-06 16:48:28 -0700 Created attachment 88542 patch 380971 2 88542 darin 2011-04-06 16:50:24 -0700 Comment on attachment 88542 patch I don’t understand this patch. It adds two new functions, but nobody calls the Document function. 380982 3 slewis 2011-04-06 17:13:00 -0700 the call to to cancelEnqueuedEvents is in Document::detach. It would be more concise I suppose to just call the QueueEvent function from there and not add a function to Document. 381011 4 88542 darin 2011-04-06 17:52:55 -0700 Comment on attachment 88542 patch View in context: https://bugs.webkit.org/attachment.cgi?id=88542&action=review > Source/WebCore/dom/Document.cpp:3553 > +void Document::cancelEnqueuedEvents() > +{ > + m_eventQueue->cancelEnqueuedEvents(); > +} I suggest just doing this in Document::detach instead of adding a function for it. 381030 5 slewis 2011-04-06 18:23:57 -0700 committed http://trac.webkit.org/changeset/83128 381058 6 webkit.review.bot 2011-04-06 19:04:18 -0700 http://trac.webkit.org/changeset/83128 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: fast/dom/52776.html fast/text/complex-text-opacity.html fast/text/international/bidi-AN-after-L.html fast/text/international/bidi-AN-after-empty-run.html fast/text/international/bidi-CS-after-AN.html fast/text/international/bidi-mirror-he-ar.html fast/text/international/bidi-neutral-run.html platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html 88541 2011-04-06 16:18:10 -0700 2011-04-06 16:18:10 -0700 testcase ScrollingLeak.html text/html 425 slewis PEhUTUw+PEhFQUQ+CjwhLS0JCQk8c2NyaXB0IHR5cGU9J3RleHQvamF2YXNjcmlwdCc+CgkJCQlm dW5jdGlvbiBPbkxvYWQoKQoJCQkJewoJCQkJCXZhciBlbGVtID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoImNvdW50ZXIiKTsKCQkJCQlzZWxmLnNjcm9sbFRvKDAsIGVsZW0ub2Zmc2V0VG9wKTsJ CQoJCQkJCXNldFRpbWVvdXQoImRvY3VtZW50LmxvY2F0aW9uPSdhYm91dDpibGFuayciLCAzMDAw MCk7CgkJCQl9CgkJCTwvc2NyaXB0Pi0tPgo8L0hFQUQ+CjwhLS08Qk9EWSBvbkxvYWQ9IkxvYWQo KSI+LS0+Cjxib2R5Pgo8ZGl2IGlkPSJjb3VudGVyIiBzdHlsZT0ncG9zaXRpb246IGFic29sdXRl OyBiYWNrZ3JvdW5kOiByZWQ7IHdpZHRoOiA2MDBweDsgaGVpZ2h0OiAxMDAwIHB4OyB0b3A6MTAw cHg7Jz48L2Rpdj4KPC9ib2R5PjwvSFRNTD4= 88542 2011-04-06 16:48:28 -0700 2011-04-06 17:52:55 -0700 patch ScrollEventLeak.txt text/plain 3421 slewis SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMTE4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDQtMDYgIFN0ZXBoYW5p ZSBMZXdpcyAgPHNsZXdpc0BhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU3OTk3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85MTg3ODU2PiBSRUdSRVNTSU9OKHI3 NTU1NSk6IH41LTcgTUIgaW5jcmVhc2UgaW4gbWVtb3J5IGJldHdlZW4gaUJlbmNoIHJ1bnMKKyAg ICAgICAgTmF2aWdhdGluZyBhd2F5IGZyb20gYSBTY3JvbGxlZCBwYWdlIHdoaWNoIHF1ZXVlcyBh IHNjcm9sbCBldmVudCB0aGF0IGlzIG5ldmVyIGRpc3BhdGNoZWQuCisgICAgICAgIENhbmNlbCBh bGwgZW5xdWV1ZWQgZXZlbnRzIHdoZW4gZGV0YWNoaW5nIHRoZSBEb2N1bWVudCB0aGUgZXZlbnRz IGNhbm5vdCBrZWVwIHRoZSBEb2N1bWVudAorICAgICAgICBhbGl2ZS4KKworICAgICAgICBObyBj aGFuZ2UgaW4gZnVuY3Rpb25hbGl0eSBzbyBubyBuZXcgdGVzdHMuICAgICAgICAKKworICAgICAg ICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6ZGV0YWNo KToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpjYW5jZWxFbnF1ZXVlZEV2ZW50cyk6Cisg ICAgICAgICogZG9tL0RvY3VtZW50Lmg6CisgICAgICAgICogZG9tL0V2ZW50UXVldWUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RXZlbnRRdWV1ZTo6Y2FuY2VsRW5xdWV1ZWRFdmVudHMpOgorICAg ICAgICAqIGRvbS9FdmVudFF1ZXVlLmg6CisKIDIwMTEtMDQtMDYgIElhbiBIZW5kZXJzb24gIDxp YW5oQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkocmV2aXNpb24gODI2MjkpCisrKyBTb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzY3LDYgKzE3NjcsNyBA QCB2b2lkIERvY3VtZW50OjpkZXRhY2goKQogCiAgICAgY2xlYXJBWE9iamVjdENhY2hlKCk7CiAg ICAgc3RvcEFjdGl2ZURPTU9iamVjdHMoKTsKKyAgICBjYW5jZWxFbnF1ZXVlZEV2ZW50cygpOwog CiAjaWYgRU5BQkxFKFJFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FKQogICAgIC8vIEZJWE1FOiBjb25z aWRlciB1c2luZyBBY3RpdmVET01PYmplY3QuCkBAIC0zNTQ2LDYgKzM1NDcsMTEgQEAgdm9pZCBE b2N1bWVudDo6ZW5xdWV1ZURvY3VtZW50RXZlbnQoUGFzcwogICAgIG1fZXZlbnRRdWV1ZS0+ZW5x dWV1ZUV2ZW50KGV2ZW50KTsKIH0KIAordm9pZCBEb2N1bWVudDo6Y2FuY2VsRW5xdWV1ZWRFdmVu dHMoKQoreworICAgIG1fZXZlbnRRdWV1ZS0+Y2FuY2VsRW5xdWV1ZWRFdmVudHMoKTsKK30KKwog UGFzc1JlZlB0cjxFdmVudD4gRG9jdW1lbnQ6OmNyZWF0ZUV2ZW50KGNvbnN0IFN0cmluZyYgZXZl bnRUeXBlLCBFeGNlcHRpb25Db2RlJiBlYykKIHsKICAgICBSZWZQdHI8RXZlbnQ+IGV2ZW50OwpJ bmRleDogU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvZG9tL0RvY3VtZW50LmgJKHJldmlzaW9uIDgyNjI5KQorKysgU291cmNlL1dlYkNv cmUvZG9tL0RvY3VtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTEwNzAsNiArMTA3MCw3IEBAIHB1 YmxpYzoKICAgICB2b2lkIGVucXVldWVQYWdlc2hvd0V2ZW50KFBhZ2VzaG93RXZlbnRQZXJzaXN0 ZW5jZSk7CiAgICAgdm9pZCBlbnF1ZXVlSGFzaGNoYW5nZUV2ZW50KGNvbnN0IFN0cmluZyYgb2xk VVJMLCBjb25zdCBTdHJpbmcmIG5ld1VSTCk7CiAgICAgdm9pZCBlbnF1ZXVlUG9wc3RhdGVFdmVu dChQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gc3RhdGVPYmplY3QpOworICAgIHZv aWQgY2FuY2VsRW5xdWV1ZWRFdmVudHMoKTsKICAgICBFdmVudFF1ZXVlKiBldmVudFF1ZXVlKCkg Y29uc3QgeyByZXR1cm4gbV9ldmVudFF1ZXVlLmdldCgpOyB9CiAKICAgICB2b2lkIGFkZE1lZGlh Q2FuU3RhcnRMaXN0ZW5lcihNZWRpYUNhblN0YXJ0TGlzdGVuZXIqKTsKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2RvbS9FdmVudFF1ZXVlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9k b20vRXZlbnRRdWV1ZS5jcHAJKHJldmlzaW9uIDgyNjI5KQorKysgU291cmNlL1dlYkNvcmUvZG9t L0V2ZW50UXVldWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Miw2ICs5MiwxMiBAQCBib29sIEV2 ZW50UXVldWU6OmNhbmNlbEV2ZW50KEV2ZW50KiBldmVuCiAgICAgcmV0dXJuIGZvdW5kOwogfQog Cit2b2lkIEV2ZW50UXVldWU6OmNhbmNlbEVucXVldWVkRXZlbnRzKCkKK3sKKyAgICBtX3BlbmRp bmdFdmVudFRpbWVyLT5zdG9wKCk7CisgICAgbV9xdWV1ZWRFdmVudHMuY2xlYXIoKTsKK30KKwog dm9pZCBFdmVudFF1ZXVlOjpwZW5kaW5nRXZlbnRUaW1lckZpcmVkKCkKIHsKICAgICBBU1NFUlQo IW1fcGVuZGluZ0V2ZW50VGltZXItPmlzQWN0aXZlKCkpOwpJbmRleDogU291cmNlL1dlYkNvcmUv ZG9tL0V2ZW50UXVldWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRR dWV1ZS5oCShyZXZpc2lvbiA4MjYyOSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFF1ZXVl LmgJKHdvcmtpbmcgY29weSkKQEAgLTUzLDYgKzUzLDcgQEAgcHVibGljOgogICAgIHZvaWQgZW5x dWV1ZUV2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+KTsKICAgICB2b2lkIGVucXVldWVTY3JvbGxFdmVu dChQYXNzUmVmUHRyPE5vZGU+LCBTY3JvbGxFdmVudFRhcmdldFR5cGUpOwogICAgIGJvb2wgY2Fu Y2VsRXZlbnQoRXZlbnQqKTsKKyAgICB2b2lkIGNhbmNlbEVucXVldWVkRXZlbnRzKCk7CiAKIHBy aXZhdGU6CiAgICAgZXhwbGljaXQgRXZlbnRRdWV1ZShTY3JpcHRFeGVjdXRpb25Db250ZXh0Kik7 Cg==