57995 2011-04-06 15:53:55 -0700 Unnecessary string allocation in CSSStyleDeclaration::setProperty 2011-04-06 16:19:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED P2 Normal --- 0 ian webkit-unassigned simon.fraser oldest_to_newest 380923 0 ian 2011-04-06 15:53:55 -0700 In CSSStyleDeclaration::setProperty(const String&, const String&, ExceptionCode&), we construct a string, either "" or "important", depending on the priority of the property. We then pass this value to CSSStyleDeclaration::setProperty(const String&, const String&, const String&, ExceptionCode&), which parses the value out of the string again. We should just pass the bool directly, without going through an intermediate string. 380930 1 88537 ian 2011-04-06 16:02:22 -0700 Created attachment 88537 proposed patch 380950 2 88537 simon.fraser 2011-04-06 16:19:28 -0700 Comment on attachment 88537 proposed patch Clearing flags on attachment: 88537 Committed r83118: <http://trac.webkit.org/changeset/83118> 380951 3 simon.fraser 2011-04-06 16:19:34 -0700 All reviewed patches have been landed. Closing bug. 88537 2011-04-06 16:02:22 -0700 2011-04-06 16:19:27 -0700 proposed patch 57995-1.patch text/plain 1683 ian SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMTE0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMDYgIElhbiBIZW5k ZXJzb24gIDxpYW5oQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBVbm5lY2Vzc2FyeSBzdHJpbmcgYWxsb2NhdGlvbiBpbiBDU1NTdHls ZURlY2xhcmF0aW9uOjpzZXRQcm9wZXJ0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTc5OTUKKworICAgICAgICBQYXNzIHRoZSBib29sIHJlcHJlc2Vu dGluZyB0aGUgcHJvcGVydHkncyBpbXBvcnRhbmNlIGRpcmVjdGx5IGluc3RlYWQKKyAgICAgICAg b2YgY29uc3RydWN0aW5nIGEgc3RyaW5nLgorCisgICAgICAgICogY3NzL0NTU1N0eWxlRGVjbGFy YXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVEZWNsYXJhdGlvbjo6c2V0UHJv cGVydHkpOgorCiAyMDExLTA0LTA2ICBCcmlhbiBXZWluc3RlaW4gIDxid2VpbnN0ZWluQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDogU291cmNlL1dl YkNvcmUvY3NzL0NTU1N0eWxlRGVjbGFyYXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NTdHlsZURlY2xhcmF0aW9uLmNwcAkocmV2aXNpb24gODMwNzUpCisrKyBT b3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVEZWNsYXJhdGlvbi5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTEwNywxMCArMTA3LDEzIEBACiB2b2lkIENTU1N0eWxlRGVjbGFyYXRpb246OnNldFByb3Bl cnR5KGNvbnN0IFN0cmluZyYgcHJvcGVydHlOYW1lLCBjb25zdCBTdHJpbmcmIHZhbHVlLCBFeGNl cHRpb25Db2RlJiBlYykKIHsKICAgICBzaXplX3QgaW1wb3J0YW50ID0gdmFsdWUuZmluZCgiIWlt cG9ydGFudCIsIDAsIGZhbHNlKTsKKyAgICBpbnQgcHJvcGVydHlJRCA9IGNzc1Byb3BlcnR5SUQo cHJvcGVydHlOYW1lKTsKKyAgICBpZiAoIXByb3BlcnR5SUQpCisgICAgICAgIHJldHVybjsKICAg ICBpZiAoaW1wb3J0YW50ID09IG5vdEZvdW5kKQotICAgICAgICBzZXRQcm9wZXJ0eShwcm9wZXJ0 eU5hbWUsIHZhbHVlLCAiIiwgZWMpOworICAgICAgICBzZXRQcm9wZXJ0eShwcm9wZXJ0eUlELCB2 YWx1ZSwgZmFsc2UsIGVjKTsKICAgICBlbHNlCi0gICAgICAgIHNldFByb3BlcnR5KHByb3BlcnR5 TmFtZSwgdmFsdWUubGVmdChpbXBvcnRhbnQgLSAxKSwgImltcG9ydGFudCIsIGVjKTsKKyAgICAg ICAgc2V0UHJvcGVydHkocHJvcGVydHlJRCwgdmFsdWUubGVmdChpbXBvcnRhbnQgLSAxKSwgdHJ1 ZSwgZWMpOwogfQogCiB2b2lkIENTU1N0eWxlRGVjbGFyYXRpb246OnNldFByb3BlcnR5KGNvbnN0 IFN0cmluZyYgcHJvcGVydHlOYW1lLCBjb25zdCBTdHJpbmcmIHZhbHVlLCBjb25zdCBTdHJpbmcm IHByaW9yaXR5LCBFeGNlcHRpb25Db2RlJiBlYykK