57992 2011-04-06 15:23:14 -0700 old-run-webkit-tests: add support for audio files 2011-06-03 03:00:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 57977 1 dpranke dpranke commit-queue crogers ossy rgabor tony oldest_to_newest 380901 0 dpranke 2011-04-06 15:23:14 -0700 See bug 57969 - we're adding support to DRT to output audio files to test web audio, and we need to add support to ORWT to handle the output correctly. 381007 1 dpranke 2011-04-06 17:50:13 -0700 See bug 57987 for the changes that needed to happen for NRWT. 413048 2 95524 dpranke 2011-05-31 18:13:18 -0700 Created attachment 95524 Patch 413464 3 95524 tony 2011-06-01 10:10:23 -0700 Comment on attachment 95524 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95524&action=review > Tools/Scripts/old-run-webkit-tests:2305 > + } elsif ($lineIn =~ /(.*)#EOF$/) { > + if ($1) { This will do the wrong thing if $1 is "0". Perl silently converts that to a number, which then becomes false. You could just compare to "". > Tools/Scripts/old-run-webkit-tests:2336 > + my $joined_error = join("", @error); Nit: Pulling this out into a variable doesn't seem to add any value. 413474 4 95524 dpranke 2011-06-01 10:32:59 -0700 Comment on attachment 95524 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95524&action=review >> Tools/Scripts/old-run-webkit-tests:2305 >> + if ($1) { > > This will do the wrong thing if $1 is "0". Perl silently converts that to a number, which then becomes false. You could just compare to "". Good catch. Will fix. >> Tools/Scripts/old-run-webkit-tests:2336 >> + my $joined_error = join("", @error); > > Nit: Pulling this out into a variable doesn't seem to add any value. I thought this made the return slightly easier to read. I'll revert it. 413642 5 95656 dpranke 2011-06-01 13:59:43 -0700 Created attachment 95656 update w/ review feedback from Tony 413830 6 95656 commit-queue 2011-06-01 19:09:52 -0700 Comment on attachment 95656 update w/ review feedback from Tony Clearing flags on attachment: 95656 Committed r87873: <http://trac.webkit.org/changeset/87873> 413831 7 commit-queue 2011-06-01 19:09:56 -0700 All reviewed patches have been landed. Closing bug. 414096 8 ossy 2011-06-02 07:27:48 -0700 I have no idea how, but this patch broke two tests on Qt port: --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/events/overflow-viewport-renderer-deleted-expected.txt 2011-06-02 07:01:35.955265937 -0700 +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/events/overflow-viewport-renderer-deleted-actual.txt 2011-06-02 07:01:35.955265937 -0700 @@ -0,0 +1 @@ +ERROR: nil result from [documentElement innerText] \ No newline at end of file --- /ramdisk/qt-linux-64-release/build/layout-test-results/plugins/document-open-expected.txt 2011-06-02 07:04:46.240269339 -0700 +++ /ramdisk/qt-linux-64-release/build/layout-test-results/plugins/document-open-actual.txt 2011-06-02 07:04:46.240269339 -0700 @@ -1 +1,2 @@ CONSOLE MESSAGE: line 0: PLUGIN: DOCUMENT OPEN SUCCESS +ERROR: nil result from [documentElement innerText] \ No newline at end of file 414097 9 ossy 2011-06-02 07:28:17 -0700 . 414627 10 dpranke 2011-06-02 20:32:07 -0700 (In reply to comment #8) > I have no idea how, but this patch broke two tests on Qt port: > > --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/events/overflow-viewport-renderer-deleted-expected.txt 2011-06-02 07:01:35.955265937 -0700 > +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/events/overflow-viewport-renderer-deleted-actual.txt 2011-06-02 07:01:35.955265937 -0700 > @@ -0,0 +1 @@ > +ERROR: nil result from [documentElement innerText] > \ No newline at end of file > > > --- /ramdisk/qt-linux-64-release/build/layout-test-results/plugins/document-open-expected.txt 2011-06-02 07:04:46.240269339 -0700 > +++ /ramdisk/qt-linux-64-release/build/layout-test-results/plugins/document-open-actual.txt 2011-06-02 07:04:46.240269339 -0700 > @@ -1 +1,2 @@ > CONSOLE MESSAGE: line 0: PLUGIN: DOCUMENT OPEN SUCCESS > +ERROR: nil result from [documentElement innerText] > \ No newline at end of file The patch changed things so that if you had text on the final line of output from DRT but no trailing newline, then that text would be included in the -actual output (previously it would have been dropped), e.g.: foo\n bar#EOF would produce an actual.txt of foo\n bar^D whereas previously the bar would've been dropped. If your DRT was somehow not appending a final newline for some tests, this would break that. The fix would be to update the baselines to contain the newly appended text and (optionally) fix DRT, since it should always be putting in a final newline for text files. (This change was needed because there is no final newline for audio files at the moment). 414628 11 dpranke 2011-06-02 20:34:06 -0700 I think we can (and should) close this again; Ossy, do you agree? 414749 12 ossy 2011-06-03 03:00:56 -0700 (In reply to comment #11) > I think we can (and should) close this again; Ossy, do you agree? Yes. Thanks for the information. I updated Qt specific results: http://trac.webkit.org/changeset/87998. Gabor, could you check this EOF/newline problem? As far as I remember you fixed a similar bug in DRT before. 95524 2011-05-31 18:13:18 -0700 2011-06-01 13:59:40 -0700 Patch bug-57992-20110531181317.patch text/plain 3028 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODc2OTcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwNjUyMGIyODViNjJiNDdmZjNmNGFkYjJhMjBlZmI1Y2Y0 MzJhY2UxLi5kODJlMDc5ZDEwZjllMzU0YzQ2YjQ5Y2JjYzhiMmU3MWM1OTk1NGZjIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTUg QEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBvbGQt cnVuLXdlYmtpdC10ZXN0czogYWRkIHN1cHBvcnQgZm9yIGF1ZGlvIGZpbGVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Nzk5MgorCisgICAgICAgICog U2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0czoKKworMjAxMS0wNS0zMSAgRGlyayBQcmFua2Ug IDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKwogICAgICAgICBucnd0OiBtYWtlIHdlYmF1ZGlvIHdvcmsgdy9vIGNvbnRlbnQtbGVu Z3RoIGhlYWRlcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjE4MTkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0 cyBiL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKaW5kZXggN2FiYWE2OGRmNzcz OTQzMjkxZTg1Zjc2NTZhNTgyZDE1ZjIwMGUwMy4uZWQxZTdhMTZlOWQ5M2VjYzg5ODMyMWM1ZTYy OTQ2ZmZmNjQ4YmZlOCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10 ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCkBAIC02NSw2ICs2 NSw3IEBAIHVzZSBGaW5kQmluOwogdXNlIEdldG9wdDo6TG9uZzsKIHVzZSBJUEM6Ok9wZW4yOwog dXNlIElQQzo6T3BlbjM7Cit1c2UgTUlNRTo6QmFzZTY0OwogdXNlIFRpbWU6OkhpUmVzIHF3KHRp bWUgdXNsZWVwKTsKIAogdXNlIExpc3Q6OlV0aWwgJ3NodWZmbGUnOwpAQCAtMjIzOCw2ICsyMjM5 LDggQEAgc3ViIGV4dGVuc2lvbkZvck1pbWVUeXBlKCQpCiAgICAgICAgIHJldHVybiAid2ViYXJj aGl2ZSI7CiAgICAgfSBlbHNpZiAoJG1pbWVUeXBlIGVxICJhcHBsaWNhdGlvbi9wZGYiKSB7CiAg ICAgICAgIHJldHVybiAicGRmIjsKKyAgICB9IGVsc2lmICgkbWltZVR5cGUgZXEgImF1ZGlvL3dh diIpIHsKKyAgICAgICAgcmV0dXJuICJ3YXYiOwogICAgIH0KICAgICByZXR1cm4gInR4dCI7CiB9 CkBAIC0yMjU5LDkgKzIyNjIsMTEgQEAgc3ViIHJlYWRGcm9tRHVtcFRvb2xXaXRoVGltZXIoKiop CiAgICAgbXkgQGVycm9yID0gKCk7CiAgICAgbXkgJHN0YXR1cyA9ICJzdWNjZXNzIjsKICAgICBt eSAkbWltZVR5cGUgPSAidGV4dC9wbGFpbiI7CisgICAgbXkgJGVuY29kaW5nID0gIiI7CiAgICAg IyBXZSBkb24ndCBoYXZlIGEgdmVyeSBnb29kIHdheSB0byBrbm93IHdoZW4gdGhlICJoZWFkZXJz IiBzdG9wCiAgICAgIyBhbmQgdGhlIGNvbnRlbnQgc3RhcnRzLCBzbyB3ZSB1c2UgdGhpcyBhcyBh IGhhY2s6CiAgICAgbXkgJGhhdmVTZWVuQ29udGVudFR5cGUgPSAwOworICAgIG15ICRoYXZlU2Vl bkNvbnRlbnRUcmFuc2ZlckVuY29kaW5nID0gMDsKICAgICBteSAkaGF2ZVNlZW5Fb2ZJbiA9IDA7 CiAgICAgbXkgJGhhdmVTZWVuRW9mRXJyb3IgPSAwOwogCkBAIC0yMjkzLDcgKzIyOTgsMTMgQEAg c3ViIHJlYWRGcm9tRHVtcFRvb2xXaXRoVGltZXIoKiopCiAgICAgICAgICAgICBpZiAoISRoYXZl U2VlbkNvbnRlbnRUeXBlICYmICRsaW5lSW4gPX4gL15Db250ZW50LVR5cGU6IChcUyspJC8pIHsK ICAgICAgICAgICAgICAgICAkbWltZVR5cGUgPSAkMTsKICAgICAgICAgICAgICAgICAkaGF2ZVNl ZW5Db250ZW50VHlwZSA9IDE7Ci0gICAgICAgICAgICB9IGVsc2lmICgkbGluZUluID1+IC8jRU9G LykgeworICAgICAgICAgICAgfSBlbHNpZiAoISRoYXZlU2VlbkNvbnRlbnRUcmFuc2ZlckVuY29k aW5nICYmICRsaW5lSW4gPX4gL15Db250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiAoXFMrKSQvKSB7 CisgICAgICAgICAgICAgICAgJGVuY29kaW5nID0gJDE7CisgICAgICAgICAgICAgICAgJGhhdmVT ZWVuQ29udGVudFRyYW5zZmVyRW5jb2RpbmcgPSAxOworICAgICAgICAgICAgfSBlbHNpZiAoJGxp bmVJbiA9fiAvKC4qKSNFT0YkLykgeworICAgICAgICAgICAgICAgIGlmICgkMSkgeworICAgICAg ICAgICAgICAgICAgICBwdXNoIEBvdXRwdXQsICQxOworICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgICAgICAkaGF2ZVNlZW5Fb2ZJbiA9IDE7CiAgICAgICAgICAgICB9IGVsc2UgewogICAg ICAgICAgICAgICAgIHB1c2ggQG91dHB1dCwgJGxpbmVJbjsKQEAgLTIzMTgsOSArMjMyOSwxNCBA QCBzdWIgcmVhZEZyb21EdW1wVG9vbFdpdGhUaW1lcigqKikKIAogICAgIHNldEZpbGVIYW5kbGVO b25CbG9ja2luZygkZmhJbiwgMCk7CiAgICAgc2V0RmlsZUhhbmRsZU5vbkJsb2NraW5nKCRmaEVy cm9yLCAwKTsKKyAgICBteSAkam9pbmVkX291dHB1dCA9IGpvaW4oIiIsIEBvdXRwdXQpOworICAg IGlmICgkZW5jb2RpbmcgZXEgImJhc2U2NCIpIHsKKyAgICAgICAgJGpvaW5lZF9vdXRwdXQgPSBk ZWNvZGVfYmFzZTY0KCRqb2luZWRfb3V0cHV0KTsKKyAgICB9CisgICAgbXkgJGpvaW5lZF9lcnJv ciA9IGpvaW4oIiIsIEBlcnJvcik7CiAgICAgcmV0dXJuIHsKLSAgICAgICAgb3V0cHV0ID0+IGpv aW4oIiIsIEBvdXRwdXQpLAotICAgICAgICBlcnJvciA9PiBqb2luKCIiLCBAZXJyb3IpLAorICAg ICAgICBvdXRwdXQgPT4gJGpvaW5lZF9vdXRwdXQsCisgICAgICAgIGVycm9yID0+ICRqb2luZWRf ZXJyb3IsCiAgICAgICAgIHN0YXR1cyA9PiAkc3RhdHVzLAogICAgICAgICBtaW1lVHlwZSA9PiAk bWltZVR5cGUsCiAgICAgICAgIGV4dGVuc2lvbiA9PiBleHRlbnNpb25Gb3JNaW1lVHlwZSgkbWlt ZVR5cGUpCg== 95656 2011-06-01 13:59:43 -0700 2011-06-01 19:09:51 -0700 update w/ review feedback from Tony bug-57992-20110601135942.patch text/plain 2905 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODc2OTcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwNjUyMGIyODViNjJiNDdmZjNmNGFkYjJhMjBlZmI1Y2Y0 MzJhY2UxLi5kODJlMDc5ZDEwZjllMzU0YzQ2YjQ5Y2JjYzhiMmU3MWM1OTk1NGZjIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTUg QEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBvbGQt cnVuLXdlYmtpdC10ZXN0czogYWRkIHN1cHBvcnQgZm9yIGF1ZGlvIGZpbGVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Nzk5MgorCisgICAgICAgICog U2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0czoKKworMjAxMS0wNS0zMSAgRGlyayBQcmFua2Ug IDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKwogICAgICAgICBucnd0OiBtYWtlIHdlYmF1ZGlvIHdvcmsgdy9vIGNvbnRlbnQtbGVu Z3RoIGhlYWRlcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjE4MTkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0 cyBiL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKaW5kZXggN2FiYWE2OGRmNzcz OTQzMjkxZTg1Zjc2NTZhNTgyZDE1ZjIwMGUwMy4uYmQ1YWM1ZDA4ZGNiYjgzYTYyNWVhMWIyZWRi OTMwMGM3NzY4MjFiNCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10 ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCkBAIC02NSw2ICs2 NSw3IEBAIHVzZSBGaW5kQmluOwogdXNlIEdldG9wdDo6TG9uZzsKIHVzZSBJUEM6Ok9wZW4yOwog dXNlIElQQzo6T3BlbjM7Cit1c2UgTUlNRTo6QmFzZTY0OwogdXNlIFRpbWU6OkhpUmVzIHF3KHRp bWUgdXNsZWVwKTsKIAogdXNlIExpc3Q6OlV0aWwgJ3NodWZmbGUnOwpAQCAtMjIzOCw2ICsyMjM5 LDggQEAgc3ViIGV4dGVuc2lvbkZvck1pbWVUeXBlKCQpCiAgICAgICAgIHJldHVybiAid2ViYXJj aGl2ZSI7CiAgICAgfSBlbHNpZiAoJG1pbWVUeXBlIGVxICJhcHBsaWNhdGlvbi9wZGYiKSB7CiAg ICAgICAgIHJldHVybiAicGRmIjsKKyAgICB9IGVsc2lmICgkbWltZVR5cGUgZXEgImF1ZGlvL3dh diIpIHsKKyAgICAgICAgcmV0dXJuICJ3YXYiOwogICAgIH0KICAgICByZXR1cm4gInR4dCI7CiB9 CkBAIC0yMjU5LDkgKzIyNjIsMTEgQEAgc3ViIHJlYWRGcm9tRHVtcFRvb2xXaXRoVGltZXIoKiop CiAgICAgbXkgQGVycm9yID0gKCk7CiAgICAgbXkgJHN0YXR1cyA9ICJzdWNjZXNzIjsKICAgICBt eSAkbWltZVR5cGUgPSAidGV4dC9wbGFpbiI7CisgICAgbXkgJGVuY29kaW5nID0gIiI7CiAgICAg IyBXZSBkb24ndCBoYXZlIGEgdmVyeSBnb29kIHdheSB0byBrbm93IHdoZW4gdGhlICJoZWFkZXJz IiBzdG9wCiAgICAgIyBhbmQgdGhlIGNvbnRlbnQgc3RhcnRzLCBzbyB3ZSB1c2UgdGhpcyBhcyBh IGhhY2s6CiAgICAgbXkgJGhhdmVTZWVuQ29udGVudFR5cGUgPSAwOworICAgIG15ICRoYXZlU2Vl bkNvbnRlbnRUcmFuc2ZlckVuY29kaW5nID0gMDsKICAgICBteSAkaGF2ZVNlZW5Fb2ZJbiA9IDA7 CiAgICAgbXkgJGhhdmVTZWVuRW9mRXJyb3IgPSAwOwogCkBAIC0yMjkzLDcgKzIyOTgsMTMgQEAg c3ViIHJlYWRGcm9tRHVtcFRvb2xXaXRoVGltZXIoKiopCiAgICAgICAgICAgICBpZiAoISRoYXZl U2VlbkNvbnRlbnRUeXBlICYmICRsaW5lSW4gPX4gL15Db250ZW50LVR5cGU6IChcUyspJC8pIHsK ICAgICAgICAgICAgICAgICAkbWltZVR5cGUgPSAkMTsKICAgICAgICAgICAgICAgICAkaGF2ZVNl ZW5Db250ZW50VHlwZSA9IDE7Ci0gICAgICAgICAgICB9IGVsc2lmICgkbGluZUluID1+IC8jRU9G LykgeworICAgICAgICAgICAgfSBlbHNpZiAoISRoYXZlU2VlbkNvbnRlbnRUcmFuc2ZlckVuY29k aW5nICYmICRsaW5lSW4gPX4gL15Db250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiAoXFMrKSQvKSB7 CisgICAgICAgICAgICAgICAgJGVuY29kaW5nID0gJDE7CisgICAgICAgICAgICAgICAgJGhhdmVT ZWVuQ29udGVudFRyYW5zZmVyRW5jb2RpbmcgPSAxOworICAgICAgICAgICAgfSBlbHNpZiAoJGxp bmVJbiA9fiAvKC4qKSNFT0YkLykgeworICAgICAgICAgICAgICAgIGlmICgkMSBuZSAiIikgewor ICAgICAgICAgICAgICAgICAgICBwdXNoIEBvdXRwdXQsICQxOworICAgICAgICAgICAgICAgIH0K ICAgICAgICAgICAgICAgICAkaGF2ZVNlZW5Fb2ZJbiA9IDE7CiAgICAgICAgICAgICB9IGVsc2Ug ewogICAgICAgICAgICAgICAgIHB1c2ggQG91dHB1dCwgJGxpbmVJbjsKQEAgLTIzMTgsOCArMjMy OSwxMiBAQCBzdWIgcmVhZEZyb21EdW1wVG9vbFdpdGhUaW1lcigqKikKIAogICAgIHNldEZpbGVI YW5kbGVOb25CbG9ja2luZygkZmhJbiwgMCk7CiAgICAgc2V0RmlsZUhhbmRsZU5vbkJsb2NraW5n KCRmaEVycm9yLCAwKTsKKyAgICBteSAkam9pbmVkX291dHB1dCA9IGpvaW4oIiIsIEBvdXRwdXQp OworICAgIGlmICgkZW5jb2RpbmcgZXEgImJhc2U2NCIpIHsKKyAgICAgICAgJGpvaW5lZF9vdXRw dXQgPSBkZWNvZGVfYmFzZTY0KCRqb2luZWRfb3V0cHV0KTsKKyAgICB9CiAgICAgcmV0dXJuIHsK LSAgICAgICAgb3V0cHV0ID0+IGpvaW4oIiIsIEBvdXRwdXQpLAorICAgICAgICBvdXRwdXQgPT4g JGpvaW5lZF9vdXRwdXQsCiAgICAgICAgIGVycm9yID0+IGpvaW4oIiIsIEBlcnJvciksCiAgICAg ICAgIHN0YXR1cyA9PiAkc3RhdHVzLAogICAgICAgICBtaW1lVHlwZSA9PiAkbWltZVR5cGUsCg==