57991 2011-04-06 15:21:52 -0700 [V8] Remove custom DOMImplementation getter on Document. 2011-04-07 14:51:52 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vitalyr webkit-unassigned abarth oldest_to_newest 380900 0 vitalyr 2011-04-06 15:21:52 -0700 [V8] Remove custom DOMImplementation getter on Document. 380904 1 88530 vitalyr 2011-04-06 15:25:55 -0700 Created attachment 88530 patch 380960 2 88530 antonm 2011-04-06 16:38:00 -0700 Comment on attachment 88530 patch LGTM 381738 3 vitalyr 2011-04-07 14:51:52 -0700 M LayoutTests/ChangeLog A LayoutTests/fast/dom/DOMImplementation/implementation-identity-expected.txt A LayoutTests/fast/dom/DOMImplementation/implementation-identity.html M Source/WebCore/ChangeLog M Source/WebCore/bindings/scripts/CodeGeneratorV8.pm M Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp M Source/WebCore/dom/Document.idl Committed r83213 88530 2011-04-06 15:25:55 -0700 2011-04-07 10:08:06 -0700 patch dom_impl.patch text/plain 6407 vitalyr ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjZjRkZjFlLi4wZDZmOGYxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQt MDYgIFZpdGFseSBSZXBlc2hrbyAgPHZpdGFseXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0gUmVtb3ZlIGN1c3RvbSBE T01JbXBsZW1lbnRhdGlvbiBnZXR0ZXIgb24gRG9jdW1lbnQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Nzk5MQorCisgICAgICAgICogZmFzdC9kb20v RE9NSW1wbGVtZW50YXRpb24vaW1wbGVtZW50YXRpb24taWRlbnRpdHktZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9ET01JbXBsZW1lbnRhdGlvbi9pbXBsZW1lbnRhdGlv bi1pZGVudGl0eS5odG1sOiBBZGRlZC4KKwogMjAxMS0wNC0wNiAgQWRyaWVubmUgV2Fsa2VyICA8 ZW5uZUBnb29nbGUuY29tPgogCiAgICAgICAgVW5yZXZpZXdlZCwgYWRkIENocm9taXVtIHNub3cg bGVvcGFyZCBiYXNlbGluZSBmb3IgbWV0ZXItYm91bmRhcnktdmFsdWVzCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2RvbS9ET01JbXBsZW1lbnRhdGlvbi9pbXBsZW1lbnRhdGlvbi1pZGVu dGl0eS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9ET01JbXBsZW1lbnRhdGlv bi9pbXBsZW1lbnRhdGlvbi1pZGVudGl0eS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMC4uNDJiZGZmZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvZG9tL0RPTUltcGxlbWVudGF0aW9uL2ltcGxlbWVudGF0aW9uLWlkZW50aXR5LWV4cGVj dGVkLnR4dApAQCAtMCwwICsxLDcgQEAKK1RoaXMgdGVzdCBjaGVja3MgdGhhdCBET01JbXBsZW1l bnRhdGlvbiBvYmplY3QgaXMgY3JlYXRlZCBwZXIgZG9jdW1lbnQuCisKK0lmIHRoZSB0ZXN0IHBh c3NlcywgeW91IHNob3VsZCBzZWUgYSBmZXcgT0sgbGluZXMgYmVsb3cuCisKK09LOiBUb3AtbGV2 ZWwgZG9jdW1lbnQgYW5kIGlmcmFtZSBkb2N1bWVudCBoYXZlIGRpZmZlcmVudCBET01JbXBsZW1l bnRhdGlvbiBvYmplY3RzCitPSzogRE9NSW1wbGVtZW50YXRpb24gb2JqZWN0IGlzIGNhY2hlZAor CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9ET01JbXBsZW1lbnRhdGlvbi9pbXBs ZW1lbnRhdGlvbi1pZGVudGl0eS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vRE9NSW1wbGVt ZW50YXRpb24vaW1wbGVtZW50YXRpb24taWRlbnRpdHkuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwLi4yYjNjNTZjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9kb20vRE9NSW1wbGVtZW50YXRpb24vaW1wbGVtZW50YXRpb24taWRlbnRpdHkuaHRtbApA QCAtMCwwICsxLDMwIEBACis8Ym9keT4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RD b250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworZnVu Y3Rpb24gcHJpbnQobWVzc2FnZSkKK3sKKyAgICB2YXIgcGFyYWdyYXBoID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgibGkiKTsKKyAgICBwYXJhZ3JhcGguYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3Jl YXRlVGV4dE5vZGUobWVzc2FnZSkpOworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb25z b2xlIikuYXBwZW5kQ2hpbGQocGFyYWdyYXBoKTsKK30KKworZnVuY3Rpb24gdGVzdCgpCit7Cisg ICAgaWYgKGRvY3VtZW50LmltcGxlbWVudGF0aW9uICE9IGZyYW1lc1swXS5kb2N1bWVudC5pbXBs ZW1lbnRhdGlvbikKKyAgICAgICAgcHJpbnQoIk9LOiBUb3AtbGV2ZWwgZG9jdW1lbnQgYW5kIGlm cmFtZSBkb2N1bWVudCBoYXZlIGRpZmZlcmVudCBET01JbXBsZW1lbnRhdGlvbiBvYmplY3RzIik7 CisgICAgZWxzZQorICAgICAgICBwcmludCgiQlVHOiBUb3AtbGV2ZWwgZG9jdW1lbnQgYW5kIGlm cmFtZSBkb2N1bWVudCBzaGFyZSBhIERPTUltcGxlbWVudGF0aW9uIG9iamVjdCIpOworCisgICAg aWYgKGRvY3VtZW50LmltcGxlbWVudGF0aW9uID09PSBkb2N1bWVudC5pbXBsZW1lbnRhdGlvbikK KyAgICAgICAgcHJpbnQoIk9LOiBET01JbXBsZW1lbnRhdGlvbiBvYmplY3QgaXMgY2FjaGVkIik7 CisgICAgZWxzZQorICAgICAgICBwcmludCgiQlVHOiBET01JbXBsZW1lbnRhdGlvbiBvYmplY3Qg aXMgbm90IGNhY2hlZCIpOworfQorPC9zY3JpcHQ+Cis8cD5UaGlzIHRlc3QgY2hlY2tzIHRoYXQg RE9NSW1wbGVtZW50YXRpb24gb2JqZWN0IGlzIGNyZWF0ZWQgcGVyIGRvY3VtZW50LjwvcD4KKzxw PklmIHRoZSB0ZXN0IHBhc3NlcywgeW91IHNob3VsZCBzZWUgYSBmZXcgT0sgbGluZXMgYmVsb3cu PC9wPgorPHA+PG9sIGlkPWNvbnNvbGU+PC9vbD48L3A+Cis8aWZyYW1lIHNyYz0iYWJvdXQ6Ymxh bmsiIG9ubG9hZD0idGVzdCgpIj48L2lmcmFtZT4KKzwvYm9keT4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMmVh NjRmLi5iYTBhNmRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDQtMDYgIFZp dGFseSBSZXBlc2hrbyAgPHZpdGFseXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0gUmVtb3ZlIGN1c3RvbSBET01JbXBs ZW1lbnRhdGlvbiBnZXR0ZXIgb24gRG9jdW1lbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Nzk5MQorCisgICAgICAgIFRoZSBjdXN0b20gZ2V0dGVy IGlzIG5vIGxvbmdlciByZXF1aXJlZCBiZWNhdXNlIERPTUltcGxlbWVudGF0aW9uCisgICAgICAg IG9iamVjdHMgYXJlIG5vdyBjcmVhdGVkIHBlciBkb2N1bWVudC4KKworICAgICAgICBUZXN0OiBm YXN0L2RvbS9ET01JbXBsZW1lbnRhdGlvbi9pbXBsZW1lbnRhdGlvbi1pZGVudGl0eS5odG1sCisK KyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKyAgICAgICAg KiBiaW5kaW5ncy92OC9jdXN0b20vVjhEb2N1bWVudEN1c3RvbS5jcHA6CisgICAgICAgICogZG9t L0RvY3VtZW50LmlkbDoKKwogMjAxMS0wNC0wNiAgSmlhIFB1ICA8anB1QGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggYTIxYmMzZS4uNzQxMjE4 OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9yVjgucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9yVjgucG0KQEAgLTQ0OCw5ICs0NDgsNyBAQCBzdWIgR2V0SW50ZXJuYWxGaWVsZHMKICAgICAg ICAgcHVzaChAY3VzdG9tSW50ZXJuYWxGaWVsZHMsICJldmVudExpc3RlbmVyQ2FjaGVJbmRleCIp OwogICAgIH0KIAotICAgIGlmIChJc1N1YlR5cGUoJGRhdGFOb2RlLCAiRG9jdW1lbnQiKSkgewot ICAgICAgICBwdXNoKEBjdXN0b21JbnRlcm5hbEZpZWxkcywgImltcGxlbWVudGF0aW9uSW5kZXgi KTsKLSAgICB9IGVsc2lmICgkbmFtZSBlcSAiRE9NV2luZG93IikgeworICAgIGlmICgkbmFtZSBl cSAiRE9NV2luZG93IikgewogICAgICAgICBwdXNoKEBjdXN0b21JbnRlcm5hbEZpZWxkcywgImVu dGVyZWRJc29sYXRlZFdvcmxkSW5kZXgiKTsKICAgICB9CiAgICAgcmV0dXJuIEBjdXN0b21JbnRl cm5hbEZpZWxkczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3Rv bS9WOERvY3VtZW50Q3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3Rv bS9WOERvY3VtZW50Q3VzdG9tLmNwcAppbmRleCBjNDM1ODYzLi43Y2FkNThlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhEb2N1bWVudEN1c3RvbS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RG9jdW1lbnRDdXN0b20u Y3BwCkBAIC0xMTgsMzQgKzExOCw2IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOERvY3VtZW50 OjpnZXRDU1NDYW52YXNDb250ZXh0Q2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50CiAgICAgcmV0 dXJuIHY4OjpVbmRlZmluZWQoKTsKIH0KIAotCi0vLyBET01JbXBsZW1lbnRhdGlvbiBpcyBhIHNp bmdsZXRvbiBpbiBXZWJDb3JlLiBJZiB3ZSB1c2Ugb3VyIG5vcm1hbAotLy8gbWFwcGluZyBmcm9t IERPTSBvYmplY3RzIHRvIFY4IHdyYXBwZXJzLCB0aGUgc2FtZSB3cmFwcGVyIHdpbGwgYmUKLS8v IHNoYXJlZCBmb3IgYWxsIGZyYW1lcyBpbiB0aGUgc2FtZSBwcm9jZXNzLiBUaGlzIGlzIGEgbWFq b3IKLS8vIHNlY3VyaXR5IHByb2JsZW0uIFRoZXJlZm9yZSwgd2UgZ2VuZXJhdGUgYSBET01JbXBs ZW1lbnRhdGlvbgotLy8gd3JhcHBlciBwZXIgZG9jdW1lbnQgYW5kIHN0b3JlIGl0IGluIGFuIGlu dGVybmFsIGZpZWxkIG9mIHRoZQotLy8gZG9jdW1lbnQuIFNpbmNlIHRoZSBET01JbXBsZW1lbnRh dGlvbiBvYmplY3QgaXMgYSBzaW5nbGV0b24sIHdlIGRvCi0vLyBub3QgaGF2ZSB0byBkbyBhbnl0 aGluZyB0byBrZWVwIHRoZSBET01JbXBsZW1lbnRhdGlvbiBvYmplY3QgYWxpdmUKLS8vIGZvciB0 aGUgbGlmZXRpbWUgb2YgdGhlIHdyYXBwZXIuCi12ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhEb2N1 bWVudDo6aW1wbGVtZW50YXRpb25BY2Nlc3NvckdldHRlcih2ODo6TG9jYWw8djg6OlN0cmluZz4g bmFtZSwgY29uc3Qgdjg6OkFjY2Vzc29ySW5mbyYgaW5mbykKLXsKLSAgICBBU1NFUlQoaW5mby5I b2xkZXIoKS0+SW50ZXJuYWxGaWVsZENvdW50KCkgPj0gaW50ZXJuYWxGaWVsZENvdW50KTsKLQot ICAgIC8vIENoZWNrIGlmIHRoZSBpbnRlcm5hbCBmaWVsZCBhbHJlYWR5IGNvbnRhaW5zIGEgd3Jh cHBlci4KLSAgICB2ODo6TG9jYWw8djg6OlZhbHVlPiBpbXBsZW1lbnRhdGlvbiA9IGluZm8uSG9s ZGVyKCktPkdldEludGVybmFsRmllbGQoVjhEb2N1bWVudDo6aW1wbGVtZW50YXRpb25JbmRleCk7 Ci0gICAgaWYgKCFpbXBsZW1lbnRhdGlvbi0+SXNVbmRlZmluZWQoKSkKLSAgICAgICAgcmV0dXJu IGltcGxlbWVudGF0aW9uOwotCi0gICAgLy8gR2VuZXJhdGUgYSB3cmFwcGVyLgotICAgIERvY3Vt ZW50KiBkb2N1bWVudCA9IFY4RG9jdW1lbnQ6OnRvTmF0aXZlKGluZm8uSG9sZGVyKCkpOwotICAg IHY4OjpIYW5kbGU8djg6OlZhbHVlPiB3cmFwcGVyID0gdG9WOChkb2N1bWVudC0+aW1wbGVtZW50 YXRpb24oKSk7Ci0KLSAgICAvLyBTdG9yZSB0aGUgd3JhcHBlciBpbiB0aGUgaW50ZXJuYWwgZmll bGQuCi0gICAgaW5mby5Ib2xkZXIoKS0+U2V0SW50ZXJuYWxGaWVsZChpbXBsZW1lbnRhdGlvbklu ZGV4LCB3cmFwcGVyKTsKLQotICAgIHJldHVybiB3cmFwcGVyOwotfQotCiB2ODo6SGFuZGxlPHY4 OjpWYWx1ZT4gdG9WOChEb2N1bWVudCogaW1wbCwgYm9vbCBmb3JjZU5ld09iamVjdCkKIHsKICAg ICBpZiAoIWltcGwpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaWRs IGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmlkbAppbmRleCA3MzI5ZDdiLi5jZjgyMGJh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaWRsCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5pZGwKQEAgLTI5LDcgKzI5LDcgQEAgbW9kdWxlIGNvcmUg ewogCiAgICAgICAgIC8vIERPTSBMZXZlbCAxIENvcmUKICAgICAgICAgcmVhZG9ubHkgYXR0cmli dXRlIERvY3VtZW50VHlwZSBkb2N0eXBlOwotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgW1Y4 Q3VzdG9tXSBET01JbXBsZW1lbnRhdGlvbiBpbXBsZW1lbnRhdGlvbjsKKyAgICAgICAgcmVhZG9u bHkgYXR0cmlidXRlIERPTUltcGxlbWVudGF0aW9uIGltcGxlbWVudGF0aW9uOwogICAgICAgICBy ZWFkb25seSBhdHRyaWJ1dGUgRWxlbWVudCBkb2N1bWVudEVsZW1lbnQ7CiAKICAgICAgICAgW1Jl dHVybnNOZXddIEVsZW1lbnQgY3JlYXRlRWxlbWVudChpbiBbQ29udmVydE51bGxUb051bGxTdHJp bmddIERPTVN0cmluZyB0YWdOYW1lKQo=