57989 2011-04-06 15:14:20 -0700 Add WKStringGetCharactersPtr() and WKStringGetLength() to WebKit2 C API 2011-04-06 15:24:39 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jeffm jeffm oldest_to_newest 380886 0 jeffm 2011-04-06 15:14:20 -0700 Add WKStringGetCharactersPtr() and WKStringGetLength() to WebKit2 C API 380894 1 88526 jeffm 2011-04-06 15:18:41 -0700 Created attachment 88526 Patch 380896 2 88526 aroben 2011-04-06 15:20:30 -0700 Comment on attachment 88526 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88526&action=review > Source/WebKit2/Shared/WebString.h:61 > + const size_t length() const { return m_string.length(); } No need for the leading "const". 380902 3 jeffm 2011-04-06 15:24:39 -0700 Committed r83110: <http://trac.webkit.org/changeset/83110> 88526 2011-04-06 15:18:41 -0700 2011-04-06 15:20:30 -0700 Patch bug-57989-20110406151839.patch text/plain 3462 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMTA2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDQtMDYgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBXS1N0cmluZ0dldENoYXJhY3RlcnNQdHIoKSBhbmQgV0tTdHJp bmdHZXRMZW5ndGgoKSB0byBXZWJLaXQyIEMgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Nzk4OQorICAgICAgICAKKyAgICAgICAgTm90ZSB0aGF0 IFdLQ2hhciwgd2hpY2ggaXMgcmV0dXJuZWQgYnkgV0tTdHJpbmdHZXRDaGFyYWN0ZXJzUHRyKCks IGlzIGRlZmluZWQgdGhlIHNhbWUgd2F5IHdlIGRlZmluZSBKU0NoYXIgaW4gSlNTdHJpbmdSZWYu aC4KKworICAgICAgICAqIFNoYXJlZC9BUEkvYy9XS1N0cmluZy5jcHA6CisgICAgICAgIChXS1N0 cmluZ0dldExlbmd0aCk6IEFkZGVkLgorICAgICAgICAoV0tTdHJpbmdHZXRDaGFyYWN0ZXJzUHRy KTogQWRkZWQuCisgICAgICAgICogU2hhcmVkL0FQSS9jL1dLU3RyaW5nLmg6IERlZmluZSBXS0No YXIgYW5kIGFkZGVkIFdLU3RyaW5nR2V0TGVuZ3RoKCkgYW5kIFdLU3RyaW5nR2V0Q2hhcmFjdGVy c1B0cigpLgorICAgICAgICAqIFNoYXJlZC9XZWJTdHJpbmcuaDoKKyAgICAgICAgKFdlYktpdDo6 V2ViU3RyaW5nOjpsZW5ndGgpOiBBZGRlZC4KKyAgICAgICAgKFdlYktpdDo6V2ViU3RyaW5nOjpj aGFyYWN0ZXJzKTogQWRkZWQuCisKIDIwMTEtMDQtMDYgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1NoYXJlZC9XZWJTdHJpbmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9T aGFyZWQvV2ViU3RyaW5nLmgJKHJldmlzaW9uIDgzMDY4KQorKysgU291cmNlL1dlYktpdDIvU2hh cmVkL1dlYlN0cmluZy5oCSh3b3JraW5nIGNvcHkpCkBAIC01Nyw2ICs1Nyw5IEBAIHB1YmxpYzoK IAogICAgIGJvb2wgaXNOdWxsKCkgY29uc3QgeyByZXR1cm4gbV9zdHJpbmcuaXNOdWxsKCk7IH0K ICAgICBib29sIGlzRW1wdHkoKSBjb25zdCB7IHJldHVybiBtX3N0cmluZy5pc0VtcHR5KCk7IH0K KyAgICAKKyAgICBjb25zdCBzaXplX3QgbGVuZ3RoKCkgY29uc3QgeyByZXR1cm4gbV9zdHJpbmcu bGVuZ3RoKCk7IH0KKyAgICBjb25zdCBVQ2hhciogY2hhcmFjdGVycygpIGNvbnN0IHsgcmV0dXJu IG1fc3RyaW5nLmNoYXJhY3RlcnMoKTsgfQogCiAgICAgc2l6ZV90IG1heGltdW1VVEY4Q1N0cmlu Z1NpemUoKSBjb25zdCB7IHJldHVybiBtX3N0cmluZy5sZW5ndGgoKSAqIDMgKyAxOyB9CiAgICAg c2l6ZV90IGdldFVURjhDU3RyaW5nKGNoYXIqIGJ1ZmZlciwgc2l6ZV90IGJ1ZmZlclNpemUpCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tTdHJpbmcuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9XS1N0cmluZy5jcHAJKHJldmlzaW9uIDgz MDY4KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLU3RyaW5nLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDcsNiArNDcsMTcgQEAgYm9vbCBXS1N0cmluZ0lzRW1wdHkoV0tTdHJpbmdS ZWYgc3RyaW5nUgogICAgIHJldHVybiB0b0ltcGwoc3RyaW5nUmVmKS0+aXNFbXB0eSgpOwogfQog CitzaXplX3QgV0tTdHJpbmdHZXRMZW5ndGgoV0tTdHJpbmdSZWYgc3RyaW5nUmVmKQoreworICAg IHJldHVybiB0b0ltcGwoc3RyaW5nUmVmKS0+bGVuZ3RoKCk7Cit9CisKK2NvbnN0IFdLQ2hhciog V0tTdHJpbmdHZXRDaGFyYWN0ZXJzUHRyKFdLU3RyaW5nUmVmIHN0cmluZ1JlZikKK3sKKyAgICBD T01QSUxFX0FTU0VSVChzaXplb2YoV0tDaGFyKSA9PSBzaXplb2YoVUNoYXIpLCBXS1N0cmluZ0dl dENoYXJhY3RlcnNQdHJfc2l6ZW9mX1dLQ2hhcl9tYXRjaGVzX1VDaGFyKTsKKyAgICByZXR1cm4g cmVpbnRlcnByZXRfY2FzdDxjb25zdCBXS0NoYXIqPih0b0ltcGwoc3RyaW5nUmVmKS0+Y2hhcmFj dGVycygpKTsKK30KKwogc2l6ZV90IFdLU3RyaW5nR2V0TWF4aW11bVVURjhDU3RyaW5nU2l6ZShX S1N0cmluZ1JlZiBzdHJpbmdSZWYpCiB7CiAgICAgcmV0dXJuIHRvSW1wbChzdHJpbmdSZWYpLT5t YXhpbXVtVVRGOENTdHJpbmdTaXplKCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJ L2MvV0tTdHJpbmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2Mv V0tTdHJpbmcuaAkocmV2aXNpb24gODMwNjgpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJ L2MvV0tTdHJpbmcuaAkod29ya2luZyBjb3B5KQpAQCAtMzYsMTIgKzM2LDIyIEBACiBleHRlcm4g IkMiIHsKICNlbmRpZgogCisjaWYgIWRlZmluZWQoV0lOMzIpICYmICFkZWZpbmVkKF9XSU4zMikg JiYgIWRlZmluZWQoX19XSU5TQ1dfXykgXAorICAgICYmICEoKGRlZmluZWQoX19DQ19BUk0pIHx8 IGRlZmluZWQoX19BUk1DQ19fKSkgJiYgIWRlZmluZWQoX19saW51eF9fKSkgLyogUlZDVCAqLwor ICAgIHR5cGVkZWYgdW5zaWduZWQgc2hvcnQgV0tDaGFyOworI2Vsc2UKKyAgICB0eXBlZGVmIHdj aGFyX3QgV0tDaGFyOworI2VuZGlmCisKIFdLX0VYUE9SVCBXS1R5cGVJRCBXS1N0cmluZ0dldFR5 cGVJRCgpOwogCiBXS19FWFBPUlQgV0tTdHJpbmdSZWYgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENT dHJpbmcoY29uc3QgY2hhciogc3RyaW5nKTsKIAogV0tfRVhQT1JUIGJvb2wgV0tTdHJpbmdJc0Vt cHR5KFdLU3RyaW5nUmVmIHN0cmluZyk7CiAKK1dLX0VYUE9SVCBzaXplX3QgV0tTdHJpbmdHZXRM ZW5ndGgoV0tTdHJpbmdSZWYgc3RyaW5nKTsKK1dLX0VYUE9SVCBjb25zdCBXS0NoYXIqIFdLU3Ry aW5nR2V0Q2hhcmFjdGVyc1B0cihXS1N0cmluZ1JlZiBzdHJpbmcpOworCiBXS19FWFBPUlQgc2l6 ZV90IFdLU3RyaW5nR2V0TWF4aW11bVVURjhDU3RyaW5nU2l6ZShXS1N0cmluZ1JlZiBzdHJpbmcp OwogV0tfRVhQT1JUIHNpemVfdCBXS1N0cmluZ0dldFVURjhDU3RyaW5nKFdLU3RyaW5nUmVmIHN0 cmluZywgY2hhciogYnVmZmVyLCBzaXplX3QgYnVmZmVyU2l6ZSk7CiAK