57986 2011-04-06 15:02:14 -0700 Stop JSObject::isUsingInlineStorage() from using the structure 2011-06-30 16:40:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 380873 0 oliver 2011-04-06 15:02:14 -0700 Stop JSObject::isUsingInlineStorage() from using the structure 380876 1 88521 oliver 2011-04-06 15:03:54 -0700 Created attachment 88521 Patch 380890 2 oliver 2011-04-06 15:15:57 -0700 Committed r83107: <http://trac.webkit.org/changeset/83107> 430835 3 88521 darin 2011-06-30 16:40:58 -0700 Comment on attachment 88521 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88521&action=review > Source/JavaScriptCore/runtime/JSObject.h:223 > + bool isUsingInlineStorage() const { return static_cast<const void*>(m_propertyStorage) == static_cast<const void*>(this + 1); } You should only have to cast one of these two to const void*. > Source/JavaScriptCore/runtime/JSObject.h:404 > + ASSERT(static_cast<void*>(inlineStorage) == static_cast<void*>(this + 1)); You should only have to cast one of these two to void*. 88521 2011-04-06 15:03:54 -0700 2011-06-30 16:40:58 -0700 Patch bug-57986-20110406150353.patch text/plain 2036 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogODMwODQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGI4 MTI1NzRlMjQ4ZGVmZmQwZDFjM2Q4NTgxODliZjhmMTllNjg3OTMuLjUzNzFiNjc5OWIwY2NmOTFl NDhkYTgyYTdjYmQ3NzNhMGMxNmM0MmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE3IEBACisyMDExLTA0LTA2ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RvcCBKU09i amVjdDo6aXNVc2luZ0lubGluZVN0b3JhZ2UoKSBmcm9tIHVzaW5nIHRoZSBzdHJ1Y3R1cmUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3OTg2CisKKyAg ICAgICAgTWFrZSB0aGUgaXNVc2luZ0lubGluZVN0b3JhZ2UoKSBpbXBsZW1lbnRhdGlvbiBqdXN0 IGxvb2sgYXQKKyAgICAgICAgd2hldGhlciB0aGUgcHJvcGVydHkgc3RvcmFnZSBpcyBpbnNpZGUg dGhlIG9iamVjdC4KKworICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuaDoKKyAgICAgICAgKEpT Qzo6SlNPYmplY3Q6OmlzVXNpbmdJbmxpbmVTdG9yYWdlKToKKyAgICAgICAgKEpTQzo6SlNPYmpl Y3Q6OkpTT2JqZWN0KToKKwogMjAxMS0wNC0wNiAgTHVjYXMgRGUgTWFyY2hpICA8bHVjYXMuZGVt YXJjaGlAcHJvZnVzaW9uLm1vYmk+CiAKICAgICAgICAgY21ha2U6IEZpeCBidWlsZCBmb3IgQVJN djcKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0Lmgg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCmluZGV4IGJiODI1YWZl OGRiMjQxNmM4NGMxNmE0ZWNmNzQ2ZTQ3ZGU3NTliNDYuLjBmOGFmMmFlYWFmZGIzMWYxZjRmZmE0 ZDAxZmY5ZGRmOWUwZThmYTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTT2JqZWN0LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmpl Y3QuaApAQCAtMjIwLDcgKzIyMCw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICB2aXJ0dWFs IENvbXBsVHlwZSBleGNlcHRpb25UeXBlKCkgY29uc3QgeyByZXR1cm4gVGhyb3c7IH0KIAogICAg ICAgICB2b2lkIGFsbG9jYXRlUHJvcGVydHlTdG9yYWdlKHNpemVfdCBvbGRTaXplLCBzaXplX3Qg bmV3U2l6ZSk7Ci0gICAgICAgIGJvb2wgaXNVc2luZ0lubGluZVN0b3JhZ2UoKSBjb25zdCB7IHJl dHVybiBtX3N0cnVjdHVyZS0+aXNVc2luZ0lubGluZVN0b3JhZ2UoKTsgfQorICAgICAgICBib29s IGlzVXNpbmdJbmxpbmVTdG9yYWdlKCkgY29uc3QgeyByZXR1cm4gc3RhdGljX2Nhc3Q8Y29uc3Qg dm9pZCo+KG1fcHJvcGVydHlTdG9yYWdlKSA9PSBzdGF0aWNfY2FzdDxjb25zdCB2b2lkKj4odGhp cyArIDEpOyB9CiAKICAgICAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIGJhc2VFeHRlcm5hbFN0 b3JhZ2VDYXBhY2l0eSA9IDE2OwogCkBAIC00MDEsNiArNDAxLDcgQEAgaW5saW5lIEpTT2JqZWN0 OjpKU09iamVjdChOb25OdWxsUGFzc1JlZlB0cjxTdHJ1Y3R1cmU+IHN0cnVjdHVyZSwgUHJvcGVy dHlTdG9yYWcKICAgICBBU1NFUlQobV9zdHJ1Y3R1cmUtPnByb3BlcnR5U3RvcmFnZUNhcGFjaXR5 KCkgPCBiYXNlRXh0ZXJuYWxTdG9yYWdlQ2FwYWNpdHkpOwogICAgIEFTU0VSVChtX3N0cnVjdHVy ZS0+aXNFbXB0eSgpKTsKICAgICBBU1NFUlQocHJvdG90eXBlKCkuaXNOdWxsKCkgfHwgSGVhcDo6 aGVhcCh0aGlzKSA9PSBIZWFwOjpoZWFwKHByb3RvdHlwZSgpKSk7CisgICAgQVNTRVJUKHN0YXRp Y19jYXN0PHZvaWQqPihpbmxpbmVTdG9yYWdlKSA9PSBzdGF0aWNfY2FzdDx2b2lkKj4odGhpcyAr IDEpKTsKIH0KIAogaW5saW5lIEpTT2JqZWN0Ojp+SlNPYmplY3QoKQo=