57982 2011-04-06 14:11:38 -0700 AVF: MediaPlayerPrivateAVFoundationObjC should not use -[AVPlayerItem isPlaybackBufferEmpty] 2011-04-06 20:34:27 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble webkit-unassigned commit-queue oldest_to_newest 380820 0 jer.noble 2011-04-06 14:11:38 -0700 -[AVPlayerItem isPlaybackBufferEmpty] often returns incorrect results. Instead, call -[AVPlayerItem loadedTimeRanges] and determine if the current time resides within those ranges. 380821 1 jer.noble 2011-04-06 14:12:07 -0700 <rdar://problem/9245087> 380830 2 jer.noble 2011-04-06 14:22:57 -0700 This might result in the platformBufferedTimeRanges() being called more often. The tradeoff here is performance vs. correctness. As it stands, the current implementation, due to bugs in AVFoundation, is incorrect. 380834 3 88512 jer.noble 2011-04-06 14:24:39 -0700 Created attachment 88512 Patch 380857 4 88512 mitz 2011-04-06 14:43:10 -0700 Comment on attachment 88512 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88512&action=review r!=me > Source/WebCore/ChangeLog:8 > + Query our cached loaded time array instead of asking AVPlayerItem if it's buffer is empty. it's -> its 380863 5 88519 jer.noble 2011-04-06 14:53:28 -0700 Created attachment 88519 Patch Fixed some inverted conditionals and extraneous apostrophes. 380970 6 88519 darin 2011-04-06 16:49:22 -0700 Comment on attachment 88519 Patch That function name, contain, is really strange. It’s a verb. 380973 7 jer.noble 2011-04-06 16:58:38 -0700 (In reply to comment #6) > (From update of attachment 88519 [details]) > That function name, contain, is really strange. It’s a verb. I know, I intensely dislike it. Thanks for the review! 381096 8 88519 commit-queue 2011-04-06 20:34:24 -0700 Comment on attachment 88519 Patch Clearing flags on attachment: 88519 Committed r83135: <http://trac.webkit.org/changeset/83135> 381097 9 commit-queue 2011-04-06 20:34:27 -0700 All reviewed patches have been landed. Closing bug. 88512 2011-04-06 14:24:39 -0700 2011-04-06 14:53:26 -0700 Patch bug-57982-20110406142438.patch text/plain 2142 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODMwMTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MjNiZWFlOTYwMjhhNDMw YTM1MDRjMGJmZjg3NTkyZmNkYzRiZWRhLi41N2IwM2UxM2UwMjg1ODk2NjNmOTRkNTU0ZjVlODA5 NjZkNDg5OWUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMDYgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQVZGOiBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25P YmpDIHNob3VsZCBub3QgdXNlIC1bQVZQbGF5ZXJJdGVtIGlzUGxheWJhY2tCdWZmZXJFbXB0eV0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3OTgyCisK KyAgICAgICAgUXVlcnkgb3VyIGNhY2hlZCBsb2FkZWQgdGltZSBhcnJheSBpbnN0ZWFkIG9mIGFz a2luZyBBVlBsYXllckl0ZW0gaWYgaXQncyBidWZmZXIgaXMgZW1wdHkuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0 aW9uT2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRh dGlvbk9iakM6OnBsYXllckl0ZW1TdGF0dXMpOgorCiAyMDExLTA0LTA1ICBKZXIgTm9ibGUgIDxq ZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0 aW9uL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW0gYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3Vu ZGF0aW9uT2JqQy5tbQppbmRleCAzNzVkMTFiNzA0MjBiZDQ3YWVlOTUzNDZjZjA1ZjhmYThmMTIx YzhhLi5jM2M2YWNkNjE3ZGZkNjNjMTA5NjM1YmYwZjBlNTdmOTExYzJmY2JlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5 ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2Jq Qy5tbQpAQCAtMzI3LDkgKzMyNyw5IEBAIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6 SXRlbVN0YXR1cyBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDOjpwCiAgICAgICAg IHJldHVybiBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb246Ok1lZGlhUGxheWVyQVZQbGF5 ZXJJdGVtU3RhdHVzRmFpbGVkOwogICAgIGlmIChbbV9hdlBsYXllckl0ZW0uZ2V0KCkgaXNQbGF5 YmFja0xpa2VseVRvS2VlcFVwXSkKICAgICAgICAgcmV0dXJuIE1lZGlhUGxheWVyUHJpdmF0ZUFW Rm91bmRhdGlvbjo6TWVkaWFQbGF5ZXJBVlBsYXllckl0ZW1TdGF0dXNQbGF5YmFja0xpa2VseVRv S2VlcFVwOwotICAgIGlmIChbbV9hdlBsYXllckl0ZW0uZ2V0KCkgaXNQbGF5YmFja0J1ZmZlckZ1 bGxdKQorICAgIGlmICghYnVmZmVyZWQoKS0+Y29udGFpbihkdXJhdGlvbigpKSkKICAgICAgICAg cmV0dXJuIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6TWVkaWFQbGF5ZXJBVlBsYXll ckl0ZW1TdGF0dXNQbGF5YmFja0J1ZmZlckZ1bGw7Ci0gICAgaWYgKFttX2F2UGxheWVySXRlbS5n ZXQoKSBpc1BsYXliYWNrQnVmZmVyRW1wdHldKQorICAgIGlmICghYnVmZmVyZWQoKS0+Y29udGFp bihjdXJyZW50VGltZSgpKSkKICAgICAgICAgcmV0dXJuIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91 bmRhdGlvbjo6TWVkaWFQbGF5ZXJBVlBsYXllckl0ZW1TdGF0dXNQbGF5YmFja0J1ZmZlckVtcHR5 OwogCiAgICAgcmV0dXJuIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6TWVkaWFQbGF5 ZXJBVlBsYXllckl0ZW1TdGF0dXNSZWFkeVRvUGxheTsK 88519 2011-04-06 14:53:28 -0700 2011-04-06 20:34:24 -0700 Patch bug-57982-20110406145326.patch text/plain 2139 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODMwMTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MjNiZWFlOTYwMjhhNDMw YTM1MDRjMGJmZjg3NTkyZmNkYzRiZWRhLi5iMDI2ZmE5ZjFhMWQ2NDUzNWI5MWQ4OTA0MTU4OTMy MGRhNGQwMTk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMDYgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQVZGOiBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25P YmpDIHNob3VsZCBub3QgdXNlIC1bQVZQbGF5ZXJJdGVtIGlzUGxheWJhY2tCdWZmZXJFbXB0eV0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3OTgyCisK KyAgICAgICAgUXVlcnkgb3VyIGNhY2hlZCBsb2FkZWQgdGltZSBhcnJheSBpbnN0ZWFkIG9mIGFz a2luZyBBVlBsYXllckl0ZW0gaWYgaXRzIGJ1ZmZlciBpcyBlbXB0eS4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRp b25PYmpDLm1tOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0 aW9uT2JqQzo6cGxheWVySXRlbVN0YXR1cyk6CisKIDIwMTEtMDQtMDUgIEplciBOb2JsZSAgPGpl ci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRp b24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbSBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5k YXRpb25PYmpDLm1tCmluZGV4IDM3NWQxMWI3MDQyMGJkNDdhZWU5NTM0NmNmMDVmOGZhOGYxMjFj OGEuLmU4ZmE2MWZkYWEyY2E1NTNjZjY3MDIzZTNlNjI1ZjY0MzI2NTM2NzAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXll clByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpD Lm1tCkBAIC0zMjcsOSArMzI3LDkgQEAgTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uOjpJ dGVtU3RhdHVzIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OnAKICAgICAgICAg cmV0dXJuIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6TWVkaWFQbGF5ZXJBVlBsYXll ckl0ZW1TdGF0dXNGYWlsZWQ7CiAgICAgaWYgKFttX2F2UGxheWVySXRlbS5nZXQoKSBpc1BsYXli YWNrTGlrZWx5VG9LZWVwVXBdKQogICAgICAgICByZXR1cm4gTWVkaWFQbGF5ZXJQcml2YXRlQVZG b3VuZGF0aW9uOjpNZWRpYVBsYXllckFWUGxheWVySXRlbVN0YXR1c1BsYXliYWNrTGlrZWx5VG9L ZWVwVXA7Ci0gICAgaWYgKFttX2F2UGxheWVySXRlbS5nZXQoKSBpc1BsYXliYWNrQnVmZmVyRnVs bF0pCisgICAgaWYgKGJ1ZmZlcmVkKCktPmNvbnRhaW4oZHVyYXRpb24oKSkpCiAgICAgICAgIHJl dHVybiBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb246Ok1lZGlhUGxheWVyQVZQbGF5ZXJJ dGVtU3RhdHVzUGxheWJhY2tCdWZmZXJGdWxsOwotICAgIGlmIChbbV9hdlBsYXllckl0ZW0uZ2V0 KCkgaXNQbGF5YmFja0J1ZmZlckVtcHR5XSkKKyAgICBpZiAoYnVmZmVyZWQoKS0+Y29udGFpbihj dXJyZW50VGltZSgpKSkKICAgICAgICAgcmV0dXJuIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRh dGlvbjo6TWVkaWFQbGF5ZXJBVlBsYXllckl0ZW1TdGF0dXNQbGF5YmFja0J1ZmZlckVtcHR5Owog CiAgICAgcmV0dXJuIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6TWVkaWFQbGF5ZXJB VlBsYXllckl0ZW1TdGF0dXNSZWFkeVRvUGxheTsK