57972 2011-04-06 12:51:47 -0700 Fix cursor problems with wx port 2011-04-06 15:27:57 -0700 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 mmacleod webkit-unassigned kevino webkit.review.bot oldest_to_newest 380736 0 88492 mmacleod 2011-04-06 12:51:47 -0700 Created attachment 88492 Cursor fix patch Implement correct behavior for cursor changes (SetCursor) in the wx port, with previous code cursor changes would simply fail silently in some instances. 380739 1 webkit.review.bot 2011-04-06 12:54:37 -0700 Attachment 88492 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style']" exit_code: 1 Source/WebKit/wx/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 380908 2 kevino 2011-04-06 15:27:57 -0700 Landed in r83090, thanks! 88492 2011-04-06 12:51:47 -0700 2011-04-06 12:53:02 -0700 Cursor fix patch cursorfix.patch text/plain 2618 mmacleod SW5kZXg6IFNvdXJjZS9XZWJLaXQvd3gvV2ViS2l0U3VwcG9ydC9DaHJvbWVDbGllbnRXeC5jcHAN Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0NCi0tLSBTb3VyY2UvV2ViS2l0L3d4L1dlYktpdFN1cHBvcnQvQ2hyb21lQ2xp ZW50V3guY3BwCShyZXZpc2lvbiA4MzA0OSkNCisrKyBTb3VyY2UvV2ViS2l0L3d4L1dlYktpdFN1 cHBvcnQvQ2hyb21lQ2xpZW50V3guY3BwCSh3b3JraW5nIGNvcHkpDQpAQCAtNDYwLDkgKzQ2MCwx MCBAQA0KICAgICBjaG9vc2VyLT5pY29uTG9hZGVkKEljb246OmNyZWF0ZUljb25Gb3JGaWxlcyhm aWxlbmFtZXMpKTsNCiB9DQogDQotdm9pZCBDaHJvbWVDbGllbnRXeDo6c2V0Q3Vyc29yKGNvbnN0 IEN1cnNvciYpDQordm9pZCBDaHJvbWVDbGllbnRXeDo6c2V0Q3Vyc29yKGNvbnN0IEN1cnNvciYg Y3Vyc29yKQ0KIHsNCi0gICAgbm90SW1wbGVtZW50ZWQoKTsNCisgICAgaWYgKG1fd2ViVmlldykN CisgICAgICAgIG1fd2ViVmlldy0+U2V0Q3Vyc29yKCpjdXJzb3IuaW1wbCgpKTsNCiB9DQogDQog dm9pZCBDaHJvbWVDbGllbnRXeDo6cmVxdWVzdEdlb2xvY2F0aW9uUGVybWlzc2lvbkZvckZyYW1l KEZyYW1lKiwgR2VvbG9jYXRpb24qKQ0KSW5kZXg6IFNvdXJjZS9XZWJLaXQvd3gvQ2hhbmdlTG9n DQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09DQotLS0gU291cmNlL1dlYktpdC93eC9DaGFuZ2VMb2cJKHJldmlzaW9uIDgz MDY5KQ0KKysrIFNvdXJjZS9XZWJLaXQvd3gvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpDQpAQCAt MSwzICsxLDEyIEBADQorMjAxMS0wNC0wNiAgTWFsY29sbSBNYWNMZW9kICA8bWFsY29sbS5tYWNs ZW9kQHRzaHdhbmVkamUuY29tPg0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuDQorDQorICAgICAgICBbd3hdIEZpeCBjdXJzb3IgaGFuZGxpbmcgc28gdGhhdCB3ZSBhbHdh eXMgY2FsbCB0aGUgY2hyb21lIHRvIHNldCBpdC4NCisNCisgICAgICAgICogV2ViS2l0U3VwcG9y dC9DaHJvbWVDbGllbnRXeC5jcHA6DQorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50V3g6 OnNldEN1cnNvcik6DQorDQogMjAxMS0wNC0wNCAgTU9SSVRBIEhhamltZSAgPG1vcnJpdGFAZ29v Z2xlLmNvbT4NCiANCiAgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4NCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBTb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cJKHJldmlzaW9uIDgzMDY5KQ0KKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQ0KQEAgLTEsMyArMSwxMiBAQA0KKzIwMTEtMDQtMDYgIE1hbGNvbG0gTWFj TGVvZCAgPG1hbGNvbG0ubWFjbGVvZEB0c2h3YW5lZGplLmNvbT4NCisNCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLg0KKw0KKyAgICAgICAgW3d4XSBGaXggY3Vyc29yIGhhbmRs aW5nIHNvIHRoYXQgd2UgYWx3YXlzIGNhbGwgdGhlIGNocm9tZSB0byBzZXQgaXQuDQorDQorICAg ICAgICAqIHBsYXRmb3JtL3d4L1dpZGdldFd4LmNwcDoNCisgICAgICAgIChXZWJDb3JlOjpXaWRn ZXQ6OnNldEN1cnNvcik6DQorDQogMjAxMS0wNC0wNiAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmph bWluLnBvdWxhaW5Abm9raWEuY29tPg0KIA0KICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIuDQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd3gvV2lkZ2V0V3guY3BwDQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09DQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd3gvV2lkZ2V0V3guY3BwCShyZXZp c2lvbiA4MzA0OSkNCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93eC9XaWRnZXRXeC5jcHAJ KHdvcmtpbmcgY29weSkNCkBAIC0yNyw4ICsyNywxMCBAQA0KIA0KICNpbmNsdWRlICJDdXJzb3Iu aCINCiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0LmgiDQorI2luY2x1ZGUgIkhvc3RXaW5kb3cu aCINCiAjaW5jbHVkZSAiSW50UmVjdC5oIg0KICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIg0K KyNpbmNsdWRlICJTY3JvbGxWaWV3LmgiDQogDQogI2luY2x1ZGUgPHd4L2RlZnMuaD4NCiAjaW5j bHVkZSA8d3gvc2Nyb2x3aW4uaD4NCkBAIC01NCw4ICs1NiwxMCBAQA0KIA0KIHZvaWQgV2lkZ2V0 OjpzZXRDdXJzb3IoY29uc3QgQ3Vyc29yJiBjdXJzb3IpDQogew0KLSAgICBpZiAocGxhdGZvcm1X aWRnZXQoKSAmJiBjdXJzb3IuaW1wbCgpKQ0KLSAgICAgICAgcGxhdGZvcm1XaWRnZXQoKS0+U2V0 Q3Vyc29yKCpjdXJzb3IuaW1wbCgpKTsNCisgICAgU2Nyb2xsVmlldyogdmlldyA9IHJvb3QoKTsN CisgICAgaWYgKCF2aWV3KQ0KKyAgICAgICAgcmV0dXJuOw0KKyAgICB2aWV3LT5ob3N0V2luZG93 KCktPnNldEN1cnNvcihjdXJzb3IpOw0KIH0NCiANCiB2b2lkIFdpZGdldDo6c2hvdygpDQo=