57965 2011-04-06 11:41:46 -0700 borderPaddingMarginStart and borderPaddingMarginEnd should take RenderInline 2011-04-06 14:08:42 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 57779 1 rniwa webkit-unassigned commit-queue eric hyatt oldest_to_newest 380670 0 rniwa 2011-04-06 11:41:46 -0700 Since borderPaddingMarginStart and borderPaddingMarginEnd do not call marginStartForChild & marginEndForChild, they should take RenderInline instead. 380694 1 88478 rniwa 2011-04-06 11:58:58 -0700 Created attachment 88478 cleanup 380743 2 88478 eric 2011-04-06 12:57:49 -0700 Comment on attachment 88478 cleanup OK. 380814 3 88478 commit-queue 2011-04-06 14:08:37 -0700 Comment on attachment 88478 cleanup Clearing flags on attachment: 88478 Committed r83098: <http://trac.webkit.org/changeset/83098> 380815 4 commit-queue 2011-04-06 14:08:42 -0700 All reviewed patches have been landed. Closing bug. 88478 2011-04-06 11:58:58 -0700 2011-04-06 14:08:37 -0700 cleanup bug-57965-20110406215854.patch text/plain 3029 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMDc3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDQtMDYgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgYm9yZGVyUGFkZGluZ01hcmdpblN0YXJ0IGFuZCBib3JkZXJQYWRk aW5nTWFyZ2luRW5kIHNob3VsZCB0YWtlIFJlbmRlcklubGluZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc5NjUKKworICAgICAgICBDaGFuZ2VkIHRo ZSBhcmd1bWVudCB0eXBlcyBvZiBib3JkZXJQYWRkaW5nTWFyZ2luU3RhcnQgYW5kIGJvcmRlclBh ZGRpbmdNYXJnaW5FbmQKKyAgICAgICAgZnJvbSBSZW5kZXJCb3hNb2RlbE9iamVjdCB0byBSZW5k ZXJJbmxpbmUgc2luY2UgdGhleSBjYWxsIG1hcmdpblN0YXJ0IGFuZCBtYXJnaW5FbmQKKyAgICAg ICAgaW5zdGVhZCBvZiBtYXJnaW5TdGFydEZvckNoaWxkIGFuZCBtYXJnaW5FbmRGb3JDaGlsZCBy ZXNwZWN0aXZlbHkuCisKKyAgICAgICAgQ2FsbGluZyB0aGVzZSB0d28gZnVuY3Rpb25zIG9uIFJl bmRlcklubGluZSBpcyBva2F5IGJlY2F1c2Ugd3JpdGluZy1tb2RlIGNhbm5vdCBkaWZmZXIKKyAg ICAgICAgZnJvbSB0aGF0IG9mIHRoZSBjb250YWluaW5nIGJsb2NrLgorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpib3Jk ZXJQYWRkaW5nTWFyZ2luU3RhcnQpOgorICAgICAgICAoV2ViQ29yZTo6Ym9yZGVyUGFkZGluZ01h cmdpbkVuZCk6CisgICAgICAgIChXZWJDb3JlOjppbmxpbmVMb2dpY2FsV2lkdGgpOgorCiAyMDEx LTA0LTA2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCShyZXZpc2lvbiA4MzA3NCkKKysrIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC02MCwxMyArNjAsMTIgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogLy8gV2UgZG9u J3QgbGV0IG91ciBsaW5lIGJveCB0cmVlIGZvciBhIHNpbmdsZSBsaW5lIGdldCBhbnkgZGVlcGVy IHRoYW4gdGhpcy4KIGNvbnN0IHVuc2lnbmVkIGNNYXhMaW5lRGVwdGggPSAyMDA7CiAKLXN0YXRp YyBpbmxpbmUgaW50IGJvcmRlclBhZGRpbmdNYXJnaW5TdGFydChSZW5kZXJCb3hNb2RlbE9iamVj dCogY2hpbGQpCitzdGF0aWMgaW5saW5lIGludCBib3JkZXJQYWRkaW5nTWFyZ2luU3RhcnQoUmVu ZGVySW5saW5lKiBjaGlsZCkKIHsKLSAgICAvLyBGSVhNRTogU2hvdWxkIHdlIGNhbGwgbWFyZ2lu U3RhcnRGb3JDaGlsZCBpbnN0ZWFkPwogICAgIHJldHVybiBjaGlsZC0+bWFyZ2luU3RhcnQoKSAr IGNoaWxkLT5wYWRkaW5nU3RhcnQoKSArIGNoaWxkLT5ib3JkZXJTdGFydCgpOwogfQogCi1zdGF0 aWMgaW5saW5lIGludCBib3JkZXJQYWRkaW5nTWFyZ2luRW5kKFJlbmRlckJveE1vZGVsT2JqZWN0 KiBjaGlsZCkKK3N0YXRpYyBpbmxpbmUgaW50IGJvcmRlclBhZGRpbmdNYXJnaW5FbmQoUmVuZGVy SW5saW5lKiBjaGlsZCkKIHsKICAgICByZXR1cm4gY2hpbGQtPm1hcmdpbkVuZCgpICsgY2hpbGQt PnBhZGRpbmdFbmQoKSArIGNoaWxkLT5ib3JkZXJFbmQoKTsKIH0KQEAgLTc2LDEzICs3NSwxMiBA QCBzdGF0aWMgaW50IGlubGluZUxvZ2ljYWxXaWR0aChSZW5kZXJPYmplCiAgICAgdW5zaWduZWQg bGluZURlcHRoID0gMTsKICAgICBpbnQgZXh0cmFXaWR0aCA9IDA7CiAgICAgUmVuZGVyT2JqZWN0 KiBwYXJlbnQgPSBjaGlsZC0+cGFyZW50KCk7Ci0gICAgd2hpbGUgKHBhcmVudC0+aXNJbmxpbmUo KSAmJiAhcGFyZW50LT5pc0lubGluZUJsb2NrT3JJbmxpbmVUYWJsZSgpICYmIGxpbmVEZXB0aCsr IDwgY01heExpbmVEZXB0aCkgewotICAgICAgICBSZW5kZXJCb3hNb2RlbE9iamVjdCogcGFyZW50 QXNCb3hNb2RlbE9iamVjdCA9IHRvUmVuZGVyQm94TW9kZWxPYmplY3QocGFyZW50KTsKLSAgICAg ICAgQVNTRVJUKHBhcmVudEFzQm94TW9kZWxPYmplY3QpOworICAgIHdoaWxlIChwYXJlbnQtPmlz UmVuZGVySW5saW5lKCkgJiYgbGluZURlcHRoKysgPCBjTWF4TGluZURlcHRoKSB7CisgICAgICAg IFJlbmRlcklubGluZSogcGFyZW50QXNSZW5kZXJJbmxpbmUgPSB0b1JlbmRlcklubGluZShwYXJl bnQpOwogICAgICAgICBpZiAoc3RhcnQgJiYgIWNoaWxkLT5wcmV2aW91c1NpYmxpbmcoKSkKLSAg ICAgICAgICAgIGV4dHJhV2lkdGggKz0gYm9yZGVyUGFkZGluZ01hcmdpblN0YXJ0KHBhcmVudEFz Qm94TW9kZWxPYmplY3QpOworICAgICAgICAgICAgZXh0cmFXaWR0aCArPSBib3JkZXJQYWRkaW5n TWFyZ2luU3RhcnQocGFyZW50QXNSZW5kZXJJbmxpbmUpOwogICAgICAgICBpZiAoZW5kICYmICFj aGlsZC0+bmV4dFNpYmxpbmcoKSkKLSAgICAgICAgICAgIGV4dHJhV2lkdGggKz0gYm9yZGVyUGFk ZGluZ01hcmdpbkVuZChwYXJlbnRBc0JveE1vZGVsT2JqZWN0KTsKKyAgICAgICAgICAgIGV4dHJh V2lkdGggKz0gYm9yZGVyUGFkZGluZ01hcmdpbkVuZChwYXJlbnRBc1JlbmRlcklubGluZSk7CiAg ICAgICAgIGNoaWxkID0gcGFyZW50OwogICAgICAgICBwYXJlbnQgPSBjaGlsZC0+cGFyZW50KCk7 CiAgICAgfQo=