57959 2011-04-06 10:06:47 -0700 Should assert on invalid type in FEComponentTransfer::apply 2011-04-22 15:42:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jschuh jschuh commit-queue eric krit zimmermann oldest_to_newest 380525 0 jschuh 2011-04-06 10:06:47 -0700 Should assert on invalid type in FEComponentTransfer::apply 380530 1 88459 jschuh 2011-04-06 10:11:36 -0700 Created attachment 88459 Patch 380618 2 88459 eric 2011-04-06 10:54:43 -0700 Comment on attachment 88459 Patch Makes sense. 380621 3 88459 eric 2011-04-06 10:55:47 -0700 Comment on attachment 88459 Patch Actually, shouldn't we do this before we loop over all the rgba values (in a separate loop?) This seems it would make debug behavior needlessly slow. 380629 4 jschuh 2011-04-06 11:02:06 -0700 (In reply to comment #3) > (From update of attachment 88459 [details]) > Actually, shouldn't we do this before we loop over all the rgba values (in a separate loop?) This seems it would make debug behavior needlessly slow. I think this way is easier to follow than a duplicate loop blocked out with debug #ifdefs. And since it's an assert (that doesn't affect release), I think readability should be the priority. 390415 5 jschuh 2011-04-21 15:54:15 -0700 Eric, did I sufficiently respond to your question and do you have any objection to me landing it? 390818 6 eric 2011-04-22 09:18:12 -0700 I'm not standing in the way of this patch, no, you're welcome to land. 390852 7 jschuh 2011-04-22 10:08:50 -0700 (In reply to comment #6) > I'm not standing in the way of this patch, no, you're welcome to land. Thanks. It slipped off my radar and I was trying to do some cleanup. 390937 8 commit-queue 2011-04-22 11:48:29 -0700 The commit-queue encountered the following flaky tests while processing attachment 88459: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. 390971 9 88459 commit-queue 2011-04-22 12:28:07 -0700 Comment on attachment 88459 Patch Rejecting attachment 88459 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: " exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp Hunk #1 FAILED at 33. Hunk #2 FAILED at 170. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8486842 391162 10 jschuh 2011-04-22 15:42:25 -0700 Fixed in http://trac.webkit.org/changeset/84653 88459 2011-04-06 10:11:36 -0700 2011-04-22 12:28:07 -0700 Patch bug-57959-20110406101134.patch text/plain 1831 jschuh SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMDY2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMDYgIEp1c3RpbiBT Y2h1aCAgPGpzY2h1aEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU2hvdWxkIGFzc2VydCBvbiBpbnZhbGlkIHR5cGUgaW4gRkVD b21wb25lbnRUcmFuc2Zlcjo6YXBwbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU3OTU5CisKKyAgICAgICAgTm8gZnVuY3Rpb25hbCBjaGFuZ2UuIE5v IG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJz L0ZFQ29tcG9uZW50VHJhbnNmZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RkVDb21wb25lbnRU cmFuc2Zlcjo6YXBwbHkpOgorCiAyMDExLTA0LTA2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVDb21wb25lbnRUcmFuc2Zl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmls dGVycy9GRUNvbXBvbmVudFRyYW5zZmVyLmNwcAkocmV2aXNpb24gODI5NDMpCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFQ29tcG9uZW50VHJhbnNmZXIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw3IEBACiAKICNpbmNsdWRlIDx3dGYvQnl0ZUFy cmF5Lmg+CiAjaW5jbHVkZSA8d3RmL01hdGhFeHRyYXMuaD4KKyNpbmNsdWRlIDx3dGYvU3RkTGli RXh0cmFzLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtMTY5LDggKzE3MCwxMCBAQCB2 b2lkIEZFQ29tcG9uZW50VHJhbnNmZXI6OmFwcGx5KCkKICAgICBDb21wb25lbnRUcmFuc2ZlckZ1 bmN0aW9uIHRyYW5zZmVyRnVuY3Rpb25bXSA9IHttX3JlZEZ1bmMsIG1fZ3JlZW5GdW5jLCBtX2Js dWVGdW5jLCBtX2FscGhhRnVuY307CiAgICAgVHJhbnNmZXJUeXBlIGNhbGxFZmZlY3RbXSA9IHtp ZGVudGl0eSwgaWRlbnRpdHksIHRhYmxlLCBkaXNjcmV0ZSwgbGluZWFyLCBnYW1tYX07CiAKLSAg ICBmb3IgKHVuc2lnbmVkIGNoYW5uZWwgPSAwOyBjaGFubmVsIDwgNDsgY2hhbm5lbCsrKQorICAg IGZvciAodW5zaWduZWQgY2hhbm5lbCA9IDA7IGNoYW5uZWwgPCA0OyBjaGFubmVsKyspIHsKKyAg ICAgICAgQVNTRVJUKHN0YXRpY19jYXN0PHNpemVfdD4odHJhbnNmZXJGdW5jdGlvbltjaGFubmVs XS50eXBlKSA8IFdURl9BUlJBWV9MRU5HVEgoY2FsbEVmZmVjdCkpOwogICAgICAgICAoKmNhbGxF ZmZlY3RbdHJhbnNmZXJGdW5jdGlvbltjaGFubmVsXS50eXBlXSkodGFibGVzW2NoYW5uZWxdLCB0 cmFuc2ZlckZ1bmN0aW9uW2NoYW5uZWxdKTsKKyAgICB9CiAKICAgICBJbnRSZWN0IGRyYXdpbmdS ZWN0ID0gcmVxdWVzdGVkUmVnaW9uT2ZJbnB1dEltYWdlRGF0YShpbi0+YWJzb2x1dGVQYWludFJl Y3QoKSk7CiAgICAgaW4tPmNvcHlVbm11bHRpcGxpZWRJbWFnZShwaXhlbEFycmF5LCBkcmF3aW5n UmVjdCk7Cg==