57947 2011-04-06 07:34:00 -0700 Split getBorderPaddingMargin into two functions 2011-04-06 11:05:51 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 57779 1 rniwa webkit-unassigned abarth commit-queue dglazkov eric hyatt rniwa simon.fraser webkit.review.bot oldest_to_newest 380347 0 rniwa 2011-04-06 07:34:00 -0700 This is a cleanup. 380381 1 88425 rniwa 2011-04-06 08:11:44 -0700 Created attachment 88425 cleanup 380382 2 88425 rniwa 2011-04-06 08:12:52 -0700 Comment on attachment 88425 cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=88425&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:66 > + // FIXME: Should we call marginStartForChild instead? > return child->marginStart() + child->paddingStart() + child->borderStart(); It's really odd that we don't call marginStartForChild here. This is almost the only place we call marginStart instead. Dave & Simon, this is correct? 380418 3 88425 dglazkov 2011-04-06 08:51:43 -0700 Comment on attachment 88425 cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=88425&action=review ok. > Source/WebCore/ChangeLog:7 > + Usually I put in something explaining why there aren't tests. Like: Refactoring, covered by existing tests. Or Refactoring, no functional change. 380523 4 88425 commit-queue 2011-04-06 10:06:30 -0700 Comment on attachment 88425 cleanup Clearing flags on attachment: 88425 Committed r83066: <http://trac.webkit.org/changeset/83066> 380524 5 commit-queue 2011-04-06 10:06:35 -0700 All reviewed patches have been landed. Closing bug. 380633 6 webkit.review.bot 2011-04-06 11:05:51 -0700 http://trac.webkit.org/changeset/83066 might have broken GTK Linux 32-bit Release The following tests are not passing: fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html fast/dom/HTMLProgressElement/progress-element.html 88425 2011-04-06 08:11:44 -0700 2011-04-06 10:06:30 -0700 cleanup bug-57947-20110406181141.patch text/plain 3195 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMDQ5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMDYgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU3BsaXQgZ2V0Qm9yZGVyUGFkZGluZ01hcmdpbiBpbnRvIHR3byBm dW5jdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU3OTQ3CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OmJvcmRlclBhZGRpbmdNYXJnaW5TdGFydCk6IEV4dHJhY3RlZCBm cm9tIGdldEJvcmRlclBhZGRpbmdNYXJnaW4uCisgICAgICAgIChXZWJDb3JlOjpib3JkZXJQYWRk aW5nTWFyZ2luRW5kKTogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjppbmxpbmVMb2dpY2FsV2lk dGgpOiBDYWxscyBib3JkZXJQYWRkaW5nTWFyZ2luU3RhcnQgYW5kIGJvcmRlclBhZGRpbmdNYXJn aW5FbmQuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6ZmluZE5leHRMaW5lQnJlYWsp OiBEaXR0by4KKwogMjAxMS0wNC0wNiAgSmlhIFB1ICA8anB1QGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCShyZXZpc2lvbiA4MzA0OCkKKysr IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC02MCwyMyArNjAsMjkgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogLy8gV2Ug ZG9uJ3QgbGV0IG91ciBsaW5lIGJveCB0cmVlIGZvciBhIHNpbmdsZSBsaW5lIGdldCBhbnkgZGVl cGVyIHRoYW4gdGhpcy4KIGNvbnN0IHVuc2lnbmVkIGNNYXhMaW5lRGVwdGggPSAyMDA7CiAKLXN0 YXRpYyBpbnQgZ2V0Qm9yZGVyUGFkZGluZ01hcmdpbihSZW5kZXJCb3hNb2RlbE9iamVjdCogY2hp bGQsIGJvb2wgZW5kT2ZJbmxpbmUpCitzdGF0aWMgaW5saW5lIGludCBib3JkZXJQYWRkaW5nTWFy Z2luU3RhcnQoUmVuZGVyQm94TW9kZWxPYmplY3QqIGNoaWxkKQogewotICAgIGlmIChlbmRPZklu bGluZSkKLSAgICAgICAgcmV0dXJuIGNoaWxkLT5tYXJnaW5FbmQoKSArIGNoaWxkLT5wYWRkaW5n RW5kKCkgKyBjaGlsZC0+Ym9yZGVyRW5kKCk7CisgICAgLy8gRklYTUU6IFNob3VsZCB3ZSBjYWxs IG1hcmdpblN0YXJ0Rm9yQ2hpbGQgaW5zdGVhZD8KICAgICByZXR1cm4gY2hpbGQtPm1hcmdpblN0 YXJ0KCkgKyBjaGlsZC0+cGFkZGluZ1N0YXJ0KCkgKyBjaGlsZC0+Ym9yZGVyU3RhcnQoKTsKIH0K IAorc3RhdGljIGlubGluZSBpbnQgYm9yZGVyUGFkZGluZ01hcmdpbkVuZChSZW5kZXJCb3hNb2Rl bE9iamVjdCogY2hpbGQpCit7CisgICAgcmV0dXJuIGNoaWxkLT5tYXJnaW5FbmQoKSArIGNoaWxk LT5wYWRkaW5nRW5kKCkgKyBjaGlsZC0+Ym9yZGVyRW5kKCk7Cit9CisKIHN0YXRpYyBpbnQgaW5s aW5lTG9naWNhbFdpZHRoKFJlbmRlck9iamVjdCogY2hpbGQsIGJvb2wgc3RhcnQgPSB0cnVlLCBi b29sIGVuZCA9IHRydWUpCiB7CiAgICAgdW5zaWduZWQgbGluZURlcHRoID0gMTsKICAgICBpbnQg ZXh0cmFXaWR0aCA9IDA7CiAgICAgUmVuZGVyT2JqZWN0KiBwYXJlbnQgPSBjaGlsZC0+cGFyZW50 KCk7CiAgICAgd2hpbGUgKHBhcmVudC0+aXNJbmxpbmUoKSAmJiAhcGFyZW50LT5pc0lubGluZUJs b2NrT3JJbmxpbmVUYWJsZSgpICYmIGxpbmVEZXB0aCsrIDwgY01heExpbmVEZXB0aCkgeworICAg ICAgICBSZW5kZXJCb3hNb2RlbE9iamVjdCogcGFyZW50QXNCb3hNb2RlbE9iamVjdCA9IHRvUmVu ZGVyQm94TW9kZWxPYmplY3QocGFyZW50KTsKKyAgICAgICAgQVNTRVJUKHBhcmVudEFzQm94TW9k ZWxPYmplY3QpOwogICAgICAgICBpZiAoc3RhcnQgJiYgIWNoaWxkLT5wcmV2aW91c1NpYmxpbmco KSkKLSAgICAgICAgICAgIGV4dHJhV2lkdGggKz0gZ2V0Qm9yZGVyUGFkZGluZ01hcmdpbih0b1Jl bmRlckJveE1vZGVsT2JqZWN0KHBhcmVudCksIGZhbHNlKTsKKyAgICAgICAgICAgIGV4dHJhV2lk dGggKz0gYm9yZGVyUGFkZGluZ01hcmdpblN0YXJ0KHBhcmVudEFzQm94TW9kZWxPYmplY3QpOwog ICAgICAgICBpZiAoZW5kICYmICFjaGlsZC0+bmV4dFNpYmxpbmcoKSkKLSAgICAgICAgICAgIGV4 dHJhV2lkdGggKz0gZ2V0Qm9yZGVyUGFkZGluZ01hcmdpbih0b1JlbmRlckJveE1vZGVsT2JqZWN0 KHBhcmVudCksIHRydWUpOworICAgICAgICAgICAgZXh0cmFXaWR0aCArPSBib3JkZXJQYWRkaW5n TWFyZ2luRW5kKHBhcmVudEFzQm94TW9kZWxPYmplY3QpOwogICAgICAgICBjaGlsZCA9IHBhcmVu dDsKICAgICAgICAgcGFyZW50ID0gY2hpbGQtPnBhcmVudCgpOwogICAgIH0KQEAgLTE3MTgsOCAr MTcyNCw3IEBAIElubGluZUl0ZXJhdG9yIFJlbmRlckJsb2NrOjpmaW5kTmV4dExpbmUKICAgICAg ICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAgIHRtcFcgKz0gZmxvd0Jv eC0+bWFyZ2luU3RhcnQoKSArIGZsb3dCb3gtPmJvcmRlclN0YXJ0KCkgKyBmbG93Qm94LT5wYWRk aW5nU3RhcnQoKSArCi0gICAgICAgICAgICAgICAgICAgIGZsb3dCb3gtPm1hcmdpbkVuZCgpICsg Zmxvd0JveC0+Ym9yZGVyRW5kKCkgKyBmbG93Qm94LT5wYWRkaW5nRW5kKCk7CisgICAgICAgICAg ICB0bXBXICs9IGJvcmRlclBhZGRpbmdNYXJnaW5TdGFydChmbG93Qm94KSArIGJvcmRlclBhZGRp bmdNYXJnaW5FbmQoZmxvd0JveCk7CiAgICAgICAgIH0gZWxzZSBpZiAoby0+aXNSZXBsYWNlZCgp KSB7CiAgICAgICAgICAgICBSZW5kZXJCb3gqIHJlcGxhY2VkQm94ID0gdG9SZW5kZXJCb3gobyk7 CiAK