57945 2011-04-06 06:44:41 -0700 [Qt][WK2] Make sure qwkhistory.h is copied into includes/WebKit2 2011-04-08 08:38:28 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 0 james.cooley webkit-unassigned benjamin commit-queue webkit-ews webkit.review.bot oldest_to_newest 380317 0 james.cooley 2011-04-06 06:44:41 -0700 qwkpage, qwkpreferences were copied as of r72039; qwkhistory is not. 380325 1 88411 james.cooley 2011-04-06 06:57:23 -0700 Created attachment 88411 proposed patch to copy qwkhistory.h into includes/WebKit2 380329 2 webkit-ews 2011-04-06 07:08:41 -0700 Attachment 88411 did not build on qt: Build output: http://queues.webkit.org/results/8343182 380339 3 james.cooley 2011-04-06 07:17:07 -0700 (In reply to comment #2) > Attachment 88411 [details] did not build on qt: > Build output: http://queues.webkit.org/results/8343182 OK, I will take a look at this. 380430 4 88411 benjamin 2011-04-06 08:57:54 -0700 Comment on attachment 88411 proposed patch to copy qwkhistory.h into includes/WebKit2 R-, does not build :) Make sure you check the checkbox "patch" when uploading a patch... 381333 5 88636 james.cooley 2011-04-07 07:48:27 -0700 Created attachment 88636 proposed patch to copy qwkhistory.h into includes/WebKit2 And this one builds! ;) 381334 6 webkit.review.bot 2011-04-07 07:49:43 -0700 Attachment 88636 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/qt/qwkhistory.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 381352 7 88641 james.cooley 2011-04-07 08:16:58 -0700 Created attachment 88641 proposed patch to copy qwkhistory.h into includes/WebKit2 382213 8 88641 benjamin 2011-04-08 07:03:00 -0700 Comment on attachment 88641 proposed patch to copy qwkhistory.h into includes/WebKit2 Looks ok. I would have liked a comment in the Changelog about the change of qwkhistory.h but that is not important. 382254 9 88641 commit-queue 2011-04-08 08:38:21 -0700 Comment on attachment 88641 proposed patch to copy qwkhistory.h into includes/WebKit2 Clearing flags on attachment: 88641 Committed r83297: <http://trac.webkit.org/changeset/83297> 382255 10 commit-queue 2011-04-08 08:38:28 -0700 All reviewed patches have been landed. Closing bug. 88411 2011-04-06 06:57:23 -0700 2011-04-07 07:48:27 -0700 proposed patch to copy qwkhistory.h into includes/WebKit2 57945.patch text/plain 992 james.cooley SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMDQwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDQtMDYgIFNvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZyAgPGphbWVzLmNvb2xleUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XVtXSzJdIE1ha2Ugc3VyZSBx d2toaXN0b3J5LmggaXMgY29waWVkIGludG8gaW5jbHVkZXMvV2ViS2l0MgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc5NDUKKworICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvcXQvV0tWaWV3Lmg6CisKIDIwMTEtMDQtMDUgIENoYW5nIFNodSAgPGNzaHVA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvV0tWaWV3LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9XS1ZpZXcuaAkocmV2aXNpb24gODMwNDApCisr KyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L1dLVmlldy5oCSh3b3JraW5nIGNvcHkp CkBAIC0yMiw2ICsyMiw3IEBACiAKICNpbmNsdWRlIDxXZWJLaXQyL3FncmFwaGljc3drdmlldy5o PgogI2luY2x1ZGUgPFdlYktpdDIvcXdrY29udGV4dC5oPgorI2luY2x1ZGUgPFdlYktpdDIvcXdr aGlzdG9yeS5oPgogI2luY2x1ZGUgPFdlYktpdDIvcXdrcGFnZS5oPgogI2luY2x1ZGUgPFdlYktp dDIvcXdrcHJlZmVyZW5jZXMuaD4KIAo= 88636 2011-04-07 07:48:27 -0700 2011-04-07 08:16:58 -0700 proposed patch to copy qwkhistory.h into includes/WebKit2 57945c.patch text/plain 1505 james.cooley SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMTY5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMDcgIEphbWllIENv b2xleSAgPGphbWVzLmNvb2xleUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XVtXSzJdIE1ha2Ugc3VyZSBxd2toaXN0b3J5Lmgg aXMgY29waWVkIGludG8gaW5jbHVkZXMvV2ViS2l0MgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc5NDUKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv cXQvV0tWaWV3Lmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2toaXN0b3J5Lmg6CisK IDIwMTEtMDQtMDcgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9xdC9XS1ZpZXcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L1dLVmlldy5oCShyZXZpc2lvbiA4MzE2OSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvcXQvV0tWaWV3LmgJKHdvcmtpbmcgY29weSkKQEAgLTIyLDYgKzIyLDcgQEAKIAog I2luY2x1ZGUgPFdlYktpdDIvcWdyYXBoaWNzd2t2aWV3Lmg+CiAjaW5jbHVkZSA8V2ViS2l0Mi9x d2tjb250ZXh0Lmg+CisjaW5jbHVkZSA8V2ViS2l0Mi9xd2toaXN0b3J5Lmg+CiAjaW5jbHVkZSA8 V2ViS2l0Mi9xd2twYWdlLmg+CiAjaW5jbHVkZSA8V2ViS2l0Mi9xd2twcmVmZXJlbmNlcy5oPgog CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a2hpc3RvcnkuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a2hpc3RvcnkuaAko cmV2aXNpb24gODMxNjkpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a2hp c3RvcnkuaAkod29ya2luZyBjb3B5KQpAQCAtMjgsNyArMjgsNyBAQAogI2luY2x1ZGUgInF3ZWJr aXRnbG9iYWwuaCIKICNpbmNsdWRlIDxRT2JqZWN0PgogI2luY2x1ZGUgPFFTaGFyZWREYXRhPgot I2luY2x1ZGUgIldLQmFja0ZvcndhcmRMaXN0SXRlbS5oIgorI2luY2x1ZGUgIldlYktpdDIvV0tC YWNrRm9yd2FyZExpc3RJdGVtLmgiCiAKIGNsYXNzIFFXS0hpc3RvcnlQcml2YXRlOwogY2xhc3Mg UVdLSGlzdG9yeUl0ZW1Qcml2YXRlOwo= 88641 2011-04-07 08:16:58 -0700 2011-04-08 08:38:21 -0700 proposed patch to copy qwkhistory.h into includes/WebKit2 57945c.patch text/plain 1777 james.cooley SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMTY5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMDcgIEphbWllIENv b2xleSAgPGphbWVzLmNvb2xleUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XVtXSzJdIE1ha2Ugc3VyZSBxd2toaXN0b3J5Lmgg aXMgY29waWVkIGludG8gaW5jbHVkZXMvV2ViS2l0MgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc5NDUKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv cXQvV0tWaWV3Lmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2toaXN0b3J5Lmg6CisK IDIwMTEtMDQtMDcgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9xdC9XS1ZpZXcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L1dLVmlldy5oCShyZXZpc2lvbiA4MzE2OSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvcXQvV0tWaWV3LmgJKHdvcmtpbmcgY29weSkKQEAgLTIyLDYgKzIyLDcgQEAKIAog I2luY2x1ZGUgPFdlYktpdDIvcWdyYXBoaWNzd2t2aWV3Lmg+CiAjaW5jbHVkZSA8V2ViS2l0Mi9x d2tjb250ZXh0Lmg+CisjaW5jbHVkZSA8V2ViS2l0Mi9xd2toaXN0b3J5Lmg+CiAjaW5jbHVkZSA8 V2ViS2l0Mi9xd2twYWdlLmg+CiAjaW5jbHVkZSA8V2ViS2l0Mi9xd2twcmVmZXJlbmNlcy5oPgog CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a2hpc3RvcnkuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a2hpc3RvcnkuaAko cmV2aXNpb24gODMxNjkpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a2hp c3RvcnkuaAkod29ya2luZyBjb3B5KQpAQCAtMjUsMTAgKzI1LDEwIEBACiAjaWZuZGVmIHF3a2hp c3RvcnlfaAogI2RlZmluZSBxd2toaXN0b3J5X2gKIAorI2luY2x1ZGUgIldlYktpdDIvV0tCYWNr Rm9yd2FyZExpc3RJdGVtLmgiCiAjaW5jbHVkZSAicXdlYmtpdGdsb2JhbC5oIgogI2luY2x1ZGUg PFFPYmplY3Q+CiAjaW5jbHVkZSA8UVNoYXJlZERhdGE+Ci0jaW5jbHVkZSAiV0tCYWNrRm9yd2Fy ZExpc3RJdGVtLmgiCiAKIGNsYXNzIFFXS0hpc3RvcnlQcml2YXRlOwogY2xhc3MgUVdLSGlzdG9y eUl0ZW1Qcml2YXRlOwpAQCAtNDksNyArNDksNyBAQCBwdWJsaWM6CiAgICAgUVVybCB1cmwoKSBj b25zdDsKIAogcHJpdmF0ZToKLSAgICBRV0tIaXN0b3J5SXRlbShXS0JhY2tGb3J3YXJkTGlzdEl0 ZW1SZWYgaXRlbSk7CisgICAgUVdLSGlzdG9yeUl0ZW0oV0tCYWNrRm9yd2FyZExpc3RJdGVtUmVm KTsKIAogICAgIFFFeHBsaWNpdGx5U2hhcmVkRGF0YVBvaW50ZXI8UVdLSGlzdG9yeUl0ZW1Qcml2 YXRlPiBkOwogCg==