<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>57941</bug_id>
          
          <creation_ts>2011-04-06 05:43:13 -0700</creation_ts>
          <short_desc>Web Inspector: it should be possible to use TextViewer to display and edit both javascript and css.</short_desc>
          <delta_ts>2011-05-24 08:09:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector (Deprecated)</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Pavel Podivilov">podivilov</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aandrey</cc>
    
    <cc>apavlov</cc>
    
    <cc>bweinstein</cc>
    
    <cc>joepeck</cc>
    
    <cc>keishi</cc>
    
    <cc>loislo</cc>
    
    <cc>pfeldman</cc>
    
    <cc>pmuellr</cc>
    
    <cc>rik</cc>
    
    <cc>yurys</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>380283</commentid>
    <comment_count>0</comment_count>
    <who name="Pavel Podivilov">podivilov</who>
    <bug_when>2011-04-06 05:43:13 -0700</bug_when>
    <thetext>Web Inspector: it should be possible to use TextViewer to display and edit both javascript and css.

Currently, TextViewer can only be used when wrapped with SourceFrame. SourceFrame is mostly javascript-specific and should not be used for css editing and displaying resource contents in resources panel.
We should decouple TextViewer from SourceFrame (SourceFrame knows too much about TextViewer internal details) and introduce CSSEditor class based on TextViewer.

TextViewer gets a TextViewerDelegate with the following interface:
 - populateContextMenu, mouseDown, mouseHover, etc
 - editable, startEditing, finishEditing

SourceFrame becomes a TextViewerDelegate implementation for viewing and editing javascript in scripts panel.
Resources panel uses its own TextViewerDelegate implementations to show and edit (when applicable) css, html, xhrs etc.

Any thoughts?</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>