57940 2011-04-06 04:55:25 -0700 Fix using UNUSED_PARAM introduced in r82906 2011-04-06 09:07:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 ossy webkit-unassigned abarth darin eric webkit.review.bot oldest_to_newest 380265 0 ossy 2011-04-06 04:55:25 -0700 https://bugs.webkit.org/show_bug.cgi?id=57815#c7 380271 1 88398 ossy 2011-04-06 05:03:56 -0700 Created attachment 88398 proposed fix Based on Darin's suggestion. 380272 2 88399 ossy 2011-04-06 05:05:03 -0700 Created attachment 88399 proposed fix 380333 3 88399 darin 2011-04-06 07:12:24 -0700 Comment on attachment 88399 proposed fix Better. Also might be worth commenting because this doesn’t clear all the caches on platforms that use things other than the CFURL cache. 380432 4 88399 ossy 2011-04-06 08:58:43 -0700 Comment on attachment 88399 proposed fix Landed in http://trac.webkit.org/changeset/83054 380450 5 webkit.review.bot 2011-04-06 09:07:54 -0700 http://trac.webkit.org/changeset/83054 might have broken WinCairo Debug (Build) 88398 2011-04-06 05:03:56 -0700 2011-04-06 05:05:03 -0700 proposed fix 1.patch text/plain 1474 ossy ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmNzBiMjE1Li5jODM2NzRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDQtMDYgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdXNpbmcg VU5VU0VEX1BBUkFNIGludHJvZHVjZWQgaW4gcjgyOTA2CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Nzk0MAorCisgICAgICAgICogV2ViUHJvY2Vzcy9S ZXNvdXJjZUNhY2hlL1dlYlJlc291cmNlQ2FjaGVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViUmVzb3VyY2VDYWNoZU1hbmFnZXI6OmNsZWFyQ2FjaGVGb3JPcmlnaW4pOgorCiAyMDEx LTA0LTA1ICBDaGFuZyBTaHUgIDxjc2h1QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1Jl c291cmNlQ2FjaGUvV2ViUmVzb3VyY2VDYWNoZU1hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9SZXNvdXJjZUNhY2hlL1dlYlJlc291cmNlQ2FjaGVNYW5hZ2VyLmNwcAppbmRl eCAyMjVjYTQ5Li43N2U1N2U5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1Jlc291cmNlQ2FjaGUvV2ViUmVzb3VyY2VDYWNoZU1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvUmVzb3VyY2VDYWNoZS9XZWJSZXNvdXJjZUNhY2hlTWFuYWdlci5j cHAKQEAgLTk5LDggKzk5LDExIEBAIHZvaWQgV2ViUmVzb3VyY2VDYWNoZU1hbmFnZXI6OmdldENh Y2hlT3JpZ2lucyh1aW50NjRfdCBjYWxsYmFja0lEKSBjb25zdAogCiB2b2lkIFdlYlJlc291cmNl Q2FjaGVNYW5hZ2VyOjpjbGVhckNhY2hlRm9yT3JpZ2luKFNlY3VyaXR5T3JpZ2luRGF0YSBvcmln aW5EYXRhLCB1aW50MzJfdCBjYWNoZXNUb0NsZWFyKSBjb25zdAogeworI2lmIFVTRShDRlVSTENB Q0hFKQogICAgIFJlc291cmNlQ2FjaGVzVG9DbGVhciByZXNvdXJjZUNhY2hlc1RvQ2xlYXIgPSBz dGF0aWNfY2FzdDxSZXNvdXJjZUNhY2hlc1RvQ2xlYXI+KGNhY2hlc1RvQ2xlYXIpOwotICAgIFVO VVNFRF9QQVJBTShyZXNvdXJjZUNhY2hlc1RvQ2xlYXIpOworI2Vsc2UKKyAgICBVTlVTRURfUEFS QU0oY2FjaGVzVG9DbGVhcik7CisjZW5kaWYKIAogICAgIFJlZlB0cjxTZWN1cml0eU9yaWdpbj4g b3JpZ2luID0gU2VjdXJpdHlPcmlnaW46OmNyZWF0ZShvcmlnaW5EYXRhLnByb3RvY29sLCBvcmln aW5EYXRhLmhvc3QsIG9yaWdpbkRhdGEucG9ydCk7CiAgICAgaWYgKCFvcmlnaW4pCg== 88399 2011-04-06 05:05:03 -0700 2011-04-06 08:58:42 -0700 proposed fix 1.patch text/plain 1474 ossy ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmNzBiMjE1Li5jODM2NzRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDQtMDYgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdXNpbmcg VU5VU0VEX1BBUkFNIGludHJvZHVjZWQgaW4gcjgyOTA3CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Nzk0MAorCisgICAgICAgICogV2ViUHJvY2Vzcy9S ZXNvdXJjZUNhY2hlL1dlYlJlc291cmNlQ2FjaGVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViUmVzb3VyY2VDYWNoZU1hbmFnZXI6OmNsZWFyQ2FjaGVGb3JPcmlnaW4pOgorCiAyMDEx LTA0LTA1ICBDaGFuZyBTaHUgIDxjc2h1QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1Jl c291cmNlQ2FjaGUvV2ViUmVzb3VyY2VDYWNoZU1hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9SZXNvdXJjZUNhY2hlL1dlYlJlc291cmNlQ2FjaGVNYW5hZ2VyLmNwcAppbmRl eCAyMjVjYTQ5Li43N2U1N2U5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1Jlc291cmNlQ2FjaGUvV2ViUmVzb3VyY2VDYWNoZU1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvUmVzb3VyY2VDYWNoZS9XZWJSZXNvdXJjZUNhY2hlTWFuYWdlci5j cHAKQEAgLTk5LDggKzk5LDExIEBAIHZvaWQgV2ViUmVzb3VyY2VDYWNoZU1hbmFnZXI6OmdldENh Y2hlT3JpZ2lucyh1aW50NjRfdCBjYWxsYmFja0lEKSBjb25zdAogCiB2b2lkIFdlYlJlc291cmNl Q2FjaGVNYW5hZ2VyOjpjbGVhckNhY2hlRm9yT3JpZ2luKFNlY3VyaXR5T3JpZ2luRGF0YSBvcmln aW5EYXRhLCB1aW50MzJfdCBjYWNoZXNUb0NsZWFyKSBjb25zdAogeworI2lmIFVTRShDRlVSTENB Q0hFKQogICAgIFJlc291cmNlQ2FjaGVzVG9DbGVhciByZXNvdXJjZUNhY2hlc1RvQ2xlYXIgPSBz dGF0aWNfY2FzdDxSZXNvdXJjZUNhY2hlc1RvQ2xlYXI+KGNhY2hlc1RvQ2xlYXIpOwotICAgIFVO VVNFRF9QQVJBTShyZXNvdXJjZUNhY2hlc1RvQ2xlYXIpOworI2Vsc2UKKyAgICBVTlVTRURfUEFS QU0oY2FjaGVzVG9DbGVhcik7CisjZW5kaWYKIAogICAgIFJlZlB0cjxTZWN1cml0eU9yaWdpbj4g b3JpZ2luID0gU2VjdXJpdHlPcmlnaW46OmNyZWF0ZShvcmlnaW5EYXRhLnByb3RvY29sLCBvcmln aW5EYXRhLmhvc3QsIG9yaWdpbkRhdGEucG9ydCk7CiAgICAgaWYgKCFvcmlnaW4pCg==