57932 2011-04-06 02:27:28 -0700 [GTK] DumpRenderTree: do not try to free NULL SoupURIs 2011-04-06 10:32:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 svillar svillar oldest_to_newest 380232 0 svillar 2011-04-06 02:27:28 -0700 [GTK] DumpRenderTree: do not try to free NULL SoupURIs 380233 1 88386 svillar 2011-04-06 02:31:11 -0700 Created attachment 88386 Patch 380269 2 88386 pnormand 2011-04-06 04:58:13 -0700 Comment on attachment 88386 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88386&action=review Thanks for fixing this :) > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1057 > + if (uri && SOUP_URI_VALID_FOR_HTTP(uri) && g_strcmp0(uri->host, "127.0.0.1") SOUP_URI_VALID_FOR_HTTP() already checks the uri, so no need for that extra check I think. 380322 3 88386 mrobinson 2011-04-06 06:53:09 -0700 Comment on attachment 88386 Patch Nice fix. If Philippe is correct, please remove the first check. 380573 4 svillar 2011-04-06 10:32:49 -0700 Committed r83068: <http://trac.webkit.org/changeset/83068> 88386 2011-04-06 02:31:11 -0700 2011-04-06 06:53:09 -0700 Patch bug-57932-20110406113109.patch text/plain 1923 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogODI5MTUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4YTU4ZjI2MzY2NDFjMDg0YTNkM2IzN2I3YTAwOTE2YTFm ZWM5OGY3Li4zYmM3ZjdhMWQ0YTQxYjZlY2EzNDBlN2UxMmZhNmQ3NThmYjQ0NDdhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDQtMDYgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10g RHVtcFJlbmRlclRyZWU6IGRvIG5vdCB0cnkgdG8gZnJlZSBOVUxMIFNvdXBVUklzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzkzMgorCisgICAgICAg IFNvbWUgTGF5b3V0IHRlc3RzIGhhdmUgaW52YWxpZCBVUklzIHRoYXQgZG8gbm90IGdlbmVyYXRl IHZhbGlkCisgICAgICAgIFNvdXBVUkkgaW5zdGFuY2VzLiBEbyBub3QgdHJ5IHRvIGZyZWUgdGhv c2UgTlVMTCBTb3VwVVJJcy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVu ZGVyVHJlZS5jcHA6CisgICAgICAgICh3aWxsU2VuZFJlcXVlc3RDYWxsYmFjayk6CisKIDIwMTEt MDQtMDQgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBCcmlhbiBXZWluc3RlaW4uCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsv RHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJU cmVlLmNwcAppbmRleCA2ODQ2ZTVmODk2ZjkwYzZlZjc2NGU1OWUyYzc0OTMxYzFlODA3MDk0Li4z NDU2NjVlYjg1YTBiZTc2ZmZmMDY3OGMxOTU4MDcyNzMwMDRjZjU5IDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTEwNTQsMTUgKzEwNTQsMTUgQEAg c3RhdGljIHZvaWQgd2lsbFNlbmRSZXF1ZXN0Q2FsbGJhY2soV2ViS2l0V2ViVmlldyogd2ViVmll dywgV2ViS2l0V2ViRnJhbWUqLCBXZWIKICAgICBTb3VwTWVzc2FnZSogc291cE1lc3NhZ2UgPSB3 ZWJraXRfbmV0d29ya19yZXF1ZXN0X2dldF9tZXNzYWdlKHJlcXVlc3QpOwogICAgIFNvdXBVUkkq IHVyaSA9IHNvdXBfdXJpX25ldyh3ZWJraXRfbmV0d29ya19yZXF1ZXN0X2dldF91cmkocmVxdWVz dCkpOwogCi0gICAgaWYgKFNPVVBfVVJJX1ZBTElEX0ZPUl9IVFRQKHVyaSkgJiYgZ19zdHJjbXAw KHVyaS0+aG9zdCwgIjEyNy4wLjAuMSIpCisgICAgaWYgKHVyaSAmJiBTT1VQX1VSSV9WQUxJRF9G T1JfSFRUUCh1cmkpICYmIGdfc3RyY21wMCh1cmktPmhvc3QsICIxMjcuMC4wLjEiKQogICAgICAg ICAmJiBnX3N0cmNtcDAodXJpLT5ob3N0LCAiMjU1LjI1NS4yNTUuMjU1IikKICAgICAgICAgJiYg Z19hc2NpaV9zdHJuY2FzZWNtcCh1cmktPmhvc3QsICJsb2NhbGhvc3QiLCA5KSkgewogICAgICAg ICBwcmludGYoIkJsb2NrZWQgYWNjZXNzIHRvIGV4dGVybmFsIFVSTCAlc1xuIiwgc291cF91cmlf dG9fc3RyaW5nKHVyaSwgRkFMU0UpKTsKICAgICAgICAgc291cF91cmlfZnJlZSh1cmkpOwogICAg ICAgICByZXR1cm47CiAgICAgfQotICAgIHNvdXBfdXJpX2ZyZWUodXJpKTsKLQorICAgIGlmICh1 cmkpCisgICAgICAgIHNvdXBfdXJpX2ZyZWUodXJpKTsKIAogICAgIGlmIChzb3VwTWVzc2FnZSkg ewogICAgICAgICBjb25zdCBzZXQ8c3RyaW5nPiYgY2xlYXJIZWFkZXJzID0gZ0xheW91dFRlc3RD b250cm9sbGVyLT53aWxsU2VuZFJlcXVlc3RDbGVhckhlYWRlcnMoKTsK