<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>57923</bug_id>
          
          <creation_ts>2011-04-05 23:06:17 -0700</creation_ts>
          <short_desc>Change EventHandler::updateSelectionForMouseDrag to take a HitTestResult only.</short_desc>
          <delta_ts>2011-04-12 18:30:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>57921</dependson>
          <blocked>55552</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Alice Boxhall">aboxhall</reporter>
          <assigned_to name="Alice Boxhall">aboxhall</assigned_to>
          <cc>aboxhall</cc>
    
    <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>noel.gordon</cc>
    
    <cc>rniwa</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>380146</commentid>
    <comment_count>0</comment_count>
    <who name="Alice Boxhall">aboxhall</who>
    <bug_when>2011-04-05 23:06:17 -0700</bug_when>
    <thetext>Change EventHandler::updateSelectionForMouseDrag to take a HitTestResult rather than a Node* and an IntPoint&amp;, as the selection may actually not extend into the Node found by the HitTest.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381842</commentid>
    <comment_count>1</comment_count>
      <attachid>88731</attachid>
    <who name="Alice Boxhall">aboxhall</who>
    <bug_when>2011-04-07 16:42:29 -0700</bug_when>
    <thetext>Created attachment 88731
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382056</commentid>
    <comment_count>2</comment_count>
      <attachid>88731</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-04-08 00:28:04 -0700</bug_when>
    <thetext>Comment on attachment 88731
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88731&amp;action=review

&gt; Source/WebCore/page/EventHandler.cpp:631
&gt; +    Node* targetNode = EventHandler::targetNode(hitTestResult);
&gt;      if (!targetNode)

You should probably rename the local variable so that you don&apos;t have to resolve the name of member function like this.

&gt; Source/WebCore/page/EventHandler.cpp:642
&gt; +    IntPoint localPoint = hitTestResult.localPoint();
&gt; +    VisiblePosition targetPosition = targetRenderer-&gt;positionForPoint(localPoint);

Why do you need to declare a local variable fot IntPoint?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382966</commentid>
    <comment_count>3</comment_count>
      <attachid>88731</attachid>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2011-04-10 17:03:04 -0700</bug_when>
    <thetext>Comment on attachment 88731
Patch

r- per the above comments. otherwise, this is a nice cleanup.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382982</commentid>
    <comment_count>4</comment_count>
      <attachid>88961</attachid>
    <who name="Alice Boxhall">aboxhall</who>
    <bug_when>2011-04-10 17:57:14 -0700</bug_when>
    <thetext>Created attachment 88961
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382983</commentid>
    <comment_count>5</comment_count>
    <who name="Alice Boxhall">aboxhall</who>
    <bug_when>2011-04-10 17:59:14 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 88731 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=88731&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/page/EventHandler.cpp:631
&gt; &gt; +    Node* targetNode = EventHandler::targetNode(hitTestResult);
&gt; &gt;      if (!targetNode)
&gt; 
&gt; You should probably rename the local variable so that you don&apos;t have to resolve the name of member function like this.

Done.

&gt; &gt; Source/WebCore/page/EventHandler.cpp:642
&gt; &gt; +    IntPoint localPoint = hitTestResult.localPoint();
&gt; &gt; +    VisiblePosition targetPosition = targetRenderer-&gt;positionForPoint(localPoint);
&gt; 
&gt; Why do you need to declare a local variable fot IntPoint?

No reason.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>383003</commentid>
    <comment_count>6</comment_count>
      <attachid>88961</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-10 19:22:01 -0700</bug_when>
    <thetext>Comment on attachment 88961
Patch

Clearing flags on attachment: 88961

Committed r83414: &lt;http://trac.webkit.org/changeset/83414&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>383004</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-10 19:22:05 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>88731</attachid>
            <date>2011-04-07 16:42:29 -0700</date>
            <delta_ts>2011-04-10 17:57:08 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-57923-20110408094227.patch</filename>
            <type>text/plain</type>
            <size>3615</size>
            <attacher name="Alice Boxhall">aboxhall</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODMyMjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMTZmYzQ4OTc0NjYwN2Rh
NGFlYTFmMGQ1OTA1MmRjOTVkNjE1MzJhLi4xNzkzZWM5NDU3MDcyZjY2YWY0Yzk2MDQ3NDljNmQy
OWMwOWI5NzFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDQtMDcgIEFsaWNl
IEJveGhhbGwgIDxhYm94aGFsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIEV2ZW50SGFuZGxlcjo6dXBkYXRlU2Vs
ZWN0aW9uRm9yTW91c2VEcmFnIHRvIHRha2UgYSBIaXRUZXN0UmVzdWx0IG9ubHkuCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzkyMworCisgICAgICAg
IENoYW5nZSBFdmVudEhhbmRsZXI6OnVwZGF0ZVNlbGVjdGlvbkZvck1vdXNlRHJhZyB0byB0YWtl
IGEgSGl0VGVzdFJlc3VsdAorICAgICAgICByYXRoZXIgdGhhbiBhIE5vZGUqIGFuZCBhbiBJbnRQ
b2ludCYsIGFzIHRoZSBzZWxlY3Rpb24gbWF5IGFjdHVhbGx5IG5vdAorICAgICAgICBleHRlbmQg
aW50byB0aGUgTm9kZSBmb3VuZCBieSB0aGUgSGl0VGVzdC4KKworICAgICAgICBObyBuZXcgdGVz
dHMuIFJlZmFjdG9yaW5nIG9ubHkuCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6
CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmhhbmRsZU1vdXNlRHJhZ2dlZEV2ZW50
KToKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6dXBkYXRlU2VsZWN0aW9uRm9yTW91
c2VEcmFnKToKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5oOgorCiAyMDExLTA0LTA3ICBE
YXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4g
QmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIu
Y3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCmluZGV4IDliYzY0ZTc0
YjJkZGJlNDYwMTQ3MTA0MzFjZTkzNWM2ZWFmZTcwOWIuLjIzM2E5NWY4MTZiMTk5NGQ4MDM0ODgx
NDk3Mjg4M2NkMDcwOTU4MmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRI
YW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKQEAg
LTU2Niw5ICs1NjYsMTAgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZU1vdXNlRHJhZ2dlZEV2
ZW50KGNvbnN0IE1vdXNlRXZlbnRXaXRoSGl0VGVzdFJlc3VsdHMmIGUKICAgICAgICAgSGl0VGVz
dFJlcXVlc3QgcmVxdWVzdChIaXRUZXN0UmVxdWVzdDo6UmVhZE9ubHkgfCBIaXRUZXN0UmVxdWVz
dDo6QWN0aXZlKTsKICAgICAgICAgSGl0VGVzdFJlc3VsdCByZXN1bHQobV9tb3VzZURvd25Qb3Mp
OwogICAgICAgICBtX2ZyYW1lLT5kb2N1bWVudCgpLT5yZW5kZXJWaWV3KCktPmxheWVyKCktPmhp
dFRlc3QocmVxdWVzdCwgcmVzdWx0KTsKLSAgICAgICAgdXBkYXRlU2VsZWN0aW9uRm9yTW91c2VE
cmFnKHJlc3VsdC5pbm5lck5vZGUoKSwgcmVzdWx0LmxvY2FsUG9pbnQoKSk7CisKKyAgICAgICAg
dXBkYXRlU2VsZWN0aW9uRm9yTW91c2VEcmFnKHJlc3VsdCk7CiAgICAgfQotICAgIHVwZGF0ZVNl
bGVjdGlvbkZvck1vdXNlRHJhZyh0YXJnZXROb2RlLCBldmVudC5sb2NhbFBvaW50KCkpOworICAg
IHVwZGF0ZVNlbGVjdGlvbkZvck1vdXNlRHJhZyhldmVudC5oaXRUZXN0UmVzdWx0KCkpOwogICAg
IHJldHVybiB0cnVlOwogfQogICAgIApAQCAtNjE4LDE0ICs2MTksMTUgQEAgdm9pZCBFdmVudEhh
bmRsZXI6OnVwZGF0ZVNlbGVjdGlvbkZvck1vdXNlRHJhZygpCiAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBIaXRUZXN0UmVxdWVzdDo6TW91c2VNb3ZlKTsKICAgICBIaXRUZXN0UmVzdWx0IHJl
c3VsdCh2aWV3LT53aW5kb3dUb0NvbnRlbnRzKG1fY3VycmVudE1vdXNlUG9zaXRpb24pKTsKICAg
ICBsYXllci0+aGl0VGVzdChyZXF1ZXN0LCByZXN1bHQpOwotICAgIHVwZGF0ZVNlbGVjdGlvbkZv
ck1vdXNlRHJhZyhyZXN1bHQuaW5uZXJOb2RlKCksIHJlc3VsdC5sb2NhbFBvaW50KCkpOworICAg
IHVwZGF0ZVNlbGVjdGlvbkZvck1vdXNlRHJhZyhyZXN1bHQpOwogfQogCi12b2lkIEV2ZW50SGFu
ZGxlcjo6dXBkYXRlU2VsZWN0aW9uRm9yTW91c2VEcmFnKE5vZGUqIHRhcmdldE5vZGUsIGNvbnN0
IEludFBvaW50JiBsb2NhbFBvaW50KQordm9pZCBFdmVudEhhbmRsZXI6OnVwZGF0ZVNlbGVjdGlv
bkZvck1vdXNlRHJhZyhjb25zdCBIaXRUZXN0UmVzdWx0JiBoaXRUZXN0UmVzdWx0KQogewogICAg
IGlmICghbV9tb3VzZURvd25NYXlTdGFydFNlbGVjdCkKICAgICAgICAgcmV0dXJuOwogCisgICAg
Tm9kZSogdGFyZ2V0Tm9kZSA9IEV2ZW50SGFuZGxlcjo6dGFyZ2V0Tm9kZShoaXRUZXN0UmVzdWx0
KTsKICAgICBpZiAoIXRhcmdldE5vZGUpCiAgICAgICAgIHJldHVybjsKIApAQCAtNjM2LDcgKzYz
OCw4IEBAIHZvaWQgRXZlbnRIYW5kbGVyOjp1cGRhdGVTZWxlY3Rpb25Gb3JNb3VzZURyYWcoTm9k
ZSogdGFyZ2V0Tm9kZSwgY29uc3QgSW50UG9pbnQmCiAgICAgaWYgKCF0YXJnZXRSZW5kZXJlcikK
ICAgICAgICAgcmV0dXJuOwogCi0gICAgVmlzaWJsZVBvc2l0aW9uIHRhcmdldFBvc2l0aW9uKHRh
cmdldFJlbmRlcmVyLT5wb3NpdGlvbkZvclBvaW50KGxvY2FsUG9pbnQpKTsKKyAgICBJbnRQb2lu
dCBsb2NhbFBvaW50ID0gaGl0VGVzdFJlc3VsdC5sb2NhbFBvaW50KCk7CisgICAgVmlzaWJsZVBv
c2l0aW9uIHRhcmdldFBvc2l0aW9uID0gdGFyZ2V0UmVuZGVyZXItPnBvc2l0aW9uRm9yUG9pbnQo
bG9jYWxQb2ludCk7CiAKICAgICAvLyBEb24ndCBtb2RpZnkgdGhlIHNlbGVjdGlvbiBpZiB3ZSdy
ZSBub3Qgb24gYSBub2RlLgogICAgIGlmICh0YXJnZXRQb3NpdGlvbi5pc051bGwoKSkKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmggYi9Tb3VyY2UvV2ViQ29y
ZS9wYWdlL0V2ZW50SGFuZGxlci5oCmluZGV4IDg2N2M4OTQwNzRjMzFlYWQ0MzRjZDZmNGU3ZTRl
MjllMGY0MzU2M2YuLjQ5MGZmODUyZjk2NWVhN2ZmMzI1OWYwNTcyYjVlMjA5NzFmZmYwMDIgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmgKKysrIGIvU291cmNl
L1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaApAQCAtMzYwLDcgKzM2MCw3IEBAIHByaXZhdGU6
CiAjZW5kaWYKIAogI2lmIEVOQUJMRShEUkFHX1NVUFBPUlQpCi0gICAgdm9pZCB1cGRhdGVTZWxl
Y3Rpb25Gb3JNb3VzZURyYWcoTm9kZSogdGFyZ2V0Tm9kZSwgY29uc3QgSW50UG9pbnQmIGxvY2Fs
UG9pbnQpOworICAgIHZvaWQgdXBkYXRlU2VsZWN0aW9uRm9yTW91c2VEcmFnKGNvbnN0IEhpdFRl
c3RSZXN1bHQmKTsKICNlbmRpZgogCiAgICAgdm9pZCB1cGRhdGVMYXN0U2Nyb2xsYmFyVW5kZXJN
b3VzZShTY3JvbGxiYXIqLCBib29sKTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>88961</attachid>
            <date>2011-04-10 17:57:14 -0700</date>
            <delta_ts>2011-04-10 19:22:01 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-57923-20110411105712.patch</filename>
            <type>text/plain</type>
            <size>4262</size>
            <attacher name="Alice Boxhall">aboxhall</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODMyMjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMTZmYzQ4OTc0NjYwN2Rh
NGFlYTFmMGQ1OTA1MmRjOTVkNjE1MzJhLi4xNzkzZWM5NDU3MDcyZjY2YWY0Yzk2MDQ3NDljNmQy
OWMwOWI5NzFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDQtMDcgIEFsaWNl
IEJveGhhbGwgIDxhYm94aGFsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIEV2ZW50SGFuZGxlcjo6dXBkYXRlU2Vs
ZWN0aW9uRm9yTW91c2VEcmFnIHRvIHRha2UgYSBIaXRUZXN0UmVzdWx0IG9ubHkuCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzkyMworCisgICAgICAg
IENoYW5nZSBFdmVudEhhbmRsZXI6OnVwZGF0ZVNlbGVjdGlvbkZvck1vdXNlRHJhZyB0byB0YWtl
IGEgSGl0VGVzdFJlc3VsdAorICAgICAgICByYXRoZXIgdGhhbiBhIE5vZGUqIGFuZCBhbiBJbnRQ
b2ludCYsIGFzIHRoZSBzZWxlY3Rpb24gbWF5IGFjdHVhbGx5IG5vdAorICAgICAgICBleHRlbmQg
aW50byB0aGUgTm9kZSBmb3VuZCBieSB0aGUgSGl0VGVzdC4KKworICAgICAgICBObyBuZXcgdGVz
dHMuIFJlZmFjdG9yaW5nIG9ubHkuCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6
CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmhhbmRsZU1vdXNlRHJhZ2dlZEV2ZW50
KToKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6dXBkYXRlU2VsZWN0aW9uRm9yTW91
c2VEcmFnKToKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5oOgorCiAyMDExLTA0LTA3ICBE
YXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4g
QmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIu
Y3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCmluZGV4IDliYzY0ZTc0
YjJkZGJlNDYwMTQ3MTA0MzFjZTkzNWM2ZWFmZTcwOWIuLjAwMGJlZTc5YWZiNmNjN2EwYTY5ZWY3
OTFhNjdhMmVmOGZkMWI5ZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRI
YW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKQEAg
LTU2Niw5ICs1NjYsMTAgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZU1vdXNlRHJhZ2dlZEV2
ZW50KGNvbnN0IE1vdXNlRXZlbnRXaXRoSGl0VGVzdFJlc3VsdHMmIGUKICAgICAgICAgSGl0VGVz
dFJlcXVlc3QgcmVxdWVzdChIaXRUZXN0UmVxdWVzdDo6UmVhZE9ubHkgfCBIaXRUZXN0UmVxdWVz
dDo6QWN0aXZlKTsKICAgICAgICAgSGl0VGVzdFJlc3VsdCByZXN1bHQobV9tb3VzZURvd25Qb3Mp
OwogICAgICAgICBtX2ZyYW1lLT5kb2N1bWVudCgpLT5yZW5kZXJWaWV3KCktPmxheWVyKCktPmhp
dFRlc3QocmVxdWVzdCwgcmVzdWx0KTsKLSAgICAgICAgdXBkYXRlU2VsZWN0aW9uRm9yTW91c2VE
cmFnKHJlc3VsdC5pbm5lck5vZGUoKSwgcmVzdWx0LmxvY2FsUG9pbnQoKSk7CisKKyAgICAgICAg
dXBkYXRlU2VsZWN0aW9uRm9yTW91c2VEcmFnKHJlc3VsdCk7CiAgICAgfQotICAgIHVwZGF0ZVNl
bGVjdGlvbkZvck1vdXNlRHJhZyh0YXJnZXROb2RlLCBldmVudC5sb2NhbFBvaW50KCkpOworICAg
IHVwZGF0ZVNlbGVjdGlvbkZvck1vdXNlRHJhZyhldmVudC5oaXRUZXN0UmVzdWx0KCkpOwogICAg
IHJldHVybiB0cnVlOwogfQogICAgIApAQCAtNjE4LDI1ICs2MTksMjYgQEAgdm9pZCBFdmVudEhh
bmRsZXI6OnVwZGF0ZVNlbGVjdGlvbkZvck1vdXNlRHJhZygpCiAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBIaXRUZXN0UmVxdWVzdDo6TW91c2VNb3ZlKTsKICAgICBIaXRUZXN0UmVzdWx0IHJl
c3VsdCh2aWV3LT53aW5kb3dUb0NvbnRlbnRzKG1fY3VycmVudE1vdXNlUG9zaXRpb24pKTsKICAg
ICBsYXllci0+aGl0VGVzdChyZXF1ZXN0LCByZXN1bHQpOwotICAgIHVwZGF0ZVNlbGVjdGlvbkZv
ck1vdXNlRHJhZyhyZXN1bHQuaW5uZXJOb2RlKCksIHJlc3VsdC5sb2NhbFBvaW50KCkpOworICAg
IHVwZGF0ZVNlbGVjdGlvbkZvck1vdXNlRHJhZyhyZXN1bHQpOwogfQogCi12b2lkIEV2ZW50SGFu
ZGxlcjo6dXBkYXRlU2VsZWN0aW9uRm9yTW91c2VEcmFnKE5vZGUqIHRhcmdldE5vZGUsIGNvbnN0
IEludFBvaW50JiBsb2NhbFBvaW50KQordm9pZCBFdmVudEhhbmRsZXI6OnVwZGF0ZVNlbGVjdGlv
bkZvck1vdXNlRHJhZyhjb25zdCBIaXRUZXN0UmVzdWx0JiBoaXRUZXN0UmVzdWx0KQogewogICAg
IGlmICghbV9tb3VzZURvd25NYXlTdGFydFNlbGVjdCkKICAgICAgICAgcmV0dXJuOwogCi0gICAg
aWYgKCF0YXJnZXROb2RlKQorICAgIE5vZGUqIHRhcmdldCA9IHRhcmdldE5vZGUoaGl0VGVzdFJl
c3VsdCk7CisgICAgaWYgKCF0YXJnZXQpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmICghY2Fu
TW91c2VEcmFnRXh0ZW5kU2VsZWN0KHRhcmdldE5vZGUpKQorICAgIGlmICghY2FuTW91c2VEcmFn
RXh0ZW5kU2VsZWN0KHRhcmdldCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIFJlbmRlck9iamVj
dCogdGFyZ2V0UmVuZGVyZXIgPSB0YXJnZXROb2RlLT5yZW5kZXJlcigpOworICAgIFJlbmRlck9i
amVjdCogdGFyZ2V0UmVuZGVyZXIgPSB0YXJnZXQtPnJlbmRlcmVyKCk7CiAgICAgaWYgKCF0YXJn
ZXRSZW5kZXJlcikKICAgICAgICAgcmV0dXJuOwogCi0gICAgVmlzaWJsZVBvc2l0aW9uIHRhcmdl
dFBvc2l0aW9uKHRhcmdldFJlbmRlcmVyLT5wb3NpdGlvbkZvclBvaW50KGxvY2FsUG9pbnQpKTsK
KyAgICBWaXNpYmxlUG9zaXRpb24gdGFyZ2V0UG9zaXRpb24gPSB0YXJnZXRSZW5kZXJlci0+cG9z
aXRpb25Gb3JQb2ludChoaXRUZXN0UmVzdWx0LmxvY2FsUG9pbnQoKSk7CiAKICAgICAvLyBEb24n
dCBtb2RpZnkgdGhlIHNlbGVjdGlvbiBpZiB3ZSdyZSBub3Qgb24gYSBub2RlLgogICAgIGlmICh0
YXJnZXRQb3NpdGlvbi5pc051bGwoKSkKQEAgLTY1Miw3ICs2NTQsNyBAQCB2b2lkIEV2ZW50SGFu
ZGxlcjo6dXBkYXRlU2VsZWN0aW9uRm9yTW91c2VEcmFnKE5vZGUqIHRhcmdldE5vZGUsIGNvbnN0
IEludFBvaW50JgogICAgIGlmIChOb2RlKiBzZWxlY3Rpb25CYXNlTm9kZSA9IG5ld1NlbGVjdGlv
bi5iYXNlKCkuZGVwcmVjYXRlZE5vZGUoKSkKICAgICAgICAgaWYgKFJlbmRlck9iamVjdCogc2Vs
ZWN0aW9uQmFzZVJlbmRlcmVyID0gc2VsZWN0aW9uQmFzZU5vZGUtPnJlbmRlcmVyKCkpCiAgICAg
ICAgICAgICBpZiAoc2VsZWN0aW9uQmFzZVJlbmRlcmVyLT5pc1NWR1RleHQoKSkKLSAgICAgICAg
ICAgICAgICBpZiAodGFyZ2V0Tm9kZS0+cmVuZGVyZXIoKS0+Y29udGFpbmluZ0Jsb2NrKCkgIT0g
c2VsZWN0aW9uQmFzZVJlbmRlcmVyLT5jb250YWluaW5nQmxvY2soKSkKKyAgICAgICAgICAgICAg
ICBpZiAodGFyZ2V0LT5yZW5kZXJlcigpLT5jb250YWluaW5nQmxvY2soKSAhPSBzZWxlY3Rpb25C
YXNlUmVuZGVyZXItPmNvbnRhaW5pbmdCbG9jaygpKQogICAgICAgICAgICAgICAgICAgICByZXR1
cm47CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRs
ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmgKaW5kZXggODY3Yzg5NDA3
NGMzMWVhZDQzNGNkNmY0ZTdlNGUyOWUwZjQzNTYzZi4uNDkwZmY4NTJmOTY1ZWE3ZmYzMjU5ZjA1
NzJiNWUyMDk3MWZmZjAwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhh
bmRsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCkBAIC0zNjAs
NyArMzYwLDcgQEAgcHJpdmF0ZToKICNlbmRpZgogCiAjaWYgRU5BQkxFKERSQUdfU1VQUE9SVCkK
LSAgICB2b2lkIHVwZGF0ZVNlbGVjdGlvbkZvck1vdXNlRHJhZyhOb2RlKiB0YXJnZXROb2RlLCBj
b25zdCBJbnRQb2ludCYgbG9jYWxQb2ludCk7CisgICAgdm9pZCB1cGRhdGVTZWxlY3Rpb25Gb3JN
b3VzZURyYWcoY29uc3QgSGl0VGVzdFJlc3VsdCYpOwogI2VuZGlmCiAKICAgICB2b2lkIHVwZGF0
ZUxhc3RTY3JvbGxiYXJVbmRlck1vdXNlKFNjcm9sbGJhciosIGJvb2wpOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>