57911 2011-04-05 18:10:18 -0700 [Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen's top left corner. 2011-04-07 18:19:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 honten webkit-unassigned commit-queue dhollowa isherman thakis tkent oldest_to_newest 380011 0 honten 2011-04-05 18:10:18 -0700 [Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen's top left corner. 380014 1 88347 honten 2011-04-05 18:18:29 -0700 Created attachment 88347 Patch 380017 2 88347 honten 2011-04-05 18:21:04 -0700 Comment on attachment 88347 Patch Please review. 380032 3 thakis 2011-04-05 18:59:20 -0700 None of use are reviewers. I'm cc'ing tkent, who reviewed https://bugs.webkit.org/show_bug.cgi?id=51382 In general, manual tests are bad. Is there any way to turn this into an automated test? 380036 4 honten 2011-04-05 19:01:06 -0700 I agree. But I already ask Ilya but he says he doesn't know. I believe there is no automation test for popup window layout, right? 380187 5 88347 isherman 2011-04-06 00:36:03 -0700 Comment on attachment 88347 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88347&action=review > Source/WebCore/ChangeLog:5 > + [Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen&apos;s top left corner. nit: &apos; -> ' > Source/WebCore/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=57911 nit: Please add a link to the Chromium bug. 380686 6 88475 honten 2011-04-06 11:52:18 -0700 Created attachment 88475 Patch 380687 7 88475 honten 2011-04-06 11:52:39 -0700 Comment on attachment 88475 Patch Please review again. 381146 8 honten 2011-04-06 23:51:07 -0700 Is there anybody who can review my patch? (In reply to comment #7) > (From update of attachment 88475 [details]) > Please review again. 381914 9 88475 commit-queue 2011-04-07 18:19:15 -0700 Comment on attachment 88475 Patch Clearing flags on attachment: 88475 Committed r83237: <http://trac.webkit.org/changeset/83237> 381915 10 commit-queue 2011-04-07 18:19:20 -0700 All reviewed patches have been landed. Closing bug. 88347 2011-04-05 18:18:29 -0700 2011-04-06 11:52:15 -0700 Patch bug-57911-20110405181823.patch text/plain 3201 honten U3VidmVyc2lvbiBSZXZpc2lvbjogODI1NDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMmIxNTM1ZTkyNTRkY2Y2 ZThkNjcyZTc4MWQ3MTU2OGMxYWNkNTE2Li4wMDVmNjkxZTBhNTI1YjU3MWYwZjY3M2M0ODg2MDc0 ZWMzZTc4MzEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDQtMDUgIE5hb2tp IFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBGaXggcmVsb2NhdGlvbiBwcm9i bGVtIG9mIHBvcHVwIHdpbmRvdyB3aGljaCBpbnRyb2R1Y2VzIGF1dG9maWxsIHBvcHVwIHNvbWV0 aW1lcyBtb3ZlcyB0byBzY3JlZW4mYXBvcztzIHRvcCBsZWZ0IGNvcm5lci4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3OTExCisKKyAgICAgICAgTWFu dWFsIHRlc3QgYWRkZWQ6IG1hbnVhbC10ZXN0cy9hdXRvZmlsbC1wb3B1cC1sb2NhdGlvbi5odG1s CisKKyAgICAgICAgT3JpZ2luYWxseSBvbmx5IGhlaWdodCBpcyBjaGVja2VkIHNvIHRoYXQgaXQg aW50cm9kdWNlcyB0aGUgYnVnLgorICAgICAgICBTbyBJIGNoYW5nZWQgaXQgdG8gY2hlY2sgYm90 aCB3aWR0aCBhbmQgaGVpZ2h0IGFzIHNpemUuCisKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvYXV0 b2ZpbGwtcG9wdXAtbG9jYXRpb24uaHRtbDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBDb250 YWluZXI6OnJlZnJlc2gpOiBDaGVjayB3aW5kb3cgc2l6ZSBiZXR3ZWVuIG9yaWdpbmFsIGFuZCBu ZXcgYmVmb3JlIGNhbGxpbmcgc2V0RnJhbWVSZWN0KCkuCisKIDIwMTEtMDMtMzAgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQg Y29ycmVjdGlvbiBhZnRlciByODI0OTYuIChQYXJ0IDMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9tYW51YWwtdGVzdHMvYXV0b2ZpbGwtcG9wdXAtbG9jYXRpb24uaHRtbCBiL1NvdXJjZS9X ZWJDb3JlL21hbnVhbC10ZXN0cy9hdXRvZmlsbC1wb3B1cC1sb2NhdGlvbi5odG1sCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjVlMjhhMTVlYTNjNTI3ZTJhYzY3MDBhZmMyN2NlZGFjZDhiMWIzZTEKLS0tIC9kZXYvbnVs bAorKysgYi9Tb3VyY2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvYXV0b2ZpbGwtcG9wdXAtbG9jYXRp b24uaHRtbApAQCAtMCwwICsxLDIwIEBACis8aHRtbD4KKyAgPGhlYWQ+CisgICAgPE1FVEEgSFRU UC1FUVVJVj0iQ09OVEVOVC1UWVBFIiBDT05URU5UPSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9VVRGLTgi PgorICAgIDx0aXRsZT4KKyAgICAgIFRlc3QgYXV0b2ZpbGwgcG9wdXAgd2luZG93IHNob3dzIGF0 IHRoZSBjb3JyZWN0IGxvY2F0aW9uLgorICAgIDwvdGl0bGU+CisgIDwvaGVhZD4KKyAgPGJvZHk+ CisgICAgPGgzPlRlc3QgYXV0b2ZpbGwgcG9wdXAgd2luZG93IHNob3dzIGF0IHRoZSBjb3JyZWN0 IGxvY2F0aW9uLjwvaDM+CisgICAgPG9sPgorICAgICAgPGxpPiBFbnRlciAnQWx3YXlzIHNob3cg Ym9va21hcmtzIGJhcicgaW4gdGhlIGZvbGxvd2luZyB0ZXh0IGlucHV0IGFyZWEuPC9saT4KKyAg ICAgIDxsaT4gRW50ZXIgJ1Rlc3QnIGluIHRoZSB0ZXh0IGlucHV0IGFyZWEuPC9saT4KKyAgICAg IDxsaT4gUHJlc3MgJ2EnIGFuZCBtYWtlIHN1cmUgJ0Fsd2F5cyBzaG93IGJvb2ttYXJrcyBiYXIn IGlzIHNob3duIGluIGF1dG9maWxsIHBvcHVwIHdpbmRvdy48L2xpPgorICAgICAgPGxpPiBTZWxl Y3QgYWxsIHdpdGggcHJlc3NpbmcgQ3RybC1hLjwvbGk+CisgICAgICA8bGk+IFByZXNzICd0JyBh bmQgbWFrZSBzdXJlICdUZXN0JyBpcyBzaG93biBhbmQgdGhlIHBvcHVwIHdpbmRvdyBsb2NhdGlv biBpcyBjb3JyZWN0LjwvbGk+CisgICAgPC9vbD4KKyAgICA8YnI+CisgICAgPGZvcm0+PGlucHV0 IG5hbWU9cSBhdXRvZm9jdXM+PC9mb3JtPgorICA8L2JvZHk+Cis8L2h0bWw+IApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3Bw CmluZGV4IGU4M2ViZTRjMjJkZDMyOTVkNWI4YjU0NTQzODc5ZTc2M2IyZWEzNDEuLmFmOTdlY2Y0 Y2VjMjIwOTUxY2Y0ZWY0MDMxZmM1ZWI4YWU4NjQ0OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAKQEAgLTU3MSwx MCArNTcxLDEwIEBAIHZvaWQgUG9wdXBDb250YWluZXI6OnJlZnJlc2goY29uc3QgSW50UmVjdCYg dGFyZ2V0Q29udHJvbFJlY3QpCiAgICAgbG9jYXRpb24ubW92ZSgwLCB0YXJnZXRDb250cm9sUmVj dC5oZWlnaHQoKSk7CiAKICAgICBsaXN0Qm94KCktPnVwZGF0ZUZyb21FbGVtZW50KCk7Ci0gICAg Ly8gU3RvcmUgdGhlIG9yaWdpbmFsIGhlaWdodCB0byBjaGVjayBpZiB3ZSBuZWVkIHRvIHJlcXVl c3QgdGhlIGxvY2F0aW9uLgotICAgIGludCBvcmlnaW5hbEhlaWdodCA9IGhlaWdodCgpOworICAg IC8vIFN0b3JlIHRoZSBvcmlnaW5hbCBzaXplIHRvIGNoZWNrIGlmIHdlIG5lZWQgdG8gcmVxdWVz dCB0aGUgbG9jYXRpb24uCisgICAgSW50U2l6ZSBvcmlnaW5hbFNpemUgPSBzaXplKCk7CiAgICAg SW50UmVjdCB3aWRnZXRSZWN0ID0gbGF5b3V0QW5kQ2FsY3VsYXRlV2lkZ2V0UmVjdCh0YXJnZXRD b250cm9sUmVjdC5oZWlnaHQoKSwgbG9jYXRpb24pOwotICAgIGlmIChvcmlnaW5hbEhlaWdodCAh PSB3aWRnZXRSZWN0LmhlaWdodCgpKQorICAgIGlmIChvcmlnaW5hbFNpemUgIT0gd2lkZ2V0UmVj dC5zaXplKCkpCiAgICAgICAgIHNldEZyYW1lUmVjdCh3aWRnZXRSZWN0KTsKIAogICAgIGludmFs aWRhdGUoKTsK 88475 2011-04-06 11:52:18 -0700 2011-04-07 18:19:15 -0700 Patch bug-57911-20110406115217.patch text/plain 3262 honten U3VidmVyc2lvbiBSZXZpc2lvbjogODI1NDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMmIxNTM1ZTkyNTRkY2Y2 ZThkNjcyZTc4MWQ3MTU2OGMxYWNkNTE2Li4wZDAzYjM0YWU0ZWRmMmY0YmRmNDg1ODA5NDNiM2Ez YzQ2ODlmMzZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDQtMDUgIE5hb2tp IFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBGaXggcmVsb2NhdGlvbiBwcm9i bGVtIG9mIHBvcHVwIHdpbmRvdyB3aGljaCBpbnRyb2R1Y2VzIGF1dG9maWxsIHBvcHVwIHNvbWV0 aW1lcyBtb3ZlcyB0byBzY3JlZW4ncyB0b3AgbGVmdCBjb3JuZXIuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzkxMQorICAgICAgICBodHRwOi8vY29k ZS5nb29nbGUuY29tL3AvY2hyb21pdW0vaXNzdWVzL2RldGFpbD9pZD03ODA3MworCisgICAgICAg IE1hbnVhbCB0ZXN0IGFkZGVkOiBtYW51YWwtdGVzdHMvYXV0b2ZpbGwtcG9wdXAtbG9jYXRpb24u aHRtbAorCisgICAgICAgIE9yaWdpbmFsbHkgb25seSBoZWlnaHQgaXMgY2hlY2tlZCBzbyB0aGF0 IGl0IGludHJvZHVjZXMgdGhlIGJ1Zy4KKyAgICAgICAgU28gSSBjaGFuZ2VkIGl0IHRvIGNoZWNr IGJvdGggd2lkdGggYW5kIGhlaWdodCBhcyBzaXplLgorCisgICAgICAgICogbWFudWFsLXRlc3Rz L2F1dG9maWxsLXBvcHVwLWxvY2F0aW9uLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3Jt L2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVw Q29udGFpbmVyOjpyZWZyZXNoKTogQ2hlY2sgd2luZG93IHNpemUgYmV0d2VlbiBvcmlnaW5hbCBh bmQgbmV3IGJlZm9yZSBjYWxsaW5nIHNldEZyYW1lUmVjdCgpLgorCiAyMDExLTAzLTMwICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGJ1 aWxkIGNvcnJlY3Rpb24gYWZ0ZXIgcjgyNDk2LiAoUGFydCAzKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvbWFudWFsLXRlc3RzL2F1dG9maWxsLXBvcHVwLWxvY2F0aW9uLmh0bWwgYi9Tb3Vy Y2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvYXV0b2ZpbGwtcG9wdXAtbG9jYXRpb24uaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi41ZTI4YTE1ZWEzYzUyN2UyYWM2NzAwYWZjMjdjZWRhY2Q4YjFiM2UxCi0tLSAvZGV2 L251bGwKKysrIGIvU291cmNlL1dlYkNvcmUvbWFudWFsLXRlc3RzL2F1dG9maWxsLXBvcHVwLWxv Y2F0aW9uLmh0bWwKQEAgLTAsMCArMSwyMCBAQAorPGh0bWw+CisgIDxoZWFkPgorICAgIDxNRVRB IEhUVFAtRVFVSVY9IkNPTlRFTlQtVFlQRSIgQ09OVEVOVD0idGV4dC9odG1sOyBjaGFyc2V0PVVU Ri04Ij4KKyAgICA8dGl0bGU+CisgICAgICBUZXN0IGF1dG9maWxsIHBvcHVwIHdpbmRvdyBzaG93 cyBhdCB0aGUgY29ycmVjdCBsb2NhdGlvbi4KKyAgICA8L3RpdGxlPgorICA8L2hlYWQ+CisgIDxi b2R5PgorICAgIDxoMz5UZXN0IGF1dG9maWxsIHBvcHVwIHdpbmRvdyBzaG93cyBhdCB0aGUgY29y cmVjdCBsb2NhdGlvbi48L2gzPgorICAgIDxvbD4KKyAgICAgIDxsaT4gRW50ZXIgJ0Fsd2F5cyBz aG93IGJvb2ttYXJrcyBiYXInIGluIHRoZSBmb2xsb3dpbmcgdGV4dCBpbnB1dCBhcmVhLjwvbGk+ CisgICAgICA8bGk+IEVudGVyICdUZXN0JyBpbiB0aGUgdGV4dCBpbnB1dCBhcmVhLjwvbGk+Cisg ICAgICA8bGk+IFByZXNzICdhJyBhbmQgbWFrZSBzdXJlICdBbHdheXMgc2hvdyBib29rbWFya3Mg YmFyJyBpcyBzaG93biBpbiBhdXRvZmlsbCBwb3B1cCB3aW5kb3cuPC9saT4KKyAgICAgIDxsaT4g U2VsZWN0IGFsbCB3aXRoIHByZXNzaW5nIEN0cmwtYS48L2xpPgorICAgICAgPGxpPiBQcmVzcyAn dCcgYW5kIG1ha2Ugc3VyZSAnVGVzdCcgaXMgc2hvd24gYW5kIHRoZSBwb3B1cCB3aW5kb3cgbG9j YXRpb24gaXMgY29ycmVjdC48L2xpPgorICAgIDwvb2w+CisgICAgPGJyPgorICAgIDxmb3JtPjxp bnB1dCBuYW1lPXEgYXV0b2ZvY3VzPjwvZm9ybT4KKyAgPC9ib2R5PgorPC9odG1sPiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVt LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVt LmNwcAppbmRleCBlODNlYmU0YzIyZGQzMjk1ZDViOGI1NDU0Mzg3OWU3NjNiMmVhMzQxLi5hZjk3 ZWNmNGNlYzIyMDk1MWNmNGVmNDAzMWZjNWViOGFlODY0NDlhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCkBAIC01 NzEsMTAgKzU3MSwxMCBAQCB2b2lkIFBvcHVwQ29udGFpbmVyOjpyZWZyZXNoKGNvbnN0IEludFJl Y3QmIHRhcmdldENvbnRyb2xSZWN0KQogICAgIGxvY2F0aW9uLm1vdmUoMCwgdGFyZ2V0Q29udHJv bFJlY3QuaGVpZ2h0KCkpOwogCiAgICAgbGlzdEJveCgpLT51cGRhdGVGcm9tRWxlbWVudCgpOwot ICAgIC8vIFN0b3JlIHRoZSBvcmlnaW5hbCBoZWlnaHQgdG8gY2hlY2sgaWYgd2UgbmVlZCB0byBy ZXF1ZXN0IHRoZSBsb2NhdGlvbi4KLSAgICBpbnQgb3JpZ2luYWxIZWlnaHQgPSBoZWlnaHQoKTsK KyAgICAvLyBTdG9yZSB0aGUgb3JpZ2luYWwgc2l6ZSB0byBjaGVjayBpZiB3ZSBuZWVkIHRvIHJl cXVlc3QgdGhlIGxvY2F0aW9uLgorICAgIEludFNpemUgb3JpZ2luYWxTaXplID0gc2l6ZSgpOwog ICAgIEludFJlY3Qgd2lkZ2V0UmVjdCA9IGxheW91dEFuZENhbGN1bGF0ZVdpZGdldFJlY3QodGFy Z2V0Q29udHJvbFJlY3QuaGVpZ2h0KCksIGxvY2F0aW9uKTsKLSAgICBpZiAob3JpZ2luYWxIZWln aHQgIT0gd2lkZ2V0UmVjdC5oZWlnaHQoKSkKKyAgICBpZiAob3JpZ2luYWxTaXplICE9IHdpZGdl dFJlY3Quc2l6ZSgpKQogICAgICAgICBzZXRGcmFtZVJlY3Qod2lkZ2V0UmVjdCk7CiAKICAgICBp bnZhbGlkYXRlKCk7Cg==