57910 2011-04-05 18:00:54 -0700 Rename CSSKeyframesRule insertRule to appendRule 2022-11-03 11:14:29 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=247364 InRadar P2 Normal --- 1 dino dino commit-queue sabouhallawa simon.fraser oldest_to_newest 380008 0 dino 2011-04-05 18:00:54 -0700 The spec renamed the method. Make sure we don't remove the existing insertRule though, in case people are using it. 380009 1 dino 2011-04-05 18:02:00 -0700 <rdar://problem/9237118> 1023474 2 galineau 2014-07-19 12:02:53 -0700 *** Bug 133746 has been marked as a duplicate of this bug. *** 1037271 3 sabouhallawa 2014-09-25 12:59:56 -0700 I have a fix for this bug. The interface WebKitCSSKeyframesRule.idl and the class WebKitCSSKeyframesRule need to have a new method called 'appendRule' which is basically and alias of InsertRule(). 1037327 4 238680 sabouhallawa 2014-09-25 15:58:48 -0700 Created attachment 238680 Patch 1037350 5 238680 commit-queue 2014-09-25 17:03:45 -0700 Comment on attachment 238680 Patch Clearing flags on attachment: 238680 Committed r173982: <http://trac.webkit.org/changeset/173982> 1037351 6 commit-queue 2014-09-25 17:03:49 -0700 All reviewed patches have been landed. Closing bug. 238680 2014-09-25 15:58:48 -0700 2014-09-25 17:03:45 -0700 Patch bug-57910-20140925155849.patch text/plain 3716 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3Mzk3NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA5LTI1ICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVuYW1lIENT U0tleWZyYW1lc1J1bGUgaW5zZXJ0UnVsZSB0byBhcHBlbmRSdWxlICg1NzkxMCkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3OTEwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdHM6IGFuaW1hdGlvbnMv Y2hhbmdlLWtleWZyYW1lcy5odG1sCisKKyAgICAgICAgKiBjc3MvV2ViS2l0Q1NTS2V5ZnJhbWVz UnVsZS5oOgorICAgICAgICAoV2ViQ29yZTo6V2ViS2l0Q1NTS2V5ZnJhbWVzUnVsZTo6YXBwZW5k UnVsZSk6CisgICAgICAgIC0tIE1ha2UgV2ViS2l0Q1NTS2V5ZnJhbWVzUnVsZTo6YXBwZW5kUnVs ZSB0byBiZSBhbiBhbGlhcyBvZiBXZWJLaXRDU1NLZXlmcmFtZXNSdWxlOjppbnNlcnRSdWxlKCkK KyAgICAgICAgICAgdG8gY29uZm9ybSB3aXRoIENTUyBzcGVjcworICAgICAgICAqIGNzcy9XZWJL aXRDU1NLZXlmcmFtZXNSdWxlLmlkbDoKKyAgICAgICAgLS0gQWRkIHRoZSBuZXcgbWV0aG9kIFdl YktpdENTU0tleWZyYW1lc1J1bGU6OmFwcGVuZFJ1bGUoKSBidXQga2VlcCB0aGUgb3JpZ2luYWwg bWV0aG9kCisgICAgICAgICAgIFdlYktpdENTU0tleWZyYW1lc1J1bGU6OmFwcGVuZFJ1bGUoKSB0 byBub3QgYnJlYWsgZXhpdGluZyBjdXN0b21lcnMnIHBhZ2VzLgorCiAyMDE0LTA5LTI1ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KIAogICAgICAgICBSYWNlIGluIHJlZiBwb2lu dGVyIGZvciBXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2Nzcy9XZWJLaXRDU1NLZXlmcmFtZXNSdWxlLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvY3NzL1dlYktpdENTU0tleWZyYW1lc1J1bGUuaAkocmV2aXNpb24gMTczNjYwKQor KysgU291cmNlL1dlYkNvcmUvY3NzL1dlYktpdENTU0tleWZyYW1lc1J1bGUuaAkod29ya2luZyBj b3B5KQpAQCAtODEsNiArODEsNyBAQCBwdWJsaWM6CiAgICAgQ1NTUnVsZUxpc3QqIGNzc1J1bGVz KCk7CiAKICAgICB2b2lkIGluc2VydFJ1bGUoY29uc3QgU3RyaW5nJiBydWxlKTsKKyAgICB2b2lk IGFwcGVuZFJ1bGUoY29uc3QgU3RyaW5nJiBydWxlKSB7IGluc2VydFJ1bGUocnVsZSk7IH0KICAg ICB2b2lkIGRlbGV0ZVJ1bGUoY29uc3QgU3RyaW5nJiBrZXkpOwogICAgIFdlYktpdENTU0tleWZy YW1lUnVsZSogZmluZFJ1bGUoY29uc3QgU3RyaW5nJiBrZXkpOwogCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9jc3MvV2ViS2l0Q1NTS2V5ZnJhbWVzUnVsZS5pZGwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvY3NzL1dlYktpdENTU0tleWZyYW1lc1J1bGUuaWRsCShyZXZpc2lvbiAxNzM2NjAp CisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTS2V5ZnJhbWVzUnVsZS5pZGwJKHdvcmtp bmcgY29weSkKQEAgLTMzLDYgKzMzLDcgQEAgaW50ZXJmYWNlIFdlYktpdENTU0tleWZyYW1lc1J1 bGUgOiBDU1NSdQogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBDU1NSdWxlTGlzdCBjc3NSdWxlczsK ICAgICAKICAgICB2b2lkIGluc2VydFJ1bGUoW0RlZmF1bHQ9VW5kZWZpbmVkXSBvcHRpb25hbCBE T01TdHJpbmcgcnVsZSk7CisgICAgdm9pZCBhcHBlbmRSdWxlKFtEZWZhdWx0PVVuZGVmaW5lZF0g b3B0aW9uYWwgRE9NU3RyaW5nIHJ1bGUpOwogICAgIHZvaWQgZGVsZXRlUnVsZShbRGVmYXVsdD1V bmRlZmluZWRdIG9wdGlvbmFsIERPTVN0cmluZyBrZXkpOwogICAgIFdlYktpdENTU0tleWZyYW1l UnVsZSBmaW5kUnVsZShbRGVmYXVsdD1VbmRlZmluZWRdIG9wdGlvbmFsIERPTVN0cmluZyBrZXkp OwogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNzM5NzgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxNC0wOS0yNSAgU2FpZCBBYm91LUhh bGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgorCisgICAgICAgIFJlbmFtZSBDU1NLZXlm cmFtZXNSdWxlIGluc2VydFJ1bGUgdG8gYXBwZW5kUnVsZSAoNTc5MTApCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzkxMAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYW5pbWF0aW9ucy9jaGFuZ2Uta2V5 ZnJhbWVzLmh0bWw6CisgICAgICAgIC0tIEVuc3VyZSBib3RoIFdlYktpdENTU0tleWZyYW1lc1J1 bGUgbWV0aG9kcyBpbnNlcnRSdWxlKCkgYW5kIGFwcGVuZFJ1bGUoKSBhcmUgCisgICAgICAgICAg IGJvdGggc3VwcG9ydGVkLgorCiAyMDE0LTA5LTI1ICBKYXZpZXIgRmVybmFuZGV6ICA8amZlcm5h bmRlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6IGNvbHVtbkNvdW50 IGluIFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VHcmlkVGVtcGxhdGVBcmVhc1JvdwpJbmRleDog TGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9jaGFuZ2Uta2V5ZnJhbWVzLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9jaGFuZ2Uta2V5ZnJhbWVzLmh0bWwJKHJldmlzaW9u IDE3MzY2MCkKKysrIExheW91dFRlc3RzL2FuaW1hdGlvbnMvY2hhbmdlLWtleWZyYW1lcy5odG1s CSh3b3JraW5nIGNvcHkpCkBAIC01NSw5ICs1NSw5IEBACiAgICAgICAgIGtleWZyYW1lcy5kZWxl dGVSdWxlKCI2MCUiKTsKICAgICAgICAga2V5ZnJhbWVzLmRlbGV0ZVJ1bGUoIjEwMCUiKTsKICAg ICAgICAga2V5ZnJhbWVzLmluc2VydFJ1bGUoIjAlIHsgdG9wOiA1MHB4OyB9Iik7Ci0gICAgICAg IGtleWZyYW1lcy5pbnNlcnRSdWxlKCIxMCUgeyB0b3A6IDEwMHB4OyB9Iik7CisgICAgICAgIGtl eWZyYW1lcy5hcHBlbmRSdWxlKCIxMCUgeyB0b3A6IDEwMHB4OyB9Iik7CiAgICAgICAgIGtleWZy YW1lcy5pbnNlcnRSdWxlKCI5MCUgeyB0b3A6IDEwMHB4OyB9Iik7Ci0gICAgICAgIGtleWZyYW1l cy5pbnNlcnRSdWxlKCIxMDAlIHsgdG9wOiAxNTBweDsgfSIpOworICAgICAgICBrZXlmcmFtZXMu YXBwZW5kUnVsZSgiMTAwJSB7IHRvcDogMTUwcHg7IH0iKTsKICAgICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ2JveCcpLnN0eWxlLndlYmtpdEFuaW1hdGlvbk5hbWUgPSAiYW5pbSI7CiAg ICAgfQogICAgIAo=