57909 2011-04-05 17:26:00 -0700 REGRESSION: Drag & Drop Gmail Attachments doesn't work 2011-04-06 11:59:58 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 enrica enrica abarth andersca ap eric webkit.review.bot oldest_to_newest 379988 0 enrica 2011-04-05 17:26:00 -0700 * STEPS TO REPRODUCE: 1) Open Gmail in Safari 2) Compose a message 3) Drag a file from Finder to the Safari window. * EXPECTED RESULTS: The formatting bar should change to 'Drop Files' box and dropping the file should attach it to the message and upload it. * ACTUAL RESULTS: Nothing. The formatting bar doesn't change to the 'Drop Files' box, and if you do drop the file, Safari opens it in the current tab instead of attaching it to the message. 379990 1 enrica 2011-04-05 17:27:09 -0700 <rdar://problem/9103220> 379997 2 88343 enrica 2011-04-05 17:36:26 -0700 Created attachment 88343 Patch 380004 3 88343 simon.fraser 2011-04-05 17:48:18 -0700 Comment on attachment 88343 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88343&action=review > Source/WebCore/ChangeLog:12 > + We canno change what platformData() returns on Mac, since there are "cannot" 380006 4 88343 darin 2011-04-05 17:54:04 -0700 Comment on attachment 88343 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88343&action=review r=me as is, but you’ll probably have to merge with my change to this file and you may want to consider changes based on the comments > Source/WebCore/platform/DragData.h:121 > + NSPasteboard* pasteboard() { return m_pasteboard.get(); } We’re supposed to format Objective-C type pointer expressions as “NSPasteboard *” rather than “NSPasteboard*”. > Source/WebKit2/UIProcess/API/mac/WKView.mm:85 > +@interface NSView (WebNSViewDetails) The right prefix to use in WebKit2 is WK rather than Web, so this should be WKNSViewDetails. > Source/WebKit2/UIProcess/API/mac/WKView.mm:1458 > +// This code is needed to support drag and drop. AppKit calls _hitTest on all the views in the application > +// if there is no match on the dragTypes. I don’t understand what you mean by “on all views in the application” here. I think the comment should say that we need to override this to allow us to support drags of all types without declaring all the types in advance. Unless that’s not the reason. > Source/WebKit2/UIProcess/API/mac/WKView.mm:1464 > + NSView *hitView = [super _hitTest:point dragTypes:types]; > + if (!hitView && [[self superview] mouse:*point inRect:[self frame]]) > + return self; > + return hitView; I think we could instead just say: if ([[self superview] mouse:*point inRect:[self frame]]) return self; return nil; Then we would not need to declare the WebNSViewDetails category above. 380631 5 enrica 2011-04-06 11:04:56 -0700 Addressed Darin's comments. Landed http://trac.webkit.org/changeset/83070 380697 6 webkit.review.bot 2011-04-06 11:59:58 -0700 http://trac.webkit.org/changeset/83070 might have broken Qt Linux Release The following tests are not passing: media/audio-delete-while-slider-thumb-clicked.html media/audio-mpeg-supported.html media/audio-mpeg4-supported.html media/video-currentTime.html media/video-pause-immediately.html 88343 2011-04-05 17:36:26 -0700 2011-04-05 17:54:04 -0700 Patch dragevents.txt text/plain 5832 enrica SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMDAwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMDQtMDUgIEVucmljYSBD YXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OOiBEcmFnICYgRHJvcCBHbWFpbCBBdHRhY2ht ZW50cyBkb2Vzbid0IHdvcmsuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01NzkwOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTEwMzIyMD4KKworICAg ICAgICBJbiBXZWJLaXQyIHdlIGNhbm5vdCByZWx5IG9uIHRoZSB2YWx1ZSByZXR1cm5lZCBieSBw bGF0Zm9ybURhdGEoKSB0aGF0CisgICAgICAgIG9uIE1hYyByZXR1cm5zIGFuIE5TRHJhZ2dpbmdJ bmZvIG9iamVjdC4gVGhpcyBpcyBhdmFpbGFibGUgb25seSBpbiB0aGUgVUkKKyAgICAgICAgcHJv Y2Vzcy4gVGhlcmVmb3JlIHdlIHNob3VsZCB1c2UgbV9wYXN0ZWJvYXJkIGluc3RlYWQuCisgICAg ICAgIFdlIGNhbm5vIGNoYW5nZSB3aGF0IHBsYXRmb3JtRGF0YSgpIHJldHVybnMgb24gTWFjLCBz aW5jZSB0aGVyZSBhcmUKKyAgICAgICAgZGVsZWdhdGUgbWV0aG9kcyB0aGF0IHJlY2VpdmUgYSBO U0RyYWdnaW5nSW5mbyBvYmplY3QgKG9ubHkgaW4gV2ViS2l0KS4KKyAgICAgICAgCisgICAgICAg ICogcGxhdGZvcm0vRHJhZ0RhdGEuaDoKKyAgICAgICAgKFdlYkNvcmU6OkRyYWdEYXRhOjpwYXN0 ZWJvYXJkKTogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL0NsaXBib2FyZE1hYy5tbToK KyAgICAgICAgKFdlYkNvcmU6OkNsaXBib2FyZDo6Y3JlYXRlKTogQ2hhbmdlZCB0byB1c2UgcGFz dGVib2FyZCgpIGluc3RlYWQgb2YgcGxhdGZvcm1EYXRhKCkuCisgICAgICAgICogcGxhdGZvcm0v bWFjL0RyYWdEYXRhTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6RHJhZ0RhdGE6OmFzQ29sb3Ip OiBSZXBsYWNlZCByZWZlcmVuY2VzIHRvIG1fcGxhdGZvcm1EYXRhIHdpdGggbV9wYXN0ZWJvYXJk LgorICAgICAgICAoV2ViQ29yZTo6RHJhZ0RhdGE6OmFzVVJMKTogU2FtZSBhcyBhYm92ZS4KKwog MjAxMS0wNC0wNSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L0RyYWdEYXRhLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRHJhZ0Rh dGEuaAkocmV2aXNpb24gODI4NjgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9EcmFnRGF0 YS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTcsNiArMTE3LDkgQEAgcHVibGljOgogICAgIGJvb2wg Y2FuU21hcnRSZXBsYWNlKCkgY29uc3Q7CiAgICAgYm9vbCBjb250YWluc0NvbG9yKCkgY29uc3Q7 CiAgICAgYm9vbCBjb250YWluc0ZpbGVzKCkgY29uc3Q7CisjaWYgUExBVEZPUk0oTUFDKQorICAg IE5TUGFzdGVib2FyZCogcGFzdGVib2FyZCgpIHsgcmV0dXJuIG1fcGFzdGVib2FyZC5nZXQoKTsg fQorI2VuZGlmCiBwcml2YXRlOgogICAgIEludFBvaW50IG1fY2xpZW50UG9zaXRpb247CiAgICAg SW50UG9pbnQgbV9nbG9iYWxQb3NpdGlvbjsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21hYy9DbGlwYm9hcmRNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWFjL0NsaXBib2FyZE1hYy5tbQkocmV2aXNpb24gODI4NjgpCisrKyBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9tYWMvQ2xpcGJvYXJkTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00OSw3ICs0 OSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogUGFzc1JlZlB0cjxDbGlwYm9hcmQ+IENsaXBi b2FyZDo6Y3JlYXRlKENsaXBib2FyZEFjY2Vzc1BvbGljeSBwb2xpY3ksIERyYWdEYXRhKiBkcmFn RGF0YSwgRnJhbWUqIGZyYW1lKQogewotICAgIHJldHVybiBDbGlwYm9hcmRNYWM6OmNyZWF0ZShE cmFnQW5kRHJvcCwgW2RyYWdEYXRhLT5wbGF0Zm9ybURhdGEoKSBkcmFnZ2luZ1Bhc3RlYm9hcmRd LCBwb2xpY3ksIGZyYW1lKTsKKyAgICByZXR1cm4gQ2xpcGJvYXJkTWFjOjpjcmVhdGUoRHJhZ0Fu ZERyb3AsIGRyYWdEYXRhLT5wYXN0ZWJvYXJkKCksIHBvbGljeSwgZnJhbWUpOwogfQogCiBDbGlw Ym9hcmRNYWM6OkNsaXBib2FyZE1hYyhDbGlwYm9hcmRUeXBlIGNsaXBib2FyZFR5cGUsIE5TUGFz dGVib2FyZCAqcGFzdGVib2FyZCwgQ2xpcGJvYXJkQWNjZXNzUG9saWN5IHBvbGljeSwgRnJhbWUg KmZyYW1lKQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0RyYWdEYXRhTWFjLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9EcmFnRGF0YU1hYy5t bQkocmV2aXNpb24gODI4NjgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvRHJhZ0Rh dGFNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTEwNCw3ICsxMDQsNyBAQCBTdHJpbmcgRHJhZ0Rh dGE6OmFzUGxhaW5UZXh0KEZyYW1lICpmcmFtCiAKIENvbG9yIERyYWdEYXRhOjphc0NvbG9yKCkg Y29uc3QKIHsKLSAgICBOU0NvbG9yICpjb2xvciA9IFtOU0NvbG9yIGNvbG9yRnJvbVBhc3RlYm9h cmQ6W21fcGxhdGZvcm1EcmFnRGF0YSBkcmFnZ2luZ1Bhc3RlYm9hcmRdXTsKKyAgICBOU0NvbG9y ICpjb2xvciA9IFtOU0NvbG9yIGNvbG9yRnJvbVBhc3RlYm9hcmQ6bV9wYXN0ZWJvYXJkLmdldCgp XTsKICAgICByZXR1cm4gbWFrZVJHQkEoKGludCkoW2NvbG9yIHJlZENvbXBvbmVudF0gKiAyNTUu MCArIDAuNSksIChpbnQpKFtjb2xvciBncmVlbkNvbXBvbmVudF0gKiAyNTUuMCArIDAuNSksIAog ICAgICAgICAgICAgICAgICAgICAoaW50KShbY29sb3IgYmx1ZUNvbXBvbmVudF0gKiAyNTUuMCAr IDAuNSksIChpbnQpKFtjb2xvciBhbHBoYUNvbXBvbmVudF0gKiAyNTUuMCArIDAuNSkpOwogfQpA QCAtMTQxLDcgKzE0MSw3IEBAIFN0cmluZyBEcmFnRGF0YTo6YXNVUkwoRnJhbWUqIGZyYW1lLCBG aWwKICAgICAodm9pZClmaWxlbmFtZVBvbGljeTsKIAogICAgIGlmICh0aXRsZSkgewotICAgICAg ICBpZiAoTlNTdHJpbmcgKlVSTFRpdGxlU3RyaW5nID0gW1ttX3BsYXRmb3JtRHJhZ0RhdGEgZHJh Z2dpbmdQYXN0ZWJvYXJkXSBzdHJpbmdGb3JUeXBlOldlYlVSTE5hbWVQYm9hcmRUeXBlXSkKKyAg ICAgICAgaWYgKE5TU3RyaW5nICpVUkxUaXRsZVN0cmluZyA9IFttX3Bhc3RlYm9hcmQuZ2V0KCkg c3RyaW5nRm9yVHlwZTpXZWJVUkxOYW1lUGJvYXJkVHlwZV0pCiAgICAgICAgICAgICAqdGl0bGUg PSBVUkxUaXRsZVN0cmluZzsKICAgICB9CiAgICAgUGFzdGVib2FyZCBwYXN0ZWJvYXJkKG1fcGFz dGVib2FyZC5nZXQoKSk7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiA4MzAwMCkKKysrIFNvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEx LTA0LTA1ICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTjogRHJhZyAmIERy b3AgR21haWwgQXR0YWNobWVudHMgZG9lc24ndCB3b3JrLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc5MDkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzkxMDMyMjA+CisKKyAgICAgICAgQWRkZWQgX2hpdFRlc3QgbWV0aG9kIGJlY2F1c2UgQXBwS2l0 IGNhbGxzIGl0IG9uIGFsbCB0aGUgdmlld3MgaW4gdGhlIGFwcGxpY2F0aW9uCisgICAgICAgIGlm IHRoZXJlIGlzIG5vIG1hdGNoIG9uIHRoZSBkcmFnVHlwZXMuCisgICAgICAgIAorICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbToKKyAgICAgICAgKC1bV0tWaWV3IF9oaXRUZXN0 OmRyYWdUeXBlczpdKTogQWRkZWQuCisKIDIwMTEtMDQtMDUgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlh a292LgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQko cmV2aXNpb24gODI4NjgpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1Zp ZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTgyLDYgKzgyLDEwIEBAIC0gKHZvaWQpX3NldFNob3dP cGFxdWVHcm93Qm94Rm9yT3duZXI6KGkKIC0gKEJPT0wpX3VwZGF0ZUdyb3dCb3hGb3JXaW5kb3dG cmFtZUNoYW5nZTsKIEBlbmQKIAorQGludGVyZmFjZSBOU1ZpZXcgKFdlYk5TVmlld0RldGFpbHMp CistIChOU1ZpZXcgKilfaGl0VGVzdDooTlNQb2ludCAqKWFQb2ludCBkcmFnVHlwZXM6KE5TU2V0 ICopdHlwZXM7CitAZW5kCisKIGV4dGVybiAiQyIgewogICAgIC8vIE5lZWQgdG8gZGVjbGFyZSB0 aGlzIGF0dHJpYnV0ZSBuYW1lIGJlY2F1c2UgQXBwS2l0IGV4cG9ydHMgaXQgYnV0IGRvZXMgbm90 IG1ha2UgaXQgYXZhaWxhYmxlIGluIEFQSSBvciBTUEkgaGVhZGVycy4KICAgICAvLyBGSVhNRTog V2Ugd291bGRuJ3QgbmVlZCB0aGlzIGlmIHdlIGltcGxlbWVudGVkIE5TVGV4dElucHV0Q2xpZW50 IHByb3RvY29sIGluc3RlYWQgb2YgZGVwcmVjYXRlZCBOU1RleHRJbnB1dC4KQEAgLTE0NTAsNiAr MTQ1NCwxNiBAQCAtIChCT09MKXBlcmZvcm1EcmFnT3BlcmF0aW9uOihpZCA8TlNEcmFnCiAgICAg cmV0dXJuIFlFUzsKIH0KIAorLy8gVGhpcyBjb2RlIGlzIG5lZWRlZCB0byBzdXBwb3J0IGRyYWcg YW5kIGRyb3AuIEFwcEtpdCBjYWxscyBfaGl0VGVzdCBvbiBhbGwgdGhlIHZpZXdzIGluIHRoZSBh cHBsaWNhdGlvbgorLy8gaWYgdGhlcmUgaXMgbm8gbWF0Y2ggb24gdGhlIGRyYWdUeXBlcy4KKy0g KE5TVmlldyAqKV9oaXRUZXN0OihOU1BvaW50ICopcG9pbnQgZHJhZ1R5cGVzOihOU1NldCAqKXR5 cGVzCit7CisgICAgTlNWaWV3ICpoaXRWaWV3ID0gW3N1cGVyIF9oaXRUZXN0OnBvaW50IGRyYWdU eXBlczp0eXBlc107CisgICAgaWYgKCFoaXRWaWV3ICYmIFtbc2VsZiBzdXBlcnZpZXddIG1vdXNl Oipwb2ludCBpblJlY3Q6W3NlbGYgZnJhbWVdXSkKKyAgICAgICAgcmV0dXJuIHNlbGY7CisgICAg cmV0dXJuIGhpdFZpZXc7Cit9CisKIC0gKHZvaWQpX3VwZGF0ZVdpbmRvd1Zpc2liaWxpdHkKIHsK ICAgICBfZGF0YS0+X3BhZ2UtPnVwZGF0ZVdpbmRvd0lzVmlzaWJsZSghW1tzZWxmIHdpbmRvd10g aXNNaW5pYXR1cml6ZWRdKTsK