57907 2011-04-05 17:02:36 -0700 Skia incorrectly draws fillRoundedRect 2011-04-05 22:12:29 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All Windows XP RESOLVED FIXED P2 Normal --- 1 enne webkit-unassigned agl enne morrita senorblanco simon.fraser thakis tkent oldest_to_newest 379971 0 enne 2011-04-05 17:02:36 -0700 http://trac.webkit.org/changeset/82969/trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp turned on a new fast path for rendering rounded corners. This broke a number of tests: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=fast/blockflow/border-radius-clipping-vertical-lr.html,fast/blockflow/box-shadow-horizontal-bt.html,fast/blockflow/box-shadow-vertical-lr.html,fast/blockflow/box-shadow-vertical-rl.html,fast/borders/border-radius-huge-assert.html,fast/borders/borderRadiusAllStylesAllCorners.html,fast/borders/borderRadiusArcs01.html,fast/borders/borderRadiusDashed01.html,fast/borders/borderRadiusDashed02.html,fast/borders/borderRadiusDashed03.html,fast/borders/borderRadiusDotted01.html,fast/borders/borderRadiusDotted02.html,fast/borders/borderRadiusDotted03.html,fast/borders/borderRadiusDouble01.html,fast/borders/borderRadiusDouble02.html,fast/borders/borderRadiusDouble03.html,fast/borders/borderRadiusGroove01.html,fast/borders/borderRadiusGroove02.html,fast/borders/borderRadiusInset01.html,fast/borders/borderRadiusInvalidColor.html,fast/borders/borderRadiusOutset01.html,fast/borders/borderRadiusRidge01.html,fast/borders/borderRadiusSolid01.html,fast/borders/borderRadiusSolid02.html,fast/borders/borderRadiusSolid03.html,fast/box-shadow/border-radius-big.html,fast/box-shadow/inset-with-extraordinary-radii-and-border.html,fast/box-shadow/inset.html,fast/box-shadow/spread-multiple-inset.html,fast/box-shadow/spread-multiple-normal.html,fast/box-shadow/spread.html,fast/css/text-input-with-webkit-border-radius.html,fast/forms/basic-selects.html,fast/layers/video-layer.html,fast/overflow/border-radius-clipping.html,fast/repaint/border-radius-repaint.html,fast/replaced/border-radius-clip.html,fast/transforms/shadows.html,media/audio-controls-rendering.html,media/controls-after-reload.html,media/controls-strict.html,media/controls-styling.html,media/controls-without-preload.html,media/media-document-audio-repaint.html,media/video-controls-rendering.html,media/video-display-toggle.html,media/video-empty-source.html,media/video-no-audio.html,media/video-volume-slider.html,media/video-zoom-controls.html,svg/custom/svg-fonts-in-html.html It essentially ends up rendering the background color as black instead of the correct color. This bug doesn't occur on Mac, just Windows and Linux, so seems likely a Skia bug. If I use fillRect instead fillRoundedRect, the color is right (even if the dimensions are wrong). So, it seems like a fillRoundedRect problem. I'm going to #ifdef it out temporarily until this can get addressed. 379974 1 thakis 2011-04-05 17:04:36 -0700 GraphicsContext::fillRoundedRect() in GraphicsContextSkia.cpp ignores its |color| parameter, maybe that's why? 379977 2 thakis 2011-04-05 17:07:43 -0700 Does this help? diff --git a/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp b/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp index df680eb..6d57fb8 100644 --- a/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp +++ b/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp @@ -853,6 +853,7 @@ void GraphicsContext::fillRoundedRect(const IntRect& rect, SkPaint paint; platformContext()->setupPaintForFilling(&paint); + paint.setColor(color.rgb()); platformContext()->canvas()->drawPath(path, paint); } 379982 3 88339 enne 2011-04-05 17:16:16 -0700 Created attachment 88339 Patch 379992 4 enne 2011-04-05 17:28:41 -0700 Committed r83002: <http://trac.webkit.org/changeset/83002> 380125 5 tkent 2011-04-05 22:12:29 -0700 Rebaseline by http://trac.webkit.org/changeset/83017 88339 2011-04-05 17:16:16 -0700 2011-04-05 17:19:02 -0700 Patch bug-57907-20110405171615.patch text/plain 1302 enne U3VidmVyc2lvbiBSZXZpc2lvbjogODI5ODMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzYmJiNmQyZmM3Njg2ZDhl ZWQ0ZDlkZDNhMDE2ZWUyOTUxZDNhNzMzLi45ZmZkMDkxYmNmOTAxMjUwNzIwMDc4ODAyYmQ3MWUy ZWQ1Zjk3ZDU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMDUgIEFkcmll bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDb3JyZWN0bHkgc2V0IGNvbG9yIHdoZW4gdXNpbmcgc2tp YSdzIGZpbGxSb3VuZGVkUmVjdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU3OTA3CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dy YXBoaWNzQ29udGV4dFNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0 OjpmaWxsUm91bmRlZFJlY3QpOgorCiAyMDExLTA0LTA0ICBWaXRhbHkgUmVwZXNoa28gIDx2aXRh bHlyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0Nv bnRleHRTa2lhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3Jh cGhpY3NDb250ZXh0U2tpYS5jcHAKaW5kZXggZGY2ODBlYjZjYmRmMzFhNjg5ODgxOTQ1NzQyZGYw YTc2NmRiNDk5YS4uNmQ1N2ZiODdmYzIwZjlhYzRmODM4OWYyODg4YzU2NzkxNjIyODJjZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0Nv bnRleHRTa2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L0dyYXBoaWNzQ29udGV4dFNraWEuY3BwCkBAIC04NTMsNiArODUzLDcgQEAgdm9pZCBHcmFwaGlj c0NvbnRleHQ6OmZpbGxSb3VuZGVkUmVjdChjb25zdCBJbnRSZWN0JiByZWN0LAogCiAgICAgU2tQ YWludCBwYWludDsKICAgICBwbGF0Zm9ybUNvbnRleHQoKS0+c2V0dXBQYWludEZvckZpbGxpbmco JnBhaW50KTsKKyAgICBwYWludC5zZXRDb2xvcihjb2xvci5yZ2IoKSk7CiAgICAgcGxhdGZvcm1D b250ZXh0KCktPmNhbnZhcygpLT5kcmF3UGF0aChwYXRoLCBwYWludCk7CiB9CiAK