57898 2011-04-05 15:57:32 -0700 REGRESSION (r82185): Scroll position not restored on navigation back to a page in the page cache 2011-05-02 14:13:35 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 58977 1 bdakin bdakin abarth bdakin eric kenneth ossy simon.fraser thakis tonikitoo webkit.review.bot yong.li.webkit zalan oldest_to_newest 379937 0 bdakin 2011-04-05 15:57:32 -0700 Regression from http://trac.webkit.org/changeset/82185/trunk/Source/WebCore * STEPS TO REPRODUCE 1. Navigate to <http://en.wikipedia.org/wiki/MathML> 2. Scroll down 3. In the same tab, navigate to >about:blank> 4. Choose History > Back * RESULTS The Wikipedia page is scrolled to the top. <rdar://problem/9226652> 388115 1 90106 bdakin 2011-04-18 15:45:56 -0700 Created attachment 90106 Patch 388171 2 90106 mjs 2011-04-18 16:53:01 -0700 Comment on attachment 90106 Patch r=me 388277 3 90106 tonikitoo 2011-04-18 21:12:58 -0700 Comment on attachment 90106 Patch Why no tests? :) It should be very easy to be tested, unless I am missing something ... 388750 4 bdakin 2011-04-19 13:39:24 -0700 (In reply to comment #3) > (From update of attachment 90106 [details]) > Why no tests? :) > > It should be very easy to be tested, unless I am missing something ... You're right, Antonio! I wrote a test that I will commit with the change. 388756 5 tonikitoo 2011-04-19 13:45:29 -0700 > > > > It should be very easy to be tested, unless I am missing something ... > > You're right, Antonio! I wrote a test that I will commit with the change. Perfect 388802 6 bdakin 2011-04-19 14:31:25 -0700 Committed fix and test with revision 84296. 388852 7 webkit.review.bot 2011-04-19 15:35:44 -0700 http://trac.webkit.org/changeset/84296 might have broken Qt Linux Release 389140 8 ossy 2011-04-20 04:05:37 -0700 (In reply to comment #7) > http://trac.webkit.org/changeset/84296 might have broken Qt Linux Release new bug for it: https://bugs.webkit.org/show_bug.cgi?id=58977 389224 9 yong.li.webkit 2011-04-20 07:48:07 -0700 (In reply to comment #7) > http://trac.webkit.org/changeset/84296 might have broken Qt Linux Release Probably FrameView::resetScrollbarsAndClearContentsSize() is never called in some cases like when it loads an unreachable URL, then the cached scroll position is always (0, 0) and the real scroll position is lost. I don't think the solution is right. HistoryController and ScrollView shouldn't think that much. Who resets contents size to (0, 0) should be responsible to restore the scroll position when contents size changes back. 390007 10 tonikitoo 2011-04-21 07:14:01 -0700 (In reply to comment #9) > (In reply to comment #7) > > http://trac.webkit.org/changeset/84296 might have broken Qt Linux Release > > Probably FrameView::resetScrollbarsAndClearContentsSize() is never called in some cases like when it loads an unreachable URL, then the cached scroll position is always (0, 0) and the real scroll position is lost. I don't think the solution is right. HistoryController and ScrollView shouldn't think that much. Who resets contents size to (0, 0) should be responsible to restore the scroll position when contents size changes back. Beth, could you reply to Yong's comment, please? It broke something important for us. 390628 11 bdakin 2011-04-21 23:07:25 -0700 Hi Yong and Antontio, I discovered that this caused a regression in Safari as well: though my patch made pages in the page cache properly restore scroll position on reload, it regressed pages that do not go into the page cache. This pages no longer restore scroll position. I have a fix and a layout test that I will post shortly. Hopefully it fixes the QT test as well. 390633 12 90672 bdakin 2011-04-21 23:21:39 -0700 Created attachment 90672 Patch that restores scroll position for cached and non-cached pages 390634 13 90672 mitz 2011-04-21 23:26:25 -0700 Comment on attachment 90672 Patch that restores scroll position for cached and non-cached pages View in context: https://bugs.webkit.org/attachment.cgi?id=90672&action=review > Source/WebCore/ChangeLog:12 > + *not* in the page cache. This patch fixed both cached and non-cached pages by “fixed” or “fixes”? 390635 14 bdakin 2011-04-21 23:30:22 -0700 Thanks Dan! Committed fix with revision 84604. 395936 15 thakis 2011-05-01 10:08:13 -0700 It looks like this still happens for in-page navigations. I filed bug 59877 for this. 396651 16 mihaip 2011-05-02 14:13:35 -0700 *** Bug 59877 has been marked as a duplicate of this bug. *** 90106 2011-04-18 15:45:56 -0700 2011-04-21 23:21:57 -0700 Patch for-review.txt text/plain 3701 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0MTkzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjggQEAKKzIwMTEtMDQtMTggIEJldGggRGFr aW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 Nzg5OAorICAgICAgICBSRUdSRVNTSU9OIChyODIxODUpOiBTY3JvbGwgcG9zaXRpb24gbm90IHJl c3RvcmVkIG9uIG5hdmlnYXRpb24gYmFjayB0byBhIHBhZ2UgaW4gCisgICAgICAgIHRoZSBwYWdl IGNhY2hlCisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzkyMjY2NTI+CisKKyAgICAgICAgU2V0dGluZyB0aGUgY29udGVudHNTaXplIG9mIGEgU2Ny b2xsVmlldyB0byAoMCwgMCkgbmVjZXNzYXJpbHkgY2F1c2VzIHRoZSBzY3JvbGwgCisgICAgICAg IHBvc2l0aW9uIHRvIGJlIGxvc3QuIChUaGUgc2Nyb2xsIHBvc2l0aW9uIGlzIGNvbXB1dGVkIGJh c2VkIG9uIHRoZSAKKyAgICAgICAgdmlzaWJsZUNvbnRlbnRTaXplLikgVGhpcyBwYXRjaCBwcm92 aWRlcyBhIG1lY2hhbmlzbSB0byBjYWNoZSB0aGUgY3VycmVudCBzY3JvbGwgCisgICAgICAgIHBv c2l0aW9uLCBhbmQgdGhlbiB0aGUgSGlzdG9yeUNvbnRyb2xsZXIgYWNjZXNzZXMgb25seSB0aGUg Y2FjaGVkIHBvc2l0aW9uIHJhdGhlciAKKyAgICAgICAgdGhhbiBjYWxsaW5nIHNjcm9sbFBvc2l0 aW9uKCkgd2hpY2ggZG9lcyBhIGNvbXB1dGF0aW9uIGJhc2VkIG9uIHRoZSAKKyAgICAgICAgdmlz aWJsZUNvbnRlbnRTaXplLiAKKworICAgICAgICAqIGxvYWRlci9IaXN0b3J5Q29udHJvbGxlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIaXN0b3J5Q29udHJvbGxlcjo6c2F2ZVNjcm9sbFBvc2l0 aW9uQW5kVmlld1N0YXRlVG9JdGVtKToKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnJlc2V0U2Nyb2xsYmFyc0FuZENsZWFyQ29udGVu dHNTaXplKToKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxWaWV3Lmg6CisgICAgICAgIChXZWJD b3JlOjpTY3JvbGxWaWV3OjpjYWNoZUN1cnJlbnRTY3JvbGxQb3NpdGlvbik6CisgICAgICAgIChX ZWJDb3JlOjpTY3JvbGxWaWV3OjpjYWNoZWRTY3JvbGxQb3NpdGlvbik6CisKIDIwMTEtMDQtMTgg IEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KIAogICAgICAgICBSdWJiZXItc3Rh bXBlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL0hpc3RvcnlD b250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvSGlzdG9y eUNvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiA4NDE2NCkKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRl ci9IaXN0b3J5Q29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc5LDcgKzc5LDcgQEAg dm9pZCBIaXN0b3J5Q29udHJvbGxlcjo6c2F2ZVNjcm9sbFBvc2l0aQogICAgIGlmICghaXRlbSB8 fCAhbV9mcmFtZS0+dmlldygpKQogICAgICAgICByZXR1cm47CiAgICAgICAgIAotICAgIGl0ZW0t PnNldFNjcm9sbFBvaW50KG1fZnJhbWUtPnZpZXcoKS0+c2Nyb2xsUG9zaXRpb24oKSk7CisgICAg aXRlbS0+c2V0U2Nyb2xsUG9pbnQobV9mcmFtZS0+dmlldygpLT5jYWNoZWRTY3JvbGxQb3NpdGlv bigpKTsKICAgICBpdGVtLT5zZXRQYWdlU2NhbGVGYWN0b3IobV9mcmFtZS0+cGFnZVNjYWxlRmFj dG9yKCkpOwogICAgIAogICAgIC8vIEZJWE1FOiBJdCB3b3VsZCBiZSBncmVhdCB0byB3b3JrIG91 dCBhIHdheSB0byBwdXQgdGhpcyBjb2RlIGluIFdlYkNvcmUgaW5zdGVhZCBvZiBjYWxsaW5nIHRo cm91Z2ggdG8gdGhlIGNsaWVudC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAJKHJl dmlzaW9uIDg0MTY0KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0yNTgsNiArMjU4LDEwIEBAIHZvaWQgRnJhbWVWaWV3OjpyZXNldFNjcm9s bGJhcnMoKQogCiB2b2lkIEZyYW1lVmlldzo6cmVzZXRTY3JvbGxiYXJzQW5kQ2xlYXJDb250ZW50 c1NpemUoKQogeworICAgIC8vIFNpbmNlIHRoZSBjb250ZW50cyBzaXplIGlzIGJlaW5nIGNsZWFy ZWQsIHRoZSBzY3JvbGwgcG9zaXRpb24gd2lsbCBsb3N0IGFzIGEgY29uc2VxdWVuY2UuCisgICAg Ly8gQ2FjaGUgdGhlIHNjcm9sbCBwb3NpdGlvbiBzbyBpdCBjYW4gYmUgcmVzdG9yZWQgYnkgdGhl IHBhZ2UgY2FjaGUgaWYgbmVjZXNzYXJ5LiAKKyAgICBjYWNoZUN1cnJlbnRTY3JvbGxQb3NpdGlv bigpOworCiAgICAgcmVzZXRTY3JvbGxiYXJzKCk7CiAKICAgICBzZXRTY3JvbGxiYXJzU3VwcHJl c3NlZCh0cnVlKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmgJKHJldmlz aW9uIDg0MTY0KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNzksNiArMTc5LDkgQEAgcHVibGljOgogCiAgICAgSW50U2l6ZSBvdmVy aGFuZ0Ftb3VudCgpIGNvbnN0OwogCisgICAgdm9pZCBjYWNoZUN1cnJlbnRTY3JvbGxQb3NpdGlv bigpIHsgbV9jYWNoZWRTY3JvbGxQb3NpdGlvbiA9IHNjcm9sbFBvc2l0aW9uKCk7IH0KKyAgICBJ bnRQb2ludCBjYWNoZWRTY3JvbGxQb3NpdGlvbigpIGNvbnN0IHsgcmV0dXJuIG1fY2FjaGVkU2Ny b2xsUG9zaXRpb247IH0KKwogICAgIC8vIEZ1bmN0aW9ucyBmb3Igc2Nyb2xsaW5nIHRoZSB2aWV3 LgogICAgIHZvaWQgc2V0U2Nyb2xsUG9zaXRpb24oY29uc3QgSW50UG9pbnQmKTsKICAgICB2b2lk IHNjcm9sbEJ5KGNvbnN0IEludFNpemUmIHMpIHsgcmV0dXJuIHNldFNjcm9sbFBvc2l0aW9uKHNj cm9sbFBvc2l0aW9uKCkgKyBzKTsgfQpAQCAtMzM4LDYgKzM0MSw3IEBAIHByaXZhdGU6CiAKICAg ICBJbnRSZWN0IG1fYWN0dWFsVmlzaWJsZUNvbnRlbnRSZWN0OwogICAgIEludFNpemUgbV9zY3Jv bGxPZmZzZXQ7IC8vIEZJWE1FOiBXb3VsZCByYXRoZXIgc3RvcmUgdGhpcyBhcyBhIHBvc2l0aW9u LCBidXQgd2Ugd2lsbCB3YWl0IHRvIG1ha2UgdGhpcyBjaGFuZ2UgdW50aWwgbW9yZSBjb2RlIGlz IHNoYXJlZC4KKyAgICBJbnRQb2ludCBtX2NhY2hlZFNjcm9sbFBvc2l0aW9uOwogICAgIEludFNp emUgbV9maXhlZExheW91dFNpemU7CiAgICAgSW50U2l6ZSBtX2NvbnRlbnRzU2l6ZTsKIAo= 90672 2011-04-21 23:21:39 -0700 2011-04-21 23:26:25 -0700 Patch that restores scroll position for cached and non-cached pages for-review.txt text/plain 4450 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NjAyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDQtMjEgIEJldGggRGFr aW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 Nzg5OAorICAgICAgICBSRUdSRVNTSU9OIChyODIxODUpOiBTY3JvbGwgcG9zaXRpb24gbm90IHJl c3RvcmVkIG9uIG5hdmlnYXRpb24gYmFjayB0byBhIHBhZ2UgaW4gCisgICAgICAgIHRoZSBwYWdl IGNhY2hlCisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzkyMjY2NTI+CisKKyAgICAgICAgVGhlIG9yaWdpbmFsIGZpeCBmb3IgdGhpcyBjaGFuZ2Ug YnJva2Ugc2Nyb2xsLXBvc2l0aW9uIHJlc3RvcmUgZm9yIHBhZ2VzIHRoYXQgYXJlIAorICAgICAg ICAqbm90KiBpbiB0aGUgcGFnZSBjYWNoZS4gVGhpcyBwYXRjaCBmaXhlZCBib3RoIGNhY2hlZCBh bmQgbm9uLWNhY2hlZCBwYWdlcyBieSAKKyAgICAgICAgdXNpbmcgdGhlIGNhY2hlZFNjcm9sbFBv c2l0aW9uKCkgb25seSBmb3IgY2FjaGVkIHBhZ2VzLgorICAgICAgICAqIGxvYWRlci9IaXN0b3J5 Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIaXN0b3J5Q29udHJvbGxlcjo6c2F2 ZVNjcm9sbFBvc2l0aW9uQW5kVmlld1N0YXRlVG9JdGVtKToKKwogMjAxMS0wNC0yMSAgSm9obiBC YXVtYW4gIDxqYmF1bWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5u ZXRoIFJ1c3NlbGwuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xs ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJv bGxlci5jcHAJKHJldmlzaW9uIDg0NTk3KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL0hpc3Rv cnlDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzgsOCArNzgsMTIgQEAgdm9pZCBI aXN0b3J5Q29udHJvbGxlcjo6c2F2ZVNjcm9sbFBvc2l0aQogewogICAgIGlmICghaXRlbSB8fCAh bV9mcmFtZS0+dmlldygpKQogICAgICAgICByZXR1cm47Ci0gICAgICAgIAotICAgIGl0ZW0tPnNl dFNjcm9sbFBvaW50KG1fZnJhbWUtPnZpZXcoKS0+Y2FjaGVkU2Nyb2xsUG9zaXRpb24oKSk7CisK KyAgICBpZiAobV9mcmFtZS0+ZG9jdW1lbnQoKS0+aW5QYWdlQ2FjaGUoKSkKKyAgICAgICAgaXRl bS0+c2V0U2Nyb2xsUG9pbnQobV9mcmFtZS0+dmlldygpLT5jYWNoZWRTY3JvbGxQb3NpdGlvbigp KTsKKyAgICBlbHNlCisgICAgICAgIGl0ZW0tPnNldFNjcm9sbFBvaW50KG1fZnJhbWUtPnZpZXco KS0+c2Nyb2xsUG9zaXRpb24oKSk7CisKICAgICBpdGVtLT5zZXRQYWdlU2NhbGVGYWN0b3IobV9m cmFtZS0+cGFnZVNjYWxlRmFjdG9yKCkpOwogICAgIAogICAgIC8vIEZJWE1FOiBJdCB3b3VsZCBi ZSBncmVhdCB0byB3b3JrIG91dCBhIHdheSB0byBwdXQgdGhpcyBjb2RlIGluIFdlYkNvcmUgaW5z dGVhZCBvZiBjYWxsaW5nIHRocm91Z2ggdG8gdGhlIGNsaWVudC4KSW5kZXg6IExheW91dFRlc3Rz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9u IDg0NjAzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMDQtMjEgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Nzg5OAorICAgICAgICBSRUdSRVNTSU9OIChy ODIxODUpOiBTY3JvbGwgcG9zaXRpb24gbm90IHJlc3RvcmVkIG9uIG5hdmlnYXRpb24gYmFjayB0 byBhIHBhZ2UgaW4gCisgICAgICAgIHRoZSBwYWdlIGNhY2hlCisgICAgICAgIC1hbmQgY29ycmVz cG9uZGluZy0KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzkyMjY2NTI+CisKKyAgICAgICAgKiBm YXN0L2xvYWRlci9zY3JvbGwtcG9zaXRpb24tcmVzdG9yZWQtb24tYmFjay1ub24tY2FjaGVkLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9sb2FkZXIvc2Nyb2xsLXBvc2l0aW9u LXJlc3RvcmVkLW9uLWJhY2stbm9uLWNhY2hlZC5odG1sOiBBZGRlZC4KKwogMjAxMS0wNC0yMSAg Q2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEJldGggRGFraW4uCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9zY3JvbGwtcG9z aXRpb24tcmVzdG9yZWQtb24tYmFjay1ub24tY2FjaGVkLWV4cGVjdGVkLnR4dAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9zY3JvbGwtcG9zaXRpb24tcmVzdG9yZWQtb24t YmFjay1ub24tY2FjaGVkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2Zhc3QvbG9hZGVyL3Njcm9sbC1wb3NpdGlvbi1yZXN0b3JlZC1vbi1iYWNrLW5vbi1jYWNoZWQt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQgQEAKK1N1Y2Nlc3MhIFRoZSBz Y3JvbGwgcG9zaXRpb24gd2FzIHJlc3RvcmVkIGFmdGVyIG5hdmlnYXRpb24uCisKKworCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9zY3JvbGwtcG9zaXRpb24tcmVzdG9yZWQtb24tYmFj ay1ub24tY2FjaGVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIv c2Nyb2xsLXBvc2l0aW9uLXJlc3RvcmVkLW9uLWJhY2stbm9uLWNhY2hlZC5odG1sCShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvc2Nyb2xsLXBvc2l0aW9uLXJlc3RvcmVk LW9uLWJhY2stbm9uLWNhY2hlZC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDM1IEBACis8 aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KKworZnVuY3Rpb24gbmF2aWdhdGUoKQoreworICAgIGlm IChsb2NhdGlvbi5oYXNoID09ICIiKSB7CisgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpIHsKKyAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQo KTsKKyAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAg ICAgICAgfQorCisgICAgICAgIHNjcm9sbFRvKDAsMTAwKTsKKyAgICAgICAgaGlzdG9yeS5wdXNo U3RhdGUoeyB9LCAiIiwgd2luZG93LmxvY2F0aW9uICsgIiMxIik7CisgICAgICAgIHNldFRpbWVv dXQoIndpbmRvdy5sb2NhdGlvbi5ocmVmID0gJ3Jlc291cmNlcy9lbXB0eS1kb2N1bWVudC1nb2Vz LWJhY2suaHRtbCciLCAwKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIHNldFRpbWVv dXQoZnVuY3Rpb24gKCkgeyAKKyAgICAgICAgdmFyIHNjcm9sbFBvc2l0aW9uID0gZG9jdW1lbnQu Ym9keS5zY3JvbGxUb3A7CisgICAgICAgIHZhciByZXN1bHQgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgicmVzdWx0Iik7CisgICAgICAgIGlmIChzY3JvbGxQb3NpdGlvbiA9PSAxMDApCisgICAg ICAgICAgICByZXN1bHQuaW5uZXJIVE1MID0gIlN1Y2Nlc3MhIFRoZSBzY3JvbGwgcG9zaXRpb24g d2FzIHJlc3RvcmVkIGFmdGVyIG5hdmlnYXRpb24uIgorICAgICAgICBpZiAod2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5 RG9uZSgpOworICAgIH0sIDApOworfQorCis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IHN0eWxl PSJ3aWR0aDo4MDBweCIgb25wYWdlc2hvdz0ibmF2aWdhdGUoKTsiPgorICAgIDxkaXYgaWQ9InJl c3VsdCI+RmFpbC4gVGhlIHNjcm9sbCBwb3NpdGlvbiB3YXMgbm90IHJlc3RvcmVkIGFmdGVyIG5h dmlnYXRpb24uPC9kaXY+PGJyLz48YnIvPgorICAgIDxkaXYgc3R5bGU9IndpZHRoOjYwMDsgaGVp Z2h0OjEwMDA7IGJhY2tncm91bmQtY29sb3I6cHVycGxlOyI+PC9kaXY+Cis8L2JvZHk+Cis8L2h0 bUw+Cg==