57892 2011-04-05 15:27:08 -0700 Don't use Exception.message because it's deprecated 2011-04-05 19:00:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth abarth eric morrita tony webkit.review.bot oldest_to_newest 379906 0 abarth 2011-04-05 15:27:08 -0700 Don't use Exception.message because it's deprecated 379910 1 88320 abarth 2011-04-05 15:29:39 -0700 Created attachment 88320 Patch 379912 2 morrita 2011-04-05 15:32:04 -0700 lgtm. Could anyone r+ this? 379930 3 88320 tony 2011-04-05 15:52:51 -0700 Comment on attachment 88320 Patch Is there no way to suppress deprecation warnings? 379933 4 tony 2011-04-05 15:54:03 -0700 http://docs.python.org/library/warnings.html#temporarily-suppressing-warnings 379934 5 abarth 2011-04-05 15:55:16 -0700 Mid-air collision detected! :) 379940 6 88325 abarth 2011-04-05 15:59:13 -0700 Created attachment 88325 Patch 379966 7 abarth 2011-04-05 16:54:39 -0700 Committed r82999: <http://trac.webkit.org/changeset/82999> 380035 8 webkit.review.bot 2011-04-05 19:00:54 -0700 http://trac.webkit.org/changeset/82999 might have broken Leopard Intel Release (Tests) The following tests are not passing: http/tests/websocket/tests/alert-in-event-handler.html http/tests/websocket/tests/bad-handshake-crash.html http/tests/websocket/tests/bufferedAmount-after-close.html http/tests/websocket/tests/close-on-navigate-new-location.html http/tests/websocket/tests/close-on-unload-and-force-gc.html http/tests/websocket/tests/close-on-unload-reference-in-parent.html http/tests/websocket/tests/close-on-unload.html http/tests/websocket/tests/cross-origin.html http/tests/websocket/tests/error-detect.html http/tests/websocket/tests/frame-length-longer-than-buffer.html http/tests/websocket/tests/frame-length-overflow.html http/tests/websocket/tests/frame-length-skip.html http/tests/websocket/tests/frame-lengths.html http/tests/websocket/tests/handshake-challenge-randomness.html http/tests/websocket/tests/handshake-error.html http/tests/websocket/tests/handshake-fail-by-cross-origin.html http/tests/websocket/tests/handshake-fail-by-maxlength.html http/tests/websocket/tests/handshake-fail-by-no-connection-header.html http/tests/websocket/tests/handshake-fail-by-no-cr.html http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html http/tests/websocket/tests/handshake-fail-by-prepended-null.html http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html http/tests/websocket/tests/httponly-cookie.pl http/tests/websocket/tests/long-invalid-header.html http/tests/websocket/tests/multiple-connections.html http/tests/websocket/tests/null-character.html http/tests/websocket/tests/reload-crash.html http/tests/websocket/tests/send-after-close-on-unload.html http/tests/websocket/tests/send-throw.html http/tests/websocket/tests/send.html http/tests/websocket/tests/simple-stress.html http/tests/websocket/tests/simple.html http/tests/websocket/tests/sub-protocol-with-space.html http/tests/websocket/tests/sub-protocol.html http/tests/websocket/tests/unicode.html http/tests/websocket/tests/url-no-trailing-slash.html http/tests/websocket/tests/url-with-credential.html http/tests/websocket/tests/url-with-empty-query.html http/tests/websocket/tests/url-with-query-for-no-query.html http/tests/websocket/tests/url-with-query.html http/tests/websocket/tests/websocket-pending-activity.html http/tests/websocket/tests/websocket-protocol-ignored.html http/tests/websocket/tests/workers/close-in-onmessage-crash.html http/tests/websocket/tests/workers/close-in-shared-worker.html http/tests/websocket/tests/workers/close-in-worker.html http/tests/websocket/tests/workers/shared-worker-simple.html http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html http/tests/websocket/tests/workers/worker-simple.html 88320 2011-04-05 15:29:39 -0700 2011-04-05 15:59:10 -0700 Patch bug-57892-20110405152937.patch text/plain 1586 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDgyOTkxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDQtMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCB1c2Ug RXhjZXB0aW9uLm1lc3NhZ2UgYmVjYXVzZSBpdCdzIGRlcHJlY2F0ZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3ODkyCisKKyAgICAgICAgSW5zdGVh ZCBvZiByZXRyZWl2aW5nIHRoZSBtZXNzYWdlIGZyb20gc2VsZi5tZXNzYWdlLCB3ZSBjYWNoZSBh bm90aGVyCisgICAgICAgIGNvcHkgb2YgaXQgdG8gYXZvaWQgZGVwcmVjYXRpb24gd2FybmluZ3Mu CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5 OgorCiAyMDExLTA0LTA1ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkJKHJldmlzaW9uIDgyOTkwKQor KysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weQkod29y a2luZyBjb3B5KQpAQCAtNzYsNiArNzYsNyBAQCBjbGFzcyBTY3JpcHRFcnJvcihFeGNlcHRpb24p OgogICAgICAgICAgICAgICAgIG1lc3NhZ2UgKz0gIiBjd2Q6ICVzIiAlIGN3ZAogCiAgICAgICAg IEV4Y2VwdGlvbi5fX2luaXRfXyhzZWxmLCBtZXNzYWdlKQorICAgICAgICBzZWxmLl9tZXNzYWdl ID0gbWVzc2FnZQogICAgICAgICBzZWxmLnNjcmlwdF9hcmdzID0gc2NyaXB0X2FyZ3MgIyAnYXJn cycgaXMgYWxyZWFkeSB1c2VkIGJ5IEV4Y2VwdGlvbgogICAgICAgICBzZWxmLmV4aXRfY29kZSA9 IGV4aXRfY29kZQogICAgICAgICBzZWxmLm91dHB1dCA9IG91dHB1dApAQCAtODMsOCArODQsOCBA QCBjbGFzcyBTY3JpcHRFcnJvcihFeGNlcHRpb24pOgogCiAgICAgZGVmIF9fc3RyX18oc2VsZik6 CiAgICAgICAgIGlmIHNlbGYub3V0cHV0OgotICAgICAgICAgICAgcmV0dXJuIHNlbGYubWVzc2Fn ZSArICJcbiIgKyBzZWxmLm91dHB1dAotICAgICAgICByZXR1cm4gc2VsZi5tZXNzYWdlCisgICAg ICAgICAgICByZXR1cm4gc2VsZi5fbWVzc2FnZSArICJcbiIgKyBzZWxmLm91dHB1dAorICAgICAg ICByZXR1cm4gc2VsZi5fbWVzc2FnZQogCiAgICAgZGVmIG1lc3NhZ2Vfd2l0aF9vdXRwdXQoc2Vs Ziwgb3V0cHV0X2xpbWl0PTUwMCk6CiAgICAgICAgIGlmIHNlbGYub3V0cHV0Ogo= 88325 2011-04-05 15:59:13 -0700 2011-04-05 15:59:50 -0700 Patch bug-57892-20110405155912.patch text/plain 1616 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDgyOTkxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDQtMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCB1c2Ug RXhjZXB0aW9uLm1lc3NhZ2UgYmVjYXVzZSBpdCdzIGRlcHJlY2F0ZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3ODkyCisKKyAgICAgICAgU3VwcHJl c3MgdGhlIHdhcm5pbmcgZm9yIG5vdy4gIFdoZW4gd2UgbW92ZSB0byBQeXRob24gMywgd2UgbWln aHQgbmVlZAorICAgICAgICB0byBzb21ldGhpbmcgbW9yZSBkcmFtYXRpYy4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHk6CisKIDIwMTEtMDQt MDUgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS9leGVjdXRpdmUucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weQkocmV2aXNpb24gODI5OTApCisrKyBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5CSh3b3JraW5nIGNvcHkpCkBA IC00Myw2ICs0Myw3IEBAIGltcG9ydCBzaWduYWwKIGltcG9ydCBzdWJwcm9jZXNzCiBpbXBvcnQg c3lzCiBpbXBvcnQgdGltZQoraW1wb3J0IHdhcm5pbmdzCiAKIGZyb20gd2Via2l0cHkuY29tbW9u LnN5c3RlbS5kZXByZWNhdGVkX2xvZ2dpbmcgaW1wb3J0IHRlZQogZnJvbSB3ZWJraXRweS5jb21t b24uc3lzdGVtLmZpbGVzeXN0ZW0gaW1wb3J0IEZpbGVTeXN0ZW0KQEAgLTgyLDkgKzgzLDExIEBA IGNsYXNzIFNjcmlwdEVycm9yKEV4Y2VwdGlvbik6CiAgICAgICAgIHNlbGYuY3dkID0gY3dkCiAK ICAgICBkZWYgX19zdHJfXyhzZWxmKToKLSAgICAgICAgaWYgc2VsZi5vdXRwdXQ6Ci0gICAgICAg ICAgICByZXR1cm4gc2VsZi5tZXNzYWdlICsgIlxuIiArIHNlbGYub3V0cHV0Ci0gICAgICAgIHJl dHVybiBzZWxmLm1lc3NhZ2UKKyAgICAgICAgd2l0aCB3YXJuaW5ncy5jYXRjaF93YXJuaW5ncygp OgorICAgICAgICAgICAgd2FybmluZ3Muc2ltcGxlZmlsdGVyKCJpZ25vcmUiKQorICAgICAgICAg ICAgaWYgc2VsZi5vdXRwdXQ6CisgICAgICAgICAgICAgICAgcmV0dXJuIHNlbGYubWVzc2FnZSAr ICJcbiIgKyBzZWxmLm91dHB1dAorICAgICAgICAgICAgcmV0dXJuIHNlbGYubWVzc2FnZQogCiAg ICAgZGVmIG1lc3NhZ2Vfd2l0aF9vdXRwdXQoc2VsZiwgb3V0cHV0X2xpbWl0PTUwMCk6CiAgICAg ICAgIGlmIHNlbGYub3V0cHV0Ogo=