57886 2011-04-05 14:52:24 -0700 Defer repaints during style recalc 2011-04-05 15:30:00 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned oldest_to_newest 379871 0 koivisto 2011-04-05 14:52:24 -0700 We can reduce time spent invalidating system painting surface by deferring repaints in Document::recalcStyle(). We already do this for layouts. 379872 1 koivisto 2011-04-05 14:52:39 -0700 <rdar://problem/9192489> 379877 2 88312 koivisto 2011-04-05 14:59:28 -0700 Created attachment 88312 patch 379884 3 88312 darin 2011-04-05 15:02:24 -0700 Comment on attachment 88312 patch View in context: https://bugs.webkit.org/attachment.cgi?id=88312&action=review > Source/WebCore/dom/Document.cpp:1566 > - if (view()) > - view()->resumeScheduledEvents(); > + if (frameView) { Is there any change that view() could become 0 during the process of style recalculation? 379887 4 88312 darin 2011-04-05 15:02:58 -0700 Comment on attachment 88312 patch View in context: https://bugs.webkit.org/attachment.cgi?id=88312&action=review >> Source/WebCore/dom/Document.cpp:1566 >> + if (frameView) { > > Is there any change that view() could become 0 during the process of style recalculation? chance, not change > Source/WebCore/dom/Document.cpp:1568 > + frameView->endDeferredRepaints(); Is there any chance that repaints were already deferred and we are ending the deferral too soon? 379893 5 koivisto 2011-04-05 15:10:59 -0700 (In reply to comment #4) > > Is there any change that view() could become 0 during the process of style recalculation? That would probably indicate bug elsewhere Nevertheless, I switched to a protected pointer: RefPtr<FrameView> frameView = view(); > > Source/WebCore/dom/Document.cpp:1568 > > + frameView->endDeferredRepaints(); > > Is there any chance that repaints were already deferred and we are ending the deferral too soon? begin/endDeferredRepaints are counting. 379911 6 koivisto 2011-04-05 15:30:00 -0700 http://trac.webkit.org/changeset/82992 88312 2011-04-05 14:59:28 -0700 2011-04-05 15:02:58 -0700 patch recalcstyle-defer-repaints-2.patch text/plain 1949 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyOTgyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDUgIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01Nzg4NgorICAgICAgICBEZWZlciByZXBhaW50cyBkdXJpbmcgc3R5bGUgcmVjYWxjCisKKyAg ICAgICAgVGhpcyByZWR1Y2VzIHRoZSBuZWVkIHRvIGRvIChvZnRlbiBleHBlbnNpdmUpIHBsYXRm b3JtIHN1cmZhY2UgaW52YWxpZGF0aW9uLgorICAgICAgICBXZSBhbHJlYWR5IGRvIHRoaXMgZHVy aW5nIGxheW91dCBidXQgc3R5bGUgcmVjYWxjdWxhdGlvbiBtYXkgdHJpZ2dlcgorICAgICAgICBp bnZhbGlkYXRpb24gYXMgd2VsbC4KKyAgICAKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnJlY2FsY1N0eWxlKToKKwogMjAxMS0wNC0wNCAg Vml0YWx5IFJlcGVzaGtvICA8dml0YWx5ckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkocmV2aXNpb24g ODI2MzApCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xNTEzLDEzICsxNTEzLDE3IEBAIHZvaWQgRG9jdW1lbnQ6OnJlY2FsY1N0eWxlKFN0eWxl Q2hhbmdlIGMKICAgICBtX2luU3R5bGVSZWNhbGMgPSB0cnVlOwogICAgIHN1c3BlbmRQb3N0QXR0 YWNoQ2FsbGJhY2tzKCk7CiAgICAgUmVuZGVyV2lkZ2V0OjpzdXNwZW5kV2lkZ2V0SGllcmFyY2h5 VXBkYXRlcygpOwotICAgIGlmICh2aWV3KCkpCi0gICAgICAgIHZpZXcoKS0+cGF1c2VTY2hlZHVs ZWRFdmVudHMoKTsKICAgICAKKyAgICBGcmFtZVZpZXcqIGZyYW1lVmlldyA9IHZpZXcoKTsKKyAg ICBpZiAoZnJhbWVWaWV3KSB7CisgICAgICAgIGZyYW1lVmlldy0+cGF1c2VTY2hlZHVsZWRFdmVu dHMoKTsKKyAgICAgICAgZnJhbWVWaWV3LT5iZWdpbkRlZmVycmVkUmVwYWludHMoKTsKKyAgICB9 CisKICAgICBBU1NFUlQoIXJlbmRlcmVyKCkgfHwgcmVuZGVyQXJlbmEoKSk7CiAgICAgaWYgKCFy ZW5kZXJlcigpIHx8ICFyZW5kZXJBcmVuYSgpKQogICAgICAgICBnb3RvIGJhaWxfb3V0OwotICAg IAorCiAgICAgaWYgKG1fcGVuZGluZ1N0eWxlUmVjYWxjU2hvdWxkRm9yY2UpCiAgICAgICAgIGNo YW5nZSA9IEZvcmNlOwogCkBAIC0xNTU5LDggKzE1NjMsMTAgQEAgYmFpbF9vdXQ6CiAgICAgICAg IG1fdXNlc0xpbmtSdWxlcyA9IG1fc3R5bGVTZWxlY3Rvci0+dXNlc0xpbmtSdWxlcygpOwogICAg IH0KIAotICAgIGlmICh2aWV3KCkpCi0gICAgICAgIHZpZXcoKS0+cmVzdW1lU2NoZWR1bGVkRXZl bnRzKCk7CisgICAgaWYgKGZyYW1lVmlldykgeworICAgICAgICBmcmFtZVZpZXctPnJlc3VtZVNj aGVkdWxlZEV2ZW50cygpOworICAgICAgICBmcmFtZVZpZXctPmVuZERlZmVycmVkUmVwYWludHMo KTsKKyAgICB9CiAgICAgUmVuZGVyV2lkZ2V0OjpyZXN1bWVXaWRnZXRIaWVyYXJjaHlVcGRhdGVz KCk7CiAgICAgcmVzdW1lUG9zdEF0dGFjaENhbGxiYWNrcygpOwogICAgIG1faW5TdHlsZVJlY2Fs YyA9IGZhbHNlOwo=