57882 2011-04-05 13:54:43 -0700 [chromium] Don't have 'using namespace' declarations in header files 2011-04-05 16:00:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 thakis thakis commit-queue oldest_to_newest 379847 0 thakis 2011-04-05 13:54:43 -0700 [chromium] Don't have 'using namespace' declarations in header files 379849 1 88305 thakis 2011-04-05 13:55:33 -0700 Created attachment 88305 Patch 379850 2 88305 dglazkov 2011-04-05 13:57:45 -0700 Comment on attachment 88305 Patch k 379942 3 88305 commit-queue 2011-04-05 16:00:04 -0700 Comment on attachment 88305 Patch Clearing flags on attachment: 88305 Committed r82996: <http://trac.webkit.org/changeset/82996> 379943 4 commit-queue 2011-04-05 16:00:08 -0700 All reviewed patches have been landed. Closing bug. 88305 2011-04-05 13:55:33 -0700 2011-04-05 16:00:04 -0700 Patch bug-57882-20110405135532.patch text/plain 6943 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogODI5NDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MTVlOGM0YzVhNmU1ZWEzZmJkZTMzNjBlOThlMjU3MjVkNTQyMTQwZi4uYTI0M2Y2MjdjOWRjNTMz YWU2ZGQyNzdmNWM1YTUzYjQyMzg3ZDVmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOCBAQAorMjAxMS0wNC0wNSAgTmljbyBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2No cm9taXVtXSBEb24ndCBoYXZlICd1c2luZyBuYW1lc3BhY2UnIGRlY2xhcmF0aW9ucyBpbiBoZWFk ZXIgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU3ODgyCisKKyAgICAgICAgKiBzcmMvRXZlbnRMaXN0ZW5lcldyYXBwZXIuY3BwOgorICAgICAg ICAqIHNyYy9FdmVudExpc3RlbmVyV3JhcHBlci5oOgorICAgICAgICAqIHNyYy9WaWRlb0ZyYW1l Q2hyb21pdW1JbXBsLmg6CisgICAgICAgICogc3JjL1dlYkRPTUV2ZW50TGlzdGVuZXIuY3BwOgor ICAgICAgICAqIHNyYy9XZWJET01FdmVudExpc3RlbmVyUHJpdmF0ZS5jcHA6CisgICAgICAgICog c3JjL1dlYkRPTUV2ZW50TGlzdGVuZXJQcml2YXRlLmg6CisgICAgICAgIChXZWJLaXQ6OldlYkRP TUV2ZW50TGlzdGVuZXJQcml2YXRlOjpMaXN0ZW5lckluZm86Okxpc3RlbmVySW5mbyk6CisKIDIw MTEtMDQtMDUgIEhhbnMgV2VubmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIEJhcnRoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9FdmVudExpc3RlbmVyV3JhcHBlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9FdmVudExpc3RlbmVyV3JhcHBlci5jcHAKaW5kZXggNjM2MDkzMmU5MDdiNTg1NWY4MTY2Yjhl ZmVlMDI0ZDI5ODk4NmFiMy4uYjM1MmQ4MTUyNzY3MjkxYzE2MjdkMWQ4MDk3YWQ5ODI4ZjAyODdk MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRXZlbnRMaXN0ZW5lcldy YXBwZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0V2ZW50TGlzdGVuZXJX cmFwcGVyLmNwcApAQCAtMzcsNiArMzcsOCBAQAogI2luY2x1ZGUgIldlYkRPTUV2ZW50LmgiCiAj aW5jbHVkZSAiV2ViRE9NRXZlbnRMaXN0ZW5lci5oIgogCit1c2luZyBuYW1lc3BhY2UgV2ViQ29y ZTsKKwogbmFtZXNwYWNlIFdlYktpdCB7CiAKIEV2ZW50TGlzdGVuZXJXcmFwcGVyOjpFdmVudExp c3RlbmVyV3JhcHBlcihXZWJET01FdmVudExpc3RlbmVyKiB3ZWJET01FdmVudExpc3RlbmVyKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRXZlbnRMaXN0ZW5lcldyYXBw ZXIuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0V2ZW50TGlzdGVuZXJXcmFwcGVyLmgK aW5kZXggNzViNmE5NTFkNGViZDRhMmIzNDIzMGFiYTFlOWJkMmFhNGRiMzA1ZS4uODNlMWNmMTA0 NDNlMzAwZjExNGRhMmJmZTE1MTI4NjZmMTU4ZjQ1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvRXZlbnRMaXN0ZW5lcldyYXBwZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9FdmVudExpc3RlbmVyV3JhcHBlci5oCkBAIC0zNywyMSArMzcsMTkgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgU2NyaXB0RXhlY3V0aW9uQ29udGV4dDsKIH0KIAot dXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7Ci0KIG5hbWVzcGFjZSBXZWJLaXQgewogCiBjbGFzcyBX ZWJET01FdmVudExpc3RlbmVyOwogCiAvLyBGSVhNRTogUmVtb3ZlIHRoZSBEZXByZWNhdGVkRXZl bnRMaXN0ZW5lcldyYXBwZXIgY2xhc3MgYmVsb3cgb25jZSBDaHJvbWl1bQogLy8gc3dpdGNoZWQg dG8gdXNpbmcgV2ViRE9NRXZlbnQuCi1jbGFzcyBFdmVudExpc3RlbmVyV3JhcHBlciA6IHB1Ymxp YyBFdmVudExpc3RlbmVyIHsKK2NsYXNzIEV2ZW50TGlzdGVuZXJXcmFwcGVyIDogcHVibGljIFdl YkNvcmU6OkV2ZW50TGlzdGVuZXIgewogcHVibGljOgogICAgIEV2ZW50TGlzdGVuZXJXcmFwcGVy KFdlYkRPTUV2ZW50TGlzdGVuZXIqKTsKICAgICB+RXZlbnRMaXN0ZW5lcldyYXBwZXIoKTsKIAot ICAgIHZpcnR1YWwgYm9vbCBvcGVyYXRvcj09KGNvbnN0IEV2ZW50TGlzdGVuZXImKTsKLSAgICB2 aXJ0dWFsIHZvaWQgaGFuZGxlRXZlbnQoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIEV2ZW50Kik7 CisgICAgdmlydHVhbCBib29sIG9wZXJhdG9yPT0oY29uc3QgV2ViQ29yZTo6RXZlbnRMaXN0ZW5l ciYpOworICAgIHZpcnR1YWwgdm9pZCBoYW5kbGVFdmVudChXZWJDb3JlOjpTY3JpcHRFeGVjdXRp b25Db250ZXh0KiwgV2ViQ29yZTo6RXZlbnQqKTsKIAogICAgIHZvaWQgd2ViRE9NRXZlbnRMaXN0 ZW5lckRlbGV0ZWQoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv VmlkZW9GcmFtZUNocm9taXVtSW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvVmlk ZW9GcmFtZUNocm9taXVtSW1wbC5oCmluZGV4IGNhN2Y4OGIzZGY2N2Y2NWRlNmEzYTFiN2IwMDUw ZmMyOWU5NmI4MzUuLjQ0YTNjYzdlYzUxMzliMzFmMDJlMjQ4YmQ2NzVmMmVlYWI5YzRjNzMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1ZpZGVvRnJhbWVDaHJvbWl1bUlt cGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9WaWRlb0ZyYW1lQ2hyb21pdW1J bXBsLmgKQEAgLTM0LDE2ICszNCwxNCBAQAogI2luY2x1ZGUgIlZpZGVvRnJhbWVDaHJvbWl1bS5o IgogI2luY2x1ZGUgIldlYlZpZGVvRnJhbWUuaCIKIAotdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7 Ci0KIG5hbWVzcGFjZSBXZWJLaXQgewogCiAvLyBBIHdyYXBwZXIgY2xhc3MgZm9yIFdlYktpdDo6 V2ViVmlkZW9GcmFtZS4gT2JqZWN0cyBjYW4gYmUgY3JlYXRlZCBpbiBXZWJLaXQKIC8vIGFuZCB1 c2VkIGluIFdlYkNvcmUgYmVjYXVzZSBvZiB0aGUgVmlkZW9GcmFtZUNocm9taXVtIGludGVyZmFj ZS4KLWNsYXNzIFZpZGVvRnJhbWVDaHJvbWl1bUltcGwgOiBwdWJsaWMgVmlkZW9GcmFtZUNocm9t aXVtIHsKK2NsYXNzIFZpZGVvRnJhbWVDaHJvbWl1bUltcGwgOiBwdWJsaWMgV2ViQ29yZTo6Vmlk ZW9GcmFtZUNocm9taXVtIHsKIHB1YmxpYzoKICAgICAvLyBDb252ZXJ0cyBhIFdlYkNvcmU6OlZp ZGVvRnJhbWVDaHJvbWl1bSB0byBhIFdlYktpdDo6V2ViVmlkZW9GcmFtZS4KLSAgICBzdGF0aWMg V2ViVmlkZW9GcmFtZSogdG9XZWJWaWRlb0ZyYW1lKFZpZGVvRnJhbWVDaHJvbWl1bSopOworICAg IHN0YXRpYyBXZWJWaWRlb0ZyYW1lKiB0b1dlYlZpZGVvRnJhbWUoV2ViQ29yZTo6VmlkZW9GcmFt ZUNocm9taXVtKik7CiAKICAgICAvLyBDcmVhdGVzIGEgVmlkZW9GcmFtZUNocm9taXVtSW1wbCBv YmplY3QgdG8gd3JhcCB0aGUgZ2l2ZW4gV2ViVmlkZW9GcmFtZS4KICAgICAvLyBUaGUgVmlkZW9G cmFtZUNocm9taXVtSW1wbCBkb2VzIG5vdCB0YWtlIG93bmVyc2hpcCBvZiB0aGUgV2ViVmlkZW9G cmFtZQpAQCAtNTksNyArNTcsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBpbnQgc3RyaWRlKHVu c2lnbmVkIHBsYW5lKSBjb25zdDsKICAgICB2aXJ0dWFsIGNvbnN0IHZvaWQqIGRhdGEodW5zaWdu ZWQgcGxhbmUpIGNvbnN0OwogICAgIHZpcnR1YWwgdW5zaWduZWQgdGV4dHVyZSh1bnNpZ25lZCBw bGFuZSkgY29uc3Q7Ci0gICAgdmlydHVhbCBjb25zdCBJbnRTaXplIHJlcXVpcmVkVGV4dHVyZVNp emUodW5zaWduZWQgcGxhbmUpIGNvbnN0OworICAgIHZpcnR1YWwgY29uc3QgV2ViQ29yZTo6SW50 U2l6ZSByZXF1aXJlZFRleHR1cmVTaXplKHVuc2lnbmVkIHBsYW5lKSBjb25zdDsKICAgICB2aXJ0 dWFsIGJvb2wgaGFzUGFkZGluZ0J5dGVzKHVuc2lnbmVkIHBsYW5lKSBjb25zdDsKIAogcHJpdmF0 ZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRPTUV2ZW50TGlz dGVuZXIuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRE9NRXZlbnRMaXN0ZW5l ci5jcHAKaW5kZXggOTNjMTY0MGUyYmVkMTE0NTdjNmQzZTIzMGVkMjhjNTM5NWQ0ZWM2OC4uNTVk NzFhNzk5OGY5OTBmYTQ5NzM2ZTQ4ZDhkZTBhMDZjYjVjMmM4MiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRE9NRXZlbnRMaXN0ZW5lci5jcHAKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRE9NRXZlbnRMaXN0ZW5lci5jcHAKQEAgLTMzLDYgKzMz LDggQEAKIAogI2luY2x1ZGUgIldlYkRPTUV2ZW50TGlzdGVuZXJQcml2YXRlLmgiCiAKK3VzaW5n IG5hbWVzcGFjZSBXZWJDb3JlOworCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogV2ViRE9NRXZlbnRM aXN0ZW5lcjo6V2ViRE9NRXZlbnRMaXN0ZW5lcigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJET01FdmVudExpc3RlbmVyUHJpdmF0ZS5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJET01FdmVudExpc3RlbmVyUHJpdmF0ZS5jcHAKaW5kZXggNGVk YmVlZjNjNzA4NzlhYmRjYzdlMWQzNzRhZWE4ZmQyMDY3Njg1NS4uZmIwNTgyMzkzODUyZDUzYzU4 NWMwODk2Yjg2NjhlYWZiNGY0NThiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViRE9NRXZlbnRMaXN0ZW5lclByaXZhdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYkRPTUV2ZW50TGlzdGVuZXJQcml2YXRlLmNwcApAQCAtMzQsNiArMzQs OCBAQAogI2luY2x1ZGUgIkV2ZW50TGlzdGVuZXJXcmFwcGVyLmgiCiAjaW5jbHVkZSAiV2ViRE9N RXZlbnRMaXN0ZW5lci5oIgogCit1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKKwogbmFtZXNwYWNl IFdlYktpdCB7CiAKIFdlYkRPTUV2ZW50TGlzdGVuZXJQcml2YXRlOjpXZWJET01FdmVudExpc3Rl bmVyUHJpdmF0ZShXZWJET01FdmVudExpc3RlbmVyKiB3ZWJET01FdmVudExpc3RlbmVyKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRE9NRXZlbnRMaXN0ZW5lclBy aXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRPTUV2ZW50TGlzdGVuZXJQ cml2YXRlLmgKaW5kZXggYzg2ZjQyNzAwMTlmZTg1M2FlNDM0ZTcwZGY2MTg2NjY0ZTUyNGFkNC4u MmZlNDQzZmUyNjYzYjI4MDY3MWJlOThhMGUyNWQ1ZWRmYzI2M2VkNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRE9NRXZlbnRMaXN0ZW5lclByaXZhdGUuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJET01FdmVudExpc3RlbmVyUHJpdmF0ZS5o CkBAIC0zOSw4ICszOSw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNzIE5vZGU7CiB9CiAK LXVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwotCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogY2xhc3Mg RXZlbnRMaXN0ZW5lcldyYXBwZXI7CkBAIC01MiwxMiArNTAsMTIgQEAgcHVibGljOgogICAgIH5X ZWJET01FdmVudExpc3RlbmVyUHJpdmF0ZSgpOwogCiAgICAgRXZlbnRMaXN0ZW5lcldyYXBwZXIq IGNyZWF0ZUV2ZW50TGlzdGVuZXJXcmFwcGVyKAotICAgICAgICBjb25zdCBXZWJTdHJpbmcmIGV2 ZW50VHlwZSwgYm9vbCB1c2VDYXB0dXJlLCBOb2RlKiBub2RlKTsKKyAgICAgICAgY29uc3QgV2Vi U3RyaW5nJiBldmVudFR5cGUsIGJvb2wgdXNlQ2FwdHVyZSwgV2ViQ29yZTo6Tm9kZSopOwogCiAg ICAgLy8gR2V0cyB0aGUgTGlzdGVuZXJFdmVudFdyYXBwZXIgZm9yIGEgc3BlY2lmaWMgbm9kZS4K ICAgICAvLyBVc2VkIGJ5IFdlYk5vZGU6OnJlbW92ZURPTUV2ZW50TGlzdGVuZXIoKS4KICAgICBF dmVudExpc3RlbmVyV3JhcHBlciogZ2V0RXZlbnRMaXN0ZW5lcldyYXBwZXIoCi0gICAgICAgIGNv bnN0IFdlYlN0cmluZyYgZXZlbnRUeXBlLCBib29sIHVzZUNhcHR1cmUsIE5vZGUqIG5vZGUpOwor ICAgICAgICBjb25zdCBXZWJTdHJpbmcmIGV2ZW50VHlwZSwgYm9vbCB1c2VDYXB0dXJlLCBXZWJD b3JlOjpOb2RlKik7CiAKICAgICAvLyBDYWxsZWQgYnkgdGhlIFdlYkRPTUV2ZW50TGlzdGVuZXIg d2hlbiBpdCBpcyBhYm91dCB0byBiZSBkZWxldGVkLgogICAgIHZvaWQgd2ViRE9NRXZlbnRMaXN0 ZW5lckRlbGV0ZWQoKTsKQEAgLTY4LDcgKzY2LDcgQEAgcHVibGljOgogICAgIHN0cnVjdCBMaXN0 ZW5lckluZm8gewogICAgICAgICBMaXN0ZW5lckluZm8oY29uc3QgV2ViU3RyaW5nJiBldmVudFR5 cGUsIGJvb2wgdXNlQ2FwdHVyZSwKICAgICAgICAgICAgICAgICAgICAgIEV2ZW50TGlzdGVuZXJX cmFwcGVyKiBldmVudExpc3RlbmVyV3JhcHBlciwKLSAgICAgICAgICAgICAgICAgICAgIE5vZGUq IG5vZGUpCisgICAgICAgICAgICAgICAgICAgICBXZWJDb3JlOjpOb2RlKiBub2RlKQogICAgICAg ICAgICAgOiBldmVudFR5cGUoZXZlbnRUeXBlKQogICAgICAgICAgICAgLCB1c2VDYXB0dXJlKHVz ZUNhcHR1cmUpCiAgICAgICAgICAgICAsIGV2ZW50TGlzdGVuZXJXcmFwcGVyKGV2ZW50TGlzdGVu ZXJXcmFwcGVyKQpAQCAtNzksNyArNzcsNyBAQCBwdWJsaWM6CiAgICAgICAgIFdlYlN0cmluZyBl dmVudFR5cGU7CiAgICAgICAgIGJvb2wgdXNlQ2FwdHVyZTsKICAgICAgICAgRXZlbnRMaXN0ZW5l cldyYXBwZXIqIGV2ZW50TGlzdGVuZXJXcmFwcGVyOwotICAgICAgICBOb2RlKiBub2RlOworICAg ICAgICBXZWJDb3JlOjpOb2RlKiBub2RlOwogICAgIH07CiAKIHByaXZhdGU6Cg==