57861 2011-04-05 10:30:57 -0700 webkit-patch should print git's stderr when git svn dcommit fail 2017-07-18 08:30:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Other REOPENED P2 Normal --- 57913 1 morrita morrita abarth eric jberlin tony oldest_to_newest 379717 0 morrita 2011-04-05 10:30:57 -0700 webkit-patch gives no hint when dcommit fail, which makes diagnosis hard. 379739 1 88278 morrita 2011-04-05 10:53:50 -0700 Created attachment 88278 Patch 379771 2 88278 tony 2011-04-05 11:36:42 -0700 Comment on attachment 88278 Patch Rather than using isinstance, can we add a ScriptError __str__ method that prints the output? 379818 3 88298 morrita 2011-04-05 13:01:08 -0700 Created attachment 88298 Patch 379820 4 morrita 2011-04-05 13:02:56 -0700 Hi Tony, thank you for your prompt review! > (From update of attachment 88278 [details]) > Rather than using isinstance, can we add a ScriptError __str__ method that prints the output? Sure. I updated to do this. 379853 5 morrita 2011-04-05 14:04:26 -0700 Committed r82978: <http://trac.webkit.org/changeset/82978> 379900 6 jberlin 2011-04-05 15:17:51 -0700 (In reply to comment #5) > Committed r82978: <http://trac.webkit.org/changeset/82978> Looks like this broke SL and Windows webkit-py test: http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/27740/steps/webkitpy-test/logs/stdio http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/11247/steps/webkitpy-test/logs/stdio 380120 7 abarth 2011-04-05 22:06:28 -0700 I tried fixing this on the bots, but didn't succeed. We need a python2.5 test environment. 423255 8 eric 2011-06-18 13:51:35 -0700 Attachment 88298 was posted by a committer and has review+, assigning to Hajime Morita for commit. 423411 9 morrita 2011-06-19 18:21:48 -0700 This patch was landed, but rolled out due to mysterious regression. I have no idea for dealing with it. 525612 10 eric 2011-12-21 14:34:15 -0800 Attachment 88298 was posted by a committer and has review+, assigning to Hajime Morita for commit. 525945 11 88298 morrita 2011-12-21 20:09:36 -0800 Comment on attachment 88298 Patch Obsoleting the patch since it has some compatibility problem. 554158 12 88298 eric 2012-02-10 10:20:07 -0800 Comment on attachment 88298 Patch Cleared Adam Barth's review+ from obsolete attachment 88298 so that this bug does not appear in http://webkit.org/pending-commit. 88278 2011-04-05 10:53:50 -0700 2011-04-05 13:01:05 -0700 Patch bug-57861-20110405105349.patch text/plain 1221 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogODI5NTQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1MjgzYzJiYzkxNDA5OTBjNDEwZDQ5OGU4OGM4NWY1NzFk MTljMTY5Li43MmU4NzZjZmJjZGUzNDM0M2YyNmY3NTU4YjdkOTMwMmE4NWIzNGE5IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDQtMDUgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd2Via2l0LXBhdGNo IHNob3VsZCBwcmludCBnaXQncyBzdGRlcnIgd2hlbiBnaXQgc3ZuIGRjb21taXQgZmFpbAorICAg ICAgICBodHRwOi8vd2Via2l0Lm9yZy9iLzU3ODYxCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9jaGVja291dC9zY20ucHk6CisKIDIwMTEtMDQtMDUgIENzYWJhIE9zenRyb2dv bsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBMYXN6bG8gR29t Ym9zLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQv c2NtLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5Cmlu ZGV4IGU0MzY0MDIyYjExYjMxZTUyODZhZjA2NDA1OGExNzA0MDNmZGVhMjIuLjQxNmI2MjQ5MjIw ZjQ5YjdmYTkwMTY5NjM1NDZiZDQ4MjNmMDUxNmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9jaGVja291dC9zY20ucHkKQEAgLTg5Miw2ICs4OTIsOCBAQCBjbGFzcyBHaXQo U0NNKToKICAgICAgICAgICAgIG91dHB1dCA9IHNlbGYucHVzaF9sb2NhbF9jb21taXRzX3RvX3Nl cnZlcigpCiAgICAgICAgIGV4Y2VwdCBFeGNlcHRpb24sIGU6CiAgICAgICAgICAgICBsb2coIkNP TU1JVCBGQUlMRUQ6ICIgKyBzdHIoZSkpCisgICAgICAgICAgICBpZiBpc2luc3RhbmNlKGUsIFNj cmlwdEVycm9yKToKKyAgICAgICAgICAgICAgICBsb2coZS5vdXRwdXQpCiAgICAgICAgICAgICBv dXRwdXQgPSAiQ29tbWl0IGZhaWxlZC4iCiAgICAgICAgICAgICBjb21taXRfc3VjY2VlZGVkID0g RmFsc2UKICAgICAgICAgZmluYWxseToK 88298 2011-04-05 13:01:08 -0700 2012-02-10 10:20:07 -0800 Patch bug-57861-20110405130107.patch text/plain 2416 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogODI5NTQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1MjgzYzJiYzkxNDA5OTBjNDEwZDQ5OGU4OGM4NWY1NzFk MTljMTY5Li43MmU4NzZjZmJjZGUzNDM0M2YyNmY3NTU4YjdkOTMwMmE4NWIzNGE5IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDQtMDUgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd2Via2l0LXBhdGNo IHNob3VsZCBwcmludCBnaXQncyBzdGRlcnIgd2hlbiBnaXQgc3ZuIGRjb21taXQgZmFpbAorICAg ICAgICBodHRwOi8vd2Via2l0Lm9yZy9iLzU3ODYxCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9jaGVja291dC9zY20ucHk6CisKIDIwMTEtMDQtMDUgIENzYWJhIE9zenRyb2dv bsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBMYXN6bG8gR29t Ym9zLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4 ZWN1dGl2ZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRp dmUucHkKaW5kZXggN2QxOThkZDQzZWEyNTMyZjhhYzAwMjRjYWM0NDE2YzQ2ZmJkZmQ3MS4uNDFm MTA3NmY1M2E0NTVmYmM2MWJkNDYwMWZiMzJlYzc1N2M0ZTcxYyAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5CkBAIC04MSw2ICs4MSwx MSBAQCBjbGFzcyBTY3JpcHRFcnJvcihFeGNlcHRpb24pOgogICAgICAgICBzZWxmLm91dHB1dCA9 IG91dHB1dAogICAgICAgICBzZWxmLmN3ZCA9IGN3ZAogCisgICAgZGVmIF9fc3RyX18oc2VsZik6 CisgICAgICAgIGlmIHNlbGYub3V0cHV0OgorICAgICAgICAgICAgcmV0dXJuIHNlbGYubWVzc2Fn ZSArICJcbiIgKyBzZWxmLm91dHB1dAorICAgICAgICByZXR1cm4gc2VsZi5tZXNzYWdlCisKICAg ICBkZWYgbWVzc2FnZV93aXRoX291dHB1dChzZWxmLCBvdXRwdXRfbGltaXQ9NTAwKToKICAgICAg ICAgaWYgc2VsZi5vdXRwdXQ6CiAgICAgICAgICAgICBpZiBvdXRwdXRfbGltaXQgYW5kIGxlbihz ZWxmLm91dHB1dCkgPiBvdXRwdXRfbGltaXQ6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZV91bml0dGVzdC5weQppbmRleCA5YTE0 ZDZiMTc1MDdmNzUyZGNiMGY1NjU5NmU0MzdlZDQ1ZjhhNWY2Li5iZGE2N2VlYjcwZGMwZGYwOGM4 OGM1MDgwZjZlOGM4NTJmMjVhMjJlIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmVfdW5pdHRlc3QucHkKQEAgLTE5OSwzICsx OTksMTggQEAgY2xhc3MgRXhlY3V0aXZlVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAg IHNlbGYuYXNzZXJ0VHJ1ZShleGVjdXRpdmUuY2hlY2tfcnVubmluZ19waWQob3MuZ2V0cGlkKCkp KQogICAgICAgICAjIE1heGltdW0gcGlkIG51bWJlciBvbiBMaW51eCBpcyAzMjc2OCBieSBkZWZh dWx0CiAgICAgICAgIHNlbGYuYXNzZXJ0RmFsc2UoZXhlY3V0aXZlLmNoZWNrX3J1bm5pbmdfcGlk KDEwMDAwMCkpCisKKworY2xhc3MgU2NyaXB0RXJyb3JUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToK KworICAgIGRlZiB0ZXN0X3N0cl93aXRoX21lc3NhZ2Uoc2VsZik6CisgICAgICAgIHRyeToKKyAg ICAgICAgICAgIHJhaXNlIFNjcmlwdEVycm9yKG1lc3NhZ2U9Im1lc3NhZ2UiKQorICAgICAgICBl eGNlcHQgU2NyaXB0RXJyb3IsIGU6CisgICAgICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHN0cihl KSwgIm1lc3NhZ2UiKQorCisgICAgZGVmIHRlc3Rfc3RyX3dpdGhvdXRfbWVzc2FnZShzZWxmKToK KyAgICAgICAgdHJ5OgorICAgICAgICAgICAgcmFpc2UgU2NyaXB0RXJyb3Ioc2NyaXB0X2FyZ3M9 WyJlY2hvIiwgImhlbGxvIl0sIGV4aXRfY29kZT0xLCBjd2Q9Ii4vIiwgb3V0cHV0PSJPdXQiKQor ICAgICAgICBleGNlcHQgU2NyaXB0RXJyb3IsIGU6CisgICAgICAgICAgICBzZWxmLmFzc2VydEVx dWFsKHN0cihlKSwgIkZhaWxlZCB0byBydW4gXCJbJ2VjaG8nLCAnaGVsbG8nXVwiIGV4aXRfY29k ZTogMSBjd2Q6IC4vXG5PdXQiIiIpCg==