57853 2011-04-05 08:53:07 -0700 DeleteButtonController is given invalid style 2011-04-05 09:35:05 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 50949 0 leviw webkit-unassigned hyatt justin.garcia mitz rniwa oldest_to_newest 379601 0 leviw 2011-04-05 08:53:07 -0700 DeleteButtonController::createDeletionUI() sets CSSPropertyWebkitUserModify to CSSValueNone, which is not a valid value for user modify. Instead, it should be CSSValueReadOnly. I ran into an ASSERT_NOT_REACHED in WebCore::Node::rendererIsEditable() when trying to add the plaintext value to unicode-bidi for 50949. After my new CSS value is added, every test using the DeleteButtonController crashed the same way. I can't reproduce this without the new CSS value. Anyone know why? 379614 1 88245 leviw 2011-04-05 09:08:24 -0700 Created attachment 88245 Patch 379646 2 88245 leviw 2011-04-05 09:34:52 -0700 Comment on attachment 88245 Patch Clearing flags on attachment: 88245 Committed r82946: <http://trac.webkit.org/changeset/82946> 379647 3 leviw 2011-04-05 09:35:05 -0700 All reviewed patches have been landed. Closing bug. 88245 2011-04-05 09:08:24 -0700 2011-04-05 09:34:52 -0700 Patch bug-57853-20110405190822.patch text/plain 1704 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyOTQzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMDUgIExldmkgV2Vp bnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIERlbGV0ZUJ1dHRvbkNvbnRyb2xsZXIgaXMgZ2l2ZW4gaW52 YWxpZCBzdHlsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTc4NTMKKworICAgICAgICBEZWxldGVCdXR0b25Db250cm9sbGVyIHdhcyBhc3NpZ25lZCBh biBpbnZhbGlkIHN0eWxlIHRoYXQgY2FuIGxlYWQgdG8gYXNzZXJ0aW9ucworICAgICAgICBpbiBk ZWJ1ZyBidWlsZHMuIFRoaXMgbWF0Y2hlcyB1cCB0aGUgY29kZSB3aXRoIGl0cyBpbnRlbnQuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIHRoaXMgY2hhbmdlcyBub3RoaW5nIG9uIHJlbGVhc2Ug YnVpbGRzLgorCisgICAgICAgICogZWRpdGluZy9EZWxldGVCdXR0b25Db250cm9sbGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkRlbGV0ZUJ1dHRvbkNvbnRyb2xsZXI6OmNyZWF0ZURlbGV0aW9u VUkpOgorCiAyMDExLTA0LTA1ICBQYXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL0RlbGV0ZUJ1dHRvbkNvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRGVsZXRlQnV0dG9uQ29udHJvbGxlci5jcHAJKHJldmlz aW9uIDgyNDIwKQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxldGVCdXR0b25Db250cm9s bGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTkyLDcgKzE5Miw3IEBAIHZvaWQgRGVsZXRlQnV0 dG9uQ29udHJvbGxlcjo6Y3JlYXRlRGVsZXQKICAgICBDU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlv biogc3R5bGUgPSBjb250YWluZXItPmdldElubGluZVN0eWxlRGVjbCgpOwogICAgIHN0eWxlLT5z ZXRQcm9wZXJ0eShDU1NQcm9wZXJ0eVdlYmtpdFVzZXJEcmFnLCBDU1NWYWx1ZU5vbmUpOwogICAg IHN0eWxlLT5zZXRQcm9wZXJ0eShDU1NQcm9wZXJ0eVdlYmtpdFVzZXJTZWxlY3QsIENTU1ZhbHVl Tm9uZSk7Ci0gICAgc3R5bGUtPnNldFByb3BlcnR5KENTU1Byb3BlcnR5V2Via2l0VXNlck1vZGlm eSwgQ1NTVmFsdWVOb25lKTsKKyAgICBzdHlsZS0+c2V0UHJvcGVydHkoQ1NTUHJvcGVydHlXZWJr aXRVc2VyTW9kaWZ5LCBDU1NWYWx1ZVJlYWRPbmx5KTsKICAgICBzdHlsZS0+c2V0UHJvcGVydHko Q1NTUHJvcGVydHlWaXNpYmlsaXR5LCBDU1NWYWx1ZUhpZGRlbik7CiAgICAgc3R5bGUtPnNldFBy b3BlcnR5KENTU1Byb3BlcnR5UG9zaXRpb24sIENTU1ZhbHVlQWJzb2x1dGUpOwogICAgIHN0eWxl LT5zZXRQcm9wZXJ0eShDU1NQcm9wZXJ0eUN1cnNvciwgQ1NTVmFsdWVEZWZhdWx0KTsK