57847 2011-04-05 07:40:58 -0700 Crash logs not generated in 64-bit Windows 7 2011-04-08 10:43:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Enhancement --- 0 pere.martir4 webkit-unassigned ap aroben commit-queue sfalken oldest_to_newest 379545 0 88229 pere.martir4 2011-04-05 07:40:58 -0700 Created attachment 88229 Proposed patch run-webkit-tests doesn't find the correct location of ntsd.exe (NT Symbolic Debugger) in 64-bit Windows. To generate the crash logs, "Debugging Tools for Windows 32-bit Version" must be installed as indicated in http://trac.webkit.org/wiki/BuildingOnWindows#GettingCrashLogs Debugging Tools now comes with Windows SDK and the default installation directory (not likely configurable) in 64-bit Windows is: C:\Program Files\Debugging Tools for Windows (x64) Tools/Scripts/old-run-webkit-tests instead looks for: C:\Program Files (x86)/Debugging Tools for Windows (x86) Note that "the 64-bit versions of Debugging Tools for Windows allow you to debug both 32-bit and 64-bit user-mode applications running on 64-bit processors." 64-bit version of Debugging Tools is also the one installed by Windows SDK. I've modified old-run-webkit-tests and successfully generated the crash logs. 379740 1 ap 2011-04-05 10:55:56 -0700 This sounds very interesting! > http://trac.webkit.org/wiki/BuildingOnWindows#GettingCrashLogs That data should probably be in <http://www.webkit.org/quality/crashlogs.html>. Since WebKit site is in svn, one can just make a patch for it. 379741 2 88229 aroben 2011-04-05 11:00:32 -0700 Comment on attachment 88229 Proposed patch The code change here looks fine. Thanks for fixing the bug! However, your patch needs a ChangeLog. <http://www.webkit.org/coding/contributing.html> explains how to write one. 379743 3 aroben 2011-04-05 11:01:17 -0700 (In reply to comment #1) > This sounds very interesting! > > > http://trac.webkit.org/wiki/BuildingOnWindows#GettingCrashLogs > > That data should probably be in <http://www.webkit.org/quality/crashlogs.html>. Since WebKit site is in svn, one can just make a patch for it. The wiki page is specifically about getting run-webkit-tests to save crash logs automatically. The webkit.org page isn't specifically about run-webkit-tests. But maybe the info could be added there anyway. 379753 4 ap 2011-04-05 11:15:59 -0700 What I meant was that the webkit.org page didn't have any information about getting crash logs under Windows 7 at all. 379757 5 aroben 2011-04-05 11:24:46 -0700 Oh, I see. The webkit.org page should be changed to say "Windows Vista or Windows 7", since the same technique works on both. 380345 6 88412 pere.martir4 2011-04-06 07:25:57 -0700 Created attachment 88412 Proposed patch with ChangeLog Some other points should also be modified in the trac Wiki. * I wondered if the test script also works in 64-bit since the wiki says very explicitly - installing "32-bit" Debugging Tools. * The wiki page doesn't mention that the Registry value "ForceQueue" must be set to 1 so that the crash logs are stored automatically, otherwise some GUI dialogs will pop up and pause the test script. This is actually mentioned in http://www.webkit.org/quality/crashlogs.html 380368 7 aroben 2011-04-06 08:02:33 -0700 (In reply to comment #6) > Some other points should also be modified in the trac Wiki. Since it's a wiki, feel free to make the modifications yourself. > * I wondered if the test script also works in 64-bit since the wiki says very explicitly - installing "32-bit" Debugging Tools. I think we were just mistaken before that the 64-bit tools wouldn't work. (The 32-bit tools are still a good idea to have installed, though, since AFAIK you need the 32-bit tools for gflags to work, e.g.) > * The wiki page doesn't mention that the Registry value "ForceQueue" must be set > to 1 so that the crash logs are stored automatically, otherwise some > GUI dialogs will pop up and pause the test script. This is actually mentioned in http://www.webkit.org/quality/crashlogs.html The wiki page is all about getting run-webkit-tests's automatic crash log saving to work. Is ForceQueue really needed for that? run-webkit-tests installs a post-mortem debugger, which should prevent the WER dialog from appearing at all. 382256 8 aroben 2011-04-08 08:47:09 -0700 Pere, if you want your patch to be committed you should mark it cq?. 382271 9 88412 webkit.review.bot 2011-04-08 09:04:44 -0700 Comment on attachment 88412 Proposed patch with ChangeLog Rejecting attachment 88412 from commit-queue. pere.martir4@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 382274 10 88412 aroben 2011-04-08 09:08:25 -0700 Comment on attachment 88412 Proposed patch with ChangeLog Non-committers should mark patches cq?. Then a committer can mark it cq+. 382367 11 88412 commit-queue 2011-04-08 10:43:33 -0700 Comment on attachment 88412 Proposed patch with ChangeLog Clearing flags on attachment: 88412 Committed r83310: <http://trac.webkit.org/changeset/83310> 382368 12 commit-queue 2011-04-08 10:43:37 -0700 All reviewed patches have been landed. Closing bug. 88229 2011-04-05 07:40:58 -0700 2011-04-06 07:25:57 -0700 Proposed patch proposed_patch text/plain 1176 pere.martir4 SW5kZXg6IG9sZC1ydW4td2Via2l0LXRlc3RzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIG9sZC1ydW4td2Via2l0 LXRlc3RzCShyZXZpc2lvbiA4MjkzNykKKysrIG9sZC1ydW4td2Via2l0LXRlc3RzCSh3b3JraW5n IGNvcHkpCkBAIC0yNjY1LDEwICsyNjY1LDEzIEBAIHN1YiBzZXRVcFdpbmRvd3NDcmFzaExvZ1Nh dmluZygpCiAKICAgICBteSAkbnRzZFBhdGggPSBGaWxlOjpTcGVjLT5jYXRmaWxlKHRvQ3lnd2lu UGF0aCgkRU5We1BST0dSQU1GSUxFU30pLCAiRGVidWdnaW5nIFRvb2xzIGZvciBXaW5kb3dzICh4 ODYpIiwgIm50c2QuZXhlIik7CiAgICAgdW5sZXNzICgtZiAkbnRzZFBhdGgpIHsKLSAgICAgICAg JG50c2RQYXRoID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSh0b0N5Z3dpblBhdGgoJEVOVntTWVNURU1S T09UfSksICJzeXN0ZW0zMiIsICJudHNkLmV4ZSIpOworICAgICAgICAkbnRzZFBhdGggPSBGaWxl OjpTcGVjLT5jYXRmaWxlKHRvQ3lnd2luUGF0aCgkRU5We1Byb2dyYW1XNjQzMn0pLCAiRGVidWdn aW5nIFRvb2xzIGZvciBXaW5kb3dzICh4NjQpIiwgIm50c2QuZXhlIik7CiAgICAgICAgIHVubGVz cyAoLWYgJG50c2RQYXRoKSB7Ci0gICAgICAgICAgICBwcmludCBTVERFUlIgIkNhbid0IGZpbmQg bnRzZC5leGUuIENyYXNoIGxvZ3Mgd2lsbCBub3QgYmUgc2F2ZWQuXG5TZWUgPGh0dHA6Ly90cmFj LndlYmtpdC5vcmcvd2lraS9CdWlsZGluZ09uV2luZG93cyNHZXR0aW5nQ3Jhc2hMb2dzPi5cbiI7 Ci0gICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICAkbnRzZFBhdGggPSBGaWxlOjpTcGVj LT5jYXRmaWxlKHRvQ3lnd2luUGF0aCgkRU5We1NZU1RFTVJPT1R9KSwgInN5c3RlbTMyIiwgIm50 c2QuZXhlIik7CisgICAgICAgICAgICB1bmxlc3MgKC1mICRudHNkUGF0aCkgeworICAgICAgICAg ICAgICAgIHByaW50IFNUREVSUiAiQ2FuJ3QgZmluZCBudHNkLmV4ZS4gQ3Jhc2ggbG9ncyB3aWxs IG5vdCBiZSBzYXZlZC5cblNlZSA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy93aWtpL0J1aWxkaW5n T25XaW5kb3dzI0dldHRpbmdDcmFzaExvZ3M+LlxuIjsKKyAgICAgICAgICAgICAgICByZXR1cm47 CisgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CiAK 88412 2011-04-06 07:25:57 -0700 2011-04-08 10:43:33 -0700 Proposed patch with ChangeLog bug57847-fix text/plain 1790 pere.martir4 SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDgzMDQzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTEtMDQtMDYgIFBlcmUgTWFydGlyICA8cGVyZS5tYXJ0aXI0QGdtYWlsLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMb2Nh dGUgTlNURC5FWEUgaW4gNjQtYml0IFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU3ODQ3CisKKyAgICAgICAgKiBTY3JpcHRzL29sZC1ydW4t d2Via2l0LXRlc3RzOgorCiAyMDExLTA0LTA1ICBLZXZpbiBPbGxpdmllciAgPGtldmlub0B0aGVv bGxpdmllcnMuY29tPgogCiAgICAgICAgIFt3eF0gTWFjIGJ1aWxkIGZpeC4gSGFuZGxlIGNhc2Vz IHdoZXJlIDEwLjQgU0RLIGlzIG5vdCBpbnN0YWxsZWQsIGFuZCBhbHNvIGFkZCB4ODZfNjQgYXJj aApJbmRleDogVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCShyZXZpc2lvbiA4Mjk1MCkKKysr IFRvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMJKHdvcmtpbmcgY29weSkKQEAgLTI2 NjUsMTAgKzI2NjUsMTMgQEAgc3ViIHNldFVwV2luZG93c0NyYXNoTG9nU2F2aW5nKCkKIAogICAg IG15ICRudHNkUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGZpbGUodG9DeWd3aW5QYXRoKCRFTlZ7UFJP R1JBTUZJTEVTfSksICJEZWJ1Z2dpbmcgVG9vbHMgZm9yIFdpbmRvd3MgKHg4NikiLCAibnRzZC5l eGUiKTsKICAgICB1bmxlc3MgKC1mICRudHNkUGF0aCkgewotICAgICAgICAkbnRzZFBhdGggPSBG aWxlOjpTcGVjLT5jYXRmaWxlKHRvQ3lnd2luUGF0aCgkRU5We1NZU1RFTVJPT1R9KSwgInN5c3Rl bTMyIiwgIm50c2QuZXhlIik7CisgICAgICAgICRudHNkUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGZp bGUodG9DeWd3aW5QYXRoKCRFTlZ7UHJvZ3JhbVc2NDMyfSksICJEZWJ1Z2dpbmcgVG9vbHMgZm9y IFdpbmRvd3MgKHg2NCkiLCAibnRzZC5leGUiKTsKICAgICAgICAgdW5sZXNzICgtZiAkbnRzZFBh dGgpIHsKLSAgICAgICAgICAgIHByaW50IFNUREVSUiAiQ2FuJ3QgZmluZCBudHNkLmV4ZS4gQ3Jh c2ggbG9ncyB3aWxsIG5vdCBiZSBzYXZlZC5cblNlZSA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy93 aWtpL0J1aWxkaW5nT25XaW5kb3dzI0dldHRpbmdDcmFzaExvZ3M+LlxuIjsKLSAgICAgICAgICAg IHJldHVybjsKKyAgICAgICAgICAgICRudHNkUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGZpbGUodG9D eWd3aW5QYXRoKCRFTlZ7U1lTVEVNUk9PVH0pLCAic3lzdGVtMzIiLCAibnRzZC5leGUiKTsKKyAg ICAgICAgICAgIHVubGVzcyAoLWYgJG50c2RQYXRoKSB7CisgICAgICAgICAgICAgICAgcHJpbnQg U1RERVJSICJDYW4ndCBmaW5kIG50c2QuZXhlLiBDcmFzaCBsb2dzIHdpbGwgbm90IGJlIHNhdmVk LlxuU2VlIDxodHRwOi8vdHJhYy53ZWJraXQub3JnL3dpa2kvQnVpbGRpbmdPbldpbmRvd3MjR2V0 dGluZ0NyYXNoTG9ncz4uXG4iOworICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAg IH0KICAgICAgICAgfQogICAgIH0KIAo=