57846 2011-04-05 07:38:12 -0700 ORWT shouldn't generate diff files for tests without expected files 2011-04-06 09:07:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 ossy webkit-unassigned abarth eric jhoneycutt mrowe webkit.review.bot oldest_to_newest 379542 0 ossy 2011-04-05 07:38:12 -0700 Now old-run-webkit-tests creates a zero sized actual-result.txt, and then generate a useless diff and a pretty diff file for all tests without checked in expected file. The original changeset was: http://trac.webkit.org/changeset/46607 379550 1 88231 ossy 2011-04-05 07:43:40 -0700 Created attachment 88231 proposed fix With this modification won't break the original goal of http://trac.webkit.org/changeset/46607 , links to the new test results will work, but we shouldn't generate useless zero bytes sized expected.txt and a diff and pretty diff file. 379555 2 88231 ossy 2011-04-05 07:46:22 -0700 Comment on attachment 88231 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=88231&action=review > Tools/Scripts/old-run-webkit-tests:2113 > + if ( !-f $expectedResultPath) { ooops, an additional space typo. I'm going to fix it before landing. 380361 3 88231 abecsi 2011-04-06 07:56:38 -0700 Comment on attachment 88231 proposed fix LGTM. 380417 4 ossy 2011-04-06 08:49:06 -0700 Landed in http://trac.webkit.org/changeset/83055 380451 5 webkit.review.bot 2011-04-06 09:07:58 -0700 http://trac.webkit.org/changeset/83055 might have broken WinCairo Debug (Build) 88231 2011-04-05 07:43:40 -0700 2011-04-06 08:49:16 -0700 proposed fix 1.patch text/plain 1481 ossy ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNGVi OTgzLi42MzE2MzRjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDQtMDUgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBPUldUIHNob3VsZG4ndCBnZW5lcmF0ZSBkaWZmIGZpbGVzIGZvciB0ZXN0cyB3 aXRob3V0IGV4cGVjdGVkIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01Nzg0NgorCisgICAgICAgICogU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10 ZXN0czoKKwogMjAxMS0wNC0wNSAgSmFkZSBIYW4gIDxqYWRlLmhhbkBub2tpYS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgTGFzemxvIEdvbWJvcy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMgYi9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRl c3RzCmluZGV4IGQ2NzliZjAuLmUzNDNlZjQgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvb2xk LXJ1bi13ZWJraXQtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0 cwpAQCAtMjEwOSwxMyArMjEwOSwxMyBAQCBzdWIgcmVjb3JkQWN0dWFsUmVzdWx0c0FuZERpZmYo JCQpCiAgICAgbWtwYXRoKGRpcm5hbWUoJGFjdHVhbFJlc3VsdHNQYXRoKSk7CiAgICAgd3JpdGVU b0ZpbGUoIiRhY3R1YWxSZXN1bHRzUGF0aCIsICRhY3R1YWxSZXN1bHRzKTsKIAotICAgIGlmICgt ZiAkZXhwZWN0ZWRSZXN1bHRQYXRoKSB7Ci0gICAgICAgIGNvcHkoIiRleHBlY3RlZFJlc3VsdFBh dGgiLCAiJGNvcGllZEV4cGVjdGVkUmVzdWx0c1BhdGgiKTsKLSAgICB9IGVsc2UgewotICAgICAg ICBvcGVuIEVNUFRZLCAiPiRjb3BpZWRFeHBlY3RlZFJlc3VsdHNQYXRoIjsKLSAgICAgICAgY2xv c2UgRU1QVFk7CisgICAgIyBXZSBkb24ndCBuZWVkIGRpZmYgYW5kIHByZXR0eSBkaWZmIGZvciB0 ZXN0cyB3aXRob3V0IGV4cGVjdGVkIGZpbGUuCisgICAgaWYgKCAhLWYgJGV4cGVjdGVkUmVzdWx0 UGF0aCkgeworICAgICAgICByZXR1cm47CiAgICAgfQogCisgICAgY29weSgiJGV4cGVjdGVkUmVz dWx0UGF0aCIsICIkY29waWVkRXhwZWN0ZWRSZXN1bHRzUGF0aCIpOworCiAgICAgbXkgJGRpZmZP dXB1dEJhc2VQYXRoID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkdGVzdFJlc3VsdHNEaXJlY3Rvcnks ICRiYXNlKTsKICAgICBteSAkZGlmZk91dHB1dFBhdGggPSAiJGRpZmZPdXB1dEJhc2VQYXRoLSRk aWZmc1RhZy50eHQiOwogICAgIHN5c3RlbSAiZGlmZiAtdSBcIiRjb3BpZWRFeHBlY3RlZFJlc3Vs dHNQYXRoXCIgXCIkYWN0dWFsUmVzdWx0c1BhdGhcIiA+IFwiJGRpZmZPdXRwdXRQYXRoXCIiOwo=