57839 2011-04-05 06:19:37 -0700 [Qt] [Symbian] the include file for symbian should be case sensitive 2011-04-06 09:09:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED Qt, QtTriaged P2 Normal --- 0 liang.qi webkit-unassigned benjamin commit-queue jturcotte s.mathur oldest_to_newest 379497 0 liang.qi 2011-04-05 06:19:37 -0700 In Source/JavaScriptCore/wtf/PageAllocatorSymbian.h, it includes #include <wtf/BitMap.h> But the real file name is Bitmap.h. Then it should be #include <wtf/Bitmap.h> Otherwise, it will break the makefile build system for armcc & gcce. 379503 1 88217 liang.qi 2011-04-05 06:25:28 -0700 Created attachment 88217 A patch to fix the include file name for wtf/PageAllocatorSymbian.h 379511 2 jturcotte 2011-04-05 06:34:57 -0700 Some stuff to fix in you Changelog entry: - Specify this bug's URL instead of the bug number for quick access. - Leave a blank line between the URL and the patch long description. - In "Correct a include file name.", "a" should be written "an". See there if you want more information: http://trac.webkit.org/wiki/QtWebKitContrib Have a look at previous entries in Changelogs, this should give you a reliable template. 379514 3 jturcotte 2011-04-05 06:37:55 -0700 Don't forget to press Details on your attachment and set the review flag to "?" if you want your patch to appear in the review queue ( webkit.org/pending-review ). Set the commit-queue flag to "?" as well if you want your patch to be committed automatically once it got approved. 379515 4 s.mathur 2011-04-05 06:38:25 -0700 Please also fix the rationale to simply say that "Use correct case of file name so as to work on Unix/Linux build hosts" or similar. This has nothing to do with Makefile/ARMCC/GCCE 379521 5 88220 liang.qi 2011-04-05 06:57:05 -0700 Created attachment 88220 A patch to fix the include file name for wtf/PageAllocatorSymbian.h Update the changelog. 379522 6 s.mathur 2011-04-05 06:59:40 -0700 (In reply to comment #5) > Created an attachment (id=88220) [details] > A patch to fix the include file name for wtf/PageAllocatorSymbian.h > > Update the changelog. Looks good. Many thanks. ( I am not a reviewer, so someone else will have to bless it with r+) 379523 7 88221 liang.qi 2011-04-05 07:02:25 -0700 Created attachment 88221 A patch to fix the include file name for wtf/PageAllocatorSymbian.h 380262 8 88221 benjamin 2011-04-06 04:45:53 -0700 Comment on attachment 88221 A patch to fix the include file name for wtf/PageAllocatorSymbian.h Good catch. 380264 9 88221 commit-queue 2011-04-06 04:48:52 -0700 Comment on attachment 88221 A patch to fix the include file name for wtf/PageAllocatorSymbian.h Rejecting attachment 88221 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: iled to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Benjamin Poulain', u'-..." exit_code: 2 Parsed 2 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog patch: **** malformed patch at line 17: 2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com> patching file Source/JavaScriptCore/wtf/PageAllocatorSymbian.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Benjamin Poulain', u'-..." exit_code: 2 Full output: http://queues.webkit.org/results/8341193 380377 10 88423 liang.qi 2011-04-06 08:09:37 -0700 Created attachment 88423 A patch to fix the include file name for wtf/PageAllocatorSymbian.h 380378 11 88423 benjamin 2011-04-06 08:10:38 -0700 Comment on attachment 88423 A patch to fix the include file name for wtf/PageAllocatorSymbian.h Let's try again. 380448 12 commit-queue 2011-04-06 09:07:19 -0700 The commit-queue encountered the following flaky tests while processing attachment 88423: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 380454 13 88423 commit-queue 2011-04-06 09:09:35 -0700 Comment on attachment 88423 A patch to fix the include file name for wtf/PageAllocatorSymbian.h Clearing flags on attachment: 88423 Committed r83059: <http://trac.webkit.org/changeset/83059> 380455 14 commit-queue 2011-04-06 09:09:40 -0700 All reviewed patches have been landed. Closing bug. 88217 2011-04-05 06:25:28 -0700 2011-04-05 06:57:05 -0700 A patch to fix the include file name for wtf/PageAllocatorSymbian.h liangqi-57839.txt text/plain 1097 liang.qi SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODI5MzEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAK KzIwMTEtMDQtMDUgIExpYW5nIFFpICA8bGlhbmcucWlAbm9raWEuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvcnJlY3QgYSBpbmNsdWRlIGZp bGUgbmFtZS4KKyAgICAgICAgKGJ1ZyAjNTc4MzkgLSBbUXRdIFtTeW1iaWFuXSB0aGUgaW5jbHVk ZSBmaWxlIGZvciBzeW1iaWFuIHNob3VsZCBiZSBjYXNlIHNlbnNpdGl2ZSkuCisgICAgICAgIEl0 IHNob3VsZCBiZSBjYXNlIHNlbnNpdGl2ZS4gT3RoZXJ3aXNlIGl0IHdpbGwgYnJlYWsgdGhlIG1h a2VmaWxlIGJ1aWxkIHN5c3RlbSB3aXRoIGFybWNjIGFuZCBnY2NlLgorCisgICAgICAgICogd3Rm L1BhZ2VBbGxvY2F0b3JTeW1iaWFuLmg6CisKIDIwMTEtMDQtMDUgIE5pa29sYXMgWmltbWVybWFu biAgPG56aW1tZXJtYW5uQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBL bGluZy4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGFnZUFsbG9jYXRvclN5bWJp YW4uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BhZ2VBbGxvY2F0 b3JTeW1iaWFuLmgJKHJldmlzaW9uIDgyOTMxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0 Zi9QYWdlQWxsb2NhdG9yU3ltYmlhbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw3ICszMCw3IEBA CiAjZGVmaW5lIFBhZ2VBbGxvY2F0b3JTeW1iaWFuX2gKIAogI2luY2x1ZGUgPGUzMnN0ZC5oPgot I2luY2x1ZGUgPHd0Zi9CaXRNYXAuaD4KKyNpbmNsdWRlIDx3dGYvQml0bWFwLmg+CiAKIG5hbWVz cGFjZSBXVEYgeyAKIAo= 88220 2011-04-05 06:57:05 -0700 2011-04-05 07:02:25 -0700 A patch to fix the include file name for wtf/PageAllocatorSymbian.h liangqi-57839.txt text/plain 1018 liang.qi SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODI5MzEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAK KzIwMTEtMDQtMDUgIExpYW5nIFFpICA8bGlhbmcucWlAbm9raWEuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01NzgzOQorICAgICAgICBDb3JyZWN0IGEgaW5jbHVkZSBmaWxl IG5hbWUuCisgICAgICAgIEl0IHNob3VsZCBiZSBjYXNlIHNlbnNpdGl2ZS4gVGhpcyBmaXggYnVp bGRzIG9uIFVuaXggaG9zdHMuCisKKyAgICAgICAgKiB3dGYvUGFnZUFsbG9jYXRvclN5bWJpYW4u aDoKKwogMjAxMS0wNC0wNSAgTmlrb2xhcyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5AcmltLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL3d0Zi9QYWdlQWxsb2NhdG9yU3ltYmlhbi5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGFnZUFsbG9jYXRvclN5bWJpYW4uaAkocmV2aXNpb24g ODI5MzEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BhZ2VBbGxvY2F0b3JTeW1iaWFu LmgJKHdvcmtpbmcgY29weSkKQEAgLTMwLDcgKzMwLDcgQEAKICNkZWZpbmUgUGFnZUFsbG9jYXRv clN5bWJpYW5faAogCiAjaW5jbHVkZSA8ZTMyc3RkLmg+Ci0jaW5jbHVkZSA8d3RmL0JpdE1hcC5o PgorI2luY2x1ZGUgPHd0Zi9CaXRtYXAuaD4KIAogbmFtZXNwYWNlIFdURiB7IAogCg== 88221 2011-04-05 07:02:25 -0700 2011-04-06 08:09:37 -0700 A patch to fix the include file name for wtf/PageAllocatorSymbian.h liangqi-57839.txt text/plain 1020 liang.qi SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODI5MzEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAK KzIwMTEtMDQtMDUgIExpYW5nIFFpICA8bGlhbmcucWlAbm9raWEuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvcnJlY3QgYSBpbmNsdWRlIGZp bGUgbmFtZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU3ODM5CisKKyAgICAgICAgSXQgc2hvdWxkIGJlIGNhc2Ugc2Vuc2l0aXZlLiBUaGlzIGZpeCBi dWlsZHMgb24gVW5peCBob3N0cy4KKworICAgICAgICAqIHd0Zi9QYWdlQWxsb2NhdG9yU3ltYmlh bi5oOgorCiAyMDExLTA0LTA1ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0u Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvd3RmL1BhZ2VBbGxvY2F0b3JTeW1iaWFuLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QYWdlQWxsb2NhdG9yU3ltYmlhbi5oCShyZXZpc2lv biA4MjkzMSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGFnZUFsbG9jYXRvclN5bWJp YW4uaAkod29ya2luZyBjb3B5KQpAQCAtMzAsNyArMzAsNyBAQAogI2RlZmluZSBQYWdlQWxsb2Nh dG9yU3ltYmlhbl9oCiAKICNpbmNsdWRlIDxlMzJzdGQuaD4KLSNpbmNsdWRlIDx3dGYvQml0TWFw Lmg+CisjaW5jbHVkZSA8d3RmL0JpdG1hcC5oPgogCiBuYW1lc3BhY2UgV1RGIHsgCiAK 88423 2011-04-06 08:09:37 -0700 2011-04-06 09:09:35 -0700 A patch to fix the include file name for wtf/PageAllocatorSymbian.h 57839.patch text/plain 980 liang.qi ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDFiMzhkODkuLjg0NjU0ZjkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTA0LTA2ICBMaWFuZyBRaSAgPGxp YW5nLnFpQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDb3JyZWN0IGEgaW5jbHVkZSBmaWxlIG5hbWUuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzgzOQorCisgICAgICAgICogd3RmL1Bh Z2VBbGxvY2F0b3JTeW1iaWFuLmg6IEl0IHNob3VsZCBiZSBjYXNlIHNlbnNpdGl2ZS4gVGhpcyBm aXggCisgICAgICAgIGJ1aWxkcyBvbiBVbml4IGhvc3RzLgorCiAyMDExLTA0LTA1ICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgVHJ5IHRvIGZpeCB0aGUgV2lu ZG93cyBidWlsZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGFnZUFs bG9jYXRvclN5bWJpYW4uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGFnZUFsbG9jYXRv clN5bWJpYW4uaAppbmRleCA0OGE4NDY0Li5lYmE1YjAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvd3RmL1BhZ2VBbGxvY2F0b3JTeW1iaWFuLmgKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9QYWdlQWxsb2NhdG9yU3ltYmlhbi5oCkBAIC0zMCw3ICszMCw3IEBACiAj ZGVmaW5lIFBhZ2VBbGxvY2F0b3JTeW1iaWFuX2gKIAogI2luY2x1ZGUgPGUzMnN0ZC5oPgotI2lu Y2x1ZGUgPHd0Zi9CaXRNYXAuaD4KKyNpbmNsdWRlIDx3dGYvQml0bWFwLmg+CiAKIG5hbWVzcGFj ZSBXVEYgeyAKIAo=