57838 2011-04-05 06:15:01 -0700 Switch from Vector<UChar> to StringBuilder in bindings/ 2011-04-05 06:40:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zimmermann zimmermann kling oldest_to_newest 379495 0 zimmermann 2011-04-05 06:15:01 -0700 As discussed in bug 56099, we should deploy StringBuilder usage in WebCore where possible. This bug addresses Source/WebCore/bindings. 379498 1 88215 zimmermann 2011-04-05 06:20:19 -0700 Created attachment 88215 Patch 379512 2 88215 kling 2011-04-05 06:35:27 -0700 Comment on attachment 88215 Patch LGTM 379517 3 zimmermann 2011-04-05 06:40:00 -0700 Landed in r82935. 88215 2011-04-05 06:20:19 -0700 2011-04-05 06:35:27 -0700 Patch Cleanup3.diff text/plain 4533 zimmermann SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyOTMxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMDUgIE5pa29sYXMg WmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3dpdGNoIGZyb20gVmVjdG9yPFVDaGFyPiB0byBT dHJpbmdCdWlsZGVyIGluIGJpbmRpbmdzLworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTc4MzgKKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTQ1NTU3R5 bGVEZWNsYXJhdGlvbkN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjc3NQcm9wZXJ0eU5h bWUpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOENTU1N0eWxlRGVjbGFyYXRpb25D dXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3NzUHJvcGVydHlJbmZvKToKKwogMjAxMS0w NC0wNSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pT Q1NTU3R5bGVEZWNsYXJhdGlvbkN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNDU1NTdHlsZURlY2xhcmF0aW9uQ3VzdG9tLmNwcAkocmV2aXNpb24g ODE5NjApCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NTU1N0eWxlRGVjbGFyYXRp b25DdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw2ICszNCw4IEBACiAjaW5jbHVkZSA8 cnVudGltZS9TdHJpbmdQcm90b3R5cGUuaD4KICNpbmNsdWRlIDx3dGYvQVNDSUlDVHlwZS5oPgog I2luY2x1ZGUgPHd0Zi90ZXh0L0F0b21pY1N0cmluZy5oPgorI2luY2x1ZGUgPHd0Zi90ZXh0L1N0 cmluZ0J1aWxkZXIuaD4KKyNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdDb25jYXRlbmF0ZS5oPgog CiB1c2luZyBuYW1lc3BhY2UgSlNDOwogdXNpbmcgbmFtZXNwYWNlIFdURjsKQEAgLTk0LDggKzk2 LDggQEAgc3RhdGljIFN0cmluZyBjc3NQcm9wZXJ0eU5hbWUoY29uc3QgSWRlbgogICAgIGlmICgh bGVuZ3RoKQogICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAKLSAgICBWZWN0b3I8VUNoYXI+IG5h bWU7Ci0gICAgbmFtZS5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KGxlbmd0aCk7CisgICAgU3RyaW5n QnVpbGRlciBidWlsZGVyOworICAgIGJ1aWxkZXIucmVzZXJ2ZUNhcGFjaXR5KGxlbmd0aCk7CiAK ICAgICB1bnNpZ25lZCBpID0gMDsKIApAQCAtMTEyLDI1ICsxMTQsMjMgQEAgc3RhdGljIFN0cmlu ZyBjc3NQcm9wZXJ0eU5hbWUoY29uc3QgSWRlbgogICAgIH0gZWxzZSBpZiAoaGFzQ1NTUHJvcGVy dHlOYW1lUHJlZml4KHByb3BlcnR5TmFtZSwgIndlYmtpdCIpCiAgICAgICAgICAgICB8fCBoYXND U1NQcm9wZXJ0eU5hbWVQcmVmaXgocHJvcGVydHlOYW1lLCAia2h0bWwiKQogICAgICAgICAgICAg fHwgaGFzQ1NTUHJvcGVydHlOYW1lUHJlZml4KHByb3BlcnR5TmFtZSwgImFwcGxlIikpCi0gICAg ICAgIG5hbWUuYXBwZW5kKCctJyk7CisgICAgICAgIGJ1aWxkZXIuYXBwZW5kKCctJyk7CiAgICAg ZWxzZSB7CiAgICAgICAgIGlmIChpc0FTQ0lJVXBwZXIocHJvcGVydHlOYW1lLmNoYXJhY3RlcnMo KVswXSkpCiAgICAgICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAgICAgfQogCi0gICAgbmFtZS5h cHBlbmQodG9BU0NJSUxvd2VyKHByb3BlcnR5TmFtZS5jaGFyYWN0ZXJzKClbaSsrXSkpOworICAg IGJ1aWxkZXIuYXBwZW5kKHRvQVNDSUlMb3dlcihwcm9wZXJ0eU5hbWUuY2hhcmFjdGVycygpW2kr K10pKTsKIAogICAgIGZvciAoOyBpIDwgbGVuZ3RoOyArK2kpIHsKICAgICAgICAgVUNoYXIgYyA9 IHByb3BlcnR5TmFtZS5jaGFyYWN0ZXJzKClbaV07CiAgICAgICAgIGlmICghaXNBU0NJSVVwcGVy KGMpKQotICAgICAgICAgICAgbmFtZS5hcHBlbmQoYyk7Ci0gICAgICAgIGVsc2UgewotICAgICAg ICAgICAgbmFtZS5hcHBlbmQoJy0nKTsKLSAgICAgICAgICAgIG5hbWUuYXBwZW5kKHRvQVNDSUlM b3dlcihjKSk7Ci0gICAgICAgIH0KKyAgICAgICAgICAgIGJ1aWxkZXIuYXBwZW5kKGMpOworICAg ICAgICBlbHNlCisgICAgICAgICAgICBidWlsZGVyLmFwcGVuZChtYWtlU3RyaW5nKCctJywgdG9B U0NJSUxvd2VyKGMpKSk7CiAgICAgfQogCi0gICAgcmV0dXJuIFN0cmluZzo6YWRvcHQobmFtZSk7 CisgICAgcmV0dXJuIGJ1aWxkZXIudG9TdHJpbmcoKTsKIH0KIAogc3RhdGljIGJvb2wgaXNDU1NQ cm9wZXJ0eU5hbWUoY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lKQpJbmRleDogU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q1NTU3R5bGVEZWNsYXJhdGlvbkN1c3RvbS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q1NT U3R5bGVEZWNsYXJhdGlvbkN1c3RvbS5jcHAJKHJldmlzaW9uIDgxOTYwKQorKysgU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q1NTU3R5bGVEZWNsYXJhdGlvbkN1c3RvbS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQwLDYgKzQwLDggQEAKICNpbmNsdWRlICJWOEJpbmRpbmcuaCIK ICNpbmNsdWRlICJWOFByb3h5LmgiCiAKKyNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdCdWlsZGVy Lmg+CisjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nQ29uY2F0ZW5hdGUuaD4KICNpbmNsdWRlIDx3 dGYvQVNDSUlDVHlwZS5oPgogI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CiAjaW5jbHVkZSA8 d3RmL1JlZlB0ci5oPgpAQCAtMTA3LDggKzEwOSw4IEBAIHN0YXRpYyBDU1NQcm9wZXJ0eUluZm8q IGNzc1Byb3BlcnR5SW5mbygKICAgICAgICAgaWYgKCFsZW5ndGgpCiAgICAgICAgICAgICByZXR1 cm4gMDsKIAotICAgICAgICBWZWN0b3I8VUNoYXI+IG5hbWU7Ci0gICAgICAgIG5hbWUucmVzZXJ2 ZUNhcGFjaXR5KGxlbmd0aCk7CisgICAgICAgIFN0cmluZ0J1aWxkZXIgYnVpbGRlcjsKKyAgICAg ICAgYnVpbGRlci5yZXNlcnZlQ2FwYWNpdHkobGVuZ3RoKTsKIAogICAgICAgICB1bnNpZ25lZCBp ID0gMDsKIApAQCAtMTIzLDIzICsxMjUsMjEgQEAgc3RhdGljIENTU1Byb3BlcnR5SW5mbyogY3Nz UHJvcGVydHlJbmZvKAogICAgICAgICB9IGVsc2UgaWYgKGhhc0NTU1Byb3BlcnR5TmFtZVByZWZp eChwcm9wZXJ0eU5hbWUsICJ3ZWJraXQiKQogICAgICAgICAgICAgICAgIHx8IGhhc0NTU1Byb3Bl cnR5TmFtZVByZWZpeChwcm9wZXJ0eU5hbWUsICJraHRtbCIpCiAgICAgICAgICAgICAgICAgfHwg aGFzQ1NTUHJvcGVydHlOYW1lUHJlZml4KHByb3BlcnR5TmFtZSwgImFwcGxlIikpCi0gICAgICAg ICAgICBuYW1lLmFwcGVuZCgnLScpOworICAgICAgICAgICAgYnVpbGRlci5hcHBlbmQoJy0nKTsK ICAgICAgICAgZWxzZSBpZiAoV1RGOjppc0FTQ0lJVXBwZXIocHJvcGVydHlOYW1lWzBdKSkKICAg ICAgICAgICAgIHJldHVybiAwOwogCi0gICAgICAgIG5hbWUuYXBwZW5kKFdURjo6dG9BU0NJSUxv d2VyKHByb3BlcnR5TmFtZVtpKytdKSk7CisgICAgICAgIGJ1aWxkZXIuYXBwZW5kKFdURjo6dG9B U0NJSUxvd2VyKHByb3BlcnR5TmFtZVtpKytdKSk7CiAKICAgICAgICAgZm9yICg7IGkgPCBsZW5n dGg7ICsraSkgewogICAgICAgICAgICAgVUNoYXIgYyA9IHByb3BlcnR5TmFtZVtpXTsKICAgICAg ICAgICAgIGlmICghV1RGOjppc0FTQ0lJVXBwZXIoYykpCi0gICAgICAgICAgICAgICAgbmFtZS5h cHBlbmQoYyk7Ci0gICAgICAgICAgICBlbHNlIHsKLSAgICAgICAgICAgICAgICBuYW1lLmFwcGVu ZCgnLScpOwotICAgICAgICAgICAgICAgIG5hbWUuYXBwZW5kKFdURjo6dG9BU0NJSUxvd2VyKGMp KTsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICBidWlsZGVyLmFwcGVuZChjKTsKKyAg ICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBidWlsZGVyLmFwcGVuZChtYWtlU3RyaW5n KCctJywgdG9BU0NJSUxvd2VyKGMpKSk7CiAgICAgICAgIH0KIAotICAgICAgICBTdHJpbmcgcHJv cE5hbWUgPSBTdHJpbmc6OmFkb3B0KG5hbWUpOworICAgICAgICBTdHJpbmcgcHJvcE5hbWUgPSBi dWlsZGVyLnRvU3RyaW5nKCk7CiAgICAgICAgIGludCBwcm9wZXJ0eUlEID0gY3NzUHJvcGVydHlJ RChwcm9wTmFtZSk7CiAgICAgICAgIGlmIChwcm9wZXJ0eUlEKSB7CiAgICAgICAgICAgICBwcm9w SW5mbyA9IG5ldyBDU1NQcm9wZXJ0eUluZm8oKTsK