57830 2011-04-05 05:22:06 -0700 Web Inspector:Duplicated display of storage db when running Web SQL from an iframe 2011-04-14 05:32:36 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 loislo webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 379461 0 88204 loislo 2011-04-05 05:22:06 -0700 Created attachment 88204 test1.html What steps will reproduce the problem? 1. Go to page with iframe and a database in it 2. See the Storage section in the dev tools 3. Every time the iframe is loaded the icon of the database is duplicated What is the expected output? Show one single instance of the database in the dev tools What do you see instead? A duplicate for every reload 379462 1 88205 loislo 2011-04-05 05:22:33 -0700 Created attachment 88205 parent.html 379465 2 88206 loislo 2011-04-05 05:36:17 -0700 Created attachment 88206 [patch] initial version 379484 3 88206 pfeldman 2011-04-05 05:55:59 -0700 Comment on attachment 88206 [patch] initial version View in context: https://bugs.webkit.org/attachment.cgi?id=88206&action=review > Source/WebCore/inspector/InspectorDatabaseAgent.cpp:224 > + resource->setDatabase(database); What is this needed for? 385596 4 88206 loislo 2011-04-14 02:09:19 -0700 Comment on attachment 88206 [patch] initial version This patch covers typical use cases. The page reopens Database and we have to update our internal ref to it because the old instance of DB usually has been closed. 385670 5 88206 loislo 2011-04-14 05:32:29 -0700 Comment on attachment 88206 [patch] initial version Clearing flags on attachment: 88206 Committed r83841: <http://trac.webkit.org/changeset/83841> 385671 6 loislo 2011-04-14 05:32:36 -0700 All reviewed patches have been landed. Closing bug. 88204 2011-04-05 05:22:06 -0700 2011-04-05 05:22:06 -0700 test1.html test1.html text/html 2038 loislo PCFET0NUWVBFIGh0bWw+CjxodG1sPjxoZWFkPjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlw ZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PUlTTy04ODU5LTEiPgoKPHRpdGxlPmRiIGFu ZCBhcHAgY2FjaGU8L3RpdGxlPgoKPHN0eWxlIHR5cGU9InRleHQvY3NzIiBtZWRpYT0ic2NyZWVu Ij4KICBib2R5IHsgZm9udDogNzUlICJMdWNpZGEgR3JhbmRlIiwgIlRyZWJ1Y2hldCBNUyIsIFZl cmRhbmEsIHNhbnMtc2VyaWY7IH0KICBoMiB7IGZvbnQtc2l6ZTogMTUwJTsgfQogIHByZSB7IGJh Y2tncm91bmQtY29sb3I6ICNlZWU7IGZvbnQtc2l6ZTogMTIwJTsgZGlzcGxheTogaW5saW5lLWJs b2NrOyB9CiAgLm5vdGUgeyBmb250LXdlaWdodDogYm9sZDsgZm9udC1zaXplOiAxMjAlO30KPC9z dHlsZT4KPC9oZWFkPgo8Ym9keT4KCQoJPGRpdj4KICAKICA8YnV0dG9uIG9uY2xpY2s9Im5ld19y ZWcoKSI+bmV3IG5vdGU8L2J1dHRvbj4KICA8YnV0dG9uIG9uY2xpY2s9ImRyb3BfdGFibGUoKSI+ ZHJvcCB0YWJsZTwvYnV0dG9uPgoKCjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFy c2V0PSJ1dGYtOCI+CiAgdmFyIGRiOwogIGRiID0gb3BlbkRhdGFiYXNlKCJEQlRlc3QiLCAiMS4w IiwgIkhUTUw1IERhdGFiYXNlIEFQSSBleGFtcGxlIiwgMjAwMDAwLCBmdW5jdGlvbihkYikgewog ICAgY29uc29sZS5sb2coJ2RhdGFiYXNlIG9wZW5lZCcpOwogIH0pOwogIAogIGRiLnRyYW5zYWN0 aW9uKGZ1bmN0aW9uKHR4KSB7CiAgICB0eC5leGVjdXRlU3FsKCJTRUxFQ1QgQ09VTlQoKikgRlJP TSBUYWJsZTFUZXN0IiwgW10sIGZ1bmN0aW9uKHJlc3VsdCkgewogICAgICBjb25zb2xlLmxvZygn dGFibGUgVGFibGUxVGVzdCBhbHJlYWR5IGV4aXN0ZWQuIHdlIHNraXAgYW55IGFjdGlvbi4nKQog ICAgfSwgCiAgICBmdW5jdGlvbih0eCwgZXJyb3IpIHsKICAgICAgY29uc29sZS5sb2coJ3RhYmxl IFRhYmxlMVRlc3QgZG9lc250IGV4aXN0LiBDcmVhdGluZyBpdCcpCiAgICAgIHR4LmV4ZWN1dGVT cWwoIkNSRUFURSBUQUJMRSBUYWJsZTFUZXN0IChpZCBSRUFMIFVOSVFVRSwgbm90ZSBURVhUKSIs IFtdLCBmdW5jdGlvbihyZXN1bHQpIHsgCiAgICAgICAgY29uc29sZS5sb2coJ1RhYmxlMVRlc3Qg Y3JlYXRlZCcpCiAgICAgIH0sCiAgICAgIGZ1bmN0aW9uKHR4LCBlcnJvcikgewogICAgICAgIGNv bnNvbGUuZXJyb3IoJ2Vycm9yIGNyZWF0aW5nIFRhYmxlMVRlc3QgdGFibGUnKTsKICAgICAgICBj b25zb2xlLmVycm9yKGVycm9yKQogICAgICB9KTsKICAgIH0pOwogIH0pOwogIAogIAogIGZ1bmN0 aW9uIG5ld19yZWcoKSB7CiAgICB2YXIgbnVtID0gTWF0aC5yb3VuZChNYXRoLnJhbmRvbSgpICog MTAwMDApOwogICAgZGIudHJhbnNhY3Rpb24oZnVuY3Rpb24odHgpIHsKICAgICAgdHguZXhlY3V0 ZVNxbCgiSU5TRVJUIElOVE8gVGFibGUxVGVzdCAoaWQsIG5vdGUpIFZBTFVFUyAoPywgPykiLCBb bnVtLCAobnVtICogMikgKyAnJ10sIGZ1bmN0aW9uKHR4KSB7CiAgICAgICAgY29uc29sZS5sb2co J3JlZ2lzdGVyIGFkZGVkJykKICAgICAgfSwgCiAgICAgIGZ1bmN0aW9uKHR4LCBlcnJvcikgewog ICAgICAgIGNvbnNvbGUuZXJyb3IoJ2Vycm9yIGFkZGluZyByZWdpc3RlcicpCiAgICAgICAgY29u c29sZS5lcnJvcihlcnJvcikKICAgICAgfSk7CiAgICB9KTsKICB9CgoKICBmdW5jdGlvbiBkcm9w X3RhYmxlKCkgewogICAgZGIudHJhbnNhY3Rpb24oZnVuY3Rpb24odHgpIHsKICAgICAgdHguZXhl Y3V0ZVNxbCgiRFJPUCBUQUJMRSBUYWJsZTFUZXN0IiwgW10sIGZ1bmN0aW9uKHR4KSB7CiAgICAg ICAgY29uc29sZS5sb2coJ1RhYmxlMVRlc3QgZHJvcHBlZCcpCiAgICAgIH0sIAogICAgICBmdW5j dGlvbih0eCwgZXJyb3IpIHsKICAgICAgICBjb25zb2xlLmVycm9yKCdlcnJvciBkcm9wcGluZyBU YWJsZTFUZXN0JykKICAgICAgICBjb25zb2xlLmVycm9yKGVycm9yKQogICAgICB9KTsKICAgIH0p OwogIH0KCiAgCjwvc2NyaXB0Pgo8L2Rpdj4KPC9ib2R5Pgo8L2h0bWw+Cg== 88205 2011-04-05 05:22:33 -0700 2011-04-05 05:22:33 -0700 parent.html test2.html text/html 1143 loislo PCFET0NUWVBFIGh0bWw+CjxodG1sPjxoZWFkPjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlw ZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PUlTTy04ODU5LTEiPgoKPHRpdGxlPmRiIGFu ZCBhcHAgY2FjaGU8L3RpdGxlPgoKPHN0eWxlIHR5cGU9InRleHQvY3NzIiBtZWRpYT0ic2NyZWVu Ij4KICBib2R5IHsgZm9udDogNzUlICJMdWNpZGEgR3JhbmRlIiwgIlRyZWJ1Y2hldCBNUyIsIFZl cmRhbmEsIHNhbnMtc2VyaWY7IH0KICBoMiB7IGZvbnQtc2l6ZTogMTUwJTsgfQogIHByZSB7IGJh Y2tncm91bmQtY29sb3I6ICNlZWU7IGZvbnQtc2l6ZTogMTIwJTsgZGlzcGxheTogaW5saW5lLWJs b2NrOyB9CiAgLm5vdGUgeyBmb250LXdlaWdodDogYm9sZDsgZm9udC1zaXplOiAxMjAlO30KPC9z dHlsZT4KPC9oZWFkPgo8Ym9keT4KCQoKICAKICA8aWZyYW1lIGlkPSJpZnIiIHNyYz0iLi90ZXN0 Ml9maWxlcy90ZXN0MS5odG1sIj48L2lmcmFtZT4KICA8YnV0dG9uIG9uY2xpY2s9InJlbG9hZF9p ZnJhbWUoKSI+cmVsb2FkIGlmcmFtZTwvYnV0dG9uPgoKPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFz Y3JpcHQiIGNoYXJzZXQ9InV0Zi04Ij4KICBmdW5jdGlvbiByZWxvYWRfaWZyYW1lKCkgewogICAg ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2lmcicpLnNyYyA9ICd0ZXN0MS5odG1sJzsKICAgIHZh ciBkYjsKICAgIGRiID0gb3BlbkRhdGFiYXNlKCJEQlRlc3QiLCAiMS4wIiwgIkhUTUw1IERhdGFi YXNlIEFQSSBleGFtcGxlIiwgMjAwMDAwLCBmdW5jdGlvbihkYikgewogICAgICBjb25zb2xlLmxv ZygnZGF0YWJhc2Ugb3BlbmVkJyk7CiAgICB9KTsKICAKICAgIGRiLnRyYW5zYWN0aW9uKGZ1bmN0 aW9uKHR4KSB7CiAgICAgIHR4LmV4ZWN1dGVTcWwoIlNFTEVDVCBDT1VOVCgqKSBGUk9NIFRhYmxl MVRlc3QiCiAgICAgICAgLCBbXQogICAgICAgICwgZnVuY3Rpb24ocmVzdWx0KSB7IGNvbnNvbGUu bG9nKCd0YWJsZSBUYWJsZTFUZXN0IGFscmVhZHkgZXhpc3RlZC4nKTsgfQogICAgICAgICwgZnVu Y3Rpb24odHgsIGVycm9yKSB7IGNvbnNvbGUubG9nKCd0YWJsZSBUYWJsZTFUZXN0IGRvZXNudCBl eGlzdC4nKTt9ICk7CiAgICB9KTsKICAKICAgIAogIH0KPC9zY3JpcHQ+Cgo8L2JvZHk+CjwvaHRt bD4K 88206 2011-04-05 05:36:17 -0700 2011-04-14 05:32:29 -0700 [patch] initial version patch text/plain 3648 loislo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMjU1MDMzLi4xNjMyYzViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTEtMDQtMDUgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6RHVwbGljYXRlZCBkaXNwbGF5IG9mIHN0b3JhZ2UgZGIgd2hlbiBydW5uaW5nIFdlYiBT UUwgZnJvbSBhbiBpZnJhbWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01NzgzMAorCisgICAgICAgIFRoZXJlIHdhcyBjcmVhdGVkIGEgbmV3IEluc3Bl Y3RvckRhdGFiYXNlUmVzb3VyY2UgZW50cnkgZm9yIGV2ZXJ5IGRpZE9wZW5EYXRhYmFzZSBldmVu dC4KKyAgICAgICAgTW9yZW92ZXIgdGhlcmUgaXMgbmV3IFdlYkNvcmU6OkRhdGFiYXNlIGZvciBl YWNoIGRpZE9wZW5EYXRhYmFzZSBldmVudC4KKyAgICAgICAgSSBkZWNpZGVkIHRvIGNoYW5nZSB0 aGUgb2xkIGluc3RhbmNlIG9mIHRoZSBEYXRhYmFzZSB0byBhIG5ldyBvbmUgaWYgdGhleSBib3Ro IHVzZSB0aGUgc2FtZSBmaWxlLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckRhdGFi YXNlQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRGF0YWJhc2VBZ2VudDo6 ZGlkT3BlbkRhdGFiYXNlKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckRhdGFiYXNlQWdl bnQ6OmZpbmRCeUZpbGVOYW1lKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRGF0YWJh c2VBZ2VudC5oOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JEYXRhYmFzZVJlc291cmNl Lmg6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JEYXRhYmFzZVJlc291cmNlOjpzZXREYXRh YmFzZSk6CisKIDIwMTEtMDQtMDQgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIEFkZCBhIGNhc2UgbGFiZWwgd2hpY2ggd2FzIHVuZXhwZWN0ZWRseSByZW1vdmVk IGluIHI4Mjg5OS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JEYXRhYmFzZUFnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JE YXRhYmFzZUFnZW50LmNwcAppbmRleCA3ZjZlMzc5Li5jNTdlNDBjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRGF0YWJhc2VBZ2VudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRhdGFiYXNlQWdlbnQuY3BwCkBAIC0yMjAs NiArMjIwLDExIEBAIHByaXZhdGU6CiAKIHZvaWQgSW5zcGVjdG9yRGF0YWJhc2VBZ2VudDo6ZGlk T3BlbkRhdGFiYXNlKFBhc3NSZWZQdHI8RGF0YWJhc2U+IGRhdGFiYXNlLCBjb25zdCBTdHJpbmcm IGRvbWFpbiwgY29uc3QgU3RyaW5nJiBuYW1lLCBjb25zdCBTdHJpbmcmIHZlcnNpb24pCiB7Cisg ICAgaWYgKEluc3BlY3RvckRhdGFiYXNlUmVzb3VyY2UqIHJlc291cmNlID0gZmluZEJ5RmlsZU5h bWUoZGF0YWJhc2UtPmZpbGVOYW1lKCkpKSB7CisgICAgICAgIHJlc291cmNlLT5zZXREYXRhYmFz ZShkYXRhYmFzZSk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBSZWZQdHI8SW5zcGVj dG9yRGF0YWJhc2VSZXNvdXJjZT4gcmVzb3VyY2UgPSBJbnNwZWN0b3JEYXRhYmFzZVJlc291cmNl OjpjcmVhdGUoZGF0YWJhc2UsIGRvbWFpbiwgbmFtZSwgdmVyc2lvbik7CiAgICAgbV9yZXNvdXJj ZXMuc2V0KHJlc291cmNlLT5pZCgpLCByZXNvdXJjZSk7CiAgICAgLy8gUmVzb3VyY2VzIGFyZSBv bmx5IGJvdW5kIHdoaWxlIHZpc2libGUuCkBAIC0yOTMsNiArMjk4LDE1IEBAIGludCBJbnNwZWN0 b3JEYXRhYmFzZUFnZW50OjpkYXRhYmFzZUlkKERhdGFiYXNlKiBkYXRhYmFzZSkKICAgICByZXR1 cm4gMDsKIH0KIAorSW5zcGVjdG9yRGF0YWJhc2VSZXNvdXJjZSogSW5zcGVjdG9yRGF0YWJhc2VB Z2VudDo6ZmluZEJ5RmlsZU5hbWUoY29uc3QgU3RyaW5nJiBmaWxlTmFtZSkKK3sKKyAgICBmb3Ig KERhdGFiYXNlUmVzb3VyY2VzTWFwOjppdGVyYXRvciBpdCA9IG1fcmVzb3VyY2VzLmJlZ2luKCk7 IGl0ICE9IG1fcmVzb3VyY2VzLmVuZCgpOyArK2l0KSB7CisgICAgICAgIGlmIChpdC0+c2Vjb25k LT5kYXRhYmFzZSgpLT5maWxlTmFtZSgpID09IGZpbGVOYW1lKQorICAgICAgICAgICAgcmV0dXJu IGl0LT5zZWNvbmQuZ2V0KCk7CisgICAgfQorICAgIHJldHVybiAwOworfQorCiBEYXRhYmFzZSog SW5zcGVjdG9yRGF0YWJhc2VBZ2VudDo6ZGF0YWJhc2VGb3JJZChpbnQgZGF0YWJhc2VJZCkKIHsK ICAgICBEYXRhYmFzZVJlc291cmNlc01hcDo6aXRlcmF0b3IgaXQgPSBtX3Jlc291cmNlcy5maW5k KGRhdGFiYXNlSWQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvckRhdGFiYXNlQWdlbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JE YXRhYmFzZUFnZW50LmgKaW5kZXggNDVmYmZhNC4uZjg1NGE2ZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRhdGFiYXNlQWdlbnQuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRGF0YWJhc2VBZ2VudC5oCkBAIC03MCw2ICs3MCw3 IEBAIHByaXZhdGU6CiAgICAgZXhwbGljaXQgSW5zcGVjdG9yRGF0YWJhc2VBZ2VudChJbnN0cnVt ZW50aW5nQWdlbnRzKik7CiAKICAgICBEYXRhYmFzZSogZGF0YWJhc2VGb3JJZChpbnQgZGF0YWJh c2VJZCk7CisgICAgSW5zcGVjdG9yRGF0YWJhc2VSZXNvdXJjZSogZmluZEJ5RmlsZU5hbWUoY29u c3QgU3RyaW5nJiBmaWxlTmFtZSk7CiAKICAgICBJbnN0cnVtZW50aW5nQWdlbnRzKiBtX2luc3Ry dW1lbnRpbmdBZ2VudHM7CiAgICAgdHlwZWRlZiBIYXNoTWFwPGludCwgUmVmUHRyPEluc3BlY3Rv ckRhdGFiYXNlUmVzb3VyY2U+ID4gRGF0YWJhc2VSZXNvdXJjZXNNYXA7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRGF0YWJhc2VSZXNvdXJjZS5oIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRhdGFiYXNlUmVzb3VyY2UuaAppbmRleCA5 ZmE3ZWJkLi4yODE1NjhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yRGF0YWJhc2VSZXNvdXJjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JEYXRhYmFzZVJlc291cmNlLmgKQEAgLTQ4LDYgKzQ4LDcgQEAgcHVibGljOgogCiAg ICAgdm9pZCBiaW5kKEluc3BlY3RvckZyb250ZW5kOjpEYXRhYmFzZSopOwogICAgIERhdGFiYXNl KiBkYXRhYmFzZSgpIHsgcmV0dXJuIG1fZGF0YWJhc2UuZ2V0KCk7IH0KKyAgICB2b2lkIHNldERh dGFiYXNlKFBhc3NSZWZQdHI8RGF0YWJhc2U+IGRhdGFiYXNlKSB7IG1fZGF0YWJhc2UgPSBkYXRh YmFzZTsgfQogICAgIGludCBpZCgpIGNvbnN0IHsgcmV0dXJuIG1faWQ7IH0KIAogcHJpdmF0ZToK