57823 2011-04-05 02:42:23 -0700 [Qt] Make URL loader accessible from testbrowser's menus 2011-04-05 04:08:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 zoltan zoltan abarth eric webkit.review.bot oldest_to_newest 379405 0 zoltan 2011-04-05 02:42:23 -0700 Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu. 379406 1 88194 zoltan 2011-04-05 02:43:16 -0700 Created attachment 88194 proposed patch 379409 2 88194 kling 2011-04-05 02:46:17 -0700 Comment on attachment 88194 proposed patch Sure, LGTM 379420 3 zoltan 2011-04-05 03:35:42 -0700 Committed r82919: <http://trac.webkit.org/changeset/82919> 379431 4 webkit.review.bot 2011-04-05 04:03:18 -0700 http://trac.webkit.org/changeset/82919 might have broken Qt Linux Release minimal 379436 5 zoltan 2011-04-05 04:08:00 -0700 Minimal fixed in r82922. 88194 2011-04-05 02:43:16 -0700 2011-04-05 02:46:17 -0700 proposed patch urlloadermenu.patch text/plain 6518 zoltan ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2YTVi MTU3Li4xZDgyMGU4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDQtMDUgIFpvbHRhbiBIb3J2YXRoICA8em9s dGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1F0XSBNYWtlIFVSTCBsb2FkZXIgYWNjZXNzaWJsZSBmcm9tIHRlc3Ricm93c2Vy J3MgbWVudXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU3ODIzCisKKyAgICAgICAgQWRkICJMb2FkIFVSTHMgZnJvbSBmaWxlIiB0byBRdFRlc3RCcm93 c2VyJ3MgYW5kIHRvIE1pbmlCcm93c2VyJ3MgbWVudS4KKworICAgICAgICAqIE1pbmlCcm93c2Vy L3F0L0Jyb3dzZXJXaW5kb3cuY3BwOgorICAgICAgICAoQnJvd3NlcldpbmRvdzo6QnJvd3Nlcldp bmRvdyk6CisgICAgICAgIChCcm93c2VyV2luZG93Ojpsb2FkVVJMTGlzdEZyb21GaWxlKToKKyAg ICAgICAgKEJyb3dzZXJXaW5kb3c6On5Ccm93c2VyV2luZG93KToKKyAgICAgICAgKiBNaW5pQnJv d3Nlci9xdC9Ccm93c2VyV2luZG93Lmg6CisgICAgICAgICogUXRUZXN0QnJvd3Nlci9sYXVuY2hl cndpbmRvdy5jcHA6CisgICAgICAgIChMYXVuY2hlcldpbmRvdzo6TGF1bmNoZXJXaW5kb3cpOgor ICAgICAgICAoTGF1bmNoZXJXaW5kb3c6On5MYXVuY2hlcldpbmRvdyk6CisgICAgICAgIChMYXVu Y2hlcldpbmRvdzo6Y3JlYXRlQ2hyb21lKToKKyAgICAgICAgKExhdW5jaGVyV2luZG93Ojpsb2Fk VVJMTGlzdEZyb21GaWxlKToKKyAgICAgICAgKiBRdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93 Lmg6CisKIDIwMTEtMDQtMDIgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEdlb2ZmIEdhcmVuLgpkaWZmIC0tZ2l0IGEvVG9vbHMvTWlu aUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5jcHAgYi9Ub29scy9NaW5pQnJvd3Nlci9xdC9Ccm93 c2VyV2luZG93LmNwcAppbmRleCA1M2Y3ZGU5Li4zODAwNDg0IDEwMDY0NAotLS0gYS9Ub29scy9N aW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmNwcAorKysgYi9Ub29scy9NaW5pQnJvd3Nlci9x dC9Ccm93c2VyV2luZG93LmNwcApAQCAtMjgsNiArMjgsNyBAQAogCiAjaW5jbHVkZSAiQnJvd3Nl cldpbmRvdy5oIgogCisjaW5jbHVkZSAiVXJsTG9hZGVyLmgiCiAjaW5jbHVkZSAicXdrcHJlZmVy ZW5jZXMuaCIKIAogc3RhdGljIFFXS1BhZ2UqIG5ld1BhZ2VGdW5jdGlvbihRV0tQYWdlKiBwYWdl KQpAQCAtNDEsNiArNDIsNyBAQCBRVmVjdG9yPHFyZWFsPiBCcm93c2VyV2luZG93OjptX3pvb21M ZXZlbHM7CiBCcm93c2VyV2luZG93OjpCcm93c2VyV2luZG93KFFXS0NvbnRleHQqIGNvbnRleHQs IFdpbmRvd09wdGlvbnMqIG9wdGlvbnMpCiAgICAgOiBtX2lzWm9vbVRleHRPbmx5KGZhbHNlKQog ICAgICwgbV9jdXJyZW50Wm9vbSgxKQorICAgICwgbV91cmxMb2FkZXIoMCkKICAgICAsIG1fY29u dGV4dChjb250ZXh0KQogewogICAgIGlmIChvcHRpb25zKQpAQCAtMTA2LDYgKzEwOCw4IEBAIEJy b3dzZXJXaW5kb3c6OkJyb3dzZXJXaW5kb3coUVdLQ29udGV4dCogY29udGV4dCwgV2luZG93T3B0 aW9ucyogb3B0aW9ucykKICAgICB0b2dnbGVGcmFtZUZsYXR0ZW5pbmctPnNldENoZWNrZWQoZmFs c2UpOwogICAgIHRvb2xzTWVudS0+YWRkU2VwYXJhdG9yKCk7CiAgICAgdG9vbHNNZW51LT5hZGRB Y3Rpb24oIkNoYW5nZSBVc2VyIEFnZW50IiwgdGhpcywgU0xPVChzaG93VXNlckFnZW50RGlhbG9n KCkpKTsKKyAgICB0b29sc01lbnUtPmFkZFNlcGFyYXRvcigpOworICAgIHRvb2xzTWVudS0+YWRk QWN0aW9uKCJMb2FkIFVSTHMgZnJvbSBmaWxlIiwgdGhpcywgU0xPVChsb2FkVVJMTGlzdEZyb21G aWxlKCkpKTsKIAogICAgIFFNZW51KiBzZXR0aW5nc01lbnUgPSBtZW51QmFyKCktPmFkZE1lbnUo IiZTZXR0aW5ncyIpOwogICAgIFFBY3Rpb24qIHRvZ2dsZUF1dG9Mb2FkSW1hZ2VzID0gc2V0dGlu Z3NNZW51LT5hZGRBY3Rpb24oIkRpc2FibGUgQXV0byBMb2FkIEltYWdlcyIsIHRoaXMsIFNMT1Qo dG9nZ2xlQXV0b0xvYWRJbWFnZXMoYm9vbCkpKTsKQEAgLTMzNSw2ICszMzksMTcgQEAgdm9pZCBC cm93c2VyV2luZG93OjpzaG93VXNlckFnZW50RGlhbG9nKCkKICAgICAgICAgcGFnZSgpLT5zZXRD dXN0b21Vc2VyQWdlbnQoY29tYm8tPmN1cnJlbnRUZXh0KCkpOwogfQogCit2b2lkIEJyb3dzZXJX aW5kb3c6OmxvYWRVUkxMaXN0RnJvbUZpbGUoKQoreworICAgIFFTdHJpbmcgc2VsZWN0ZWRGaWxl ID0gUUZpbGVEaWFsb2c6OmdldE9wZW5GaWxlTmFtZSh0aGlzLCB0cigiTG9hZCBVUkwgbGlzdCBm cm9tIGZpbGUiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICwgUVN0cmluZygpLCB0cigiVGV4dCBGaWxlcyAoKi50eHQpOztBbGwgRmlsZXMg KCopIikpOworICAgIGlmIChzZWxlY3RlZEZpbGUuaXNFbXB0eSgpKQorICAgICAgIHJldHVybjsK KworICAgIG1fdXJsTG9hZGVyID0gbmV3IFVybExvYWRlcih0aGlzLCBzZWxlY3RlZEZpbGUsIDAs IDApOworICAgIG1fdXJsTG9hZGVyLT5sb2FkTmV4dCgpOworfQorCiB2b2lkIEJyb3dzZXJXaW5k b3c6OnByaW50VVJMKGNvbnN0IFFVcmwmIHVybCkKIHsKICAgICBRVGV4dFN0cmVhbSBvdXRwdXQo c3Rkb3V0KTsKQEAgLTM4MCw2ICszOTUsNyBAQCB2b2lkIEJyb3dzZXJXaW5kb3c6OmFwcGx5Wm9v bSgpCiAKIEJyb3dzZXJXaW5kb3c6On5Ccm93c2VyV2luZG93KCkKIHsKKyAgICBkZWxldGUgbV91 cmxMb2FkZXI7CiAgICAgZGVsZXRlIG1fYWRkcmVzc0JhcjsKICAgICBkZWxldGUgbV9icm93c2Vy OwogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5oIGIv VG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5oCmluZGV4IDZhZDhmMjcuLjA2ZGEy YTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuaAorKysg Yi9Ub29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmgKQEAgLTM1LDYgKzM1LDggQEAK ICNpbmNsdWRlIDxRU3RyaW5nTGlzdD4KICNpbmNsdWRlIDxRdEd1aT4KIAorY2xhc3MgVXJsTG9h ZGVyOworCiBjbGFzcyBCcm93c2VyV2luZG93IDogcHVibGljIFFNYWluV2luZG93IHsKICAgICBR X09CSkVDVAogCkBAIC02OSw2ICs3MSw4IEBAIHByb3RlY3RlZCBzbG90czoKICAgICB2b2lkIHRv Z2dsZUZyYW1lRmxhdHRlbmluZyhib29sKTsKICAgICB2b2lkIHNob3dVc2VyQWdlbnREaWFsb2co KTsKIAorICAgIHZvaWQgbG9hZFVSTExpc3RGcm9tRmlsZSgpOworCiAgICAgdm9pZCBwcmludFVS TChjb25zdCBRVXJsJik7CiAKICAgICB2b2lkIHRvZ2dsZUF1dG9Mb2FkSW1hZ2VzKGJvb2wpOwpA QCAtODMsNiArODcsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9pc1pvb21UZXh0T25seTsKICAg ICBxcmVhbCBtX2N1cnJlbnRab29tOwogCisgICAgVXJsTG9hZGVyKiBtX3VybExvYWRlcjsKICAg ICBRV0tDb250ZXh0KiBtX2NvbnRleHQ7CiAgICAgV2luZG93T3B0aW9ucyBtX3dpbmRvd09wdGlv bnM7CiAgICAgQnJvd3NlclZpZXcqIG1fYnJvd3NlcjsKZGlmZiAtLWdpdCBhL1Rvb2xzL1F0VGVz dEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuY3BwIGIvVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hl cndpbmRvdy5jcHAKaW5kZXggZjRkYjg5OC4uMDcyYWU1YyAxMDA2NDQKLS0tIGEvVG9vbHMvUXRU ZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKKysrIGIvVG9vbHMvUXRUZXN0QnJvd3Nlci9s YXVuY2hlcndpbmRvdy5jcHAKQEAgLTMxLDYgKzMxLDcgQEAKICAqLwogCiAjaW5jbHVkZSAibGF1 bmNoZXJ3aW5kb3cuaCIKKyNpbmNsdWRlICJ1cmxsb2FkZXIuaCIKIAogY29uc3QgaW50IGdFeGl0 Q2xpY2tBcmVhID0gODA7CiBRVmVjdG9yPGludD4gTGF1bmNoZXJXaW5kb3c6Om1fem9vbUxldmVs czsKQEAgLTM4LDYgKzM5LDcgQEAgUVZlY3RvcjxpbnQ+IExhdW5jaGVyV2luZG93OjptX3pvb21M ZXZlbHM7CiBMYXVuY2hlcldpbmRvdzo6TGF1bmNoZXJXaW5kb3coV2luZG93T3B0aW9ucyogZGF0 YSwgUUdyYXBoaWNzU2NlbmUqIHNoYXJlZFNjZW5lKQogICAgIDogTWFpbldpbmRvdygpCiAgICAg LCBtX2N1cnJlbnRab29tKDEwMCkKKyAgICAsIG1fdXJsTG9hZGVyKDApCiAgICAgLCBtX3ZpZXco MCkKICAgICAsIG1faW5zcGVjdG9yKDApCiAgICAgLCBtX2Zvcm1hdE1lbnVBY3Rpb24oMCkKQEAg LTU2LDYgKzU4LDcgQEAgTGF1bmNoZXJXaW5kb3c6OkxhdW5jaGVyV2luZG93KFdpbmRvd09wdGlv bnMqIGRhdGEsIFFHcmFwaGljc1NjZW5lKiBzaGFyZWRTY2VuZSkKIExhdW5jaGVyV2luZG93Ojp+ TGF1bmNoZXJXaW5kb3coKQogewogICAgIGdyYWJab29tS2V5cyhmYWxzZSk7CisgICAgZGVsZXRl IG1fdXJsTG9hZGVyOwogfQogCiB2b2lkIExhdW5jaGVyV2luZG93Ojppbml0KCkKQEAgLTI4Nyw2 ICsyOTAsOCBAQCB2b2lkIExhdW5jaGVyV2luZG93OjpjcmVhdGVDaHJvbWUoKQogICAgIFFBY3Rp b24qIHNob3dJbnNwZWN0b3JBY3Rpb24gPSB0b29sc01lbnUtPmFkZEFjdGlvbigiU2hvdyBXZWIg SW5zcGVjdG9yIiwgbV9pbnNwZWN0b3IsIFNMT1Qoc2V0VmlzaWJsZShib29sKSksIFFLZXlTZXF1 ZW5jZShRdDo6Q1RSTCB8IFF0OjpBTFQgfCBRdDo6S2V5X0kpKTsKICAgICBzaG93SW5zcGVjdG9y QWN0aW9uLT5zZXRDaGVja2FibGUodHJ1ZSk7CiAgICAgc2hvd0luc3BlY3RvckFjdGlvbi0+Y29u bmVjdChtX2luc3BlY3RvciwgU0lHTkFMKHZpc2libGVDaGFuZ2VkKGJvb2wpKSwgU0xPVChzZXRD aGVja2VkKGJvb2wpKSk7CisgICAgdG9vbHNNZW51LT5hZGRTZXBhcmF0b3IoKTsKKyAgICB0b29s c01lbnUtPmFkZEFjdGlvbigiTG9hZCBVUkxzIGZyb20gZmlsZSIsIHRoaXMsIFNMT1QobG9hZFVS TExpc3RGcm9tRmlsZSgpKSk7CiAKICAgICAvLyBHcmFwaGljc1ZpZXcgc3ViIG1lbnUuCiAgICAg UUFjdGlvbiogdG9nZ2xlQWNjZWxlcmF0ZWRDb21wb3NpdGluZyA9IGdyYXBoaWNzVmlld01lbnUt PmFkZEFjdGlvbigiVG9nZ2xlIEFjY2VsZXJhdGVkIENvbXBvc2l0aW5nIiwgdGhpcywgU0xPVCh0 b2dnbGVBY2NlbGVyYXRlZENvbXBvc2l0aW5nKGJvb2wpKSk7CkBAIC05MDAsNiArOTA1LDE3IEBA IHZvaWQgTGF1bmNoZXJXaW5kb3c6OnNob3dVc2VyQWdlbnREaWFsb2coKQogICAgIGRlbGV0ZSBk aWFsb2c7CiB9CiAKK3ZvaWQgTGF1bmNoZXJXaW5kb3c6OmxvYWRVUkxMaXN0RnJvbUZpbGUoKQor eworICAgIFFTdHJpbmcgc2VsZWN0ZWRGaWxlID0gUUZpbGVEaWFsb2c6OmdldE9wZW5GaWxlTmFt ZSh0aGlzLCB0cigiTG9hZCBVUkwgbGlzdCBmcm9tIGZpbGUiKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICwgUVN0cmluZygpLCB0cigiVGV4 dCBGaWxlcyAoKi50eHQpOztBbGwgRmlsZXMgKCopIikpOworICAgIGlmIChzZWxlY3RlZEZpbGUu aXNFbXB0eSgpKQorICAgICAgIHJldHVybjsKKworICAgIG1fdXJsTG9hZGVyID0gbmV3IFVybExv YWRlcih0aGlzLT5wYWdlKCktPm1haW5GcmFtZSgpLCBzZWxlY3RlZEZpbGUsIDAsIDApOworICAg IG1fdXJsTG9hZGVyLT5sb2FkTmV4dCgpOworfQorCiB2b2lkIExhdW5jaGVyV2luZG93Ojpwcmlu dFVSTChjb25zdCBRVXJsJiB1cmwpCiB7CiAgICAgUVRleHRTdHJlYW0gb3V0cHV0KHN0ZG91dCk7 CmRpZmYgLS1naXQgYS9Ub29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmggYi9Ub29s cy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmgKaW5kZXggOGJkYWQ0ZC4uMTYzNjhmNSAx MDA2NDQKLS0tIGEvVG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5oCisrKyBiL1Rv b2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuaApAQCAtMTY1LDYgKzE2NSw4IEBAIHBy b3RlY3RlZCBzbG90czoKICAgICAvKiB2b2lkIGR1bXBQbHVnaW5zKCkgKi8KICAgICB2b2lkIGR1 bXBIdG1sKCk7CiAKKyAgICB2b2lkIGxvYWRVUkxMaXN0RnJvbUZpbGUoKTsKKwogICAgIHZvaWQg c2V0VG91Y2hNb2NraW5nKGJvb2wgb24pOwogICAgIHZvaWQgdG9nZ2xlV2ViVmlldyhib29sIGdy YXBoaWNzQmFzZWQpOwogICAgIHZvaWQgdG9nZ2xlQWNjZWxlcmF0ZWRDb21wb3NpdGluZyhib29s IHRvZ2dsZSk7CkBAIC0yMTcsNiArMjE5LDggQEAgcHJpdmF0ZToKICAgICBzdGF0aWMgUVZlY3Rv cjxpbnQ+IG1fem9vbUxldmVsczsKICAgICBpbnQgbV9jdXJyZW50Wm9vbTsKIAorICAgIFVybExv YWRlciogbV91cmxMb2FkZXI7CisKICAgICBRV2lkZ2V0KiBtX3ZpZXc7CiAgICAgV2ViSW5zcGVj dG9yKiBtX2luc3BlY3RvcjsKIAo=