57810 2011-04-04 17:35:20 -0700 [V8] Keep dirty primitive CSS values alive 2011-04-05 14:20:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vitalyr webkit-unassigned abarth antonm oldest_to_newest 379254 0 vitalyr 2011-04-04 17:35:20 -0700 [V8] Keep dirty primitive CSS values alive This should make fast/dom/StyleSheet/gc-inline-style-cssvalues.html pass again. 379258 1 88174 vitalyr 2011-04-04 17:41:53 -0700 Created attachment 88174 patch 379400 2 88174 antonm 2011-04-05 02:27:40 -0700 Comment on attachment 88174 patch View in context: https://bugs.webkit.org/attachment.cgi?id=88174&action=review LGTM > Source/WebCore/bindings/v8/V8GCController.cpp:368 > + Vector<v8::Persistent<v8::Value> > values; nit: may you add a space between < and v8::Persistent? 379861 3 vitalyr 2011-04-05 14:20:53 -0700 M LayoutTests/ChangeLog M LayoutTests/platform/chromium/test_expectations.txt M Source/WebCore/ChangeLog M Source/WebCore/bindings/v8/V8GCController.cpp Committed r82981 88174 2011-04-04 17:41:53 -0700 2011-04-05 11:19:03 -0700 patch css_values.patch text/plain 3692 vitalyr ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkMzU5MDllLi5lOTc2OWY3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQt MDQgIFZpdGFseSBSZXBlc2hrbyAgPHZpdGFseXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0gS2VlcCBkaXJ0eSBwcmlt aXRpdmUgQ1NTIHZhbHVlcyBhbGl2ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU3ODEwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQ6IE1hcmsKKyAgICAgICAgZmFzdC9kb20vU3R5bGVTaGVldC9nYy1p bmxpbmUtc3R5bGUtY3NzdmFsdWVzLmh0bWwgYXMgcGFzc2luZy4KKwogMjAxMS0wNC0wNCAgSmVz c2llIEJlcmxpbiAgPGpiZXJsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBhIHRlc3Qg ZnJvbSB0aGUgd2luLXdrMiBza2lwcGVkIGxpc3QgdGhhdCBkb2VzIG5vdCBleGlzdC4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4 dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApp bmRleCA3ZGYwMWFlLi45ZjZhYjY3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Y2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC0zMTM2LDkgKzMxMzYsNiBAQCBCVUdX SzU2MDYwIExJTlVYIFg4Nl82NCA6IGZhc3QvaW1hZ2VzL2Zhdmljb24tYXMtaW1hZ2UuaHRtbCA9 IElNQUdFK1RFWFQKIAogQlVHQ1I3NTYzMiBMSU5VWCA6IHN2Zy9XM0MtU1ZHLTEuMS90ZXh0LXRl eHQtMDMtYi5zdmcgPSBDUkFTSCBQQVNTCiAKLS8vIEkgKGFudG9ubSkgYW0gd29ya2luZyBvbiBw cm9wZXIgZml4IGZvciBpdC4gIFRlbXBvcmFyeSBzdXBwcmVzc2luZyB0ZXh0IGRpZmZlcmVuY2Vz LgotQlVHV0s1NTM5OSA6IGZhc3QvZG9tL1N0eWxlU2hlZXQvZ2MtaW5saW5lLXN0eWxlLWNzc3Zh bHVlcy5odG1sID0gVEVYVAotCiAvLyBUZXN0IGNoYW5nZWQgaW4gV2sgcjgwNzQzLCB0aHJvd3Mg YW4gZXhjZXB0aW9uIHJhdGhlciB0aGFuIHJldHVybmluZyAndHJ1ZScKIEJVR0NSNzU3NDAgOiBm YXN0L2pzL3JlZ2V4cC10ZXN0LW51bGwtc3RyaW5nLmh0bWwgPSBGQUlMCiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCAxNzk1ZTZjLi5hNTZiZjJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQt MDQgIFZpdGFseSBSZXBlc2hrbyAgPHZpdGFseXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0gS2VlcCBkaXJ0eSBwcmlt aXRpdmUgQ1NTIHZhbHVlcyBhbGl2ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU3ODEwCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEdDQ29udHJv bGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcm91cGVyVmlzaXRvcjo6dmlzaXRET01XcmFw cGVyKToKKwogMjAxMS0wNC0wNCAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAKaW5kZXggY2Q4MzhiZC4uMzBh OTI4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xs ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNw cApAQCAtMzU5LDYgKzM1OSwyNCBAQCBwdWJsaWM6CiAgICAgICAgICAgICBHcm91cElkIGdyb3Vw SWQgPSBjYWxjdWxhdGVHcm91cElkKGNzc1N0eWxlRGVjbGFyYXRpb24pOwogICAgICAgICAgICAg bV9ncm91cGVyLmFwcGVuZChHcm91cGVySXRlbShncm91cElkLCB3cmFwcGVyKSk7CiAKKyAgICAg ICAgICAgIC8vIEtlZXAgYWxpdmUgImRpcnR5IiBwcmltaXRpdmUgdmFsdWVzIChpLmUuIHRoZSBv bmVzIHRoYXQKKyAgICAgICAgICAgIC8vIGhhdmUgdXNlci1hZGRlZCBwcm9wZXJ0aWVzKSBieSBj cmVhdGluZyBpbXBsaWNpdAorICAgICAgICAgICAgLy8gcmVmZXJlbmNlcyBiZXR3ZWVuIHRoZSBz dHlsZSBkZWNsYXJhdGlvbiBhbmQgdGhlIHZhbHVlcworICAgICAgICAgICAgLy8gaW4gaXQuCisg ICAgICAgICAgICBpZiAoY3NzU3R5bGVEZWNsYXJhdGlvbi0+aXNNdXRhYmxlU3R5bGVEZWNsYXJh dGlvbigpKSB7CisgICAgICAgICAgICAgICAgQ1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24qIGNz c011dGFibGVTdHlsZURlY2xhcmF0aW9uID0gc3RhdGljX2Nhc3Q8Q1NTTXV0YWJsZVN0eWxlRGVj bGFyYXRpb24qPihjc3NTdHlsZURlY2xhcmF0aW9uKTsKKyAgICAgICAgICAgICAgICBWZWN0b3I8 djg6OlBlcnNpc3RlbnQ8djg6OlZhbHVlPiA+IHZhbHVlczsKKyAgICAgICAgICAgICAgICB2YWx1 ZXMucmVzZXJ2ZUNhcGFjaXR5KGNzc011dGFibGVTdHlsZURlY2xhcmF0aW9uLT5sZW5ndGgoKSk7 CisgICAgICAgICAgICAgICAgQ1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb246OmNvbnN0X2l0ZXJh dG9yIGVuZCA9IGNzc011dGFibGVTdHlsZURlY2xhcmF0aW9uLT5lbmQoKTsKKyAgICAgICAgICAg ICAgICBmb3IgKENTU011dGFibGVTdHlsZURlY2xhcmF0aW9uOjpjb25zdF9pdGVyYXRvciBpdCA9 IGNzc011dGFibGVTdHlsZURlY2xhcmF0aW9uLT5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpIHsK KyAgICAgICAgICAgICAgICAgICAgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4gdmFsdWUgPSBz dG9yZS0+ZG9tT2JqZWN0TWFwKCkuZ2V0KGl0LT52YWx1ZSgpKTsKKyAgICAgICAgICAgICAgICAg ICAgaWYgKCF2YWx1ZS5Jc0VtcHR5KCkgJiYgdmFsdWUtPklzRGlydHkoKSkKKyAgICAgICAgICAg ICAgICAgICAgICAgIHZhbHVlcy5hcHBlbmQodmFsdWUpOworICAgICAgICAgICAgICAgIH0KKyAg ICAgICAgICAgICAgICBpZiAoIXZhbHVlcy5pc0VtcHR5KCkpCisgICAgICAgICAgICAgICAgICAg IHY4OjpWODo6QWRkSW1wbGljaXRSZWZlcmVuY2VzKHdyYXBwZXIsIHZhbHVlcy5kYXRhKCksIHZh bHVlcy5zaXplKCkpOworICAgICAgICAgICAgfQorCiAgICAgICAgIH0gZWxzZSBpZiAodHlwZUlu Zm8tPmlzU3ViY2xhc3MoJlY4Q1NTUnVsZUxpc3Q6OmluZm8pKSB7CiAgICAgICAgICAgICBDU1NS dWxlTGlzdCogY3NzUnVsZUxpc3QgPSBzdGF0aWNfY2FzdDxDU1NSdWxlTGlzdCo+KG9iamVjdCk7 CiAgICAgICAgICAgICBHcm91cElkIGdyb3VwSWQoY3NzUnVsZUxpc3QpOwo=