57795 2011-04-04 15:15:18 -0700 HTML5 Player Has no Fullscreen Mode 2011-04-05 15:23:40 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 jer.noble jer.noble commit-queue oldest_to_newest 379121 0 jer.noble 2011-04-04 15:15:18 -0700 3/31/11 11:23 PM Joe Thompson: Summary: The HTML 5 video element no longer has a fullscreen button or can be put into fullscreen programatically as "webkitSupportsFullscreen" always returns false. Steps to Reproduce: Using WebKit's HTML 5 video element with the default Safari controls or using custom ones (such as on Vimeo) and attempt to put it into fullscreen mode. Expected Results: Like on Snow Leopard there is a fullscreen button in the default Safari controls or a custom control that enabled the functionality through JavaScript. Actual Results: The default Safari controls that have been updated in Lion have no fullscreen button and JavaScript can no longer programatically put the video element into fullscreen. Regression: Fullscreen support (required to ensure HTML 5 video elements can be properly used to replace traditional Flash video players) worked on previous versions of Safari on Snow Leopard. Notes: N/A 379122 1 jer.noble 2011-04-04 15:15:33 -0700 <rdar://problem/9220025> 379130 2 88142 jer.noble 2011-04-04 15:27:45 -0700 Created attachment 88142 Patch 379212 3 88142 darin 2011-04-04 16:46:19 -0700 Comment on attachment 88142 Patch Is there an easy way to regression-test this? 379603 4 jer.noble 2011-04-05 08:54:27 -0700 (In reply to comment #3) > (From update of attachment 88142 [details]) > Is there an easy way to regression-test this? Not really; we'd have to convince DRT to answer "false" to supportsFullscreenForNode(), and "true" to supportsFullscreenForElement(), which would break a lot of existing tests on platforms which don't support the new API. 379604 5 jer.noble 2011-04-05 08:54:59 -0700 OTOH, I have a bug which would add support for the new API to WebKitTestRunner, and once that's fixed, this would be easily regression testable. 379607 6 jer.noble 2011-04-05 08:56:17 -0700 That WebKitTestRunner bug is: bug #56318. 379904 7 88142 commit-queue 2011-04-05 15:23:35 -0700 Comment on attachment 88142 Patch Clearing flags on attachment: 88142 Committed r82991: <http://trac.webkit.org/changeset/82991> 379905 8 commit-queue 2011-04-05 15:23:40 -0700 All reviewed patches have been landed. Closing bug. 88142 2011-04-04 15:27:45 -0700 2011-04-05 15:23:35 -0700 Patch bug-57795-20110404152743.patch text/plain 1395 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODI3MzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwYTgwNTdjZDYzZDgyZjQ3 YjI2N2NiZGVjOGFjOGFkYWNhY2Y4MmJkLi5mODE5OWZkZWE1ZTNkM2NkOGZlN2Q3Mjc1MjVjNTE3 MzIwN2QwMmM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMDQgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSFRNTDUgUGxheWVyIEhhcyBubyBGdWxsc2NyZWVuIE1vZGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3Nzk1CisK KyAgICAgICAgKiBodG1sL0hUTUxWaWRlb0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SFRNTFZpZGVvRWxlbWVudDo6c3VwcG9ydHNGdWxsc2NyZWVuKTogQ2FsbCB0aGUgbmV3IENocm9t ZUNsaWVudCBBUEkKKyAgICAgICAgICAgIHN1cHBvcnRzRnVsbFNjcmVlbkZvckVsZW1lbnQoKSBi ZWZvcmUgdGhlIG9sZCBzdXBwb3J0c0Z1bGxTY3JlZW5Gb3JOb2RlKCkgQVBJLgorCiAyMDExLTA0 LTAxICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVmlk ZW9FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFZpZGVvRWxlbWVudC5jcHAK aW5kZXggNGRkY2RmZTk0OTU4YzdhMmExNWRlNDUxOTc4YmI3NTI0MjIzNWI4NS4uMDFlZGVhNTlk ZGY0NjE5Y2RhYzEwM2ZlNzZhMjc3ODgwOGFmMGU4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MVmlkZW9FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxWaWRlb0VsZW1lbnQuY3BwCkBAIC0xMjksNiArMTI5LDExIEBAIGJvb2wgSFRNTFZpZGVvRWxl bWVudDo6c3VwcG9ydHNGdWxsc2NyZWVuKCkgY29uc3QKICAgICAgICAgcmV0dXJuIGZhbHNlOwog CiAgICAgLy8gQ2hlY2sgd2l0aCB0aGUgcGxhdGZvcm0gY2xpZW50LgorI2lmIEVOQUJMRShGVUxM U0NSRUVOX0FQSSkKKyAgICBpZiAocGFnZS0+Y2hyb21lKCktPmNsaWVudCgpLT5zdXBwb3J0c0Z1 bGxTY3JlZW5Gb3JFbGVtZW50KHRoaXMsIGZhbHNlKSkKKyAgICAgICAgcmV0dXJuIHRydWU7Cisj ZW5kaWYKKwogICAgIHJldHVybiBwYWdlLT5jaHJvbWUoKS0+Y2xpZW50KCktPnN1cHBvcnRzRnVs bHNjcmVlbkZvck5vZGUodGhpcyk7CiB9CiAK