57793 2011-04-04 14:53:19 -0700 Fixed a weak-handle-related leak in RegisterFile 2011-04-04 15:29:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ggaren ggaren abarth eric oliver webkit.review.bot oldest_to_newest 379100 0 ggaren 2011-04-04 14:53:19 -0700 Fixed a weak-handle-related leak in RegisterFile 379103 1 88137 ggaren 2011-04-04 14:55:46 -0700 Created attachment 88137 Patch 379109 2 ggaren 2011-04-04 15:02:50 -0700 Committed r82877: <http://trac.webkit.org/changeset/82877> 379137 3 webkit.review.bot 2011-04-04 15:29:53 -0700 http://trac.webkit.org/changeset/82877 might have broken GTK Linux 32-bit Release 88137 2011-04-04 14:55:46 -0700 2011-04-04 14:56:41 -0700 Patch bug-57793-20110404145545.patch text/plain 4720 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODI4NzUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTEtMDQtMDQgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCBhIHdlYWstaGFu ZGxlLXJlbGF0ZWQgbGVhayBpbiBSZWdpc3RlckZpbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NzkzCisKKyAgICAgICAgKiBpbnRlcnByZXRlci9S ZWdpc3RlckZpbGUuY3BwOiBOaXhlZCBsZWFreSBHbG9iYWxPYmplY3ROb3RpZmllci4KKyAgICAg ICAgKiBpbnRlcnByZXRlci9SZWdpc3RlckZpbGUuaDoKKyAgICAgICAgKEpTQzo6UmVnaXN0ZXJG aWxlOjpHbG9iYWxPYmplY3RPd25lcjo6ZmluYWxpemUpOgorICAgICAgICAoSlNDOjpSZWdpc3Rl ckZpbGU6OlJlZ2lzdGVyRmlsZSk6IFJlcGxhY2VkIEdsb2JhbE9iamVjdE5vdGlmaWVyIHdpdGgK KyAgICAgICAgYSBwZXItUmVnaXN0ZXJGaWxlIHdlYWsgaGFuZGxlIG93bmVyLCB3aGljaCBkb2Vz IG5vdCBsZWFrLgorCisgICAgICAgICogcnVudGltZS9XZWFrR0NQdHIuaDoKKyAgICAgICAgKEpT Qzo6V2Vha0dDUHRyOjpzZXQpOiBBbGxvdyBzZXQoKSB0byB0YWtlIGEgY29udGV4dCBhcmd1bWVu dCwgc2luY2UKKyAgICAgICAgUmVnaXN0ZXJGaWxlIG5vdyBuZWVkcyB0aGlzLiAoU2VlbXMgbGlr ZSBpdCB3YXMgYW4gYWNjaWRlbnRhbCBvbWlzc2lvbgorICAgICAgICBhbGwgYWxvbmcuKQorCiAy MDExLTA0LTA0ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50 ZXJwcmV0ZXIvUmVnaXN0ZXJGaWxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaW50ZXJwcmV0ZXIvUmVnaXN0ZXJGaWxlLmNwcAkocmV2aXNpb24gODI4NzEpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvUmVnaXN0ZXJGaWxlLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNzIsMjQgKzcyLDcgQEAgdm9pZCBSZWdpc3RlckZpbGU6OnJlbGVhc2VFeGNl c3NDYXBhY2l0eQogCiB2b2lkIFJlZ2lzdGVyRmlsZTo6c2V0R2xvYmFsT2JqZWN0KEpTR2xvYmFs T2JqZWN0KiBnbG9iYWxPYmplY3QpCiB7Ci0gICAgbV9nbG9iYWxPYmplY3Quc2V0KGdsb2JhbE9i amVjdC0+Z2xvYmFsRGF0YSgpLCBnbG9iYWxPYmplY3QsIFJlZ2lzdGVyRmlsZTo6Z2xvYmFsT2Jq ZWN0Q29sbGVjdGVkTm90aWZpZXIoKSk7Ci19Ci0KLWNsYXNzIEdsb2JhbE9iamVjdE5vdGlmaWVy IDogcHVibGljIFdlYWtIYW5kbGVPd25lciB7Ci1wdWJsaWM6Ci0gICAgdm9pZCBmaW5hbGl6ZShI YW5kbGU8VW5rbm93bj4gdmFsdWUsIHZvaWQqKQotICAgIHsKLSAgICAgICAgSlNHbG9iYWxPYmpl Y3QqIGdsb2JhbE9iamVjdCA9IGFzR2xvYmFsT2JqZWN0KHZhbHVlLmdldCgpKTsKLSAgICAgICAg Z2xvYmFsT2JqZWN0LT5nbG9iYWxEYXRhKCkuaW50ZXJwcmV0ZXItPnJlZ2lzdGVyRmlsZSgpLnNl dE51bUdsb2JhbHMoMCk7Ci0gICAgfQotfTsKLQotV2Vha0hhbmRsZU93bmVyKiBSZWdpc3RlckZp bGU6Omdsb2JhbE9iamVjdENvbGxlY3RlZE5vdGlmaWVyKCkKLXsKLSAgICAvLyBUaGlzIHdpbGwg bGVhayBhbGFzLCBidXQgd2Ugb25seSBjcmVhdGUgb25lIG9mIHRoZW0sIGFuZCBpdCBkb2Vzbid0 Ci0gICAgLy8gdGFrZSB1cCBhbnkgc2lnbmlmaWNhbnQgYW1vdW50IG9mIHNwYWNlLgotICAgIHN0 YXRpYyBHbG9iYWxPYmplY3ROb3RpZmllciogbm90aWZpZXIgPSBuZXcgR2xvYmFsT2JqZWN0Tm90 aWZpZXI7Ci0gICAgcmV0dXJuIG5vdGlmaWVyOworICAgIG1fZ2xvYmFsT2JqZWN0LnNldChnbG9i YWxPYmplY3QtPmdsb2JhbERhdGEoKSwgZ2xvYmFsT2JqZWN0LCAmbV9nbG9iYWxPYmplY3RPd25l ciwgdGhpcyk7CiB9CiAKIEpTR2xvYmFsT2JqZWN0KiBSZWdpc3RlckZpbGU6Omdsb2JhbE9iamVj dCgpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvUmVnaXN0ZXJGaWxl LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL1JlZ2lz dGVyRmlsZS5oCShyZXZpc2lvbiA4Mjg3MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRl cnByZXRlci9SZWdpc3RlckZpbGUuaAkod29ya2luZyBjb3B5KQpAQCAtMTM1LDggKzEzNSw2IEBA IG5hbWVzcGFjZSBKU0MgewogICAgICAgICBzdGF0aWMgc2l6ZV90IGNvbW1pdHRlZEJ5dGVDb3Vu dCgpOwogICAgICAgICBzdGF0aWMgdm9pZCBpbml0aWFsaXplVGhyZWFkaW5nKCk7CiAKLSAgICAg ICAgc3RhdGljIFdlYWtIYW5kbGVPd25lciogZ2xvYmFsT2JqZWN0Q29sbGVjdGVkTm90aWZpZXIo KTsKLQogICAgICAgICBSZWdpc3RlciogY29uc3QgKiBhZGRyZXNzT2ZFbmQoKSBjb25zdAogICAg ICAgICB7CiAgICAgICAgICAgICByZXR1cm4gJm1fZW5kOwpAQCAtMTU1LDYgKzE1MywxMiBAQCBu YW1lc3BhY2UgSlNDIHsKICAgICAgICAgUGFnZVJlc2VydmF0aW9uIG1fcmVzZXJ2YXRpb247CiAK ICAgICAgICAgV2Vha0dDUHRyPEpTR2xvYmFsT2JqZWN0PiBtX2dsb2JhbE9iamVjdDsgLy8gVGhl IGdsb2JhbCBvYmplY3Qgd2hvc2UgdmFycyBhcmUgY3VycmVudGx5IHN0b3JlZCBpbiB0aGUgcmVn aXN0ZXIgZmlsZS4KKyAgICAgICAgY2xhc3MgR2xvYmFsT2JqZWN0T3duZXIgOiBwdWJsaWMgV2Vh a0hhbmRsZU93bmVyIHsKKyAgICAgICAgICAgIHZpcnR1YWwgdm9pZCBmaW5hbGl6ZShIYW5kbGU8 VW5rbm93bj4sIHZvaWQqIGNvbnRleHQpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAg c3RhdGljX2Nhc3Q8UmVnaXN0ZXJGaWxlKj4oY29udGV4dCktPnNldE51bUdsb2JhbHMoMCk7Cisg ICAgICAgICAgICB9CisgICAgICAgIH0gbV9nbG9iYWxPYmplY3RPd25lcjsKICAgICB9OwogCiAg ICAgaW5saW5lIFJlZ2lzdGVyRmlsZTo6UmVnaXN0ZXJGaWxlKEpTR2xvYmFsRGF0YSYgZ2xvYmFs RGF0YSwgc2l6ZV90IGNhcGFjaXR5LCBzaXplX3QgbWF4R2xvYmFscykKQEAgLTE2Myw3ICsxNjcs NyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgLCBtX3N0YXJ0KDApCiAgICAgICAgICwgbV9l bmQoMCkKICAgICAgICAgLCBtX21heCgwKQotICAgICAgICAsIG1fZ2xvYmFsT2JqZWN0KGdsb2Jh bERhdGEsIFJlZ2lzdGVyRmlsZTo6Z2xvYmFsT2JqZWN0Q29sbGVjdGVkTm90aWZpZXIoKSkKKyAg ICAgICAgLCBtX2dsb2JhbE9iamVjdChnbG9iYWxEYXRhLCAmbV9nbG9iYWxPYmplY3RPd25lciwg dGhpcykKICAgICB7CiAgICAgICAgIEFTU0VSVChtYXhHbG9iYWxzICYmIGlzUGFnZUFsaWduZWQo bWF4R2xvYmFscykpOwogICAgICAgICBBU1NFUlQoY2FwYWNpdHkgJiYgaXNQYWdlQWxpZ25lZChj YXBhY2l0eSkpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2Vha0dDUHRy LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2Vha0dDUHRy LmgJKHJldmlzaW9uIDgyODcxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2Vh a0dDUHRyLmgJKHdvcmtpbmcgY29weSkKQEAgLTc3LDExICs3NywxMSBAQCBwdWJsaWM6CiAgICAg ICAgIEhhbmRsZUhlYXA6OmhlYXBGb3IobV9zbG90KS0+ZGVhbGxvY2F0ZShtX3Nsb3QpOwogICAg IH0KIAotICAgIHZvaWQgc2V0KEpTR2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSwgRXh0ZXJuYWxUeXBl IHZhbHVlLCBXZWFrSGFuZGxlT3duZXIqIHdlYWtPd25lcikKKyAgICB2b2lkIHNldChKU0dsb2Jh bERhdGEmIGdsb2JhbERhdGEsIEV4dGVybmFsVHlwZSB2YWx1ZSwgV2Vha0hhbmRsZU93bmVyKiB3 ZWFrT3duZXIgPSAwLCB2b2lkKiBjb250ZXh0ID0gMCkKICAgICB7CiAgICAgICAgIGlmICghdGhp cy0+bV9zbG90KSB7CiAgICAgICAgICAgICB0aGlzLT5tX3Nsb3QgPSBnbG9iYWxEYXRhLmFsbG9j YXRlR2xvYmFsSGFuZGxlKCk7Ci0gICAgICAgICAgICBIYW5kbGVIZWFwOjpoZWFwRm9yKHRoaXMt Pm1fc2xvdCktPm1ha2VXZWFrKHRoaXMtPm1fc2xvdCwgd2Vha093bmVyKTsKKyAgICAgICAgICAg IEhhbmRsZUhlYXA6OmhlYXBGb3IodGhpcy0+bV9zbG90KS0+bWFrZVdlYWsodGhpcy0+bV9zbG90 LCB3ZWFrT3duZXIsIGNvbnRleHQpOwogICAgICAgICB9CiAgICAgICAgIEFTU0VSVChIYW5kbGVI ZWFwOjpoZWFwRm9yKHRoaXMtPm1fc2xvdCktPmhhc1dlYWtPd25lcih0aGlzLT5tX3Nsb3QsIHdl YWtPd25lcikpOwogICAgICAgICB0aGlzLT5pbnRlcm5hbFNldCh2YWx1ZSk7Cg==