57790 2011-04-04 14:30:54 -0700 Renamed clearWeakPointers => updateWeakHandles and removed misleading comment 2011-04-06 08:32:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ggaren ggaren abarth eric oliver webkit.review.bot oldest_to_newest 379080 0 ggaren 2011-04-04 14:30:54 -0700 Renamed clearWeakPointers => updateWeakHandles and removed misleading comment 379082 1 88131 ggaren 2011-04-04 14:32:22 -0700 Created attachment 88131 Patch 379089 2 ggaren 2011-04-04 14:40:18 -0700 Committed r82875: <http://trac.webkit.org/changeset/82875> 379135 3 webkit.review.bot 2011-04-04 15:29:41 -0700 http://trac.webkit.org/changeset/82875 might have broken GTK Linux 32-bit Release 379201 4 88156 morrita 2011-04-04 16:38:31 -0700 Created attachment 88156 Trying a build fix 380398 5 88156 levin 2011-04-06 08:32:41 -0700 Comment on attachment 88156 Trying a build fix It looks like this has been landed. Clearing r?. 88131 2011-04-04 14:32:22 -0700 2011-04-04 16:38:28 -0700 Patch bug-57790-20110404143221.patch text/plain 2958 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODI4NzQpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTEtMDQtMDQgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW5hbWVkIGNsZWFyV2Vh a1BvaW50ZXJzID0+IHVwZGF0ZVdlYWtIYW5kbGVzIGFuZCByZW1vdmVkIG1pc2xlYWRpbmcgY29t bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc3 OTAKKworICAgICAgICAqIGNvbGxlY3Rvci9oYW5kbGVzL0hhbmRsZUhlYXAuY3BwOgorICAgICAg ICAoSlNDOjpIYW5kbGVIZWFwOjp1cGRhdGVXZWFrSGFuZGxlcyk6IFVwZGF0ZWQgZm9yIHJlbmFt ZS4KKworICAgICAgICAqIGNvbGxlY3Rvci9oYW5kbGVzL0hhbmRsZUhlYXAuaDogUmVtb3ZlZCBj b21tZW50IGNsYWltaW5nIHRoYXQgdGhpcworICAgICAgICBmdW5jdGlvbiBzaG91bGQgb25seSBi ZSBjYWxsZWQgZHVyaW5nIHRlYXJkb3duLCBiZWNhdXNlIGl0J3MgYWN0dWFsbHkKKyAgICAgICAg Y2FsbGVkIGFmdGVyIGV2ZXJ5IEdDIHBhc3MuCisKKyAgICAgICAgKiBydW50aW1lL0hlYXAuY3Bw OgorICAgICAgICAoSlNDOjpIZWFwOjpkZXN0cm95KToKKyAgICAgICAgKEpTQzo6SGVhcDo6bWFy a1Jvb3RzKTogVXBkYXRlZCBmb3IgcmVuYW1lLgorCiAyMDExLTA0LTA0ICBHZW9mZnJleSBHYXJl biAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQu CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvY29sbGVjdG9yL2hhbmRsZXMvSGFuZGxlSGVh cC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2NvbGxlY3Rvci9oYW5k bGVzL0hhbmRsZUhlYXAuY3BwCShyZXZpc2lvbiA4Mjg3NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9jb2xsZWN0b3IvaGFuZGxlcy9IYW5kbGVIZWFwLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NTUsMTIgKzU1LDcgQEAgdm9pZCBIYW5kbGVIZWFwOjptYXJrU3Ryb25nSGFuZGxlcyhIZWFwUgog ICAgICAgICBoZWFwUm9vdE1hcmtlci5tYXJrKG5vZGUtPnNsb3QoKSk7CiB9CiAKLXZvaWQgSGFu ZGxlSGVhcDo6dXBkYXRlQWZ0ZXJNYXJrKCkKLXsKLSAgICBjbGVhcldlYWtQb2ludGVycygpOwot fQotCi12b2lkIEhhbmRsZUhlYXA6OmNsZWFyV2Vha1BvaW50ZXJzKCkKK3ZvaWQgSGFuZGxlSGVh cDo6dXBkYXRlV2Vha0hhbmRsZXMoKQogewogICAgIE5vZGUqIGVuZCA9IG1fd2Vha0xpc3QuZW5k KCk7CiAgICAgZm9yIChOb2RlKiBub2RlID0gbV93ZWFrTGlzdC5iZWdpbigpOyBub2RlICE9IGVu ZDsgbm9kZSA9IG1fbmV4dFRvRmluYWxpemUpIHsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9jb2xsZWN0b3IvaGFuZGxlcy9IYW5kbGVIZWFwLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2NvbGxlY3Rvci9oYW5kbGVzL0hhbmRsZUhlYXAuaAkocmV2aXNpb24gODI4 NzQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvY29sbGVjdG9yL2hhbmRsZXMvSGFuZGxlSGVh cC5oCSh3b3JraW5nIGNvcHkpCkBAIC01NiwxMCArNTYsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBt YWtlV2VhayhIYW5kbGVTbG90LCBXZWFrSGFuZGxlT3duZXIqID0gMCwgdm9pZCogY29udGV4dCA9 IDApOwogCiAgICAgdm9pZCBtYXJrU3Ryb25nSGFuZGxlcyhIZWFwUm9vdE1hcmtlciYpOwotICAg IHZvaWQgdXBkYXRlQWZ0ZXJNYXJrKCk7Ci0gICAgCi0gICAgLy8gU2hvdWxkIG9ubHkgYmUgY2Fs bGVkIGR1cmluZyB0ZWFyZG93bi4KLSAgICB2b2lkIGNsZWFyV2Vha1BvaW50ZXJzKCk7CisgICAg dm9pZCB1cGRhdGVXZWFrSGFuZGxlcygpOwogCiAgICAgdm9pZCB3cml0ZUJhcnJpZXIoSGFuZGxl U2xvdCwgY29uc3QgSlNWYWx1ZSYpOwogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9IZWFwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9IZWFwLmNwcAkocmV2aXNpb24gODI4NzEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9IZWFwLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODIsNyArODIsNyBAQCB2b2lkIEhlYXA6 OmRlc3Ryb3koKQogICAgIGRlbGV0ZSBtX21hcmtMaXN0U2V0OwogICAgIG1fbWFya0xpc3RTZXQg PSAwOwogICAgIG1fbWFya2VkU3BhY2UuY2xlYXJNYXJrcygpOwotICAgIG1faGFuZGxlSGVhcC5j bGVhcldlYWtQb2ludGVycygpOworICAgIG1faGFuZGxlSGVhcC51cGRhdGVXZWFrSGFuZGxlcygp OwogICAgIG1fbWFya2VkU3BhY2UuZGVzdHJveSgpOwogCiAgICAgbV9nbG9iYWxEYXRhID0gMDsK QEAgLTI0OSw3ICsyNDksNyBAQCB2b2lkIEhlYXA6Om1hcmtSb290cygpCiAgICAgbWFya1N0YWNr LmRyYWluKCk7CiAgICAgbWFya1N0YWNrLmNvbXBhY3QoKTsKICAgICAKLSAgICBtX2hhbmRsZUhl YXAudXBkYXRlQWZ0ZXJNYXJrKCk7CisgICAgbV9oYW5kbGVIZWFwLnVwZGF0ZVdlYWtIYW5kbGVz KCk7CiAKICAgICBtX29wZXJhdGlvbkluUHJvZ3Jlc3MgPSBOb09wZXJhdGlvbjsKIH0K 88156 2011-04-04 16:38:31 -0700 2011-04-06 08:32:41 -0700 Trying a build fix bug-57790-20110404163830.patch text/plain 3293 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogODI4NzUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDgy ODhiYzNhOTA5ODlmY2I5Yzk1Njc0NWIwNjI0OTdkOTA2OTU0ZGIuLjRjZDBjYzgyNDc4NjY4YWRh ODljNWI1Y2JhZjlkNzRiZjkzMDMxZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMiw2 ICsyLDI0IEBACiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCiAKKyAgICAgICAg UmVuYW1lZCBjbGVhcldlYWtQb2ludGVycyA9PiB1cGRhdGVXZWFrSGFuZGxlcyBhbmQgcmVtb3Zl ZCBtaXNsZWFkaW5nIGNvbW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU3NzkwCisKKyAgICAgICAgKiBjb2xsZWN0b3IvaGFuZGxlcy9IYW5kbGVI ZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGFuZGxlSGVhcDo6dXBkYXRlV2Vha0hhbmRsZXMpOiBV cGRhdGVkIGZvciByZW5hbWUuCisKKyAgICAgICAgKiBjb2xsZWN0b3IvaGFuZGxlcy9IYW5kbGVI ZWFwLmg6IFJlbW92ZWQgY29tbWVudCBjbGFpbWluZyB0aGF0IHRoaXMKKyAgICAgICAgZnVuY3Rp b24gc2hvdWxkIG9ubHkgYmUgY2FsbGVkIGR1cmluZyB0ZWFyZG93biwgYmVjYXVzZSBpdCdzIGFj dHVhbGx5CisgICAgICAgIGNhbGxlZCBhZnRlciBldmVyeSBHQyBwYXNzLgorCisgICAgICAgICog cnVudGltZS9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVhcDo6ZGVzdHJveSk6CisgICAgICAg IChKU0M6OkhlYXA6Om1hcmtSb290cyk6IFVwZGF0ZWQgZm9yIHJlbmFtZS4KKworMjAxMS0wNC0w NCAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE9saXZlciBIdW50LgorCiAgICAgICAgIFN0YW5kYXJkaXplZCBoYW5kbGluZyBvZiBoYW5k bGVzIGZvciBpbW1lZGlhdGUgdmFsdWVzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01Nzc4OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvY29sbGVjdG9yL2hhbmRsZXMvSGFuZGxlSGVhcC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvY29sbGVjdG9yL2hhbmRsZXMvSGFuZGxlSGVhcC5jcHAKaW5kZXggZTgzNTZjZTYxZDMzNjc4 ZjRlOGY5NjU1ZTNlM2FlMTVhYjMxZjg5ZS4uMjNkNWVhYmI1NDRiMDExNTFlNzg2NTU1YzQ5MjYw NDNkODkxMTcwZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2NvbGxlY3Rvci9o YW5kbGVzL0hhbmRsZUhlYXAuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9jb2xsZWN0 b3IvaGFuZGxlcy9IYW5kbGVIZWFwLmNwcApAQCAtNTUsMTIgKzU1LDcgQEAgdm9pZCBIYW5kbGVI ZWFwOjptYXJrU3Ryb25nSGFuZGxlcyhIZWFwUm9vdE1hcmtlciYgaGVhcFJvb3RNYXJrZXIpCiAg ICAgICAgIGhlYXBSb290TWFya2VyLm1hcmsobm9kZS0+c2xvdCgpKTsKIH0KIAotdm9pZCBIYW5k bGVIZWFwOjp1cGRhdGVBZnRlck1hcmsoKQotewotICAgIGNsZWFyV2Vha1BvaW50ZXJzKCk7Ci19 Ci0KLXZvaWQgSGFuZGxlSGVhcDo6Y2xlYXJXZWFrUG9pbnRlcnMoKQordm9pZCBIYW5kbGVIZWFw Ojp1cGRhdGVXZWFrSGFuZGxlcygpCiB7CiAgICAgTm9kZSogZW5kID0gbV93ZWFrTGlzdC5lbmQo KTsKICAgICBmb3IgKE5vZGUqIG5vZGUgPSBtX3dlYWtMaXN0LmJlZ2luKCk7IG5vZGUgIT0gZW5k OyBub2RlID0gbV9uZXh0VG9GaW5hbGl6ZSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2NvbGxlY3Rvci9oYW5kbGVzL0hhbmRsZUhlYXAuaCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9jb2xsZWN0b3IvaGFuZGxlcy9IYW5kbGVIZWFwLmgKaW5kZXggNjc5MTIxNjkxYWU4NWNj ODQwZTI1ODkyZGIzNmY0ZGM5OTljNjlmYi4uYWQyYWE1OTRhNmYzZWZlZmI2NDJjODMwOTFkM2Qy OWNiZjIxNTA0OCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2NvbGxlY3Rvci9o YW5kbGVzL0hhbmRsZUhlYXAuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvY29sbGVjdG9y L2hhbmRsZXMvSGFuZGxlSGVhcC5oCkBAIC01NiwxMCArNTYsNyBAQCBwdWJsaWM6CiAgICAgdm9p ZCBtYWtlV2VhayhIYW5kbGVTbG90LCBXZWFrSGFuZGxlT3duZXIqID0gMCwgdm9pZCogY29udGV4 dCA9IDApOwogCiAgICAgdm9pZCBtYXJrU3Ryb25nSGFuZGxlcyhIZWFwUm9vdE1hcmtlciYpOwot ICAgIHZvaWQgdXBkYXRlQWZ0ZXJNYXJrKCk7Ci0gICAgCi0gICAgLy8gU2hvdWxkIG9ubHkgYmUg Y2FsbGVkIGR1cmluZyB0ZWFyZG93bi4KLSAgICB2b2lkIGNsZWFyV2Vha1BvaW50ZXJzKCk7Cisg ICAgdm9pZCB1cGRhdGVXZWFrSGFuZGxlcygpOwogCiAgICAgdm9pZCB3cml0ZUJhcnJpZXIoSGFu ZGxlU2xvdCwgY29uc3QgSlNWYWx1ZSYpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9IZWFwLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0hl YXAuY3BwCmluZGV4IGUzZWY4YmIzZGYxZDU5MDIwZDgwMDZlM2I3MTg0ZDE0NThmNzgzNTEuLmQ2 NjQyYTdkMThjZWViNzNlYjk1ZmZkYTliMDEwOTE3YjYyYWRjZTAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0hlYXAuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0hlYXAuY3BwCkBAIC04Miw3ICs4Miw3IEBAIHZvaWQgSGVhcDo6ZGVzdHJv eSgpCiAgICAgZGVsZXRlIG1fbWFya0xpc3RTZXQ7CiAgICAgbV9tYXJrTGlzdFNldCA9IDA7CiAg ICAgbV9tYXJrZWRTcGFjZS5jbGVhck1hcmtzKCk7Ci0gICAgbV9oYW5kbGVIZWFwLmNsZWFyV2Vh a1BvaW50ZXJzKCk7CisgICAgbV9oYW5kbGVIZWFwLnVwZGF0ZVdlYWtIYW5kbGVzKCk7CiAgICAg bV9tYXJrZWRTcGFjZS5kZXN0cm95KCk7CiAKICAgICBtX2dsb2JhbERhdGEgPSAwOwpAQCAtMjQ5 LDcgKzI0OSw3IEBAIHZvaWQgSGVhcDo6bWFya1Jvb3RzKCkKICAgICBtYXJrU3RhY2suZHJhaW4o KTsKICAgICBtYXJrU3RhY2suY29tcGFjdCgpOwogICAgIAotICAgIG1faGFuZGxlSGVhcC51cGRh dGVBZnRlck1hcmsoKTsKKyAgICBtX2hhbmRsZUhlYXAudXBkYXRlV2Vha0hhbmRsZXMoKTsKIAog ICAgIG1fb3BlcmF0aW9uSW5Qcm9ncmVzcyA9IE5vT3BlcmF0aW9uOwogfQo=