57788 2011-04-04 14:15:20 -0700 Standardized handling of handles for immediate values 2011-04-04 15:29:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ggaren ggaren abarth eric oliver webkit.review.bot oldest_to_newest 379066 0 ggaren 2011-04-04 14:15:20 -0700 Standardized handling of handles for immediate values 379069 1 88128 ggaren 2011-04-04 14:17:24 -0700 Created attachment 88128 Patch 379079 2 ggaren 2011-04-04 14:30:01 -0700 Committed r82874: <http://trac.webkit.org/changeset/82874> 379134 3 webkit.review.bot 2011-04-04 15:29:36 -0700 http://trac.webkit.org/changeset/82874 might have broken GTK Linux 32-bit Release 88128 2011-04-04 14:17:24 -0700 2011-04-04 14:19:21 -0700 Patch bug-57788-20110404141723.patch text/plain 3875 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODI4NzIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAK KzIwMTEtMDQtMDQgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdGFuZGFyZGl6ZWQgaGFu ZGxpbmcgb2YgaGFuZGxlcyBmb3IgaW1tZWRpYXRlIHZhbHVlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc3ODgKKworICAgICAgICAqIGNvbGxlY3Rv ci9oYW5kbGVzL0hhbmRsZUhlYXAuY3BwOgorICAgICAgICAoSlNDOjpIYW5kbGVIZWFwOjpjbGVh cldlYWtQb2ludGVycyk6IERvbid0IGNoZWNrIGZvciBudWxsIG9yIG5vbi1jZWxsCisgICAgICAg IHZhbHVlcyBoZXJlLCBiZWNhdXNlIG91ciB3cml0ZSBiYXJyaWVyIGd1YXJhbnRlZXMgdGhhdCBz dWNocyB2YWx1ZXMgYXJlCisgICAgICAgIG5vdCBpbiB0aGUgd2VhayBsaXN0LgorCisgICAgICAg IChKU0M6OkhhbmRsZUhlYXA6OndyaXRlQmFycmllcik6IFN0YW5kYXJkaXplZCBvbiBjaGVja2lu ZyBmb3IgbnVsbCBiZWZvcmUKKyAgICAgICAgY2hlY2tpbmcgZm9yIGNlbGwsIGFuZCBvbiB1c2lu ZyBlYXJseSByZXR1cm4gaW5zdGVhZCBvZiBpZi9lbHNlLgorCisgICAgICAgICogY29sbGVjdG9y L2hhbmRsZXMvSGFuZGxlSGVhcC5oOgorICAgICAgICAoSlNDOjpIYW5kbGVIZWFwOjpkZWFsbG9j YXRlKToKKyAgICAgICAgKEpTQzo6SGFuZGxlSGVhcDo6bWFrZVdlYWspOiBEaXR0by4KKwogMjAx MS0wNC0wNCAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIE5v dCByZXZpZXdlZC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9jb2xsZWN0b3IvaGFuZGxl cy9IYW5kbGVIZWFwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvY29s bGVjdG9yL2hhbmRsZXMvSGFuZGxlSGVhcC5jcHAJKHJldmlzaW9uIDgyODcxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2NvbGxlY3Rvci9oYW5kbGVzL0hhbmRsZUhlYXAuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC02NywxNSArNjcsMTQgQEAgdm9pZCBIYW5kbGVIZWFwOjpjbGVhcldlYWtQb2lu dGVycygpCiAgICAgICAgIG1fbmV4dFRvRmluYWxpemUgPSBub2RlLT5uZXh0KCk7CiAKICAgICAg ICAgSlNWYWx1ZSB2YWx1ZSA9ICpub2RlLT5zbG90KCk7Ci0gICAgICAgIGlmICghdmFsdWUgfHwg IXZhbHVlLmlzQ2VsbCgpKQotICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIAorICAgICAg ICBBU1NFUlQodmFsdWUpOworCiAgICAgICAgIEpTQ2VsbCogY2VsbCA9IHZhbHVlLmFzQ2VsbCgp OwotICAgICAgICBBU1NFUlQoIWNlbGwgfHwgY2VsbC0+c3RydWN0dXJlKCkpOwotICAgICAgICAK KyAgICAgICAgQVNTRVJUKGNlbGwgJiYgY2VsbC0+c3RydWN0dXJlKCkpOwogI2lmIEVOQUJMRShK U0NfWk9NQklFUykKICAgICAgICAgQVNTRVJUKCFjZWxsLT5pc1pvbWJpZSgpKTsKICNlbmRpZgor CiAgICAgICAgIGlmIChIZWFwOjppc01hcmtlZChjZWxsKSkKICAgICAgICAgICAgIGNvbnRpbnVl OwogCkBAIC05NywxOCArOTYsMjIgQEAgdm9pZCBIYW5kbGVIZWFwOjp3cml0ZUJhcnJpZXIoSGFu ZGxlU2xvdAogewogICAgIEFTU0VSVCghbV9uZXh0VG9GaW5hbGl6ZSk7IC8vIEZvcmJpZCBhc3Np Z25tZW50IHRvIGhhbmRsZXMgZHVyaW5nIHRoZSBmaW5hbGl6YXRpb24gcGhhc2UsIHNpbmNlIGl0 IHdvdWxkIHZpb2xhdGUgbWFueSBHQyBpbnZhcmlhbnRzLgogCi0gICAgaWYgKHNsb3QtPmlzQ2Vs bCgpID09IHZhbHVlLmlzQ2VsbCgpICYmICF2YWx1ZSA9PSAhKnNsb3QpCisgICAgaWYgKCF2YWx1 ZSA9PSAhKnNsb3QgJiYgc2xvdC0+aXNDZWxsKCkgPT0gdmFsdWUuaXNDZWxsKCkpCiAgICAgICAg IHJldHVybjsKKwogICAgIE5vZGUqIG5vZGUgPSB0b05vZGUoc2xvdCk7CiAgICAgU2VudGluZWxM aW5rZWRMaXN0PE5vZGU+OjpyZW1vdmUobm9kZSk7Ci0gICAgaWYgKCF2YWx1ZS5pc0NlbGwoKSB8 fCAhdmFsdWUpIHsKKyAgICBpZiAoIXZhbHVlIHx8ICF2YWx1ZS5pc0NlbGwoKSkgewogICAgICAg ICBtX2ltbWVkaWF0ZUxpc3QucHVzaChub2RlKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KLSAg ICBpZiAobm9kZS0+aXNXZWFrKCkpCisKKyAgICBpZiAobm9kZS0+aXNXZWFrKCkpIHsKICAgICAg ICAgbV93ZWFrTGlzdC5wdXNoKG5vZGUpOwotICAgIGVsc2UKLSAgICAgICAgbV9zdHJvbmdMaXN0 LnB1c2gobm9kZSk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBtX3N0cm9uZ0xpc3Qu cHVzaChub2RlKTsKIH0KIAogdW5zaWduZWQgSGFuZGxlSGVhcDo6cHJvdGVjdGVkR2xvYmFsT2Jq ZWN0Q291bnQoKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2NvbGxlY3Rvci9oYW5kbGVz L0hhbmRsZUhlYXAuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvY29sbGVj dG9yL2hhbmRsZXMvSGFuZGxlSGVhcC5oCShyZXZpc2lvbiA4Mjg3MikKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9jb2xsZWN0b3IvaGFuZGxlcy9IYW5kbGVIZWFwLmgJKHdvcmtpbmcgY29weSkK QEAgLTE0NSwxMCArMTQ1LDExIEBAIGlubGluZSBIYW5kbGVTbG90IEhhbmRsZUhlYXA6OmFsbG9j YXRlKCkKIGlubGluZSB2b2lkIEhhbmRsZUhlYXA6OmRlYWxsb2NhdGUoSGFuZGxlU2xvdCBoYW5k bGUpCiB7CiAgICAgTm9kZSogbm9kZSA9IHRvTm9kZShoYW5kbGUpOwotICAgIGlmIChtX25leHRU b0ZpbmFsaXplID09IG5vZGUpIHsKKyAgICBpZiAobm9kZSA9PSBtX25leHRUb0ZpbmFsaXplKSB7 CiAgICAgICAgIG1fbmV4dFRvRmluYWxpemUgPSBub2RlLT5uZXh0KCk7CiAgICAgICAgIEFTU0VS VChtX25leHRUb0ZpbmFsaXplLT5uZXh0KCkpOwogICAgIH0KKwogICAgIFNlbnRpbmVsTGlua2Vk TGlzdDxOb2RlPjo6cmVtb3ZlKG5vZGUpOwogICAgIG1fZnJlZUxpc3QucHVzaChub2RlKTsKIH0K QEAgLTE1NiwxMiArMTU3LDE1IEBAIGlubGluZSB2b2lkIEhhbmRsZUhlYXA6OmRlYWxsb2NhdGUo SGFuZGwKIGlubGluZSB2b2lkIEhhbmRsZUhlYXA6Om1ha2VXZWFrKEhhbmRsZVNsb3QgaGFuZGxl LCBXZWFrSGFuZGxlT3duZXIqIHdlYWtPd25lciwgdm9pZCogY29udGV4dCkKIHsKICAgICBOb2Rl KiBub2RlID0gdG9Ob2RlKGhhbmRsZSk7Ci0gICAgU2VudGluZWxMaW5rZWRMaXN0PE5vZGU+Ojpy ZW1vdmUobm9kZSk7CiAgICAgbm9kZS0+bWFrZVdlYWsod2Vha093bmVyLCBjb250ZXh0KTsKLSAg ICBpZiAoaGFuZGxlLT5pc0NlbGwoKSAmJiAqaGFuZGxlKQotICAgICAgICBtX3dlYWtMaXN0LnB1 c2gobm9kZSk7Ci0gICAgZWxzZQorCisgICAgU2VudGluZWxMaW5rZWRMaXN0PE5vZGU+OjpyZW1v dmUobm9kZSk7CisgICAgaWYgKCEqaGFuZGxlIHx8ICFoYW5kbGUtPmlzQ2VsbCgpKSB7CiAgICAg ICAgIG1faW1tZWRpYXRlTGlzdC5wdXNoKG5vZGUpOworICAgICAgICByZXR1cm47CisgICAgfQor CisgICAgbV93ZWFrTGlzdC5wdXNoKG5vZGUpOwogfQogCiAjaWYgIUFTU0VSVF9ESVNBQkxFRAo=