57782 2011-04-04 13:22:44 -0700 Replace SKIA_TEXT with isNativeFontRenderingAllowed() for print-preview to work 2011-04-08 13:08:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 reed reed commit-queue ctguil eric jamesr kbr oldest_to_newest 379008 0 reed 2011-04-04 13:22:44 -0700 Replace SKIA_TEXT with isNativeFontRenderingAllowed() for print-preview to work 379010 1 88112 reed 2011-04-04 13:23:46 -0700 Created attachment 88112 Patch 380997 2 88112 kbr 2011-04-06 17:36:43 -0700 Comment on attachment 88112 Patch Looks fine to me as long as it's been tested. 381059 3 kbr 2011-04-06 19:04:31 -0700 Also, did you want a cq+? Please mark bugs with cq? if so. ('webkit-patch upload' does this automatically.) 381727 4 ctguil 2011-04-07 14:44:00 -0700 Shouldn't this change already be landed from this change: http://trac.webkit.org/changeset/82532/trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp Am I missing something? 381860 5 88112 commit-queue 2011-04-07 17:03:48 -0700 Comment on attachment 88112 Patch Rejecting attachment 88112 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'bu..." exit_code: 2 Last 500 characters of output: error continues to appear after building again then the build system needs to be modified so that the inappropriate files are no longer copied in to the framework. Command /bin/sh failed with exit code 1 Command /bin/sh failed with exit code 1 ** BUILD FAILED ** The following build commands failed: WebCore: PhaseScriptExecution "Check For Inappropriate Files In Framework" /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Script-5DF50887116F3077005202AB.sh (1 failure) Full output: http://queues.webkit.org/results/8373286 382212 6 88817 reed 2011-04-08 07:02:01 -0700 Created attachment 88817 Patch 382236 7 88817 eric 2011-04-08 08:08:58 -0700 Comment on attachment 88817 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88817&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Any way to test this? We technically have printing tests but no one uses them. 382244 8 reed 2011-04-08 08:23:21 -0700 It is also testable when we define SKIA_GPU, which implements the isNativeFontRenderingAllowed() call. It is in that scenario that I saw the bug, where we had missed this one location in an earlier patch change replaced SKIA_TEXT with isNativeFontRenderingAllowed(). Without this patch, we fail to properly setup the paint (calling setupPaintForFont) but we still fall into skiaDrawText, which draws but with the wrong font, etc. 382249 9 eric 2011-04-08 08:25:40 -0700 So when Chrome runs new-run-webkit-tests in "gpu tests mode" or whatever this path is tested (and baselines will need updates)? Is that correct? 382257 10 reed 2011-04-08 08:47:37 -0700 Not yet. SKIA_GPU is not yet the default for gpu. It is just under developement. Under the existing SW and GPU builds, the only change should affect print-preview, which should get more correct stroked text. I don't expect any image rebaselining related to this change. 382328 11 eric 2011-04-08 10:06:20 -0700 Ok. Ideally your ChangeLog should explain why there is no testing. In this case, this is impossible to test as it only affects print preview. Unfortunately this chagne can't be cq+'d as is because it has OOPS on the test line. the cq is smart enough to replace the OOPS in the reviewer line with the actual reviewer, but wont' fix the testing line and thus the pre-commit hook which checks for OOPS in ChangeLog files will fail. It's kidna confusing, I know. :( 382335 12 88837 reed 2011-04-08 10:12:43 -0700 Created attachment 88837 Patch 382336 13 reed 2011-04-08 10:13:21 -0700 updated Tests in ChangeLog (I had just forgotten to do that, sorry) 382342 14 88837 eric 2011-04-08 10:19:16 -0700 Comment on attachment 88837 Patch Thanks. 382485 15 commit-queue 2011-04-08 13:04:56 -0700 The commit-queue encountered the following flaky tests while processing attachment 88837: http/tests/websocket/tests/handshake-fail-by-no-cr.html bug 58156 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 382490 16 88837 commit-queue 2011-04-08 13:08:32 -0700 Comment on attachment 88837 Patch Clearing flags on attachment: 88837 Committed r83329: <http://trac.webkit.org/changeset/83329> 382491 17 commit-queue 2011-04-08 13:08:36 -0700 All reviewed patches have been landed. Closing bug. 88112 2011-04-04 13:23:46 -0700 2011-04-08 07:01:57 -0700 Patch bug-57782-20110404162345.patch text/plain 1603 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyODU5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMDQgIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZXBsYWNlIFNLSUFfVEVYVCB3aXRoIGlzTmF0aXZlRm9udFJlbmRlcmlu Z0FsbG93ZWQoKSBmb3IgcHJpbnQtcHJldmlldyB0byB3b3JrCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Nzc4MgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cy4gRXhpc3RpbmcgdGVzdHMgdGhhdCBleGVyY2lzZSB0ZXh0IGRyYXdpbmcgZXhlcmNpc2UgdGhp cyBwYXRoLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Ta2lhRm9udFdpbi5j cHA6CisgICAgICAgIChXZWJDb3JlOjpwYWludFNraWFUZXh0KToKKwogMjAxMS0wNC0wNCAgQWRh bSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgQXR0ZW1wdGVkIE1hYyBidWls ZCBmaXgKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvU2tpYUZv bnRXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3NraWEvU2tpYUZvbnRXaW4uY3BwCShyZXZpc2lvbiA4Mjg0NykKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvU2tpYUZvbnRXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zNzcsMTAgKzM3NywxMCBAQCBib29sIHBhaW50U2tpYVRleHQoR3JhcGhpY3NDb250ZXh0KiBj b250CiAgICAgICAgIHBhaW50LnJlc2V0KCk7CiAgICAgICAgIHBsYXRmb3JtQ29udGV4dC0+c2V0 dXBQYWludEZvclN0cm9raW5nKCZwYWludCwgMCwgMCk7CiAgICAgICAgIHBhaW50LnNldEZsYWdz KFNrUGFpbnQ6OmtBbnRpQWxpYXNfRmxhZyk7Ci0jaWYgRU5BQkxFKFNLSUFfVEVYVCkKLSAgICAg ICAgcGFpbnQuc2V0VGV4dEVuY29kaW5nKFNrUGFpbnQ6OmtHbHlwaElEX1RleHRFbmNvZGluZyk7 Ci0gICAgICAgIHNldHVwUGFpbnRGb3JGb250KGhmb250LCAmcGFpbnQpOwotI2VuZGlmCisgICAg ICAgIGlmICghcGxhdGZvcm1Db250ZXh0LT5pc05hdGl2ZUZvbnRSZW5kZXJpbmdBbGxvd2VkKCkp IHsKKyAgICAgICAgICAgIHBhaW50LnNldFRleHRFbmNvZGluZyhTa1BhaW50OjprR2x5cGhJRF9U ZXh0RW5jb2RpbmcpOworICAgICAgICAgICAgc2V0dXBQYWludEZvckZvbnQoaGZvbnQsICZwYWlu dCk7CisgICAgICAgIH0KIAogICAgICAgICBpZiAoZGlkRmlsbCkgewogICAgICAgICAgICAgLy8g SWYgdGhlcmUgaXMgYSBzaGFkb3cgYW5kIHdlIGZpbGxlZCBhYm92ZSwgdGhlcmUgd2lsbCBhbHJl YWR5IGJlCg== 88817 2011-04-08 07:02:01 -0700 2011-04-08 10:12:39 -0700 Patch bug-57782-20110408100200.patch text/plain 1563 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMjkwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMDggIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZXBsYWNlIFNLSUFfVEVYVCB3aXRoIGlzTmF0aXZlRm9udFJlbmRlcmlu Z0FsbG93ZWQoKSBmb3IgcHJpbnQtcHJldmlldyB0byB3b3JrCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Nzc4MgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cy4gKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Ta2lhRm9udFdp bi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpwYWludFNraWFUZXh0KToKKwogMjAxMS0wNC0wOCAg UGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvc2tpYS9Ta2lhRm9udFdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Ta2lhRm9udFdpbi5jcHAJKHJldmlzaW9uIDgzMTk1KQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Ta2lhRm9udFdpbi5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTM3NywxMCArMzc3LDEwIEBAIGJvb2wgcGFpbnRTa2lhVGV4dChH cmFwaGljc0NvbnRleHQqIGNvbnQKICAgICAgICAgcGFpbnQucmVzZXQoKTsKICAgICAgICAgcGxh dGZvcm1Db250ZXh0LT5zZXR1cFBhaW50Rm9yU3Ryb2tpbmcoJnBhaW50LCAwLCAwKTsKICAgICAg ICAgcGFpbnQuc2V0RmxhZ3MoU2tQYWludDo6a0FudGlBbGlhc19GbGFnKTsKLSNpZiBFTkFCTEUo U0tJQV9URVhUKQotICAgICAgICBwYWludC5zZXRUZXh0RW5jb2RpbmcoU2tQYWludDo6a0dseXBo SURfVGV4dEVuY29kaW5nKTsKLSAgICAgICAgc2V0dXBQYWludEZvckZvbnQoaGZvbnQsICZwYWlu dCk7Ci0jZW5kaWYKKyAgICAgICAgaWYgKCFwbGF0Zm9ybUNvbnRleHQtPmlzTmF0aXZlRm9udFJl bmRlcmluZ0FsbG93ZWQoKSkgeworICAgICAgICAgICAgcGFpbnQuc2V0VGV4dEVuY29kaW5nKFNr UGFpbnQ6OmtHbHlwaElEX1RleHRFbmNvZGluZyk7CisgICAgICAgICAgICBzZXR1cFBhaW50Rm9y Rm9udChoZm9udCwgJnBhaW50KTsKKyAgICAgICAgfQogCiAgICAgICAgIGlmIChkaWRGaWxsKSB7 CiAgICAgICAgICAgICAvLyBJZiB0aGVyZSBpcyBhIHNoYWRvdyBhbmQgd2UgZmlsbGVkIGFib3Zl LCB0aGVyZSB3aWxsIGFscmVhZHkgYmUK 88837 2011-04-08 10:12:43 -0700 2011-04-08 13:08:32 -0700 Patch bug-57782-20110408131242.patch text/plain 1621 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMjkyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMDggIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZXBsYWNlIFNLSUFfVEVYVCB3aXRoIGlzTmF0aXZlRm9udFJlbmRlcmlu Z0FsbG93ZWQoKSBmb3IgcHJpbnQtcHJldmlldyB0byB3b3JrCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Nzc4MgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cy4gVGhpcyBjaGFuZ2Ugb25seSBhZmZlY3RzIHByaW50LXByZXZpZXcgYW5kIGJ1aWxkIG9wdGlv biBTS0lBX0dQVSAKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvU2tpYUZvbnRX aW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGFpbnRTa2lhVGV4dCk6CisKIDIwMTEtMDQtMDgg IFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3NraWEvU2tpYUZvbnRXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvU2tpYUZvbnRXaW4uY3BwCShyZXZpc2lvbiA4MzI5MikK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvU2tpYUZvbnRXaW4uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zNzcsMTAgKzM3NywxMCBAQCBib29sIHBhaW50U2tpYVRleHQo R3JhcGhpY3NDb250ZXh0KiBjb250CiAgICAgICAgIHBhaW50LnJlc2V0KCk7CiAgICAgICAgIHBs YXRmb3JtQ29udGV4dC0+c2V0dXBQYWludEZvclN0cm9raW5nKCZwYWludCwgMCwgMCk7CiAgICAg ICAgIHBhaW50LnNldEZsYWdzKFNrUGFpbnQ6OmtBbnRpQWxpYXNfRmxhZyk7Ci0jaWYgRU5BQkxF KFNLSUFfVEVYVCkKLSAgICAgICAgcGFpbnQuc2V0VGV4dEVuY29kaW5nKFNrUGFpbnQ6OmtHbHlw aElEX1RleHRFbmNvZGluZyk7Ci0gICAgICAgIHNldHVwUGFpbnRGb3JGb250KGhmb250LCAmcGFp bnQpOwotI2VuZGlmCisgICAgICAgIGlmICghcGxhdGZvcm1Db250ZXh0LT5pc05hdGl2ZUZvbnRS ZW5kZXJpbmdBbGxvd2VkKCkpIHsKKyAgICAgICAgICAgIHBhaW50LnNldFRleHRFbmNvZGluZyhT a1BhaW50OjprR2x5cGhJRF9UZXh0RW5jb2RpbmcpOworICAgICAgICAgICAgc2V0dXBQYWludEZv ckZvbnQoaGZvbnQsICZwYWludCk7CisgICAgICAgIH0KIAogICAgICAgICBpZiAoZGlkRmlsbCkg ewogICAgICAgICAgICAgLy8gSWYgdGhlcmUgaXMgYSBzaGFkb3cgYW5kIHdlIGZpbGxlZCBhYm92 ZSwgdGhlcmUgd2lsbCBhbHJlYWR5IGJlCg==