57772 2011-04-04 11:57:50 -0700 Implement various "NotImplemented" file handling functions 2011-04-04 12:16:58 -0700 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 mmacleod webkit-unassigned kevino webkit.review.bot oldest_to_newest 378935 0 88090 mmacleod 2011-04-04 11:57:50 -0700 Created attachment 88090 Temporary files handling patch Various file handling functions, mostly relating to temporary files are not yet implemented on the wx port. This prevents PDF embedding (embed/object tag) from working correctly (on some machines?) as well as possibly interfering with various other functionality as well. The attached patch implements these functions allowing PDF embedding to work correctly. 378941 1 webkit.review.bot 2011-04-04 12:03:57 -0700 Attachment 88090 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style']" exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 378951 2 kevino 2011-04-04 12:16:58 -0700 Landed in r82851, thanks! 88090 2011-04-04 11:57:50 -0700 2011-04-04 12:07:00 -0700 Temporary files handling patch tempfiles.patch text/plain 3172 mmacleod SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFNvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODI4NDYpDQorKysgU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpDQpAQCAtMSwzICsxLDE2IEBADQorMjAxMS0wNC0wNCAgTWFs Y29sbSBNYWNMZW9kICA8bW1hY2xlb2RAd2VibWFpbC5jby56YT4NCisNCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLg0KKw0KKyAgICAgICAgW3d4XSBJbXBsZW1lbnQgc3VwcG9y dCBmb3IgdGVtcG9yYXJ5IGZpbGVzLg0KKw0KKyAgICAgICAgKiBwbGF0Zm9ybS9GaWxlU3lzdGVt Lmg6DQorICAgICAgICAqIHBsYXRmb3JtL3d4L0ZpbGVTeXN0ZW1XeC5jcHA6DQorICAgICAgICAo V2ViQ29yZTo6Z2V0RmlsZU1vZGlmaWNhdGlvblRpbWUpOg0KKyAgICAgICAgKFdlYkNvcmU6Om9w ZW5UZW1wb3JhcnlGaWxlKToNCisgICAgICAgIChXZWJDb3JlOjpjbG9zZUZpbGUpOg0KKyAgICAg ICAgKFdlYkNvcmU6OndyaXRlVG9GaWxlKToNCisNCiAyMDExLTA0LTA0ICBZdXJ5IFNlbWlraGF0 c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPg0KIA0KICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwg RmVsZG1hbi4NCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlU3lzdGVtLmgNCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0NCi0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlU3lzdGVtLmgJKHJldmlz aW9uIDgyODM0KQ0KKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVTeXN0ZW0uaAkod29y a2luZyBjb3B5KQ0KQEAgLTQ3LDYgKzQ3LDExIEBADQogI2VuZGlmDQogI2VuZGlmDQogDQorI2lm IFBMQVRGT1JNKFdYKQ0KKyNpbmNsdWRlIDx3eC9kZWZzLmg+DQorI2luY2x1ZGUgPHd4L2ZpbGUu aD4NCisjZW5kaWYNCisNCiAjaWYgVVNFKENGKSB8fCAoUExBVEZPUk0oUVQpICYmIGRlZmluZWQo UV9XU19NQUMpKQ0KIHR5cGVkZWYgc3RydWN0IF9fQ0ZCdW5kbGUqIENGQnVuZGxlUmVmOw0KIHR5 cGVkZWYgY29uc3Qgc3RydWN0IF9fQ0ZEYXRhKiBDRkRhdGFSZWY7DQpAQCAtMTI4LDYgKzEzMyw5 IEBADQogI2VsaWYgUExBVEZPUk0oR1RLKQ0KIHR5cGVkZWYgR0ZpbGVJT1N0cmVhbSogUGxhdGZv cm1GaWxlSGFuZGxlOw0KIGNvbnN0IFBsYXRmb3JtRmlsZUhhbmRsZSBpbnZhbGlkUGxhdGZvcm1G aWxlSGFuZGxlID0gMDsNCisjZWxpZiBQTEFURk9STShXWCkNCit0eXBlZGVmIHd4RmlsZSogUGxh dGZvcm1GaWxlSGFuZGxlOw0KK2NvbnN0IFBsYXRmb3JtRmlsZUhhbmRsZSBpbnZhbGlkUGxhdGZv cm1GaWxlSGFuZGxlID0gMDsNCiAjZWxzZQ0KIHR5cGVkZWYgaW50IFBsYXRmb3JtRmlsZUhhbmRs ZTsNCiBjb25zdCBQbGF0Zm9ybUZpbGVIYW5kbGUgaW52YWxpZFBsYXRmb3JtRmlsZUhhbmRsZSA9 IC0xOw0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3d4L0ZpbGVTeXN0ZW1XeC5jcHAN Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0NCi0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93eC9GaWxlU3lzdGVtV3gu Y3BwCShyZXZpc2lvbiA4MjgzNCkNCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93eC9GaWxl U3lzdGVtV3guY3BwCSh3b3JraW5nIGNvcHkpDQpAQCAtNzgsOCArNzgsMTEgQEANCiANCiBib29s IGdldEZpbGVNb2RpZmljYXRpb25UaW1lKGNvbnN0IFN0cmluZyYgcGF0aCwgdGltZV90JiB0KQ0K IHsNCi0gICAgdCA9IHd4RmlsZU5hbWUocGF0aCkuR2V0TW9kaWZpY2F0aW9uVGltZSgpLkdldFRp Y2tzKCk7DQotICAgIHJldHVybiB0cnVlOw0KKyAgICBpZiAod3hGaWxlRXhpc3RzKHBhdGgpKSB7 DQorICAgICAgICB0ID0gd3hGaWxlTmFtZShwYXRoKS5HZXRNb2RpZmljYXRpb25UaW1lKCkuR2V0 VGlja3MoKTsNCisgICAgICAgIHJldHVybiB0cnVlOw0KKyAgICB9DQorICAgIHJldHVybiBmYWxz ZTsNCiB9DQogDQogYm9vbCBtYWtlQWxsRGlyZWN0b3JpZXMoY29uc3QgU3RyaW5nJiBwYXRoKQ0K QEAgLTEwNywyMiArMTEwLDI2IEBADQogICAgIHJldHVybiB3eEZpbGVOYW1lKHBhdGgpLkdldFBh dGgoKTsNCiB9DQogDQotU3RyaW5nIG9wZW5UZW1wb3JhcnlGaWxlKGNvbnN0IFN0cmluZyYsIFBs YXRmb3JtRmlsZUhhbmRsZSYgaGFuZGxlKQ0KK1N0cmluZyBvcGVuVGVtcG9yYXJ5RmlsZShjb25z dCBTdHJpbmcmIHByZWZpeCwgUGxhdGZvcm1GaWxlSGFuZGxlJiBoYW5kbGUpDQogew0KLSAgICBu b3RJbXBsZW1lbnRlZCgpOw0KLSAgICBoYW5kbGUgPSBpbnZhbGlkUGxhdGZvcm1GaWxlSGFuZGxl Ow0KLSAgICByZXR1cm4gU3RyaW5nKCk7DQorICAgIHd4U3RyaW5nIHNGaWxlbmFtZSA9IHd4Rmls ZU5hbWU6OkNyZWF0ZVRlbXBGaWxlTmFtZShwcmVmaXgpOw0KKyAgICB3eEZpbGUqIHRlbXAgPSBu ZXcgd3hGaWxlKCk7DQorICAgIHRlbXAtPk9wZW4oc0ZpbGVuYW1lLmNfc3RyKCksIHd4RmlsZTo6 cmVhZF93cml0ZSk7DQorICAgIGhhbmRsZSA9IHRlbXA7DQorICAgIHJldHVybiBTdHJpbmcoc0Zp bGVuYW1lKTsNCiB9DQogDQotdm9pZCBjbG9zZUZpbGUoUGxhdGZvcm1GaWxlSGFuZGxlJikNCit2 b2lkIGNsb3NlRmlsZShQbGF0Zm9ybUZpbGVIYW5kbGUmIGhhbmRsZSkNCiB7DQotICAgIG5vdElt cGxlbWVudGVkKCk7DQorICAgIGlmIChoYW5kbGUpDQorICAgICAgICBkZWxldGUgaGFuZGxlOw0K IH0NCiANCi1pbnQgd3JpdGVUb0ZpbGUoUGxhdGZvcm1GaWxlSGFuZGxlLCBjb25zdCBjaGFyKiBk YXRhLCBpbnQgbGVuZ3RoKQ0KK2ludCB3cml0ZVRvRmlsZShQbGF0Zm9ybUZpbGVIYW5kbGUgaGFu ZGxlLCBjb25zdCBjaGFyKiBkYXRhLCBpbnQgbGVuZ3RoKQ0KIHsNCi0gICAgbm90SW1wbGVtZW50 ZWQoKTsNCi0gICAgcmV0dXJuIDA7DQorICAgIGlmIChoYW5kbGUpDQorICAgICAgICByZXR1cm4g aGFuZGxlLT5Xcml0ZShkYXRhLCBsZW5ndGgpOw0KKyAgICByZXR1cm4gLTE7DQogfQ0KIA0KIGJv b2wgdW5sb2FkTW9kdWxlKFBsYXRmb3JtTW9kdWxlIG1vZCkNCg==