57755 2011-04-04 07:57:10 -0700 REGRESSION(r81328): Null pointer crash in canAppendNewLineFeed when selection isn't inside an editable element 2011-04-06 01:52:57 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P1 Normal --- 1 skylined webkit-unassigned abarth commit-queue eric honten isherman rniwa webkit.review.bot oldest_to_newest 378784 0 88058 skylined 2011-04-04 07:57:10 -0700 Created attachment 88058 Repro Chromium: http://code.google.com/p/chromium/issues/detail?id=78320 "selection.rootEditableElement()" can return NULL, something that "canAppendNewLineFeed" does not handle: static bool canAppendNewLineFeed(const VisibleSelection& selection) { ExceptionCode ec = 0; RefPtr<BeforeTextInsertedEvent> event = BeforeTextInsertedEvent::create(String("\n")); selection.rootEditableElement()->dispatchEvent(event, ec); // CRASH return event->text().length(); } Repro: <body onload="go()"> <script> function go() { document.designMode="on"; document.write("</"); document.getSelection().addRange(document.createRange()); document.execCommand("InsertLineBreak"); } </script> id: chrome.dll!WebCore::EventTarget::dispatchEvent ReadAV@NULL (6c815dec64b94a3dde8974a25da7f213) description: Attempt to read from unallocated NULL pointer in chrome.dll!WebCore::EventTarget::dispatchEvent application: Chromium 12.0.725.0 stack: chrome.dll!WebCore::EventTarget::dispatchEvent chrome.dll!WebCore::canAppendNewLineFeed chrome.dll!WebCore::TypingCommand::insertLineBreak chrome.dll!WebCore::EditCommand::apply chrome.dll!WebCore::applyCommand chrome.dll!WebCore::TypingCommand::insertLineBreak chrome.dll!WebCore::executeInsertLineBreak chrome.dll!WebCore::Editor::Command::execute chrome.dll!WebCore::Document::execCommand chrome.dll!WebCore::DocumentInternal::execCommandCallback chrome.dll!v8::internal::HandleApiCallHelper<...> chrome.dll!v8::internal::Builtin_HandleApiCall chrome.dll!v8::internal::Invoke chrome.dll!v8::internal::Execution::Call ... 379452 1 rniwa 2011-04-05 05:02:28 -0700 Naoki, could you fix this crash? 379610 2 honten 2011-04-05 09:03:13 -0700 Ok, I'll look into it. 380021 3 honten 2011-04-05 18:27:23 -0700 I can reproduce ToT. 380060 4 88353 honten 2011-04-05 19:44:05 -0700 Created attachment 88353 Patch 380061 5 88353 honten 2011-04-05 19:44:26 -0700 Comment on attachment 88353 Patch Please review. 380154 6 88353 rniwa 2011-04-05 23:22:21 -0700 Comment on attachment 88353 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88353&action=review > LayoutTests/editing/execCommand/insert-line-break-onload.html:1 > +<body onload="go()"> Missing DOCTYPE. > LayoutTests/editing/execCommand/insert-line-break-onload.html:2 > +Test InsertLineBreak is called correctly without any exception. Mn... I'd expect that adding this line would stop reproducing the crash. Did you make sure this test case cause a crash? > LayoutTests/editing/execCommand/insert-line-break-onload.html:10 > + var result = "Calling InsertLineBreak succeeded without any exception."; I'd just print 'PASS' with the test description because that's what other tests do. > LayoutTests/editing/execCommand/insert-line-break-onload.html:15 > + } else > + alert(result); Why do you need an alert here? I'd expect for document.write to work here as well. > Source/WebCore/editing/TypingCommand.cpp:52 > + if (Node* node = selection.rootEditableElement()) { We normally do an early exit in these cases. 380160 7 honten 2011-04-05 23:33:25 -0700 Thank you for your review. (In reply to comment #6) > > LayoutTests/editing/execCommand/insert-line-break-onload.html:2 > > +Test InsertLineBreak is called correctly without any exception. > > Mn... I'd expect that adding this line would stop reproducing the crash. Did you make sure this test case cause a crash? Yes, it crashes. > > LayoutTests/editing/execCommand/insert-line-break-onload.html:15 > > + } else > > + alert(result); > > Why do you need an alert here? I'd expect for document.write to work here as well. Because I referred to insert-line-break-no-scroll.html Anyway I'll change it to use document.write(). 380168 8 88376 honten 2011-04-05 23:44:56 -0700 Created attachment 88376 Patch 380169 9 88376 honten 2011-04-05 23:45:16 -0700 Comment on attachment 88376 Patch Please review again. 380170 10 88376 honten 2011-04-05 23:47:09 -0700 Comment on attachment 88376 Patch Oops, I forgot to change one more thing... 380171 11 88377 honten 2011-04-05 23:50:36 -0700 Created attachment 88377 Patch 380172 12 88377 honten 2011-04-05 23:50:53 -0700 Comment on attachment 88377 Patch Ok, please review again. 380182 13 88377 commit-queue 2011-04-06 00:22:47 -0700 Comment on attachment 88377 Patch Clearing flags on attachment: 88377 Committed r83026: <http://trac.webkit.org/changeset/83026> 380183 14 commit-queue 2011-04-06 00:22:53 -0700 All reviewed patches have been landed. Closing bug. 380218 15 webkit.review.bot 2011-04-06 01:52:57 -0700 http://trac.webkit.org/changeset/83026 might have broken GTK Linux 32-bit Debug 88058 2011-04-04 07:57:10 -0700 2011-04-04 07:57:10 -0700 Repro repro.html text/html 224 skylined PGJvZHkgb25sb2FkPSJnbygpIj4KPHNjcmlwdD4KICBmdW5jdGlvbiBnbygpIHsKICAgIGRvY3Vt ZW50LmRlc2lnbk1vZGU9Im9uIjsKICAgIGRvY3VtZW50LndyaXRlKCI8LyIpOwogICAgZG9jdW1l bnQuZ2V0U2VsZWN0aW9uKCkuYWRkUmFuZ2UoZG9jdW1lbnQuY3JlYXRlUmFuZ2UoKSk7CiAgICBk b2N1bWVudC5leGVjQ29tbWFuZCgiSW5zZXJ0TGluZUJyZWFrIik7CiAgfQo8L3NjcmlwdD4= 88353 2011-04-05 19:44:05 -0700 2011-04-05 23:44:53 -0700 Patch bug-57755-20110405194404.patch text/plain 4120 honten U3VidmVyc2lvbiBSZXZpc2lvbjogODI1NDkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzZDQ3NGYwZDJjN2U2YzdlY2QxMTY1 M2M3ZTNlNDVkZDY5OTM1MjkwLi5jMjk4ZWI1MDZiZjQ0NmQyOWZkYTA3ZDc2OGZjNGI3ZjNlMzM0 ODdmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMDUgIE5hb2tpIFRha2FubyAgPHRh a2Fuby5uYW9raUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUkVHUkVTU0lPTihyODEzMjgpOiBOdWxsIHBvaW50ZXIgY3Jhc2ggaW4g Y2FuQXBwZW5kTmV3TGluZUZlZWQgd2hlbiBzZWxlY3Rpb24gaXNuJ3QgaW5zaWRlIGFuIGVkaXRh YmxlIGVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU3NzU1CisKKyAgICAgICAgKiBlZGl0aW5nL2V4ZWNDb21tYW5kL2luc2VydC1saW5lLWJy ZWFrLW9ubG9hZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvZXhlY0Nv bW1hbmQvaW5zZXJ0LWxpbmUtYnJlYWstb25sb2FkLmh0bWw6IEFkZGVkIHRvIGNoZWNrIGNhbGxp bmcgSW5zZXJ0TGluZUJyZWFrIHdpdGhvdXQgYW55IGNyYXNoLgorCiAyMDExLTAzLTMwICBTYW0g V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkaW5nIGZhc3QvZG9tL0hUTUxL ZXlnZW5FbGVtZW50L2tleWdlbi5odG1sIHRvIG1hYy13azIgU2tpcHBlZCBsaXN0CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2luc2VydC1saW5lLWJyZWFrLW9u bG9hZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2luc2Vy dC1saW5lLWJyZWFrLW9ubG9hZC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDdjNDhkMjU1OGVj ZDdlMTBiM2RkNGZmMTZhMDZmZDQ2ZTVkMzljNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvaW5zZXJ0LWxpbmUtYnJlYWstb25sb2FkLWV4cGVjdGVk LnR4dApAQCAtMCwwICsxIEBACitDYWxsaW5nIEluc2VydExpbmVCcmVhayBzdWNjZWVkZWQgd2l0 aG91dCBhbnkgZXhjZXB0aW9uLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVj Q29tbWFuZC9pbnNlcnQtbGluZS1icmVhay1vbmxvYWQuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRp bmcvZXhlY0NvbW1hbmQvaW5zZXJ0LWxpbmUtYnJlYWstb25sb2FkLmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u MGY4YzA1NzljYjU2ZTM3Y2IxNTFkNWVkOGE5ZWExYzEzMGViNDQ3MgotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvaW5zZXJ0LWxpbmUtYnJlYWstb25s b2FkLmh0bWwKQEAgLTAsMCArMSwxNyBAQAorPGJvZHkgb25sb2FkPSJnbygpIj4KK1Rlc3QgSW5z ZXJ0TGluZUJyZWFrIGlzIGNhbGxlZCBjb3JyZWN0bHkgd2l0aG91dCBhbnkgZXhjZXB0aW9uLgor PHNjcmlwdD4KK2Z1bmN0aW9uIGdvKCkgeworICAgIGRvY3VtZW50LmRlc2lnbk1vZGU9Im9uIjsK KyAgICBkb2N1bWVudC53cml0ZSgiPC8iKTsKKyAgICBkb2N1bWVudC5nZXRTZWxlY3Rpb24oKS5h ZGRSYW5nZShkb2N1bWVudC5jcmVhdGVSYW5nZSgpKTsKKyAgICBkb2N1bWVudC5leGVjQ29tbWFu ZCgiSW5zZXJ0TGluZUJyZWFrIik7CisKKyAgICB2YXIgcmVzdWx0ID0gIkNhbGxpbmcgSW5zZXJ0 TGluZUJyZWFrIHN1Y2NlZWRlZCB3aXRob3V0IGFueSBleGNlcHRpb24uIjsKKyAgICBpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgIGRvY3VtZW50LndyaXRlKCI8aHRt bD4iICsgcmVzdWx0ICsgIjxodG1sPiIpOworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5k dW1wQXNUZXh0KCk7CisgICAgfSBlbHNlCisgICAgICAgIGFsZXJ0KHJlc3VsdCk7Cit9Cis8L3Nj cmlwdD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwppbmRleCBmMmIxNTM1ZTkyNTRkY2Y2ZThkNjcyZTc4MWQ3MTU2OGMxYWNk NTE2Li42ZGQ0MTcwMGY0NDdkN2Y1ZmE0YTIwMmEyMDFkMTIxOTliMTkzYzNjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMDUgIE5hb2tpIFRha2FubyAgPHRha2Fuby5uYW9r aUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUkVHUkVTU0lPTihyODEzMjgpOiBOdWxsIHBvaW50ZXIgY3Jhc2ggaW4gY2FuQXBwZW5k TmV3TGluZUZlZWQgd2hlbiBzZWxlY3Rpb24gaXNuJ3QgaW5zaWRlIGFuIGVkaXRhYmxlIGVsZW1l bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NzU1 CisKKyAgICAgICAgVGVzdDogZWRpdGluZy9leGVjQ29tbWFuZC9pbnNlcnQtbGluZS1icmVhay1v bmxvYWQuaHRtbAorCisgICAgICAgICogZWRpdGluZy9UeXBpbmdDb21tYW5kLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OmNhbkFwcGVuZE5ld0xpbmVGZWVkKTogQWRkZWQgbnVsbCBwb2ludGVyIGNo ZWNrIGZvciByb290RWRpdGFibGVFbGVtZW50KCkuCisKIDIwMTEtMDMtMzAgIEJyZW50IEZ1bGdo YW0gIDxiZnVsZ2hhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgY29y cmVjdGlvbiBhZnRlciByODI0OTYuIChQYXJ0IDMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL1R5cGluZ0NvbW1hbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UeXBp bmdDb21tYW5kLmNwcAppbmRleCBhZWRkYTMxZjdlYThmM2NlNjNiM2IwNzg4YzYyMDhjZTI1OTBm Nzg5Li5jZjc0MTgzMjBjZmVlOTE2YjMxNzM3YWVhMjc4YTk3NzNmZTI1YTUxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1R5cGluZ0NvbW1hbmQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvVHlwaW5nQ29tbWFuZC5jcHAKQEAgLTQ5LDEwICs0OSwxMyBAQCB1c2lu ZyBuYW1lc3BhY2UgSFRNTE5hbWVzOwogCiBzdGF0aWMgYm9vbCBjYW5BcHBlbmROZXdMaW5lRmVl ZChjb25zdCBWaXNpYmxlU2VsZWN0aW9uJiBzZWxlY3Rpb24pCiB7Ci0gICAgRXhjZXB0aW9uQ29k ZSBlYyA9IDA7Ci0gICAgUmVmUHRyPEJlZm9yZVRleHRJbnNlcnRlZEV2ZW50PiBldmVudCA9IEJl Zm9yZVRleHRJbnNlcnRlZEV2ZW50OjpjcmVhdGUoU3RyaW5nKCJcbiIpKTsKLSAgICBzZWxlY3Rp b24ucm9vdEVkaXRhYmxlRWxlbWVudCgpLT5kaXNwYXRjaEV2ZW50KGV2ZW50LCBlYyk7Ci0gICAg cmV0dXJuIGV2ZW50LT50ZXh0KCkubGVuZ3RoKCk7CisgICAgaWYgKE5vZGUqIG5vZGUgPSBzZWxl Y3Rpb24ucm9vdEVkaXRhYmxlRWxlbWVudCgpKSB7CisgICAgICAgIFJlZlB0cjxCZWZvcmVUZXh0 SW5zZXJ0ZWRFdmVudD4gZXZlbnQgPSBCZWZvcmVUZXh0SW5zZXJ0ZWRFdmVudDo6Y3JlYXRlKFN0 cmluZygiXG4iKSk7CisgICAgICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOworICAgICAgICBub2Rl LT5kaXNwYXRjaEV2ZW50KGV2ZW50LCBlYyk7CisgICAgICAgIHJldHVybiBldmVudC0+dGV4dCgp Lmxlbmd0aCgpOworICAgIH0KKyAgICByZXR1cm4gZmFsc2U7CiB9CiAKIFR5cGluZ0NvbW1hbmQ6 OlR5cGluZ0NvbW1hbmQoRG9jdW1lbnQgKmRvY3VtZW50LCBFVHlwaW5nQ29tbWFuZCBjb21tYW5k VHlwZSwgY29uc3QgU3RyaW5nICZ0ZXh0VG9JbnNlcnQsIFR5cGluZ0NvbW1hbmRPcHRpb25zIG9w dGlvbnMsIFRleHRHcmFudWxhcml0eSBncmFudWxhcml0eSwgVGV4dENvbXBvc2l0aW9uVHlwZSBj b21wb3NpdGlvblR5cGUpCg== 88376 2011-04-05 23:44:56 -0700 2011-04-05 23:50:30 -0700 Patch bug-57755-20110405234455.patch text/plain 3721 honten U3VidmVyc2lvbiBSZXZpc2lvbjogODI1NDkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzZDQ3NGYwZDJjN2U2YzdlY2QxMTY1 M2M3ZTNlNDVkZDY5OTM1MjkwLi5jMjk4ZWI1MDZiZjQ0NmQyOWZkYTA3ZDc2OGZjNGI3ZjNlMzM0 ODdmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMDUgIE5hb2tpIFRha2FubyAgPHRh a2Fuby5uYW9raUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUkVHUkVTU0lPTihyODEzMjgpOiBOdWxsIHBvaW50ZXIgY3Jhc2ggaW4g Y2FuQXBwZW5kTmV3TGluZUZlZWQgd2hlbiBzZWxlY3Rpb24gaXNuJ3QgaW5zaWRlIGFuIGVkaXRh YmxlIGVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU3NzU1CisKKyAgICAgICAgKiBlZGl0aW5nL2V4ZWNDb21tYW5kL2luc2VydC1saW5lLWJy ZWFrLW9ubG9hZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvZXhlY0Nv bW1hbmQvaW5zZXJ0LWxpbmUtYnJlYWstb25sb2FkLmh0bWw6IEFkZGVkIHRvIGNoZWNrIGNhbGxp bmcgSW5zZXJ0TGluZUJyZWFrIHdpdGhvdXQgYW55IGNyYXNoLgorCiAyMDExLTAzLTMwICBTYW0g V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkaW5nIGZhc3QvZG9tL0hUTUxL ZXlnZW5FbGVtZW50L2tleWdlbi5odG1sIHRvIG1hYy13azIgU2tpcHBlZCBsaXN0CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2luc2VydC1saW5lLWJyZWFrLW9u bG9hZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2luc2Vy dC1saW5lLWJyZWFrLW9ubG9hZC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uN2VmMjJlOWE0MzFh ZDAyNzI3MTNiNzFmZGM4Nzk0MDE2YzhlZjEyZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvaW5zZXJ0LWxpbmUtYnJlYWstb25sb2FkLWV4cGVjdGVk LnR4dApAQCAtMCwwICsxIEBACitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5n L2V4ZWNDb21tYW5kL2luc2VydC1saW5lLWJyZWFrLW9ubG9hZC5odG1sIGIvTGF5b3V0VGVzdHMv ZWRpdGluZy9leGVjQ29tbWFuZC9pbnNlcnQtbGluZS1icmVhay1vbmxvYWQuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi4xZTViMDg3YzIxNjhlNWFkOTQ5ZDdlMGRmZGIwZDEwYTBlNjE4YmFmCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9pbnNlcnQtbGluZS1icmVh ay1vbmxvYWQuaHRtbApAQCAtMCwwICsxLDIxIEBACis8IURPQ1RZUEUgSFRNTD4KKzxodG1sPgor PGJvZHkgb25sb2FkPSJnbygpIj4KK1Rlc3QgSW5zZXJ0TGluZUJyZWFrIGlzIGNhbGxlZCBjb3Jy ZWN0bHkgd2l0aG91dCBhbnkgZXhjZXB0aW9uLgorPHNjcmlwdD4KK2Z1bmN0aW9uIGdvKCkgewor ICAgIGRvY3VtZW50LmRlc2lnbk1vZGU9Im9uIjsKKyAgICBkb2N1bWVudC53cml0ZSgiPC8iKTsK KyAgICBkb2N1bWVudC5nZXRTZWxlY3Rpb24oKS5hZGRSYW5nZShkb2N1bWVudC5jcmVhdGVSYW5n ZSgpKTsKKyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgiSW5zZXJ0TGluZUJyZWFrIik7CisKKyAg ICB2YXIgcmVzdWx0ID0gIlBBU1MiOworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs ZXIpIHsKKyAgICAgICAgZG9jdW1lbnQud3JpdGUoIjxodG1sPiIgKyByZXN1bHQgKyAiPGh0bWw+ Iik7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICB9IGVs c2UKKyAgICAgICAgYWxlcnQocmVzdWx0KTsKK30KKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1s PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IGYyYjE1MzVlOTI1NGRjZjZlOGQ2NzJlNzgxZDcxNTY4YzFhY2Q1MTYu LjZkZDQxNzAwZjQ0N2Q3ZjVmYTRhMjAyYTIwMWQxMjE5OWIxOTNjM2MgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wNC0wNSAgTmFva2kgVGFrYW5vICA8dGFrYW5vLm5hb2tpQGdt YWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSRUdSRVNTSU9OKHI4MTMyOCk6IE51bGwgcG9pbnRlciBjcmFzaCBpbiBjYW5BcHBlbmROZXdM aW5lRmVlZCB3aGVuIHNlbGVjdGlvbiBpc24ndCBpbnNpZGUgYW4gZWRpdGFibGUgZWxlbWVudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc3NTUKKwor ICAgICAgICBUZXN0OiBlZGl0aW5nL2V4ZWNDb21tYW5kL2luc2VydC1saW5lLWJyZWFrLW9ubG9h ZC5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL1R5cGluZ0NvbW1hbmQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Y2FuQXBwZW5kTmV3TGluZUZlZWQpOiBBZGRlZCBudWxsIHBvaW50ZXIgY2hlY2sg Zm9yIHJvb3RFZGl0YWJsZUVsZW1lbnQoKS4KKwogMjAxMS0wMy0zMCAgQnJlbnQgRnVsZ2hhbSAg PGJmdWxnaGFtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBjb3JyZWN0 aW9uIGFmdGVyIHI4MjQ5Ni4gKFBhcnQgMykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvVHlwaW5nQ29tbWFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1R5cGluZ0Nv bW1hbmQuY3BwCmluZGV4IGFlZGRhMzFmN2VhOGYzY2U2M2IzYjA3ODhjNjIwOGNlMjU5MGY3ODku LmRmMTUwZWUwMDM5NTA4ZDYzNDI3YWNiNGVjYmNkNTBmZTZmNDI2MDggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2VkaXRpbmcvVHlwaW5nQ29tbWFuZC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvZWRpdGluZy9UeXBpbmdDb21tYW5kLmNwcApAQCAtNDksOSArNDksMTMgQEAgdXNpbmcgbmFt ZXNwYWNlIEhUTUxOYW1lczsKIAogc3RhdGljIGJvb2wgY2FuQXBwZW5kTmV3TGluZUZlZWQoY29u c3QgVmlzaWJsZVNlbGVjdGlvbiYgc2VsZWN0aW9uKQogewotICAgIEV4Y2VwdGlvbkNvZGUgZWMg PSAwOworICAgIE5vZGUqIG5vZGUgPSBzZWxlY3Rpb24ucm9vdEVkaXRhYmxlRWxlbWVudCgpOwor ICAgIGlmICghbm9kZSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgUmVmUHRyPEJlZm9y ZVRleHRJbnNlcnRlZEV2ZW50PiBldmVudCA9IEJlZm9yZVRleHRJbnNlcnRlZEV2ZW50OjpjcmVh dGUoU3RyaW5nKCJcbiIpKTsKLSAgICBzZWxlY3Rpb24ucm9vdEVkaXRhYmxlRWxlbWVudCgpLT5k aXNwYXRjaEV2ZW50KGV2ZW50LCBlYyk7CisgICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7CisgICAg bm9kZS0+ZGlzcGF0Y2hFdmVudChldmVudCwgZWMpOwogICAgIHJldHVybiBldmVudC0+dGV4dCgp Lmxlbmd0aCgpOwogfQogCg== 88377 2011-04-05 23:50:36 -0700 2011-04-06 00:22:47 -0700 Patch bug-57755-20110405235034.patch text/plain 3752 honten U3VidmVyc2lvbiBSZXZpc2lvbjogODI1NDkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzZDQ3NGYwZDJjN2U2YzdlY2QxMTY1 M2M3ZTNlNDVkZDY5OTM1MjkwLi5jMjk4ZWI1MDZiZjQ0NmQyOWZkYTA3ZDc2OGZjNGI3ZjNlMzM0 ODdmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMDUgIE5hb2tpIFRha2FubyAgPHRh a2Fuby5uYW9raUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUkVHUkVTU0lPTihyODEzMjgpOiBOdWxsIHBvaW50ZXIgY3Jhc2ggaW4g Y2FuQXBwZW5kTmV3TGluZUZlZWQgd2hlbiBzZWxlY3Rpb24gaXNuJ3QgaW5zaWRlIGFuIGVkaXRh YmxlIGVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU3NzU1CisKKyAgICAgICAgKiBlZGl0aW5nL2V4ZWNDb21tYW5kL2luc2VydC1saW5lLWJy ZWFrLW9ubG9hZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvZXhlY0Nv bW1hbmQvaW5zZXJ0LWxpbmUtYnJlYWstb25sb2FkLmh0bWw6IEFkZGVkIHRvIGNoZWNrIGNhbGxp bmcgSW5zZXJ0TGluZUJyZWFrIHdpdGhvdXQgYW55IGNyYXNoLgorCiAyMDExLTAzLTMwICBTYW0g V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkaW5nIGZhc3QvZG9tL0hUTUxL ZXlnZW5FbGVtZW50L2tleWdlbi5odG1sIHRvIG1hYy13azIgU2tpcHBlZCBsaXN0CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2luc2VydC1saW5lLWJyZWFrLW9u bG9hZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2luc2Vy dC1saW5lLWJyZWFrLW9ubG9hZC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uN2VmMjJlOWE0MzFh ZDAyNzI3MTNiNzFmZGM4Nzk0MDE2YzhlZjEyZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvaW5zZXJ0LWxpbmUtYnJlYWstb25sb2FkLWV4cGVjdGVk LnR4dApAQCAtMCwwICsxIEBACitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5n L2V4ZWNDb21tYW5kL2luc2VydC1saW5lLWJyZWFrLW9ubG9hZC5odG1sIGIvTGF5b3V0VGVzdHMv ZWRpdGluZy9leGVjQ29tbWFuZC9pbnNlcnQtbGluZS1icmVhay1vbmxvYWQuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi43M2JjY2Q5MWUwZTE3OGE5MDUwMjVkMDIwMjAzNzVmMGNmNDhhM2QwCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9pbnNlcnQtbGluZS1icmVh ay1vbmxvYWQuaHRtbApAQCAtMCwwICsxLDIxIEBACis8IURPQ1RZUEUgSFRNTD4KKzxodG1sPgor PGJvZHkgb25sb2FkPSJnbygpIj4KK1Rlc3QgSW5zZXJ0TGluZUJyZWFrIGlzIGNhbGxlZCBjb3Jy ZWN0bHkgd2l0aG91dCBhbnkgZXhjZXB0aW9uLgorPHNjcmlwdD4KK2Z1bmN0aW9uIGdvKCkgewor ICAgIGRvY3VtZW50LmRlc2lnbk1vZGU9Im9uIjsKKyAgICBkb2N1bWVudC53cml0ZSgiPC8iKTsK KyAgICBkb2N1bWVudC5nZXRTZWxlY3Rpb24oKS5hZGRSYW5nZShkb2N1bWVudC5jcmVhdGVSYW5n ZSgpKTsKKyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgiSW5zZXJ0TGluZUJyZWFrIik7CisKKyAg ICB2YXIgcmVzdWx0ID0gIlBBU1MiOworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs ZXIpIHsKKyAgICAgICAgZG9jdW1lbnQud3JpdGUoIjxodG1sPiIgKyByZXN1bHQgKyAiPGh0bWw+ Iik7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICB9IGVs c2UKKyAgICAgICAgZG9jdW1lbnQud3JpdGUoIjxodG1sPiIgKyByZXN1bHQgKyAiPGh0bWw+Iik7 Cit9Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMmIxNTM1ZTky NTRkY2Y2ZThkNjcyZTc4MWQ3MTU2OGMxYWNkNTE2Li42ZGQ0MTcwMGY0NDdkN2Y1ZmE0YTIwMmEy MDFkMTIxOTliMTkzYzNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMDUg IE5hb2tpIFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTihyODEzMjgpOiBOdWxs IHBvaW50ZXIgY3Jhc2ggaW4gY2FuQXBwZW5kTmV3TGluZUZlZWQgd2hlbiBzZWxlY3Rpb24gaXNu J3QgaW5zaWRlIGFuIGVkaXRhYmxlIGVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NzU1CisKKyAgICAgICAgVGVzdDogZWRpdGluZy9leGVj Q29tbWFuZC9pbnNlcnQtbGluZS1icmVhay1vbmxvYWQuaHRtbAorCisgICAgICAgICogZWRpdGlu Zy9UeXBpbmdDb21tYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNhbkFwcGVuZE5ld0xpbmVG ZWVkKTogQWRkZWQgbnVsbCBwb2ludGVyIGNoZWNrIGZvciByb290RWRpdGFibGVFbGVtZW50KCku CisKIDIwMTEtMDMtMzAgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgY29ycmVjdGlvbiBhZnRlciByODI0OTYuIChQYXJ0IDMp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1R5cGluZ0NvbW1hbmQuY3BwIGIv U291cmNlL1dlYkNvcmUvZWRpdGluZy9UeXBpbmdDb21tYW5kLmNwcAppbmRleCBhZWRkYTMxZjdl YThmM2NlNjNiM2IwNzg4YzYyMDhjZTI1OTBmNzg5Li5kZjE1MGVlMDAzOTUwOGQ2MzQyN2FjYjRl Y2JjZDUwZmU2ZjQyNjA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1R5cGlu Z0NvbW1hbmQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVHlwaW5nQ29tbWFuZC5j cHAKQEAgLTQ5LDkgKzQ5LDEzIEBAIHVzaW5nIG5hbWVzcGFjZSBIVE1MTmFtZXM7CiAKIHN0YXRp YyBib29sIGNhbkFwcGVuZE5ld0xpbmVGZWVkKGNvbnN0IFZpc2libGVTZWxlY3Rpb24mIHNlbGVj dGlvbikKIHsKLSAgICBFeGNlcHRpb25Db2RlIGVjID0gMDsKKyAgICBOb2RlKiBub2RlID0gc2Vs ZWN0aW9uLnJvb3RFZGl0YWJsZUVsZW1lbnQoKTsKKyAgICBpZiAoIW5vZGUpCisgICAgICAgIHJl dHVybiBmYWxzZTsKKwogICAgIFJlZlB0cjxCZWZvcmVUZXh0SW5zZXJ0ZWRFdmVudD4gZXZlbnQg PSBCZWZvcmVUZXh0SW5zZXJ0ZWRFdmVudDo6Y3JlYXRlKFN0cmluZygiXG4iKSk7Ci0gICAgc2Vs ZWN0aW9uLnJvb3RFZGl0YWJsZUVsZW1lbnQoKS0+ZGlzcGF0Y2hFdmVudChldmVudCwgZWMpOwor ICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOworICAgIG5vZGUtPmRpc3BhdGNoRXZlbnQoZXZlbnQs IGVjKTsKICAgICByZXR1cm4gZXZlbnQtPnRleHQoKS5sZW5ndGgoKTsKIH0KIAo=