57742 2011-04-03 22:10:53 -0700 Prefer a using directive over qualified names in LocalizedNumberICU.cpp 2011-04-04 02:21:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 thakis thakis ap commit-queue oldest_to_newest 378645 0 thakis 2011-04-03 22:10:53 -0700 Prefer a using directive over qualified names in LocalizedNumberICU.cpp 378646 1 88032 thakis 2011-04-03 22:12:26 -0700 Created attachment 88032 Patch 378648 2 88032 eric 2011-04-03 22:16:15 -0700 Comment on attachment 88032 Patch OK. That's fine. 378657 3 ap 2011-04-03 22:35:22 -0700 Thanks Nico! 378713 4 88032 commit-queue 2011-04-04 02:21:01 -0700 Comment on attachment 88032 Patch Clearing flags on attachment: 88032 Committed r82809: <http://trac.webkit.org/changeset/82809> 378715 5 commit-queue 2011-04-04 02:21:07 -0700 All reviewed patches have been landed. Closing bug. 88032 2011-04-03 22:12:26 -0700 2011-04-04 02:21:01 -0700 Patch bug-57742-20110403221225.patch text/plain 3497 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogODI3OTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4NDZjMjVmYzZhOTNmNzkx MjIyMjM2NzA4NTBiNGJkZjljMGFhYmZmLi4xYjhiN2M4MDc4NWUwMjI5NDA1M2U0ZTA2MDU0ZjI0 NWNhMTVlYWQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMDMgIE5pY28g V2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFByZWZlciBhIHVzaW5nIGRpcmVjdGl2ZSBvdmVyIHF1YWxp ZmllZCBuYW1lcyBpbiBMb2NhbGl6ZWROdW1iZXJJQ1UuY3BwCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Nzc0MgorCisgICAgICAgIFJlcXVlc3RlZCBi eSBhcCBpbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc3MTUKKwor ICAgICAgICAqIHBsYXRmb3JtL3RleHQvTG9jYWxpemVkTnVtYmVySUNVLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OmNyZWF0ZUZvcm1hdHRlckZvckN1cnJlbnRMb2NhbGUpOgorICAgICAgICAoV2Vi Q29yZTo6bnVtYmVyRm9ybWF0dGVyKToKKyAgICAgICAgKFdlYkNvcmU6OnBhcnNlTG9jYWxpemVk TnVtYmVyKToKKyAgICAgICAgKFdlYkNvcmU6OmZvcm1hdExvY2FsaXplZE51bWJlcik6CisKIDIw MTEtMDQtMDMgIEx1a2UgTWFjcGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3RleHQvTG9jYWxpemVkTnVtYmVySUNVLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3RleHQvTG9jYWxpemVkTnVtYmVySUNVLmNwcAppbmRleCBhOGM2MmE3OTI3Mjc3 NGU1ZWI3ZTUzMjBmYTc4OGRiY2M3MWU1YzI4Li5kYTE2MjYyZjgxZTIxYmJiZjE3MjE3Zjg2OTYz YzRhMjBjMmFlNjg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xv Y2FsaXplZE51bWJlcklDVS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9M b2NhbGl6ZWROdW1iZXJJQ1UuY3BwCkBAIC0zNywyMiArMzcsMjMgQEAKICNpbmNsdWRlIDx3dGYv TWF0aEV4dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi9QYXNzT3duUHRyLmg+CiAKK3VzaW5nIG5hbWVz cGFjZSBpY3U7CiB1c2luZyBuYW1lc3BhY2Ugc3RkOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK LXN0YXRpYyBQYXNzT3duUHRyPGljdTo6TnVtYmVyRm9ybWF0PiBjcmVhdGVGb3JtYXR0ZXJGb3JD dXJyZW50TG9jYWxlKCkKK3N0YXRpYyBQYXNzT3duUHRyPE51bWJlckZvcm1hdD4gY3JlYXRlRm9y bWF0dGVyRm9yQ3VycmVudExvY2FsZSgpCiB7CiAgICAgVUVycm9yQ29kZSBzdGF0dXMgPSBVX1pF Uk9fRVJST1I7Ci0gICAgT3duUHRyPGljdTo6TnVtYmVyRm9ybWF0PiBmb3JtYXR0ZXIgPSBhZG9w dFB0cihpY3U6Ok51bWJlckZvcm1hdDo6Y3JlYXRlSW5zdGFuY2Uoc3RhdHVzKSk7CisgICAgT3du UHRyPE51bWJlckZvcm1hdD4gZm9ybWF0dGVyID0gYWRvcHRQdHIoTnVtYmVyRm9ybWF0OjpjcmVh dGVJbnN0YW5jZShzdGF0dXMpKTsKICAgICByZXR1cm4gVV9TVUNDRVNTKHN0YXR1cykgPyBmb3Jt YXR0ZXIucmVsZWFzZSgpIDogMDsKIH0KIAogLy8gVGhpcyBtaWdodCByZXR1cm4gMC4KLXN0YXRp YyBpY3U6Ok51bWJlckZvcm1hdCogbnVtYmVyRm9ybWF0dGVyKCkKK3N0YXRpYyBOdW1iZXJGb3Jt YXQqIG51bWJlckZvcm1hdHRlcigpCiB7CiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKLSAg ICBzdGF0aWMgaWN1OjpOdW1iZXJGb3JtYXQqIGZvcm1hdHRlciA9IGNyZWF0ZUZvcm1hdHRlckZv ckN1cnJlbnRMb2NhbGUoKS5sZWFrUHRyKCk7CisgICAgc3RhdGljIE51bWJlckZvcm1hdCogZm9y bWF0dGVyID0gY3JlYXRlRm9ybWF0dGVyRm9yQ3VycmVudExvY2FsZSgpLmxlYWtQdHIoKTsKICAg ICByZXR1cm4gZm9ybWF0dGVyOwogfQogCkBAIC02MCwxMiArNjEsMTIgQEAgZG91YmxlIHBhcnNl TG9jYWxpemVkTnVtYmVyKGNvbnN0IFN0cmluZyYgbnVtYmVyU3RyaW5nKQogewogICAgIGlmIChu dW1iZXJTdHJpbmcuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gbnVtZXJpY19saW1pdHM8ZG91 YmxlPjo6cXVpZXRfTmFOKCk7Ci0gICAgaWN1OjpOdW1iZXJGb3JtYXQqIGZvcm1hdHRlciA9IG51 bWJlckZvcm1hdHRlcigpOworICAgIE51bWJlckZvcm1hdCogZm9ybWF0dGVyID0gbnVtYmVyRm9y bWF0dGVyKCk7CiAgICAgaWYgKCFmb3JtYXR0ZXIpCiAgICAgICAgIHJldHVybiBudW1lcmljX2xp bWl0czxkb3VibGU+OjpxdWlldF9OYU4oKTsKLSAgICBpY3U6OlVuaWNvZGVTdHJpbmcgbnVtYmVy VW5pY29kZVN0cmluZyhudW1iZXJTdHJpbmcuY2hhcmFjdGVycygpLCBudW1iZXJTdHJpbmcubGVu Z3RoKCkpOwotICAgIGljdTo6Rm9ybWF0dGFibGUgcmVzdWx0OwotICAgIGljdTo6UGFyc2VQb3Np dGlvbiBwb3NpdGlvbigwKTsKKyAgICBVbmljb2RlU3RyaW5nIG51bWJlclVuaWNvZGVTdHJpbmco bnVtYmVyU3RyaW5nLmNoYXJhY3RlcnMoKSwgbnVtYmVyU3RyaW5nLmxlbmd0aCgpKTsKKyAgICBG b3JtYXR0YWJsZSByZXN1bHQ7CisgICAgUGFyc2VQb3NpdGlvbiBwb3NpdGlvbigwKTsKICAgICBm b3JtYXR0ZXItPnBhcnNlKG51bWJlclVuaWNvZGVTdHJpbmcsIHJlc3VsdCwgcG9zaXRpb24pOwog ICAgIGlmIChwb3NpdGlvbi5nZXRJbmRleCgpICE9IG51bWJlclVuaWNvZGVTdHJpbmcubGVuZ3Ro KCkpCiAgICAgICAgIHJldHVybiBudW1lcmljX2xpbWl0czxkb3VibGU+OjpxdWlldF9OYU4oKTsK QEAgLTc2LDEwICs3NywxMCBAQCBkb3VibGUgcGFyc2VMb2NhbGl6ZWROdW1iZXIoY29uc3QgU3Ry aW5nJiBudW1iZXJTdHJpbmcpCiAKIFN0cmluZyBmb3JtYXRMb2NhbGl6ZWROdW1iZXIoZG91Ymxl IG51bWJlciwgdW5zaWduZWQgZnJhY3Rpb25EaWdpdHMpCiB7Ci0gICAgaWN1OjpOdW1iZXJGb3Jt YXQqIGZvcm1hdHRlciA9IG51bWJlckZvcm1hdHRlcigpOworICAgIE51bWJlckZvcm1hdCogZm9y bWF0dGVyID0gbnVtYmVyRm9ybWF0dGVyKCk7CiAgICAgaWYgKCFmb3JtYXR0ZXIpCiAgICAgICAg IHJldHVybiBTdHJpbmcoKTsKLSAgICBpY3U6OlVuaWNvZGVTdHJpbmcgcmVzdWx0OworICAgIFVu aWNvZGVTdHJpbmcgcmVzdWx0OwogICAgIGZvcm1hdHRlci0+c2V0TWF4aW11bUZyYWN0aW9uRGln aXRzKGNsYW1wVG9JbnRlZ2VyKGZyYWN0aW9uRGlnaXRzKSk7CiAgICAgZm9ybWF0dGVyLT5mb3Jt YXQobnVtYmVyLCByZXN1bHQpOwogICAgIHJldHVybiBTdHJpbmcocmVzdWx0LmdldEJ1ZmZlcigp LCByZXN1bHQubGVuZ3RoKCkpOwo=