5774 2005-11-18 14:35:14 -0800 Failed assertion `!eventDispatchForbidden()' in dom_nodeimpl.cpp:892 2005-11-19 00:52:32 -0800 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 VERIFIED FIXED http://www.macworld.com/news/2005/11/16/google/index.php?lsrc=mwrss P2 Normal --- 1 mitz harrison harrison oldest_to_newest 24248 0 mitz 2005-11-18 14:35:14 -0800 With the fix for bug 5629 in place, the assert in dispatchSubtreeModifiedEvent() actually fails when opening the URL. Backtrace: #3 0x0183cf28 in DOM::NodeImpl::dispatchSubtreeModifiedEvent (this=0xcac35f0, sendChildrenChanged=false) at WebCore/khtml/xml/dom_nodeimpl.cpp:892 #4 0x0182b0bc in DOM::NamedAttrMapImpl::addAttribute (this=0xca7ca80, attr=0xca7cab0) at WebCore/khtml/xml/dom_elementimpl.cpp:1051 #5 0x0182e70c in DOM::ElementImpl::setAttribute (this=0xcac35f0, name=@0x1a41ab8, value=0xcc0fb10, exceptioncode=@0xbfffd9a8) at WebCore/khtml/xml/dom_elementimpl.cpp:394 #6 0x0182e7d8 in DOM::ElementImpl::setAttribute (this=0xcac35f0, name=@0x1a41ab8, value=@0xbfffda14) at WebCore/khtml/xml/dom_elementimpl.cpp:308 #7 0x017535d8 in DOM::HTMLBodyElementImpl::insertedIntoDocument (this=0xcac35f0) at WebCore/ khtml/html/html_baseimpl.cpp:187 #8 0x01835fa4 in DOM::ContainerNodeImpl::addChild (this=0xcac2df0, newChild=0xcac35f0) at WebCore/khtml/xml/dom_nodeimpl.cpp:2528 #9 0x0179f620 in HTMLParser::insertNode (this=0xcc1c6b0, n=0xcac35f0, flat=false) at WebCore/ khtml/html/htmlparser.cpp:274 24249 1 mitz 2005-11-18 15:06:12 -0800 Here the problem is that during addChild(), HTMLBodyElementImpl::insertedIntoDocument() calls setAttribute() which wants to dispatch an event. 24250 2 harrison 2005-11-18 15:57:34 -0800 Am working on this. 24253 3 4729 harrison 2005-11-18 18:27:50 -0800 Created attachment 4729 Call enableEventDispatch() sooner. Call enableEventDispatch() sooner, when basic dom mods are done. 24254 4 4729 timothy 2005-11-18 18:32:58 -0800 Comment on attachment 4729 Call enableEventDispatch() sooner. r=me 24255 5 harrison 2005-11-18 18:36:34 -0800 Committed. 24258 6 mitz 2005-11-19 00:52:32 -0800 That was fast! 4729 2005-11-18 18:27:50 -0800 2005-11-18 18:32:58 -0800 Call enableEventDispatch() sooner. patch_5774.txt text/plain 5245 harrison SW5kZXg6IGtodG1sL3htbC9kb21fZG9jaW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2 cy9yb290L1dlYkNvcmUva2h0bWwveG1sL2RvbV9kb2NpbXBsLmNwcCx2CnJldHJpZXZpbmcgcmV2 aXNpb24gMS4yNzIKZGlmZiAtdSAtcCAtcjEuMjcyIGRvbV9kb2NpbXBsLmNwcAotLS0ga2h0bWwv eG1sL2RvbV9kb2NpbXBsLmNwcAkxOCBOb3YgMjAwNSAyMTozNDo0MCAtMDAwMAkxLjI3MgorKysg a2h0bWwveG1sL2RvbV9kb2NpbXBsLmNwcAkxOSBOb3YgMjAwNSAwMjoyMzowMiAtMDAwMApAQCAt NDU1LDcgKzQ1NSw2IEBAIERvY3VtZW50SW1wbDo6RG9jdW1lbnRJbXBsKERPTUltcGxlbWVudGEK ICAgICByZXNldFZpc2l0ZWRMaW5rQ29sb3IoKTsKICAgICByZXNldEFjdGl2ZUxpbmtDb2xvcigp OwogCi0gICAgbV9ldmVudERpc3BhdGNoRm9yYmlkZGVuID0gMDsKICAgICBtX3Byb2Nlc3NpbmdM b2FkRXZlbnQgPSBmYWxzZTsKICAgICBtX3N0YXJ0VGltZS5yZXN0YXJ0KCk7CiAgICAgbV9vdmVy TWluaW11bUxheW91dFRocmVzaG9sZCA9IGZhbHNlOwpJbmRleDoga2h0bWwveG1sL2RvbV9kb2Np bXBsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwveG1sL2Rv bV9kb2NpbXBsLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTM4CmRpZmYgLXUgLXAgLXIxLjEz OCBkb21fZG9jaW1wbC5oCi0tLSBraHRtbC94bWwvZG9tX2RvY2ltcGwuaAkxOCBOb3YgMjAwNSAy MTozNDo0MCAtMDAwMAkxLjEzOAorKysga2h0bWwveG1sL2RvbV9kb2NpbXBsLmgJMTkgTm92IDIw MDUgMDI6MjM6MDIgLTAwMDAKQEAgLTcwNSw3ICs3MDUsNiBAQCBwcm90ZWN0ZWQ6CiAgICAgS1dR QWNjT2JqZWN0Q2FjaGUqIG1fYWNjQ2FjaGU7CiAjZW5kaWYKICAgICAKLSAgICBpbnQgbV9ldmVu dERpc3BhdGNoRm9yYmlkZGVuOwogICAgIFFQdHJMaXN0PEhUTUxJbWFnZUxvYWRlcj4gbV9pbWFn ZUxvYWRFdmVudERpc3BhdGNoU29vbkxpc3Q7CiAgICAgUVB0ckxpc3Q8SFRNTEltYWdlTG9hZGVy PiBtX2ltYWdlTG9hZEV2ZW50RGlzcGF0Y2hpbmdMaXN0OwogICAgIGludCBtX2ltYWdlTG9hZEV2 ZW50VGltZXI7CkluZGV4OiBraHRtbC94bWwvZG9tX25vZGVpbXBsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC94bWwvZG9tX25vZGVpbXBsLmNwcCx2CnJl dHJpZXZpbmcgcmV2aXNpb24gMS4yMTIKZGlmZiAtdSAtcCAtcjEuMjEyIGRvbV9ub2RlaW1wbC5j cHAKLS0tIGtodG1sL3htbC9kb21fbm9kZWltcGwuY3BwCTE4IE5vdiAyMDA1IDIxOjM0OjQwIC0w MDAwCTEuMjEyCisrKyBraHRtbC94bWwvZG9tX25vZGVpbXBsLmNwcAkxOSBOb3YgMjAwNSAwMjoy MzowMiAtMDAwMApAQCAtODkwLDcgKzg5MCw3IEBAIHZvaWQgTm9kZUltcGw6Om5vdGlmeU5vZGVM aXN0c0NoaWxkcmVuQ2gKIGJvb2wgTm9kZUltcGw6OmRpc3BhdGNoU3VidHJlZU1vZGlmaWVkRXZl bnQoYm9vbCBzZW5kQ2hpbGRyZW5DaGFuZ2VkKQogewogICAgIGFzc2VydCghZXZlbnREaXNwYXRj aEZvcmJpZGRlbigpKTsKLSAgICAKKwogICAgIC8vIEZJWE1FOiBQdWxsIHRoaXMgd2hvbGUgaWYg Y2xhdXNlIG91dCBvZiB0aGlzIGZ1bmN0aW9uLgogICAgIGlmIChzZW5kQ2hpbGRyZW5DaGFuZ2Vk KSB7CiAgICAgICAgIG5vdGlmeU5vZGVMaXN0c0NoaWxkcmVuQ2hhbmdlZCgpOwpAQCAtMjE2Nywx MiArMjE2NywxMiBAQCBOb2RlSW1wbCAqQ29udGFpbmVyTm9kZUltcGw6Omluc2VydEJlZm9yCiAg ICAgICAgIGNoaWxkLT5zZXRQYXJlbnQodGhpcyk7CiAgICAgICAgIGNoaWxkLT5zZXRQcmV2aW91 c1NpYmxpbmcocHJldik7CiAgICAgICAgIGNoaWxkLT5zZXROZXh0U2libGluZyhyZWZDaGlsZCk7 CisgICAgICAgIGFsbG93RXZlbnREaXNwYXRjaCgpOwogCiAgICAgICAgIC8vIEFkZCBjaGlsZCB0 byB0aGUgcmVuZGVyaW5nIHRyZWUKICAgICAgICAgLy8gIyMjIHNob3VsZCB3ZSBkZXRhY2goKSBp dCBmaXJzdCBpZiBpdCdzIGFscmVhZHkgYXR0YWNoZWQ/CiAgICAgICAgIGlmIChhdHRhY2hlZCgp ICYmICFjaGlsZC0+YXR0YWNoZWQoKSkKICAgICAgICAgICAgIGNoaWxkLT5hdHRhY2goKTsKLSAg ICAgICAgYWxsb3dFdmVudERpc3BhdGNoKCk7CiAgICAgICAgIAogICAgICAgICAvLyBEaXNwYXRj aCB0aGUgbXV0YXRpb24gZXZlbnRzCiAgICAgICAgIGRpc3BhdGNoQ2hpbGRJbnNlcnRlZEV2ZW50 cyhjaGlsZCxleGNlcHRpb25jb2RlKTsKQEAgLTIyMjksOSArMjIyOSw4IEBAIE5vZGVJbXBsICpD b250YWluZXJOb2RlSW1wbDo6cmVwbGFjZUNoaWwKICAgICAgICAgaWYgKGV4Y2VwdGlvbmNvZGUp CiAgICAgICAgICAgICByZXR1cm4gMDsKIAotICAgICAgICBmb3JiaWRFdmVudERpc3BhdGNoKCk7 Ci0KICAgICAgICAgLy8gQWRkIGNoaWxkIGluIHRoZSBjb3JyZWN0IHBvc2l0aW9uCisgICAgICAg IGZvcmJpZEV2ZW50RGlzcGF0Y2goKTsKICAgICAgICAgaWYgKHByZXYpIHByZXYtPnNldE5leHRT aWJsaW5nKGNoaWxkKTsKICAgICAgICAgaWYgKG5leHQpIG5leHQtPnNldFByZXZpb3VzU2libGlu ZyhjaGlsZCk7CiAgICAgICAgIGlmKCFwcmV2KSBfZmlyc3QgPSBjaGlsZDsKQEAgLTIyMzksMTIg KzIyMzgsMTIgQEAgTm9kZUltcGwgKkNvbnRhaW5lck5vZGVJbXBsOjpyZXBsYWNlQ2hpbAogICAg ICAgICBjaGlsZC0+c2V0UGFyZW50KHRoaXMpOwogICAgICAgICBjaGlsZC0+c2V0UHJldmlvdXNT aWJsaW5nKHByZXYpOwogICAgICAgICBjaGlsZC0+c2V0TmV4dFNpYmxpbmcobmV4dCk7CisgICAg ICAgIGFsbG93RXZlbnREaXNwYXRjaCgpOwogCiAgICAgICAgIC8vIEFkZCBjaGlsZCB0byB0aGUg cmVuZGVyaW5nIHRyZWUKICAgICAgICAgLy8gIyMjIHNob3VsZCB3ZSBkZXRhY2goKSBpdCBmaXJz dCBpZiBpdCdzIGFscmVhZHkgYXR0YWNoZWQ/CiAgICAgICAgIGlmIChhdHRhY2hlZCgpICYmICFj aGlsZC0+YXR0YWNoZWQoKSkKICAgICAgICAgICAgIGNoaWxkLT5hdHRhY2goKTsKLSAgICAgICAg YWxsb3dFdmVudERpc3BhdGNoKCk7CiAKICAgICAgICAgLy8gRGlzcGF0Y2ggdGhlIG11dGF0aW9u IGV2ZW50cwogICAgICAgICBkaXNwYXRjaENoaWxkSW5zZXJ0ZWRFdmVudHMoY2hpbGQsZXhjZXB0 aW9uY29kZSk7CkBAIC0yMzMzLDEwICsyMzMyLDEwIEBAIE5vZGVJbXBsICpDb250YWluZXJOb2Rl SW1wbDo6cmVtb3ZlQ2hpbGQKICAgICBvbGRDaGlsZC0+c2V0TmV4dFNpYmxpbmcoMCk7CiAgICAg b2xkQ2hpbGQtPnNldFBhcmVudCgwKTsKIAotICAgIGdldERvY3VtZW50KCktPnNldERvY3VtZW50 Q2hhbmdlZCh0cnVlKTsKLQogICAgIGFsbG93RXZlbnREaXNwYXRjaCgpOwogCisgICAgZ2V0RG9j dW1lbnQoKS0+c2V0RG9jdW1lbnRDaGFuZ2VkKHRydWUpOworCiAgICAgLy8gRGlzcGF0Y2ggcG9z dC1yZW1vdmFsIG11dGF0aW9uIGV2ZW50cwogICAgIGRpc3BhdGNoU3VidHJlZU1vZGlmaWVkRXZl bnQoKTsKIApAQCAtMjQyNSwyNiArMjQyNCwyMiBAQCBOb2RlSW1wbCAqQ29udGFpbmVyTm9kZUlt cGw6OmFwcGVuZENoaWxkCiAgICAgICAgICAgICAgICAgcmV0dXJuIDA7CiAgICAgICAgIH0KIAot ICAgICAgICBmb3JiaWRFdmVudERpc3BhdGNoKCk7Ci0KICAgICAgICAgLy8gQXBwZW5kIGNoaWxk IHRvIHRoZSBlbmQgb2YgdGhlIGxpc3QKKyAgICAgICAgZm9yYmlkRXZlbnREaXNwYXRjaCgpOwog ICAgICAgICBjaGlsZC0+c2V0UGFyZW50KHRoaXMpOwotCi0gICAgICAgIGlmKF9sYXN0KQotICAg ICAgICB7CisgICAgICAgIGlmIChfbGFzdCkgewogICAgICAgICAgICAgY2hpbGQtPnNldFByZXZp b3VzU2libGluZyhfbGFzdCk7CiAgICAgICAgICAgICBfbGFzdC0+c2V0TmV4dFNpYmxpbmcoY2hp bGQpOwogICAgICAgICAgICAgX2xhc3QgPSBjaGlsZDsKICAgICAgICAgfSBlbHNlCiAgICAgICAg ICAgICBfZmlyc3QgPSBfbGFzdCA9IGNoaWxkOworICAgICAgICBhbGxvd0V2ZW50RGlzcGF0Y2go KTsKIAogICAgICAgICAvLyBBZGQgY2hpbGQgdG8gdGhlIHJlbmRlcmluZyB0cmVlCiAgICAgICAg IC8vICMjIyBzaG91bGQgd2UgZGV0YWNoKCkgaXQgZmlyc3QgaWYgaXQncyBhbHJlYWR5IGF0dGFj aGVkPwogICAgICAgICBpZiAoYXR0YWNoZWQoKSAmJiAhY2hpbGQtPmF0dGFjaGVkKCkpCiAgICAg ICAgICAgICBjaGlsZC0+YXR0YWNoKCk7CiAgICAgICAgIAotICAgICAgICBhbGxvd0V2ZW50RGlz cGF0Y2goKTsKLSAgICAgICAgCiAgICAgICAgIC8vIERpc3BhdGNoIHRoZSBtdXRhdGlvbiBldmVu dHMKICAgICAgICAgZGlzcGF0Y2hDaGlsZEluc2VydGVkRXZlbnRzKGNoaWxkLGV4Y2VwdGlvbmNv ZGUpOwogCkBAIC0yNTA4LDI3ICsyNTAzLDIwIEBAIE5vZGVJbXBsICpDb250YWluZXJOb2RlSW1w bDo6YWRkQ2hpbGQoTm8KICAgICBpZiAoZ2V0RG9jdW1lbnQoKS0+aXNIVE1MRG9jdW1lbnQoKSAm JiAhY2hpbGRBbGxvd2VkKG5ld0NoaWxkKSkKICAgICAgICAgcmV0dXJuIDA7CiAKLSAgICBmb3Ji aWRFdmVudERpc3BhdGNoKCk7Ci0KICAgICAvLyBqdXN0IGFkZCBpdC4uLgorICAgIGZvcmJpZEV2 ZW50RGlzcGF0Y2goKTsKICAgICBuZXdDaGlsZC0+c2V0UGFyZW50KHRoaXMpOwotCi0gICAgaWYo X2xhc3QpCi0gICAgeworICAgIGlmKF9sYXN0KSB7CiAgICAgICAgIG5ld0NoaWxkLT5zZXRQcmV2 aW91c1NpYmxpbmcoX2xhc3QpOwogICAgICAgICBfbGFzdC0+c2V0TmV4dFNpYmxpbmcobmV3Q2hp bGQpOwogICAgICAgICBfbGFzdCA9IG5ld0NoaWxkOwotICAgIH0KLSAgICBlbHNlCi0gICAgewor ICAgIH0gZWxzZQogICAgICAgICBfZmlyc3QgPSBfbGFzdCA9IG5ld0NoaWxkOwotICAgIH0KKyAg ICBhbGxvd0V2ZW50RGlzcGF0Y2goKTsKIAogICAgIGlmIChpbkRvY3VtZW50KCkpCiAgICAgICAg IG5ld0NoaWxkLT5pbnNlcnRlZEludG9Eb2N1bWVudCgpOwogICAgIGNoaWxkcmVuQ2hhbmdlZCgp OwotCi0gICAgYWxsb3dFdmVudERpc3BhdGNoKCk7CiAgICAgCiAgICAgaWYobmV3Q2hpbGQtPm5v ZGVUeXBlKCkgPT0gTm9kZTo6RUxFTUVOVF9OT0RFKQogICAgICAgICByZXR1cm4gbmV3Q2hpbGQ7 Cg==