57708 2011-04-02 12:07:54 -0700 [Qt] Style fix for QtMobileWebStyle.h 2011-04-14 06:31:14 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 diegohcg webkit-unassigned benjamin commit-queue menard tonikitoo oldest_to_newest 378413 0 diegohcg 2011-04-02 12:07:54 -0700 Fix style drawControl and drawComplexControl prototype 378414 1 87983 diegohcg 2011-04-02 12:10:19 -0700 Created attachment 87983 Patch 378617 2 87983 tonikitoo 2011-04-03 19:32:42 -0700 Comment on attachment 87983 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87983&action=review > Source/WebCore/platform/qt/QtMobileWebStyle.h:31 > + void drawControl(ControlElement, const QStyleOption*, QPainter*, const QWidget*) const; > + void drawComplexControl(ComplexControl, const QStyleOptionComplex*, QPainter*, const QWidget*) const; You are changing the default value, diego. It goes beyond style fixes :) 378739 3 menard 2011-04-04 05:34:39 -0700 So it's r- no? 378773 4 tonikitoo 2011-04-04 07:20:12 -0700 (In reply to comment #3) > So it's r- no? Not necesseraly. No everything needs to be r- if the contributor is a committer and patch has an issue. I r+ and expressed my concern, so it is just a matter of fixing it before landing. 378774 5 tonikitoo 2011-04-04 07:20:48 -0700 (In reply to comment #4) > (In reply to comment #3) > > So it's r- no? > > Not necesseraly. No everything needs to be r- if the contributor is a committer and patch has an issue. I r+ and expressed my concern, so it is just a matter of fixing it before landing. Also it seems this default value is not used, since it did not break stuff to diego. So I do not really care this time. 378796 6 87983 benjamin 2011-04-04 08:23:22 -0700 Comment on attachment 87983 Patch Let's cq+... 378800 7 87983 commit-queue 2011-04-04 08:26:53 -0700 Comment on attachment 87983 Patch Rejecting attachment 87983 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2 Last 500 characters of output: Scripts/svn-apply', u'--reviewer', u'Antonio Gomes', u'--fo..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/qt/QtMobileWebStyle.h Hunk #1 FAILED at 27. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/qt/QtMobileWebStyle.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Antonio Gomes', u'--fo..." exit_code: 1 Full output: http://queues.webkit.org/results/8185955 379158 8 diegohcg 2011-04-04 16:00:20 -0700 Thanks guys. I will commit it manually. 380414 9 diegohcg 2011-04-06 08:43:54 -0700 Fixed at r83047 87983 2011-04-02 12:10:19 -0700 2011-04-14 06:31:14 -0700 Patch 0001-Qt-Style-fix-for-QtMobileWebStyle.h.diff text/plain 1927 diegohcg RnJvbSAzNzMyMzE1YzAwOWUxMDQ4OTgwZGI3OTdhZGFiNDAyYTVjOGQ1ZmI1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWVnbyBHb256YWxleiA8ZGllZ29oY2dAd2Via2l0Lm9yZz4K RGF0ZTogU2F0LCAyIEFwciAyMDExIDE1OjA5OjAyIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gW1F0 XSBTdHlsZSBmaXggZm9yIFF0TW9iaWxlV2ViU3R5bGUuaAogaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTU3NzA4CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiog cGxhdGZvcm0vcXQvUXRNb2JpbGVXZWJTdHlsZS5oOgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyAgICAgICAgICAgICAgICAgICAgICB8ICAgIDkgKysrKysrKysrCiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9xdC9RdE1vYmlsZVdlYlN0eWxlLmggfCAgICA0ICsrLS0KIDIgZmlsZXMgY2hh bmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDQ0 MTU0MC4uNGUxNzgyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTA0LTAyICBE aWVnbyBHb256YWxleiAgPGRpZWdvaGNnQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBTdHlsZSBmaXggZm9yIFF0TW9iaWxl V2ViU3R5bGUuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTc3MDgKKworICAgICAgICAqIHBsYXRmb3JtL3F0L1F0TW9iaWxlV2ViU3R5bGUuaDoKKwog MjAxMS0wMy0yNyAgRGllZ28gR29uemFsZXogIDxkaWVnb2hjZ0B3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vcXQvUXRNb2JpbGVXZWJTdHlsZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vcXQvUXRNb2JpbGVXZWJTdHlsZS5oCmluZGV4IDNkNDMxYmQuLjFiOTlkMmIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1F0TW9iaWxlV2ViU3R5bGUuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9RdE1vYmlsZVdlYlN0eWxlLmgKQEAgLTI3LDggKzI3 LDggQEAgY2xhc3MgUXRNb2JpbGVXZWJTdHlsZSA6IHB1YmxpYyBRV2luZG93c1N0eWxlIHsKIHB1 YmxpYzoKICAgICBRdE1vYmlsZVdlYlN0eWxlKCk7CiAKLSAgICB2b2lkIGRyYXdDb250cm9sKENv bnRyb2xFbGVtZW50IGVsZW1lbnQsIGNvbnN0IFFTdHlsZU9wdGlvbiogb3B0aW9uLCBRUGFpbnRl ciogcGFpbnRlciwgY29uc3QgUVdpZGdldCogd2lkZ2V0ID0gMCkgY29uc3Q7Ci0gICAgdm9pZCBk cmF3Q29tcGxleENvbnRyb2woQ29tcGxleENvbnRyb2wgY2MsIGNvbnN0IFFTdHlsZU9wdGlvbkNv bXBsZXgqIG9wdGlvbiwgUVBhaW50ZXIqIHBhaW50ZXIsIGNvbnN0IFFXaWRnZXQqIHdpZGdldCA9 IDApIGNvbnN0OworICAgIHZvaWQgZHJhd0NvbnRyb2woQ29udHJvbEVsZW1lbnQsIGNvbnN0IFFT dHlsZU9wdGlvbiosIFFQYWludGVyKiwgY29uc3QgUVdpZGdldCopIGNvbnN0OworICAgIHZvaWQg ZHJhd0NvbXBsZXhDb250cm9sKENvbXBsZXhDb250cm9sLCBjb25zdCBRU3R5bGVPcHRpb25Db21w bGV4KiwgUVBhaW50ZXIqLCBjb25zdCBRV2lkZ2V0KikgY29uc3Q7CiAgICAgdm9pZCBkcmF3UHJp bWl0aXZlKFByaW1pdGl2ZUVsZW1lbnQsIGNvbnN0IFFTdHlsZU9wdGlvbiosIFFQYWludGVyKiwg Y29uc3QgUVdpZGdldCopIGNvbnN0OwogCiBwcml2YXRlOgotLSAKMS43LjEKCg==