57699 2011-04-01 22:34:29 -0700 V8StringCallback.cpp requires V8Binding.h 2011-04-04 00:16:37 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 ryuan.choi webkit-unassigned commit-queue dglazkov eric oldest_to_newest 378342 0 ryuan.choi 2011-04-01 22:34:29 -0700 V8StringCallback use v8String() which is in V8Binding.h But, it doesn't include V8Binding.h. I checked chromium port, but it was fine because of magic file including many cpp files. I believe that it should be fixed because v8 can be used for other ports. Currently qt have v8 option, but it looks not compiled because of some reasons with this. 378345 1 87969 ryuan.choi 2011-04-01 22:38:55 -0700 Created attachment 87969 Patch 378663 2 eric 2011-04-03 22:55:52 -0700 What's the magic file? 378667 3 ryuan.choi 2011-04-03 23:21:25 -0700 (In reply to comment #2) > What's the magic file? Thank you for your review. Magic files which I said are V8DerivedSources1.cpp ~ V8DerivedSources8.cpp including a list of cpp files. 378677 4 87969 commit-queue 2011-04-04 00:16:32 -0700 Comment on attachment 87969 Patch Clearing flags on attachment: 87969 Committed r82802: <http://trac.webkit.org/changeset/82802> 378678 5 commit-queue 2011-04-04 00:16:37 -0700 All reviewed patches have been landed. Closing bug. 87969 2011-04-01 22:38:55 -0700 2011-04-04 00:16:32 -0700 Patch bug-57699-20110402143855.patch text/plain 1203 ryuan.choi SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyNzY2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMDEgIFJ5dWFuIENo b2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFY4U3RyaW5nQ2FsbGJhY2suY3BwIHJlcXVpcmVzIFY4Qmlu ZGluZy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NzY5OQorCisgICAgICAgIE5vIG5ldyB0ZXN0cyByZXF1aXJlZCBiZWNhdXNlIG9mIGp1c3QgYWRk aW5nIGhlYWRlciBmaWxlLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9yVjgucG06CisKIDIwMTEtMDQtMDEgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQkocmV2aXNp b24gODI3NjUpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0 b3JWOC5wbQkod29ya2luZyBjb3B5KQpAQCAtMjM0OCw2ICsyMzQ4LDcgQEAgc3ViIEdlbmVyYXRl Q2FsbGJhY2tJbXBsZW1lbnRhdGlvbgogICAgIHB1c2goQGltcGxGaXhlZEhlYWRlciwgR2VuZXJh dGVJbXBsZW1lbnRhdGlvbkNvbnRlbnRIZWFkZXIoJGRhdGFOb2RlKSk7CiAgICAgICAgICAKICAg ICAkaW1wbEluY2x1ZGVzeyJTY3JpcHRFeGVjdXRpb25Db250ZXh0LmgifSA9IDE7CisgICAgJGlt cGxJbmNsdWRlc3siVjhCaW5kaW5nLmgifSA9IDE7CiAgICAgJGltcGxJbmNsdWRlc3siVjhDdXN0 b21Wb2lkQ2FsbGJhY2suaCJ9ID0gMTsKICAgICAkaW1wbEluY2x1ZGVzeyJWOFByb3h5LmgifSA9 IDE7CiAK