5768 2005-11-18 00:16:21 -0800 pages with frames that are all "fixed" get no layout and are blank (like www.farnell.nl) 2011-05-04 14:42:14 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED http://www.farnell.nl/ P2 Critical --- 1 henk.kampman hyatt dbates gabriel mitz oldest_to_newest 24223 0 henk.kampman 2005-11-18 00:16:21 -0800 Goto http://www. farnell.nl/ Click on one of the buttons (NIEUWE PRODUCTEN, PUBLICATIES,ED WORLD,SUPPORT,ZOEK) at the top of the page. The corresponding page is loaded, but nothing is visible. However the content will appear when you click once in the window content region. 24273 1 mitz 2005-11-19 13:37:46 -0800 I reduced it to the noresize attribute of the frame element. When it's present, even the simplest testcase of <html> <frameset> <frame src="frame1.html" noresize> </frameset> </html> with frame1.html linking to frame2.html and vice versa results in frame content not appearing after the second switch (dragging in the empty frame behaves like a resize, after which the content is visible again). Without the noresize attribute, content does not disappear. When content is invisible, it's because the RenderFrame is at -500000. It is marked as needing layout but nothing triggers layout for it. 24276 2 4736 mitz 2005-11-19 15:26:50 -0800 Created attachment 4736 Proposed patch Don't skip layout even if all children are fixed. 24425 3 4736 darin 2005-11-22 19:55:15 -0800 Comment on attachment 4736 Proposed patch I was fooled by the formatting changes into thinking this was a bigger change than it is. The substance of this change is simple, and clearly a good idea. But can't we just move the end2: label up one line to get the same effect? I don't see a lot of value in indenting all the code. 24427 4 4778 mitz 2005-11-22 22:02:44 -0800 Created attachment 4778 Equivalent patch without all the indenting (In reply to comment #3) > But can't we just move the end2: label up one line to get the same effect? I > don't see a lot of value in indenting all the code. Just moving end2: up one line will cause RenderContainer::layout() to be called even when there are no children at all. I don't know how significant this is. This patch is equivalent to the previous patch. 24442 5 4778 mitz 2005-11-22 22:17:00 -0800 Comment on attachment 4778 Equivalent patch without all the indenting I'm leaving the r+ on the other patch, but if you prefer this version, please remove it. 24462 6 4778 darin 2005-11-23 06:42:59 -0800 Comment on attachment 4778 Equivalent patch without all the indenting Excellent. Seems much clearer this way. 25176 7 eric 2005-11-29 19:38:18 -0800 It would be good to have a ready-to-land test case for this. 25242 8 4882 mitz 2005-11-30 12:19:33 -0800 Created attachment 4882 unsuccesful attempt at automatic testing This test works (automatically) in Safari, but I couldn't get it to work in DumpRenderTree. Perhaps relayout needs to be forced at some points, which I don't know how to do. Posting it here in hope that it will inspire someone else. 26093 9 darin 2005-12-17 20:20:53 -0800 I tried really hard to make that test work under DumpRenderTree, but I wasn't able to figure it out. There's something about how layout is done for repainting that seems to be required. I spent quite a while debugging both DumpRenderTree and Safari to see what's different between the two but it was ultimately fruitless. 27007 10 mitz 2005-12-28 04:49:32 -0800 *** Bug 5591 has been marked as a duplicate of this bug. *** 35545 11 webkit 2006-03-08 10:32:20 -0800 *** Bug 4110 has been marked as a duplicate of this bug. *** 398266 12 dbates 2011-05-04 14:42:14 -0700 For completeness, this bug was fixed in changeset 11648 <http://trac.webkit.org/changeset/11648>. 4736 2005-11-19 15:26:50 -0800 2005-11-23 06:49:08 -0800 Proposed patch 5768_r1.patch text/plain 4608 mitz SW5kZXg6IFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9mcmFtZXMuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfZnJh bWVzLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS44NApkaWZmIC1wIC11IC1yMS44NCBXZWJD b3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfZnJhbWVzLmNwcAotLS0gV2ViQ29yZS9raHRtbC9y ZW5kZXJpbmcvcmVuZGVyX2ZyYW1lcy5jcHAJMTIgTm92IDIwMDUgMDI6MzI6MjEgLTAwMDAJMS44 NAorKysgV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX2ZyYW1lcy5jcHAJMTkgTm92IDIw MDUgMjI6NTk6NTkgLTAwMDAKQEAgLTMzNCw2NCArMzM0LDYwIEBAIHZvaWQgUmVuZGVyRnJhbWVT ZXQ6OmxheW91dCggKQogICAgIHBvc2l0aW9uRnJhbWVzKCk7CiAKICAgICBSZW5kZXJPYmplY3Qg KmNoaWxkID0gZmlyc3RDaGlsZCgpOwotICAgIGlmICggIWNoaWxkICkKLQlnb3RvIGVuZDI7CiAK LSAgICBpZighbV9oU3BsaXRWYXIgJiYgIW1fdlNwbGl0VmFyKQotICAgIHsKLSNpZmRlZiBERUJV R19MQVlPVVQKLSAgICAgICAga2REZWJ1ZyggNjAzMSApIDw8ICJjYWxjdWxhdGlvbmcgZml4ZWQg U3BsaXR0ZXJzIiA8PCBlbmRsOwotI2VuZGlmCi0gICAgICAgIGlmKCFtX3ZTcGxpdFZhciAmJiBl bGVtZW50KCktPnRvdGFsQ29scygpID4gMSkKLSAgICAgICAgewotICAgICAgICAgICAgbV92U3Bs aXRWYXIgPSBuZXcgYm9vbFtlbGVtZW50KCktPnRvdGFsQ29scygpXTsKLSAgICAgICAgICAgIGZv cihpbnQgaSA9IDA7IGkgPCBlbGVtZW50KCktPnRvdGFsQ29scygpOyBpKyspIG1fdlNwbGl0VmFy W2ldID0gdHJ1ZTsKLSAgICAgICAgfQotICAgICAgICBpZighbV9oU3BsaXRWYXIgJiYgZWxlbWVu dCgpLT50b3RhbFJvd3MoKSA+IDEpCi0gICAgICAgIHsKLSAgICAgICAgICAgIG1faFNwbGl0VmFy ID0gbmV3IGJvb2xbZWxlbWVudCgpLT50b3RhbFJvd3MoKV07Ci0gICAgICAgICAgICBmb3IoaW50 IGkgPSAwOyBpIDwgZWxlbWVudCgpLT50b3RhbFJvd3MoKTsgaSsrKSBtX2hTcGxpdFZhcltpXSA9 IHRydWU7Ci0gICAgICAgIH0KLQotICAgICAgICBmb3IoaW50IHIgPSAwOyByIDwgZWxlbWVudCgp LT50b3RhbFJvd3MoKTsgcisrKQotICAgICAgICB7Ci0gICAgICAgICAgICBmb3IoaW50IGMgPSAw OyBjIDwgZWxlbWVudCgpLT50b3RhbENvbHMoKTsgYysrKQotICAgICAgICAgICAgewotICAgICAg ICAgICAgICAgIGJvb2wgZml4ZWQgPSBmYWxzZTsKKyAgICBpZiAoY2hpbGQpIHsKKyAgICAgICAg aWYoIW1faFNwbGl0VmFyICYmICFtX3ZTcGxpdFZhcikgeworICAgICNpZmRlZiBERUJVR19MQVlP VVQKKyAgICAgICAgICAgIGtkRGVidWcoIDYwMzEgKSA8PCAiY2FsY3VsYXRpb25nIGZpeGVkIFNw bGl0dGVycyIgPDwgZW5kbDsKKyAgICAjZW5kaWYKKyAgICAgICAgICAgIGlmICghbV92U3BsaXRW YXIgJiYgZWxlbWVudCgpLT50b3RhbENvbHMoKSA+IDEpIHsKKyAgICAgICAgICAgICAgICBtX3ZT cGxpdFZhciA9IG5ldyBib29sW2VsZW1lbnQoKS0+dG90YWxDb2xzKCldOworICAgICAgICAgICAg ICAgIGZvciAoaW50IGkgPSAwOyBpIDwgZWxlbWVudCgpLT50b3RhbENvbHMoKTsgaSsrKQorICAg ICAgICAgICAgICAgICAgICBtX3ZTcGxpdFZhcltpXSA9IHRydWU7CisgICAgICAgICAgICB9Cisg ICAgICAgICAgICBpZiAoIW1faFNwbGl0VmFyICYmIGVsZW1lbnQoKS0+dG90YWxSb3dzKCkgPiAx KSB7CisgICAgICAgICAgICAgICAgbV9oU3BsaXRWYXIgPSBuZXcgYm9vbFtlbGVtZW50KCktPnRv dGFsUm93cygpXTsKKyAgICAgICAgICAgICAgICBmb3IgKGludCBpID0gMDsgaSA8IGVsZW1lbnQo KS0+dG90YWxSb3dzKCk7IGkrKykKKyAgICAgICAgICAgICAgICAgICAgbV9oU3BsaXRWYXJbaV0g PSB0cnVlOworICAgICAgICAgICAgfQogCi0gICAgICAgICAgICAgICAgaWYgKCBjaGlsZC0+aXNG cmFtZVNldCgpICkKLSAgICAgICAgICAgICAgICAgIGZpeGVkID0gc3RhdGljX2Nhc3Q8UmVuZGVy RnJhbWVTZXQgKj4oY2hpbGQpLT5lbGVtZW50KCktPm5vUmVzaXplKCk7Ci0gICAgICAgICAgICAg ICAgZWxzZQotICAgICAgICAgICAgICAgICAgZml4ZWQgPSBzdGF0aWNfY2FzdDxSZW5kZXJGcmFt ZSAqPihjaGlsZCktPmVsZW1lbnQoKS0+bm9SZXNpemUoKTsKLQotICAgICAgICAgICAgICAgIGlm KGZpeGVkKQotICAgICAgICAgICAgICAgIHsKLSNpZmRlZiBERUJVR19MQVlPVVQKLSAgICAgICAg ICAgICAgICAgICAga2REZWJ1ZyggNjAzMSApIDw8ICJmb3VuZCBmaXhlZCBjZWxsICIgPDwgciA8 PCAiLyIgPDwgYyA8PCAiISIgPDwgZW5kbDsKLSNlbmRpZgotICAgICAgICAgICAgICAgICAgICBp ZiggZWxlbWVudCgpLT50b3RhbENvbHMoKSA+IDEpCi0gICAgICAgICAgICAgICAgICAgIHsKLSAg ICAgICAgICAgICAgICAgICAgICAgIGlmKGM+MCkgbV92U3BsaXRWYXJbYy0xXSA9IGZhbHNlOwot ICAgICAgICAgICAgICAgICAgICAgICAgbV92U3BsaXRWYXJbY10gPSBmYWxzZTsKKyAgICAgICAg ICAgIGZvcihpbnQgciA9IDA7IHIgPCBlbGVtZW50KCktPnRvdGFsUm93cygpOyByKyspIHsKKyAg ICAgICAgICAgICAgICBmb3IoaW50IGMgPSAwOyBjIDwgZWxlbWVudCgpLT50b3RhbENvbHMoKTsg YysrKSB7CisgICAgICAgICAgICAgICAgICAgIGJvb2wgZml4ZWQgPSBmYWxzZTsKKworICAgICAg ICAgICAgICAgICAgICBpZiAoY2hpbGQtPmlzRnJhbWVTZXQoKSkKKyAgICAgICAgICAgICAgICAg ICAgICAgIGZpeGVkID0gc3RhdGljX2Nhc3Q8UmVuZGVyRnJhbWVTZXQgKj4oY2hpbGQpLT5lbGVt ZW50KCktPm5vUmVzaXplKCk7CisgICAgICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAg ICAgICAgICAgICAgIGZpeGVkID0gc3RhdGljX2Nhc3Q8UmVuZGVyRnJhbWUgKj4oY2hpbGQpLT5l bGVtZW50KCktPm5vUmVzaXplKCk7CisKKyAgICAgICAgICAgICAgICAgICAgaWYgKGZpeGVkKSB7 CisgICAgI2lmZGVmIERFQlVHX0xBWU9VVAorICAgICAgICAgICAgICAgICAgICAgICAga2REZWJ1 ZyggNjAzMSApIDw8ICJmb3VuZCBmaXhlZCBjZWxsICIgPDwgciA8PCAiLyIgPDwgYyA8PCAiISIg PDwgZW5kbDsKKyAgICAjZW5kaWYKKyAgICAgICAgICAgICAgICAgICAgICAgIGlmIChlbGVtZW50 KCktPnRvdGFsQ29scygpID4gMSkgeworICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChj ID4gMCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbV92U3BsaXRWYXJbYy0xXSA9 IGZhbHNlOworICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1fdlNwbGl0VmFyW2NdID0gZmFs c2U7CisgICAgICAgICAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgICAgICAgICBp ZiAoZWxlbWVudCgpLT50b3RhbFJvd3MoKSA+IDEpIHsKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICBpZiAociA+IDApCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1faFNwbGl0 VmFyW3ItMV0gPSBmYWxzZTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBtX2hTcGxpdFZh cltyXSA9IGZhbHNlOworICAgICAgICAgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAg ICAgICAgICAgY2hpbGQgPSBjaGlsZC0+bmV4dFNpYmxpbmcoKTsKKyAgICAgICAgICAgICAgICAg ICAgICAgIGlmICghY2hpbGQpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ290byBlbmQx OwogICAgICAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICAgICAgICAgIGlmKCBlbGVtZW50 KCktPnRvdGFsUm93cygpID4gMSkKLSAgICAgICAgICAgICAgICAgICAgewotICAgICAgICAgICAg ICAgICAgICAgICAgaWYocj4wKSBtX2hTcGxpdFZhcltyLTFdID0gZmFsc2U7Ci0gICAgICAgICAg ICAgICAgICAgICAgICBtX2hTcGxpdFZhcltyXSA9IGZhbHNlOwotICAgICAgICAgICAgICAgICAg ICB9Ci0gICAgICAgICAgICAgICAgICAgIGNoaWxkID0gY2hpbGQtPm5leHRTaWJsaW5nKCk7Ci0g ICAgICAgICAgICAgICAgICAgIGlmKCFjaGlsZCkgZ290byBlbmQyOworICAgICNpZmRlZiBERUJV R19MQVlPVVQKKyAgICAgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgICAgICAg ICAga2REZWJ1ZyggNjAzMSApIDw8ICJub3QgZml4ZWQ6ICIgPDwgciA8PCAiLyIgPDwgYyA8PCAi ISIgPDwgZW5kbDsKKyAgICAjZW5kaWYKICAgICAgICAgICAgICAgICB9Ci0jaWZkZWYgREVCVUdf TEFZT1VUCi0gICAgICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgICAgICBrZERlYnVn KCA2MDMxICkgPDwgIm5vdCBmaXhlZDogIiA8PCByIDw8ICIvIiA8PCBjIDw8ICIhIiA8PCBlbmRs OwotI2VuZGlmCiAgICAgICAgICAgICB9CiAgICAgICAgIH0KLQorIGVuZDE6CisgICAgICAgIFJl bmRlckNvbnRhaW5lcjo6bGF5b3V0KCk7CiAgICAgfQotICAgIFJlbmRlckNvbnRhaW5lcjo6bGF5 b3V0KCk7Ci0gZW5kMjoKICAgICBzZXROZWVkc0xheW91dChmYWxzZSk7CiB9CiAK 4778 2005-11-22 22:02:44 -0800 2005-11-23 06:42:59 -0800 Equivalent patch without all the indenting 5768_r2.patch text/plain 911 mitz SW5kZXg6IFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9mcmFtZXMuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfZnJh bWVzLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS44NQpkaWZmIC1wIC11IC1yMS44NSBXZWJD b3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfZnJhbWVzLmNwcAotLS0gV2ViQ29yZS9raHRtbC9y ZW5kZXJpbmcvcmVuZGVyX2ZyYW1lcy5jcHAJMjEgTm92IDIwMDUgMDE6MjA6MjQgLTAwMDAJMS44 NQorKysgV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX2ZyYW1lcy5jcHAJMjMgTm92IDIw MDUgMDY6MDU6NDggLTAwMDAKQEAgLTM4MCw3ICszODAsOCBAQCB2b2lkIFJlbmRlckZyYW1lU2V0 OjpsYXlvdXQoICkKICAgICAgICAgICAgICAgICAgICAgICAgIG1faFNwbGl0VmFyW3JdID0gZmFs c2U7CiAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAgY2hpbGQgPSBj aGlsZC0+bmV4dFNpYmxpbmcoKTsKLSAgICAgICAgICAgICAgICAgICAgaWYoIWNoaWxkKSBnb3Rv IGVuZDI7CisgICAgICAgICAgICAgICAgICAgIGlmKCFjaGlsZCkKKyAgICAgICAgICAgICAgICAg ICAgICAgIGdvdG8gZW5kMTsKICAgICAgICAgICAgICAgICB9CiAjaWZkZWYgREVCVUdfTEFZT1VU CiAgICAgICAgICAgICAgICAgZWxzZQpAQCAtMzkwLDYgKzM5MSw3IEBAIHZvaWQgUmVuZGVyRnJh bWVTZXQ6OmxheW91dCggKQogICAgICAgICB9CiAKICAgICB9CisgZW5kMToKICAgICBSZW5kZXJD b250YWluZXI6OmxheW91dCgpOwogIGVuZDI6CiAgICAgc2V0TmVlZHNMYXlvdXQoZmFsc2UpOwo= 4882 2005-11-30 12:19:33 -0800 2005-11-30 12:19:33 -0800 unsuccesful attempt at automatic testing 5768_testcase.zip application/octet-stream 1393 mitz UEsDBAoAAAAAAAGyfjMAAAAAAAAAAAAAAAAOABAANTc2OF90ZXN0Y2FzZS9VWAwANwiOQ4IIjkP1 AVAAUEsDBBQACAAIAKuxfjMAAAAAAAAAAAAAAAAbABAANTc2OF90ZXN0Y2FzZS81NzY4dGVzdC5o dG1sVVgMALIIjkPiB45D9QEAAK1TTW8TMRC9+1cMe+muCnbSBA7NJocmQVQqpUJbIY5md9wYHDvy TroNqP8dO06ASK3IoXPxxzw/P4/flK9mn6bV15s5fKg+XsHN7cXV5RSyN0J8GUyFmFWzlBjyXh/e e7nEFkmI+XUGLFsQrc6F6LqOdwPu/J2oPosFLc1QqB2UN9RkE1bG3TigbMJAmgxOrh14NHLj1gTd Ai1IYyAdBOkRlH7AphQJzMq29npFQJsVjjPCBxLf5b1Mu+EKrSDvtG1cxxNnhS1NnSXvjEFfMAjx VIZ3UtOtJW1mzmJejNi99KBhDL0RU2tbk3YWKJzJC/ZrS6NPT0fbSUSqgGxcvV6iJX6HNDcYpxeb yyY/USdFQradpnqR6wISRYxatgj98z/rGLsnhNJVeolBbB5vfg39Xm/HtI9vHuWP0SHZ2SGZ4q2v g7zMY+vWvsY2fcwZj/+R/Z9v8JLihseJ6x8r7u1Lint3SHaUm/6NJ51lHWm12dvqGQmP7JGVIvk4 2FzsemTfQZMtKC3BWeNkE+0f3ZiBDnOVQSjk+JkygnUhoX/GDhJ/OUuROvI3UEsHCJPOMC+pAQAA AAQAAFBLAwQKAAAAAAD9sX4zAAAAAAAAAAAAAAAAGAAQADU3NjhfdGVzdGNhc2UvcmVzb3VyY2Vz L1VYDAB2CI5DfgiOQ/UBUABQSwMEFAAIAAgA2a5+MwAAAAAAAAAAAAAAACMAEAA1NzY4X3Rlc3Rj YXNlL3Jlc291cmNlcy9mcmFtZTEuaHRtbFVYDACyCI5DigOOQ/UBAACzySjJzbHjsslITUwBUiWZ JTmpdmlFibmphjb6EB6XjT5UNik/pdKOyw0kq2AIFIbwgdIgMwBQSwcIaNBwQjYAAABKAAAAUEsD BBQACAAIANaufjMAAAAAAAAAAAAAAAAjABAANTc2OF90ZXN0Y2FzZS9yZXNvdXJjZXMvZnJhbWUy Lmh0bWxVWAwAsgiOQ4QDjkP1AQAAs8koyc2x47LJSE1MAVIlmSU5qXZpRYm5qUY2+hAel40+VDYp P6XSjssNJKtgBBSG8IHSIDMAUEsHCIi+OFc2AAAASgAAAFBLAQIVAwoAAAAAAAGyfjMAAAAAAAAA AAAAAAAOAAwAAAAAAAAAAEDtQQAAAAA1NzY4X3Rlc3RjYXNlL1VYCAA3CI5DggiOQ1BLAQIVAxQA CAAIAKuxfjOTzjAvqQEAAAAEAAAbAAwAAAAAAAAAAECkgTwAAAA1NzY4X3Rlc3RjYXNlLzU3Njh0 ZXN0Lmh0bWxVWAgAsgiOQ+IHjkNQSwECFQMKAAAAAAD9sX4zAAAAAAAAAAAAAAAAGAAMAAAAAAAA AABA7UE+AgAANTc2OF90ZXN0Y2FzZS9yZXNvdXJjZXMvVVgIAHYIjkN+CI5DUEsBAhUDFAAIAAgA 2a5+M2jQcEI2AAAASgAAACMADAAAAAAAAAAAQKSBhAIAADU3NjhfdGVzdGNhc2UvcmVzb3VyY2Vz L2ZyYW1lMS5odG1sVVgIALIIjkOKA45DUEsBAhUDFAAIAAgA1q5+M4i+OFc2AAAASgAAACMADAAA AAAAAAAAQKSBGwMAADU3NjhfdGVzdGNhc2UvcmVzb3VyY2VzL2ZyYW1lMi5odG1sVVgIALIIjkOE A45DUEsFBgAAAAAFAAUAqQEAALIDAAAAAA==