<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>57673</bug_id>
          
          <creation_ts>2011-04-01 15:36:10 -0700</creation_ts>
          <short_desc>Media Element&apos;s muted value ignored if set before play</short_desc>
          <delta_ts>2011-04-08 20:05:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://scotland.proximity.on.ca/dxr/tmp/mute.html</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Humphrey (humphd)">david.humphrey</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>jer.noble</cc>
    
    <cc>mihaip</cc>
    
    <cc>paulirish</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>378138</commentid>
    <comment_count>0</comment_count>
    <who name="David Humphrey (humphd)">david.humphrey</who>
    <bug_when>2011-04-01 15:36:10 -0700</bug_when>
    <thetext>Here&apos;s a testcase where the value of muted gets reset when the media resource actually starts playing.  The element does get muted, according to the controls for the element, but that value isn&apos;t being passed down to, or is being ignored by, the player.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>378141</commentid>
    <comment_count>1</comment_count>
    <who name="David Humphrey (humphd)">david.humphrey</who>
    <bug_when>2011-04-01 15:39:15 -0700</bug_when>
    <thetext>I&apos;m testing this on Chrome/Chromium, and Paul Irish is telling me that this might not belong in WebKit proper.  Let me know if I need to refile elsewhere.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>378153</commentid>
    <comment_count>2</comment_count>
    <who name="David Humphrey (humphd)">david.humphrey</who>
    <bug_when>2011-04-01 15:51:41 -0700</bug_when>
    <thetext>See also https://code.google.com/p/chromium/issues/detail?id=70777</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>378989</commentid>
    <comment_count>3</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-04 13:00:28 -0700</bug_when>
    <thetext>Testcase does not reproduce in WebKit/Safari, as only a .ogv source is provided.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>379123</commentid>
    <comment_count>4</comment_count>
    <who name="David Humphrey (humphd)">david.humphrey</who>
    <bug_when>2011-04-04 15:15:53 -0700</bug_when>
    <thetext>http://scotland.proximity.on.ca/dxr/tmp/mute-mp3.html

Also fails, as described above.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>379126</commentid>
    <comment_count>5</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-04 15:21:17 -0700</bug_when>
    <thetext>Verified that this also reproduces on WebKit/Safari.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>380050</commentid>
    <comment_count>6</comment_count>
      <attachid>88351</attachid>
    <who name="David Humphrey (humphd)">david.humphrey</who>
    <bug_when>2011-04-05 19:23:18 -0700</bug_when>
    <thetext>Created attachment 88351
Possible fix

Here&apos;s a possible fix.  This change fixes the case I linked above.  I couldn&apos;t figure out where the tests for the media element were, and no one on irc was around to answer.  If you can guide me, I&apos;ll do a test for this, too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>380098</commentid>
    <comment_count>7</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-05 21:22:02 -0700</bug_when>
    <thetext>David, the media layout tests are in LayoutTests/media/.  Writing a test may be difficult, because HTMLMediaElement::isMuted() will return true, even if the MediaPlayer is still generating sound.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>380112</commentid>
    <comment_count>8</comment_count>
      <attachid>88364</attachid>
    <who name="David Humphrey (humphd)">david.humphrey</who>
    <bug_when>2011-04-05 21:54:31 -0700</bug_when>
    <thetext>Created attachment 88364
Test for mute before play.

Here&apos;s a test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>380114</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-05 21:55:59 -0700</bug_when>
    <thetext>Attachment 88364 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;]&quot; exit_code: 1

Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>380121</commentid>
    <comment_count>10</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2011-04-05 22:10:46 -0700</bug_when>
    <thetext>The test case passes on my install of Safari, which does not have your fix.  I don&apos;t believe the test case tests the failure condition correctly.

(This is what I mean by it being a hard test case to write.) :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>380308</commentid>
    <comment_count>11</comment_count>
      <attachid>88364</attachid>
    <who name="David Humphrey (humphd)">david.humphrey</who>
    <bug_when>2011-04-06 06:21:01 -0700</bug_when>
    <thetext>Comment on attachment 88364
Test for mute before play.

mmm, clearly I shouldn&apos;t be writing tests at 1 am :)  Yeah, I agree that this is untestable from content scripts.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>380428</commentid>
    <comment_count>12</comment_count>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2011-04-06 08:56:45 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; (From update of attachment 88364 [details])
&gt; mmm, clearly I shouldn&apos;t be writing tests at 1 am :)  Yeah, I agree that this is untestable from content scripts.

It should be possible to create a manual test in Source/WebCore/manual-tests/. I think you want to have a test that sets muted to true before setting src, and verify that no sound is emitted when the movie plays.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>380431</commentid>
    <comment_count>13</comment_count>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2011-04-06 08:58:26 -0700</bug_when>
    <thetext>(In reply to comment #12)
&gt; 
&gt; It should be possible to create a manual test in Source/WebCore/manual-tests/. I think you want to have a test that sets muted to true before setting src, and verify that no sound is emitted when the movie plays.

Oh, and the test should be part of the patch instead of a separate attachment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>380433</commentid>
    <comment_count>14</comment_count>
    <who name="David Humphrey (humphd)">david.humphrey</who>
    <bug_when>2011-04-06 08:59:37 -0700</bug_when>
    <thetext>OK, I&apos;ll do that.  Tell me, what&apos;s the difference here:

./third_party/WebKit/Source/WebCore/manual-tests
./third_party/WebKit/WebCore/manual-tests</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>380548</commentid>
    <comment_count>15</comment_count>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2011-04-06 10:19:16 -0700</bug_when>
    <thetext>(In reply to comment #14)
&gt; OK, I&apos;ll do that.  Tell me, what&apos;s the difference here:
&gt; 
&gt; ./third_party/WebKit/Source/WebCore/manual-tests
&gt; ./third_party/WebKit/WebCore/manual-tests

WebKit/WebCore/ doesn&apos;t exist any more, you probably had a modified file in there somewhere when the repository was updated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>380994</commentid>
    <comment_count>16</comment_count>
      <attachid>88547</attachid>
    <who name="David Humphrey (humphd)">david.humphrey</who>
    <bug_when>2011-04-06 17:30:25 -0700</bug_when>
    <thetext>Created attachment 88547
Fix + manual test

Here&apos;s the fix with a manual test.  I was unable to find any test media in the tree that also has sound, so I&apos;ve followed the example of some other manual tests and linked to urls in svn.  If there is a more suitable media resource, please let me know.  Once again, irc is getting me nowhere.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381310</commentid>
    <comment_count>17</comment_count>
      <attachid>88547</attachid>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2011-04-07 07:11:08 -0700</bug_when>
    <thetext>Comment on attachment 88547
Fix + manual test

View in context: https://bugs.webkit.org/attachment.cgi?id=88547&amp;action=review

&quot;bugzilla-57673.html&quot; won&apos;t be a terribly helpful name to someone browsing the test directory later, maybe something like &quot;media-muted.html&quot; to follow the pattern of several of the existing manual media tests?

This patch is missing the ChangeLog. If you aren&apos;t sure how to generate it, http://www.webkit.org/coding/contributing.html has a good description. 

Also if you set the cq? flag when you set r?, the reviewer will set cq+ when your patch is r+&apos;ed and the commit bot will commit it automatically.

Marking r- because of the missing ChangeLog, but please also consider the load() comment and test name suggestion.

&gt; third_party/WebKit/Source/WebCore/manual-tests/bugzilla-57673.html:22
&gt; +            vid.src = &quot;http://src.chromium.org/svn/trunk/src/chrome/test/data/media/&quot; + findMediaFile(&quot;video&quot;, &quot;bear&quot;);
&gt; +
&gt; +            vid.load();

vid.load() is unnecessary, setting vid.src triggers the resource selection algorithm.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381311</commentid>
    <comment_count>18</comment_count>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2011-04-07 07:13:20 -0700</bug_when>
    <thetext>(In reply to comment #16)
&gt;  Once again, irc is getting me nowhere.

I (eric_carlson) am usually on #webkit from early morning through early afternoon Pacific time.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381934</commentid>
    <comment_count>19</comment_count>
      <attachid>88754</attachid>
    <who name="David Humphrey (humphd)">david.humphrey</who>
    <bug_when>2011-04-07 19:25:56 -0700</bug_when>
    <thetext>Created attachment 88754
Fix + manual test + review fixes

Thanks for the review, Eric.  Here&apos;s a new patch with the fixes you suggest, plus a ChangeLog entry.  Hopefully I&apos;ve done this the way you want.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381938</commentid>
    <comment_count>20</comment_count>
      <attachid>88757</attachid>
    <who name="David Humphrey (humphd)">david.humphrey</who>
    <bug_when>2011-04-07 19:29:08 -0700</bug_when>
    <thetext>Created attachment 88757
Fix + manual test + review fixes (whitespace fix)

That patch had some white space issues in the ChangeLog, here&apos;s a better one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381946</commentid>
    <comment_count>21</comment_count>
      <attachid>88757</attachid>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2011-04-07 19:57:20 -0700</bug_when>
    <thetext>Comment on attachment 88757
Fix + manual test + review fixes (whitespace fix)

Thanks David!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>381989</commentid>
    <comment_count>22</comment_count>
      <attachid>88757</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-07 21:34:13 -0700</bug_when>
    <thetext>Comment on attachment 88757
Fix + manual test + review fixes (whitespace fix)

Rejecting attachment 88757 from commit-queue.

Failed to run &quot;[&apos;./Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;--bot-id=cr-jail-7&apos;, &apos;apply-...&quot; exit_code: 2

Last 500 characters of output:
==========================================
|--- third_party/WebKit/Source/WebCore/html/HTMLMediaElement.cpp	(revision 82928)
|+++ third_party/WebKit/Source/WebCore/html/HTMLMediaElement.cpp	(working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
patching file third_party/WebKit/Source/WebCore/manual-tests/media-muted.html

Failed to run &quot;[u&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply&apos;, u&apos;--reviewer&apos;, u&apos;Eric Carlson&apos;, u&apos;--for...&quot; exit_code: 1

Full output: http://queues.webkit.org/results/8348803</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382499</commentid>
    <comment_count>23</comment_count>
    <who name="Mihai Parparita">mihaip</who>
    <bug_when>2011-04-08 13:15:23 -0700</bug_when>
    <thetext>(In reply to comment #22)
&gt; Rejecting attachment 88757 [details] from commit-queue.
&gt; Last 500 characters of output:
&gt; ==========================================
&gt; |--- third_party/WebKit/Source/WebCore/html/HTMLMediaElement.cpp    (revision 82928)
&gt; |+++ third_party/WebKit/Source/WebCore/html/HTMLMediaElement.cpp    (working copy)
&gt; --------------------------
&gt; No file to patch.  Skipping patch.

It looks like the patch did not apply cleanly because the paths are prefixed with third_party/WebKit, which i the location of WebKit inside the Chromium tree. That prefix should be absent for patches on the WebKit side.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382500</commentid>
    <comment_count>24</comment_count>
    <who name="Mihai Parparita">mihaip</who>
    <bug_when>2011-04-08 13:16:57 -0700</bug_when>
    <thetext>(In reply to comment #23)
&gt; It looks like the patch did not apply cleanly because the paths are prefixed with third_party/WebKit, which i the location of WebKit inside the Chromium tree. That prefix should be absent for patches on the WebKit side.

More generally, see http://dev.chromium.org/developers/contributing-to-webkit and the pointer towards using webkit-patch upload, which will generally do The Right Thing as far as patch paths, ChangeLogs, etc.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382684</commentid>
    <comment_count>25</comment_count>
      <attachid>88908</attachid>
    <who name="David Humphrey (humphd)">david.humphrey</who>
    <bug_when>2011-04-08 18:02:45 -0700</bug_when>
    <thetext>Created attachment 88908
Fix + manual test + review fixes (whitespace fix, webkit)

Switched to a WebKit tree.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382707</commentid>
    <comment_count>26</comment_count>
      <attachid>88908</attachid>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2011-04-08 18:57:56 -0700</bug_when>
    <thetext>Comment on attachment 88908
Fix + manual test + review fixes (whitespace fix, webkit)

Hopefully the third time will be a charm :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382720</commentid>
    <comment_count>27</comment_count>
      <attachid>88908</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-08 20:05:38 -0700</bug_when>
    <thetext>Comment on attachment 88908
Fix + manual test + review fixes (whitespace fix, webkit)

Clearing flags on attachment: 88908

Committed r83373: &lt;http://trac.webkit.org/changeset/83373&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>382721</commentid>
    <comment_count>28</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-08 20:05:42 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>88351</attachid>
            <date>2011-04-05 19:23:18 -0700</date>
            <delta_ts>2011-04-06 17:30:25 -0700</delta_ts>
            <desc>Possible fix</desc>
            <filename>bug57673.diff</filename>
            <type>text/plain</type>
            <size>1060</size>
            <attacher name="David Humphrey (humphd)">david.humphrey</attacher>
            
              <data encoding="base64">SW5kZXg6IHRoaXJkX3BhcnR5L1dlYktpdC9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVs
ZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIHRoaXJkX3BhcnR5L1dlYktpdC9Tb3VyY2UvV2ViQ29y
ZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCShyZXZpc2lvbiA4MjkyOCkKKysrIHRoaXJkX3Bh
cnR5L1dlYktpdC9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCSh3b3Jr
aW5nIGNvcHkpCkBAIC0yMTM3LDkgKzIxMzcsMTEgQEAKICAgICAgICAgICAgIGlmICghbV9pc0Z1
bGxzY3JlZW4gJiYgaXNWaWRlbygpICYmIGRvY3VtZW50KCkgJiYgZG9jdW1lbnQoKS0+cGFnZSgp
ICYmIGRvY3VtZW50KCktPnBhZ2UoKS0+Y2hyb21lKCktPnJlcXVpcmVzRnVsbHNjcmVlbkZvclZp
ZGVvUGxheWJhY2soKSkKICAgICAgICAgICAgICAgICBlbnRlckZ1bGxzY3JlZW4oKTsKIAotICAg
ICAgICAgICAgLy8gU2V0IHJhdGUgYmVmb3JlIGNhbGxpbmcgcGxheSBpbiBjYXNlIHRoZSByYXRl
IHdhcyBzZXQgYmVmb3JlIHRoZSBtZWRpYSBlbmdpbmUgd2FzIHNldHVwLgotICAgICAgICAgICAg
Ly8gVGhlIG1lZGlhIGVuZ2luZSBzaG91bGQganVzdCBzdGFzaCB0aGUgcmF0ZSBzaW5jZSBpdCBp
c24ndCBhbHJlYWR5IHBsYXlpbmcuCisgICAgICAgICAgICAvLyBTZXQgcmF0ZSwgbXV0ZWQgYmVm
b3JlIGNhbGxpbmcgcGxheSBpbiBjYXNlIHRoZXkgd2VyZSBzZXQgYmVmb3JlIHRoZSBtZWRpYSBl
bmdpbmUgd2FzIHNldHVwLgorICAgICAgICAgICAgLy8gVGhlIG1lZGlhIGVuZ2luZSBzaG91bGQg
anVzdCBzdGFzaCB0aGUgcmF0ZSBhbmQgbXV0ZWQgdmFsdWVzIHNpbmNlIGl0IGlzbid0IGFscmVh
ZHkgcGxheWluZy4KICAgICAgICAgICAgIG1fcGxheWVyLT5zZXRSYXRlKG1fcGxheWJhY2tSYXRl
KTsKKyAgICAgICAgICAgIG1fcGxheWVyLT5zZXRNdXRlZChtX211dGVkKTsKKwogICAgICAgICAg
ICAgbV9wbGF5ZXItPnBsYXkoKTsKICAgICAgICAgfQogCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="0"
              isprivate="0"
          >
            <attachid>88364</attachid>
            <date>2011-04-05 21:54:31 -0700</date>
            <delta_ts>2011-04-06 06:21:00 -0700</delta_ts>
            <desc>Test for mute before play.</desc>
            <filename>video-mute-before-play.html</filename>
            <type>text/html</type>
            <size>701</size>
            <attacher name="David Humphrey (humphd)">david.humphrey</attacher>
            
              <data encoding="base64">PGh0bWw+CjxoZWFkPgogICAgPHNjcmlwdCBzcmM9bWVkaWEtZmlsZS5qcz48L3NjcmlwdD4KICAg
IDxzY3JpcHQgc3JjPXZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+CiAgICA8c2NyaXB0PgogICAgdmFy
IHZpZGVvOwoKICAgIGZ1bmN0aW9uIGNhbnBsYXl0aHJvdWdoKCkKICAgIHsKICAgICAgICB2aWRl
by5tdXRlZCA9IHRydWU7CiAgICAgICAgdmlkZW8ucGxheSgpOwoKICAgICAgICB0ZXN0RXhwZWN0
ZWQoInZpZGVvLm11dGVkIiwgdHJ1ZSk7CgogICAgICAgIHZpZGVvLnBhdXNlKCk7CiAgICAgICAg
ZW5kVGVzdCgpOwogICAgfQoKICAgIGZ1bmN0aW9uIHRlc3QoKQogICAgewogICAgICAgIHZpZGVv
ID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ3ZpZGVvJylbMF07CiAgICAgICAgdmlk
ZW8uYWRkRXZlbnRMaXN0ZW5lcigiY2FucGxheXRocm91Z2giLCBjYW5wbGF5dGhyb3VnaCk7Cgog
ICAgICAgIHZpZGVvLnNyYyA9IGZpbmRNZWRpYUZpbGUoInZpZGVvIiwgImNvbnRlbnQvY291bnRp
bmciKTsKICAgICAgICB2aWRlby5sb2FkKCk7CiAgICB9CiAgICA8L3NjcmlwdD4KPC9oZWFkPgo8
Ym9keSBvbmxvYWQ9InRlc3QoKSI+CjxwPk1ha2Ugc3VyZSBzZXR0aW5nIHZpZGVvLm11dGVkIHdv
cmtzIGlmIGNhbGxlZCBiZWZvcmUgcGxheSgpLjwvcD4KPHZpZGVvIGNvbnRyb2xzPjwvdmlkZW8+
CjwvYm9keT4KPC9odG1sPgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>88547</attachid>
            <date>2011-04-06 17:30:25 -0700</date>
            <delta_ts>2011-04-07 19:25:56 -0700</delta_ts>
            <desc>Fix + manual test</desc>
            <filename>bug57673-2.diff</filename>
            <type>text/plain</type>
            <size>2430</size>
            <attacher name="David Humphrey (humphd)">david.humphrey</attacher>
            
              <data encoding="base64">SW5kZXg6IHRoaXJkX3BhcnR5L1dlYktpdC9Tb3VyY2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvYnVn
emlsbGEtNTc2NzMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB0aGlyZF9wYXJ0eS9XZWJLaXQvU291cmNl
L1dlYkNvcmUvbWFudWFsLXRlc3RzL2J1Z3ppbGxhLTU3NjczLmh0bWwJKHJldmlzaW9uIDApCisr
KyB0aGlyZF9wYXJ0eS9XZWJLaXQvU291cmNlL1dlYkNvcmUvbWFudWFsLXRlc3RzL2J1Z3ppbGxh
LTU3NjczLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzQgQEAKKzxodG1sPgorICAgIDwh
LS0gTGF5b3V0VGVzdHMgbG9jYXRpb24gaXMgaGFyZC1jb2RlZCB0byBhdm9pZCBkdXBsaWNhdGlv
biBvZiBjb2RlLiAtLT4KKyAgICA8c2NyaXB0IHNyYz0iaHR0cDovL3N2bi53ZWJraXQub3JnL3Jl
cG9zaXRvcnkvd2Via2l0L3RydW5rL0xheW91dFRlc3RzL21lZGlhL21lZGlhLWZpbGUuanMiPjwv
c2NyaXB0PgorICAgIDxzY3JpcHQ+CisgICAgICAgIHZhciB2aWQ7CisKKyAgICAgICAgZnVuY3Rp
b24gY2FucGxheXRocm91Z2goKQorICAgICAgICB7CisgICAgICAgICAgICB2aWQucGxheSgpOwor
ICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gbG9hZCgpCisgICAgICAgIHsKKyAgICAgICAg
ICAgIHZpZCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd2aWQnKTsKKyAgICAgICAgICAgIHZp
ZC5hZGRFdmVudExpc3RlbmVyKCdjYW5wbGF5dGhyb3VnaCcsIGNhbnBsYXl0aHJvdWdoKTsKKwor
ICAgICAgICAgICAgLy8gTXV0ZSBmaXJzdAorICAgICAgICAgICAgdmlkLm11dGVkID0gdHJ1ZTsK
KworICAgICAgICAgICAgdmlkLnNyYyA9ICJodHRwOi8vc3JjLmNocm9taXVtLm9yZy9zdm4vdHJ1
bmsvc3JjL2Nocm9tZS90ZXN0L2RhdGEvbWVkaWEvIiArIGZpbmRNZWRpYUZpbGUoInZpZGVvIiwg
ImJlYXIiKTsKKworICAgICAgICAgICAgdmlkLmxvYWQoKTsKKyAgICAgICAgfQorICAgIDwvc2Ny
aXB0PgorCisgICAgPGJvZHk+CisgICAgICAgIDx2aWRlbyBpZD12aWQgY29udHJvbHMgYXV0b3Bs
YXk+CisgICAgICAgIDwvdmlkZW8+CisgICAgICAgIDxwPlRFU1Q6IFZpZGVvIHNob3VsZCBiZSBt
dXRlZCAoZS5nLiwgY29udHJvbHMpIGFuZCBhbHNvIHByb2R1Y2Ugbm8gc291bmQgKDxhIGhyZWY9
Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzY3MyI+YnVnIDU3Njcz
PC9hPikuPC9wPgorICAgICAgICA8aW5wdXQgdHlwZT0iYnV0dG9uIiB2YWx1ZT0iTG9hZCBtb3Zp
ZSIgb25jbGljaz0ibG9hZCgpIj4KKyAgICAgICAgPGJyPgorICAgIDwvYm9keT4KKworPC9odG1s
PgpJbmRleDogdGhpcmRfcGFydHkvV2ViS2l0L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh
RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gdGhpcmRfcGFydHkvV2ViS2l0L1NvdXJjZS9XZWJD
b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHJldmlzaW9uIDgyOTI4KQorKysgdGhpcmRf
cGFydHkvV2ViS2l0L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHdv
cmtpbmcgY29weSkKQEAgLTIxMzcsOSArMjEzNywxMSBAQAogICAgICAgICAgICAgaWYgKCFtX2lz
RnVsbHNjcmVlbiAmJiBpc1ZpZGVvKCkgJiYgZG9jdW1lbnQoKSAmJiBkb2N1bWVudCgpLT5wYWdl
KCkgJiYgZG9jdW1lbnQoKS0+cGFnZSgpLT5jaHJvbWUoKS0+cmVxdWlyZXNGdWxsc2NyZWVuRm9y
VmlkZW9QbGF5YmFjaygpKQogICAgICAgICAgICAgICAgIGVudGVyRnVsbHNjcmVlbigpOwogCi0g
ICAgICAgICAgICAvLyBTZXQgcmF0ZSBiZWZvcmUgY2FsbGluZyBwbGF5IGluIGNhc2UgdGhlIHJh
dGUgd2FzIHNldCBiZWZvcmUgdGhlIG1lZGlhIGVuZ2luZSB3YXMgc2V0dXAuCi0gICAgICAgICAg
ICAvLyBUaGUgbWVkaWEgZW5naW5lIHNob3VsZCBqdXN0IHN0YXNoIHRoZSByYXRlIHNpbmNlIGl0
IGlzbid0IGFscmVhZHkgcGxheWluZy4KKyAgICAgICAgICAgIC8vIFNldCByYXRlLCBtdXRlZCBi
ZWZvcmUgY2FsbGluZyBwbGF5IGluIGNhc2UgdGhleSB3ZXJlIHNldCBiZWZvcmUgdGhlIG1lZGlh
IGVuZ2luZSB3YXMgc2V0dXAuCisgICAgICAgICAgICAvLyBUaGUgbWVkaWEgZW5naW5lIHNob3Vs
ZCBqdXN0IHN0YXNoIHRoZSByYXRlIGFuZCBtdXRlZCB2YWx1ZXMgc2luY2UgaXQgaXNuJ3QgYWxy
ZWFkeSBwbGF5aW5nLgogICAgICAgICAgICAgbV9wbGF5ZXItPnNldFJhdGUobV9wbGF5YmFja1Jh
dGUpOworICAgICAgICAgICAgbV9wbGF5ZXItPnNldE11dGVkKG1fbXV0ZWQpOworCiAgICAgICAg
ICAgICBtX3BsYXllci0+cGxheSgpOwogICAgICAgICB9CiAK
</data>
<flag name="review"
          id="81076"
          type_id="1"
          status="-"
          setter="eric.carlson"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>88754</attachid>
            <date>2011-04-07 19:25:56 -0700</date>
            <delta_ts>2011-04-07 19:29:08 -0700</delta_ts>
            <desc>Fix + manual test + review fixes</desc>
            <filename>bug57673-3.diff</filename>
            <type>text/plain</type>
            <size>3276</size>
            <attacher name="David Humphrey (humphd)">david.humphrey</attacher>
            
              <data encoding="base64">SW5kZXg6IHRoaXJkX3BhcnR5L1dlYktpdC9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gdGhpcmRfcGFydHkvV2ViS2l0L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2
aXNpb24gODMyMzkpCisrKyB0aGlyZF9wYXJ0eS9XZWJLaXQvU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDcgIERhdmlkIEh1
bXBocmV5ICA8ZGF2aWQuaHVtcGhyZXlAc2VuZWNhYy5vbi5jYT4KKworICAgICAgICBSZXZpZXdl
ZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgRml4IGNhbGwgb3JkZXIgb2YgbWVkaWEgZWxl
bWVudCBtdXRlZCBhbmQgcGxheSgpLCBzdWNoIHRoYXQgc2V0dGluZyBtdXRlZCBiZWZvcmUgcGxh
eSgpIHdvcmtzLgorCSAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9NTc2NzMKKwkgICAgICAgaHR0cHM6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1
ZXMvZGV0YWlsP2lkPTcwNzc3CisKKwkgICAgICAgTWFudWFsIHRlc3QgYWRkZWQ6IG1hbnVhbC10
ZXN0cy9tZWRpYS1tdXRlZC5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQu
Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlUGxheVN0YXRl
KToKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvbWVkaWEtbXV0ZWQuaHRtbDogQWRkZWQuCisKIDIw
MTEtMDQtMDcgIE5hb2tpIFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFpbC5jb20+CiAKICAgICAg
ICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IHRoaXJkX3BhcnR5L1dlYktpdC9Tb3Vy
Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHRoaXJk
X3BhcnR5L1dlYktpdC9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCShy
ZXZpc2lvbiA4MjkyOCkKKysrIHRoaXJkX3BhcnR5L1dlYktpdC9Tb3VyY2UvV2ViQ29yZS9odG1s
L0hUTUxNZWRpYUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTM3LDkgKzIxMzcsMTEg
QEAKICAgICAgICAgICAgIGlmICghbV9pc0Z1bGxzY3JlZW4gJiYgaXNWaWRlbygpICYmIGRvY3Vt
ZW50KCkgJiYgZG9jdW1lbnQoKS0+cGFnZSgpICYmIGRvY3VtZW50KCktPnBhZ2UoKS0+Y2hyb21l
KCktPnJlcXVpcmVzRnVsbHNjcmVlbkZvclZpZGVvUGxheWJhY2soKSkKICAgICAgICAgICAgICAg
ICBlbnRlckZ1bGxzY3JlZW4oKTsKIAotICAgICAgICAgICAgLy8gU2V0IHJhdGUgYmVmb3JlIGNh
bGxpbmcgcGxheSBpbiBjYXNlIHRoZSByYXRlIHdhcyBzZXQgYmVmb3JlIHRoZSBtZWRpYSBlbmdp
bmUgd2FzIHNldHVwLgotICAgICAgICAgICAgLy8gVGhlIG1lZGlhIGVuZ2luZSBzaG91bGQganVz
dCBzdGFzaCB0aGUgcmF0ZSBzaW5jZSBpdCBpc24ndCBhbHJlYWR5IHBsYXlpbmcuCisgICAgICAg
ICAgICAvLyBTZXQgcmF0ZSwgbXV0ZWQgYmVmb3JlIGNhbGxpbmcgcGxheSBpbiBjYXNlIHRoZXkg
d2VyZSBzZXQgYmVmb3JlIHRoZSBtZWRpYSBlbmdpbmUgd2FzIHNldHVwLgorICAgICAgICAgICAg
Ly8gVGhlIG1lZGlhIGVuZ2luZSBzaG91bGQganVzdCBzdGFzaCB0aGUgcmF0ZSBhbmQgbXV0ZWQg
dmFsdWVzIHNpbmNlIGl0IGlzbid0IGFscmVhZHkgcGxheWluZy4KICAgICAgICAgICAgIG1fcGxh
eWVyLT5zZXRSYXRlKG1fcGxheWJhY2tSYXRlKTsKKyAgICAgICAgICAgIG1fcGxheWVyLT5zZXRN
dXRlZChtX211dGVkKTsKKwogICAgICAgICAgICAgbV9wbGF5ZXItPnBsYXkoKTsKICAgICAgICAg
fQogCkluZGV4OiB0aGlyZF9wYXJ0eS9XZWJLaXQvU291cmNlL1dlYkNvcmUvbWFudWFsLXRlc3Rz
L21lZGlhLW11dGVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gdGhpcmRfcGFydHkvV2ViS2l0L1NvdXJj
ZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9tZWRpYS1tdXRlZC5odG1sCShyZXZpc2lvbiAwKQorKysg
dGhpcmRfcGFydHkvV2ViS2l0L1NvdXJjZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9tZWRpYS1tdXRl
ZC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMyIEBACis8aHRtbD4KKyAgICA8IS0tIExh
eW91dFRlc3RzIGxvY2F0aW9uIGlzIGhhcmQtY29kZWQgdG8gYXZvaWQgZHVwbGljYXRpb24gb2Yg
Y29kZS4gLS0+CisgICAgPHNjcmlwdCBzcmM9Imh0dHA6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0
b3J5L3dlYmtpdC90cnVuay9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1maWxlLmpzIj48L3Njcmlw
dD4KKyAgICA8c2NyaXB0PgorICAgICAgICB2YXIgdmlkOworCisgICAgICAgIGZ1bmN0aW9uIGNh
bnBsYXl0aHJvdWdoKCkKKyAgICAgICAgeworICAgICAgICAgICAgdmlkLnBsYXkoKTsKKyAgICAg
ICAgfQorCisgICAgICAgIGZ1bmN0aW9uIGxvYWQoKQorICAgICAgICB7CisgICAgICAgICAgICB2
aWQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndmlkJyk7CisgICAgICAgICAgICB2aWQuYWRk
RXZlbnRMaXN0ZW5lcignY2FucGxheXRocm91Z2gnLCBjYW5wbGF5dGhyb3VnaCk7CisKKyAgICAg
ICAgICAgIC8vIE11dGUgZmlyc3QKKyAgICAgICAgICAgIHZpZC5tdXRlZCA9IHRydWU7CisKKyAg
ICAgICAgICAgIHZpZC5zcmMgPSAiaHR0cDovL3NyYy5jaHJvbWl1bS5vcmcvc3ZuL3RydW5rL3Ny
Yy9jaHJvbWUvdGVzdC9kYXRhL21lZGlhLyIgKyBmaW5kTWVkaWFGaWxlKCJ2aWRlbyIsICJiZWFy
Iik7CisgICAgICAgIH0KKyAgICA8L3NjcmlwdD4KKworICAgIDxib2R5PgorICAgICAgICA8dmlk
ZW8gaWQ9dmlkIGNvbnRyb2xzIGF1dG9wbGF5PgorICAgICAgICA8L3ZpZGVvPgorICAgICAgICA8
cD5URVNUOiBWaWRlbyBzaG91bGQgYmUgbXV0ZWQgKGUuZy4sIGNvbnRyb2xzKSBhbmQgYWxzbyBw
cm9kdWNlIG5vIHNvdW5kICg8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9NTc2NzMiPmJ1ZyA1NzY3MzwvYT4pLjwvcD4KKyAgICAgICAgPGlucHV0IHR5cGU9
ImJ1dHRvbiIgdmFsdWU9IkxvYWQgbW92aWUiIG9uY2xpY2s9ImxvYWQoKSI+CisgICAgICAgIDxi
cj4KKyAgICA8L2JvZHk+CisKKzwvaHRtbD4K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>88757</attachid>
            <date>2011-04-07 19:29:08 -0700</date>
            <delta_ts>2011-04-08 18:02:45 -0700</delta_ts>
            <desc>Fix + manual test + review fixes (whitespace fix)</desc>
            <filename>bug57673-3.diff</filename>
            <type>text/plain</type>
            <size>3276</size>
            <attacher name="David Humphrey (humphd)">david.humphrey</attacher>
            
              <data encoding="base64">SW5kZXg6IHRoaXJkX3BhcnR5L1dlYktpdC9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gdGhpcmRfcGFydHkvV2ViS2l0L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2
aXNpb24gODMyMzkpCisrKyB0aGlyZF9wYXJ0eS9XZWJLaXQvU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDcgIERhdmlkIEh1
bXBocmV5ICA8ZGF2aWQuaHVtcGhyZXlAc2VuZWNhYy5vbi5jYT4KKworICAgICAgICBSZXZpZXdl
ZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgRml4IGNhbGwgb3JkZXIgb2YgbWVkaWEgZWxl
bWVudCBtdXRlZCBhbmQgcGxheSgpLCBzdWNoIHRoYXQgc2V0dGluZyBtdXRlZCBiZWZvcmUgcGxh
eSgpIHdvcmtzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9NTc2NzMKKyAgICAgICAgaHR0cHM6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1
ZXMvZGV0YWlsP2lkPTcwNzc3CisKKyAgICAgICAgTWFudWFsIHRlc3QgYWRkZWQ6IG1hbnVhbC10
ZXN0cy9tZWRpYS1tdXRlZC5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQu
Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlUGxheVN0YXRl
KToKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvbWVkaWEtbXV0ZWQuaHRtbDogQWRkZWQuCisKIDIw
MTEtMDQtMDcgIE5hb2tpIFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFpbC5jb20+CiAKICAgICAg
ICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IHRoaXJkX3BhcnR5L1dlYktpdC9Tb3Vy
Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHRoaXJk
X3BhcnR5L1dlYktpdC9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCShy
ZXZpc2lvbiA4MjkyOCkKKysrIHRoaXJkX3BhcnR5L1dlYktpdC9Tb3VyY2UvV2ViQ29yZS9odG1s
L0hUTUxNZWRpYUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTM3LDkgKzIxMzcsMTEg
QEAKICAgICAgICAgICAgIGlmICghbV9pc0Z1bGxzY3JlZW4gJiYgaXNWaWRlbygpICYmIGRvY3Vt
ZW50KCkgJiYgZG9jdW1lbnQoKS0+cGFnZSgpICYmIGRvY3VtZW50KCktPnBhZ2UoKS0+Y2hyb21l
KCktPnJlcXVpcmVzRnVsbHNjcmVlbkZvclZpZGVvUGxheWJhY2soKSkKICAgICAgICAgICAgICAg
ICBlbnRlckZ1bGxzY3JlZW4oKTsKIAotICAgICAgICAgICAgLy8gU2V0IHJhdGUgYmVmb3JlIGNh
bGxpbmcgcGxheSBpbiBjYXNlIHRoZSByYXRlIHdhcyBzZXQgYmVmb3JlIHRoZSBtZWRpYSBlbmdp
bmUgd2FzIHNldHVwLgotICAgICAgICAgICAgLy8gVGhlIG1lZGlhIGVuZ2luZSBzaG91bGQganVz
dCBzdGFzaCB0aGUgcmF0ZSBzaW5jZSBpdCBpc24ndCBhbHJlYWR5IHBsYXlpbmcuCisgICAgICAg
ICAgICAvLyBTZXQgcmF0ZSwgbXV0ZWQgYmVmb3JlIGNhbGxpbmcgcGxheSBpbiBjYXNlIHRoZXkg
d2VyZSBzZXQgYmVmb3JlIHRoZSBtZWRpYSBlbmdpbmUgd2FzIHNldHVwLgorICAgICAgICAgICAg
Ly8gVGhlIG1lZGlhIGVuZ2luZSBzaG91bGQganVzdCBzdGFzaCB0aGUgcmF0ZSBhbmQgbXV0ZWQg
dmFsdWVzIHNpbmNlIGl0IGlzbid0IGFscmVhZHkgcGxheWluZy4KICAgICAgICAgICAgIG1fcGxh
eWVyLT5zZXRSYXRlKG1fcGxheWJhY2tSYXRlKTsKKyAgICAgICAgICAgIG1fcGxheWVyLT5zZXRN
dXRlZChtX211dGVkKTsKKwogICAgICAgICAgICAgbV9wbGF5ZXItPnBsYXkoKTsKICAgICAgICAg
fQogCkluZGV4OiB0aGlyZF9wYXJ0eS9XZWJLaXQvU291cmNlL1dlYkNvcmUvbWFudWFsLXRlc3Rz
L21lZGlhLW11dGVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gdGhpcmRfcGFydHkvV2ViS2l0L1NvdXJj
ZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9tZWRpYS1tdXRlZC5odG1sCShyZXZpc2lvbiAwKQorKysg
dGhpcmRfcGFydHkvV2ViS2l0L1NvdXJjZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9tZWRpYS1tdXRl
ZC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMyIEBACis8aHRtbD4KKyAgICA8IS0tIExh
eW91dFRlc3RzIGxvY2F0aW9uIGlzIGhhcmQtY29kZWQgdG8gYXZvaWQgZHVwbGljYXRpb24gb2Yg
Y29kZS4gLS0+CisgICAgPHNjcmlwdCBzcmM9Imh0dHA6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0
b3J5L3dlYmtpdC90cnVuay9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1maWxlLmpzIj48L3Njcmlw
dD4KKyAgICA8c2NyaXB0PgorICAgICAgICB2YXIgdmlkOworCisgICAgICAgIGZ1bmN0aW9uIGNh
bnBsYXl0aHJvdWdoKCkKKyAgICAgICAgeworICAgICAgICAgICAgdmlkLnBsYXkoKTsKKyAgICAg
ICAgfQorCisgICAgICAgIGZ1bmN0aW9uIGxvYWQoKQorICAgICAgICB7CisgICAgICAgICAgICB2
aWQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndmlkJyk7CisgICAgICAgICAgICB2aWQuYWRk
RXZlbnRMaXN0ZW5lcignY2FucGxheXRocm91Z2gnLCBjYW5wbGF5dGhyb3VnaCk7CisKKyAgICAg
ICAgICAgIC8vIE11dGUgZmlyc3QKKyAgICAgICAgICAgIHZpZC5tdXRlZCA9IHRydWU7CisKKyAg
ICAgICAgICAgIHZpZC5zcmMgPSAiaHR0cDovL3NyYy5jaHJvbWl1bS5vcmcvc3ZuL3RydW5rL3Ny
Yy9jaHJvbWUvdGVzdC9kYXRhL21lZGlhLyIgKyBmaW5kTWVkaWFGaWxlKCJ2aWRlbyIsICJiZWFy
Iik7CisgICAgICAgIH0KKyAgICA8L3NjcmlwdD4KKworICAgIDxib2R5PgorICAgICAgICA8dmlk
ZW8gaWQ9dmlkIGNvbnRyb2xzIGF1dG9wbGF5PgorICAgICAgICA8L3ZpZGVvPgorICAgICAgICA8
cD5URVNUOiBWaWRlbyBzaG91bGQgYmUgbXV0ZWQgKGUuZy4sIGNvbnRyb2xzKSBhbmQgYWxzbyBw
cm9kdWNlIG5vIHNvdW5kICg8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9NTc2NzMiPmJ1ZyA1NzY3MzwvYT4pLjwvcD4KKyAgICAgICAgPGlucHV0IHR5cGU9
ImJ1dHRvbiIgdmFsdWU9IkxvYWQgbW92aWUiIG9uY2xpY2s9ImxvYWQoKSI+CisgICAgICAgIDxi
cj4KKyAgICA8L2JvZHk+CisKKzwvaHRtbD4K
</data>
<flag name="review"
          id="81321"
          type_id="1"
          status="+"
          setter="eric.carlson"
    />
    <flag name="commit-queue"
          id="81322"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>88908</attachid>
            <date>2011-04-08 18:02:45 -0700</date>
            <delta_ts>2011-04-08 20:05:37 -0700</delta_ts>
            <desc>Fix + manual test + review fixes (whitespace fix, webkit)</desc>
            <filename>bug57673-4.diff</filename>
            <type>text/plain</type>
            <size>3145</size>
            <attacher name="David Humphrey (humphd)">david.humphrey</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzMzYzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDggIERhdmlkIEh1
bXBocmV5ICA8ZGF2aWQuaHVtcGhyZXlAc2VuZWNhYy5vbi5jYT4KKworICAgICAgICBSZXZpZXdl
ZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgRml4IGNhbGwgb3JkZXIgb2YgbWVkaWEgZWxl
bWVudCBtdXRlZCBhbmQgcGxheSgpLCBzdWNoIHRoYXQgc2V0dGluZyBtdXRlZCBiZWZvcmUgcGxh
eSgpIHdvcmtzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9NTc2NzMKKyAgICAgICAgaHR0cHM6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1
ZXMvZGV0YWlsP2lkPTcwNzc3CisKKyAgICAgICAgTWFudWFsIHRlc3QgYWRkZWQ6IG1hbnVhbC10
ZXN0cy9tZWRpYS1tdXRlZC5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQu
Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlUGxheVN0YXRl
KToKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvbWVkaWEtbXV0ZWQuaHRtbDogQWRkZWQuCisKIDIw
MTEtMDQtMDggIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAg
UmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M
TWVkaWFFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxN
ZWRpYUVsZW1lbnQuY3BwCShyZXZpc2lvbiA4MzM0MykKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwv
SFRNTE1lZGlhRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIxMzcsOSArMjEzNywxMSBA
QCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0ZVBsYXlTdGF0ZSgpCiAgICAgICAgICAgICBp
ZiAoIW1faXNGdWxsc2NyZWVuICYmIGlzVmlkZW8oKSAmJiBkb2N1bWVudCgpICYmIGRvY3VtZW50
KCktPnBhZ2UoKSAmJiBkb2N1bWVudCgpLT5wYWdlKCktPmNocm9tZSgpLT5yZXF1aXJlc0Z1bGxz
Y3JlZW5Gb3JWaWRlb1BsYXliYWNrKCkpCiAgICAgICAgICAgICAgICAgZW50ZXJGdWxsc2NyZWVu
KCk7CiAKLSAgICAgICAgICAgIC8vIFNldCByYXRlIGJlZm9yZSBjYWxsaW5nIHBsYXkgaW4gY2Fz
ZSB0aGUgcmF0ZSB3YXMgc2V0IGJlZm9yZSB0aGUgbWVkaWEgZW5naW5lIHdhcyBzZXR1cC4KLSAg
ICAgICAgICAgIC8vIFRoZSBtZWRpYSBlbmdpbmUgc2hvdWxkIGp1c3Qgc3Rhc2ggdGhlIHJhdGUg
c2luY2UgaXQgaXNuJ3QgYWxyZWFkeSBwbGF5aW5nLgorICAgICAgICAgICAgLy8gU2V0IHJhdGUs
IG11dGVkIGJlZm9yZSBjYWxsaW5nIHBsYXkgaW4gY2FzZSB0aGV5IHdlcmUgc2V0IGJlZm9yZSB0
aGUgbWVkaWEgZW5naW5lIHdhcyBzZXR1cC4KKyAgICAgICAgICAgIC8vIFRoZSBtZWRpYSBlbmdp
bmUgc2hvdWxkIGp1c3Qgc3Rhc2ggdGhlIHJhdGUgYW5kIG11dGVkIHZhbHVlcyBzaW5jZSBpdCBp
c24ndCBhbHJlYWR5IHBsYXlpbmcuCiAgICAgICAgICAgICBtX3BsYXllci0+c2V0UmF0ZShtX3Bs
YXliYWNrUmF0ZSk7CisgICAgICAgICAgICBtX3BsYXllci0+c2V0TXV0ZWQobV9tdXRlZCk7CisK
ICAgICAgICAgICAgIG1fcGxheWVyLT5wbGF5KCk7CiAgICAgICAgIH0KIApJbmRleDogU291cmNl
L1dlYkNvcmUvbWFudWFsLXRlc3RzL21lZGlhLW11dGVkLmh0bWwKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL1dlYkNvcmUvbWFudWFsLXRlc3RzL21lZGlhLW11dGVkLmh0bWwJKHJldmlzaW9uIDApCisr
KyBTb3VyY2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvbWVkaWEtbXV0ZWQuaHRtbAkocmV2aXNpb24g
MCkKQEAgLTAsMCArMSwzMiBAQAorPGh0bWw+CisgICAgPCEtLSBMYXlvdXRUZXN0cyBsb2NhdGlv
biBpcyBoYXJkLWNvZGVkIHRvIGF2b2lkIGR1cGxpY2F0aW9uIG9mIGNvZGUuIC0tPgorICAgIDxz
Y3JpcHQgc3JjPSJodHRwOi8vc3ZuLndlYmtpdC5vcmcvcmVwb3NpdG9yeS93ZWJraXQvdHJ1bmsv
TGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtZmlsZS5qcyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdD4K
KyAgICAgICAgdmFyIHZpZDsKKworICAgICAgICBmdW5jdGlvbiBjYW5wbGF5dGhyb3VnaCgpCisg
ICAgICAgIHsKKyAgICAgICAgICAgIHZpZC5wbGF5KCk7CisgICAgICAgIH0KKworICAgICAgICBm
dW5jdGlvbiBsb2FkKCkKKyAgICAgICAgeworICAgICAgICAgICAgdmlkID0gZG9jdW1lbnQuZ2V0
RWxlbWVudEJ5SWQoJ3ZpZCcpOworICAgICAgICAgICAgdmlkLmFkZEV2ZW50TGlzdGVuZXIoJ2Nh
bnBsYXl0aHJvdWdoJywgY2FucGxheXRocm91Z2gpOworCisgICAgICAgICAgICAvLyBNdXRlIGZp
cnN0CisgICAgICAgICAgICB2aWQubXV0ZWQgPSB0cnVlOworCisgICAgICAgICAgICB2aWQuc3Jj
ID0gImh0dHA6Ly9zcmMuY2hyb21pdW0ub3JnL3N2bi90cnVuay9zcmMvY2hyb21lL3Rlc3QvZGF0
YS9tZWRpYS8iICsgZmluZE1lZGlhRmlsZSgidmlkZW8iLCAiYmVhciIpOworICAgICAgICB9Cisg
ICAgPC9zY3JpcHQ+CisKKyAgICA8Ym9keT4KKyAgICAgICAgPHZpZGVvIGlkPXZpZCBjb250cm9s
cyBhdXRvcGxheT4KKyAgICAgICAgPC92aWRlbz4KKyAgICAgICAgPHA+VEVTVDogVmlkZW8gc2hv
dWxkIGJlIG11dGVkIChlLmcuLCBjb250cm9scykgYW5kIGFsc28gcHJvZHVjZSBubyBzb3VuZCAo
PGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3NjczIj5i
dWcgNTc2NzM8L2E+KS48L3A+CisgICAgICAgIDxpbnB1dCB0eXBlPSJidXR0b24iIHZhbHVlPSJM
b2FkIG1vdmllIiBvbmNsaWNrPSJsb2FkKCkiPgorICAgICAgICA8YnI+CisgICAgPC9ib2R5Pgor
Cis8L2h0bWw+Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>