<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>57666</bug_id>
          
          <creation_ts>2011-04-01 14:59:18 -0700</creation_ts>
          <short_desc>[Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671</short_desc>
          <delta_ts>2011-04-01 19:34:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>Blocker</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Keith Kyzivat">kamaji</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>378107</commentid>
    <comment_count>0</comment_count>
    <who name="Keith Kyzivat">kamaji</who>
    <bug_when>2011-04-01 14:59:18 -0700</bug_when>
    <thetext>Svn rev 82671 caused a regression in MiniBrowser compilation -- .qrc is not found, as it should have moved to the qt/ directory.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>378114</commentid>
    <comment_count>1</comment_count>
      <attachid>87924</attachid>
    <who name="Keith Kyzivat">kamaji</who>
    <bug_when>2011-04-01 15:14:11 -0700</bug_when>
    <thetext>Created attachment 87924
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>378115</commentid>
    <comment_count>2</comment_count>
    <who name="Keith Kyzivat">kamaji</who>
    <bug_when>2011-04-01 15:15:30 -0700</bug_when>
    <thetext>I see what the problem was...
webkit-patch post &lt;bug&gt; is not properly working with git renames - as can be evidenced here.. will post patch with git diff --staged now..</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>378116</commentid>
    <comment_count>3</comment_count>
      <attachid>87925</attachid>
    <who name="Keith Kyzivat">kamaji</who>
    <bug_when>2011-04-01 15:17:23 -0700</bug_when>
    <thetext>Created attachment 87925
Fixed patch with proper rename

Fixed patch with proper rename</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>378144</commentid>
    <comment_count>4</comment_count>
      <attachid>87925</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-04-01 15:40:31 -0700</bug_when>
    <thetext>Comment on attachment 87925
Fixed patch with proper rename

LGTM, r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>378273</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-01 18:38:21 -0700</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 87925:

fast/history/history-subframe-with-name.html bug 51039 (author: mihaip@chromium.org)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>378275</commentid>
    <comment_count>6</comment_count>
      <attachid>87925</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-01 18:41:13 -0700</bug_when>
    <thetext>Comment on attachment 87925
Fixed patch with proper rename

Clearing flags on attachment: 87925

Committed r82755: &lt;http://trac.webkit.org/changeset/82755&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>378276</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-01 18:41:18 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>378295</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-01 19:34:20 -0700</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 87925:

animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>87924</attachid>
            <date>2011-04-01 15:14:11 -0700</date>
            <delta_ts>2011-04-01 15:17:23 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-57666-20110401181531.patch</filename>
            <type>text/plain</type>
            <size>641</size>
            <attacher name="Keith Kyzivat">kamaji</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODI3MjIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2NDJiMzQ1ZDYwOGQxMjA3YjYyY2Y2OTZhNWQ3YWE3NjYy
MDVlYThiLi42NWI1NDI2ZjBkZTMzMDFmYjIzN2I0MjdkZDcwM2MxOWM5OGZmYmI3IDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg
QEAKKzIwMTEtMDQtMDEgIEtlaXRoIEt5eml2YXQgIDxrZWl0aC5reXppdmF0QG5va2lhLmNvbT4K
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFtX
SzJdIE1pbmlCcm93c2VyLnFyYyBub3QgZm91bmQgLSByZWdyZXNzaW9uIGZyb20gcmV2IDgyNjcx
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzY2Ngor
CisgICAgICAgICogTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXIucXJjOiBSZW5hbWVkIGZyb20g
VG9vbHMvTWluaUJyb3dzZXIvTWluaUJyb3dzZXIucXJjLgorCiAyMDExLTA0LTAxICBEb21pbmlj
IENvb25leSAgPGRvbWluaWNjQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFy
dGluIFJvYmluc29uLgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>87925</attachid>
            <date>2011-04-01 15:17:23 -0700</date>
            <delta_ts>2011-04-01 18:41:12 -0700</delta_ts>
            <desc>Fixed patch with proper rename</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>1157</size>
            <attacher name="Keith Kyzivat">kamaji</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2NDJi
MzQ1Li42NWI1NDI2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDQtMDEgIEtlaXRoIEt5eml2YXQgIDxrZWl0
aC5reXppdmF0QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICBbUXRdIFtXSzJdIE1pbmlCcm93c2VyLnFyYyBub3QgZm91bmQgLSByZWdy
ZXNzaW9uIGZyb20gcmV2IDgyNjcxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD01NzY2NgorCisgICAgICAgICogTWluaUJyb3dzZXIvcXQvTWluaUJyb3dz
ZXIucXJjOiBSZW5hbWVkIGZyb20gVG9vbHMvTWluaUJyb3dzZXIvTWluaUJyb3dzZXIucXJjLgor
CiAyMDExLTA0LTAxICBEb21pbmljIENvb25leSAgPGRvbWluaWNjQGdvb2dsZS5jb20+CiAKICAg
ICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvVG9vbHMvTWlu
aUJyb3dzZXIvTWluaUJyb3dzZXIucXJjIGIvVG9vbHMvTWluaUJyb3dzZXIvTWluaUJyb3dzZXIu
cXJjCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCBmZmU3N2IwLi4wMDAwMDAwCi0tLSBh
L1Rvb2xzL01pbmlCcm93c2VyL01pbmlCcm93c2VyLnFyYworKysgL2Rldi9udWxsCkBAIC0xLDUg
KzAsMCBAQAotPFJDQz4KLSAgICA8cXJlc291cmNlIHByZWZpeD0iLyI+Ci0gICAgICAgIDxmaWxl
PnVzZXJhZ2VudGxpc3QudHh0PC9maWxlPgotICAgIDwvcXJlc291cmNlPgotPC9SQ0M+CmRpZmYg
LS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3Nlci5xcmMgYi9Ub29scy9NaW5p
QnJvd3Nlci9xdC9NaW5pQnJvd3Nlci5xcmMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw
MDAwMC4uZmZlNzdiMAotLS0gL2Rldi9udWxsCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L01p
bmlCcm93c2VyLnFyYwpAQCAtMCwwICsxLDUgQEAKKzxSQ0M+CisgICAgPHFyZXNvdXJjZSBwcmVm
aXg9Ii8iPgorICAgICAgICA8ZmlsZT51c2VyYWdlbnRsaXN0LnR4dDwvZmlsZT4KKyAgICA8L3Fy
ZXNvdXJjZT4KKzwvUkNDPgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>