57659 2011-04-01 14:07:58 -0700 Add a ResourceRequestBase::TargetType for favicons 2011-04-06 14:59:30 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 0 asanka webkit-unassigned abarth commit-queue eric webkit.review.bot oldest_to_newest 378061 0 asanka 2011-04-01 14:07:58 -0700 Requests for Favicons may require different handling than requests for other types of requests. I believe having a separate target type for favicons would be sufficient to differentiate these requests. The immediate application is to suppress prompting for authentication when the target of the request is a favicon. 378094 1 87918 asanka 2011-04-01 14:42:02 -0700 Created attachment 87918 Patch 380860 2 87918 commit-queue 2011-04-06 14:49:28 -0700 Comment on attachment 87918 Patch Clearing flags on attachment: 87918 Committed r83102: <http://trac.webkit.org/changeset/83102> 380861 3 commit-queue 2011-04-06 14:49:32 -0700 All reviewed patches have been landed. Closing bug. 380870 4 webkit.review.bot 2011-04-06 14:59:30 -0700 http://trac.webkit.org/changeset/83102 might have broken Windows Release (Build) and Chromium Win Release 87918 2011-04-01 14:42:02 -0700 2011-04-06 14:49:28 -0700 Patch bug-57659-20110401174200.patch text/plain 2373 asanka U3VidmVyc2lvbiBSZXZpc2lvbjogODI1MTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjMWRmZTVhNDM4YTJlODUy NWIyMDQzNDVmNjU1NmUyMGVlMzc4ZmI2Li43ODQ4MjQ2ZTBlNWE5YzRmZDg2OWJlZWU0NzVkN2Y4 MDI5MTQwYzE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMDEgIEFzYW5r YSBIZXJhdGggIDxhc2Fua2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBuZXcgVGFyZ2V0VHlwZTogVGFyZ2V0SXNGYXZp Y29uCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3 NjU5CisKKyAgICAgICAgTm8gbmV3IGZ1bmN0aW9uYWxpdHkgYWRkZWQsIHNvIG5vIGFkZGl0aW9u YWwgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJh c2UuaDoKKwogMjAxMS0wMy0yOSAgTWF0dGhldyBEZWxhbmV5ICA8bWRlbGFuZXlAYXBwbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXF1ZXN0QmFzZS5oIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNlLmgKaW5kZXggMzFh MWU2OWY2NmExZWRiMTJjNThkYzNkYWJkNTQ0ZTY3ZTI5ODY4Zi4uZDVjMzk2ODQwYjVkZTQ2MzE2 YTkyMTlkZDNkYzRmNzA5Nzk4YmY5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNlLmgKQEAgLTY1LDYgKzY1LDcgQEAgbmFt ZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAgICAgVGFyZ2V0SXNXb3JrZXIsCiAgICAgICAgICAg ICBUYXJnZXRJc1NoYXJlZFdvcmtlciwKICAgICAgICAgICAgIFRhcmdldElzUHJlZmV0Y2gsCisg ICAgICAgICAgICBUYXJnZXRJc0Zhdmljb24sCiAgICAgICAgIH07CiAKICAgICAgICAgc3RhdGlj IFBhc3NPd25QdHI8UmVzb3VyY2VSZXF1ZXN0PiBhZG9wdChQYXNzT3duUHRyPENyb3NzVGhyZWFk UmVzb3VyY2VSZXF1ZXN0RGF0YT4pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCA4YmVj ZGJhODQ1Y2NlODBlNGY5NGI1NTk5MTNiNjBlZDVjYzk4Zjk3Li4yZWU0Mzc2Y2I0ODJjY2NlODQ4 NDBkMzIyMzJhODE2MjYxMzNlOWYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEzIEBACisyMDExLTA0LTAxICBBc2Fua2EgSGVyYXRoICA8YXNhbmthQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQg bmV3IFRhcmdldFR5cGU6IFRhcmdldElzRmF2aWNvbgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzY1OQorCisgICAgICAgICogcHVibGljL1dlYlVS TFJlcXVlc3QuaDoKKwogMjAxMS0wMy0yOSAgSm9obiBBYmQtRWwtTWFsZWsgIDxqYW1AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJVUkxSZXF1ZXN0LmggYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJVUkxSZXF1ZXN0LmgKaW5kZXggN2RkOTdjYTU5ZDA5NGY4 ZDhhY2E5Yzg1YTFiNGM2MWJiYTcxZTVhOC4uZDg4YzdiOWRjYmFlYTBlMzg3NTQ2NDVlZDkzMTU0 MzkxMzdhNTZjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi VVJMUmVxdWVzdC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlVSTFJl cXVlc3QuaApAQCAtNjksNiArNjksNyBAQCBwdWJsaWM6CiAgICAgICAgIFRhcmdldElzV29ya2Vy ID0gOSwKICAgICAgICAgVGFyZ2V0SXNTaGFyZWRXb3JrZXIgPSAxMCwKICAgICAgICAgVGFyZ2V0 SXNQcmVmZXRjaCA9IDExLAorICAgICAgICBUYXJnZXRJc0Zhdmljb24gPSAxMiwKICAgICB9Owog CiAgICAgfldlYlVSTFJlcXVlc3QoKSB7IHJlc2V0KCk7IH0K